193987 2019-01-29 15:11:41 -0800 [iOS] REGRESSION (r238635): Text area fails to re-focus after dismissal of keyboard on support.apple.com 2019-01-30 20:41:43 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED https://support.apple.com/guide/iphone/welcome/ios InRadar, PlatformOnly, Regression P2 Normal --- 1 dbates dbates thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1499750 0 dbates 2019-01-29 15:11:41 -0800 Seen on iOS. Steps to reproduce: The following steps assume that a hardware keyboard is not connected. 1. Visit <https://support.apple.com/guide/iphone/welcome/ios> and scroll to the bottom of the page. 2. Tap Yes. 3. Focus the comment field to bring up the keyboard. 4. Dismiss the keyboard by pressing Done or the keyboard hide button. 5. Tap the comment field again. Then the text field should show the number of characters remaining in the upper right corner. But it does not (*). (*) Once you are in this state then to have the number of remaining characters indicator shown you have to defocus the field and focus it again, say by tapping the background and then tapping the field. 1499751 1 dbates 2019-01-29 15:11:59 -0800 <rdar://problem/47230785> 1499797 2 360521 dbates 2019-01-29 16:27:10 -0800 Created attachment 360521 Patch 1499814 3 360521 thorton 2019-01-29 16:58:30 -0800 Comment on attachment 360521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360521&action=review > Source/WebKit/ChangeLog:9 > + It is unncessary to relinquish first responder status when a user explicitly dismissing unnecessary 1500393 4 dbates 2019-01-30 20:41:43 -0800 Committed r240757: <https://trac.webkit.org/changeset/240757> 360521 2019-01-29 16:27:10 -0800 2019-01-29 16:58:30 -0800 Patch bug-193987-20190129162709.patch text/plain 6606 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQyMjAzMTcxNzcxNjRkOTk1 ZTIzZmE3YjNlY2Y0YWM5ZTQzNTY3NWUuLmU4YjQ4OWUyOTY1NTZkODc3MDMzMTJjOGQyNTgwODBh NjlkNmE5MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcgQEAKKzIwMTktMDEtMjkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFJFR1JFU1NJT04gKHIy Mzg2MzUpOiBUZXh0IGFyZWEgZmFpbHMgdG8gcmUtZm9jdXMgYWZ0ZXIgZGlzbWlzc2FsIG9mIGtl eWJvYXJkIG9uIHN1cHBvcnQuYXBwbGUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5ODcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3MjMw Nzg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0 IGlzIHVubmNlc3NhcnkgdG8gcmVsaW5xdWlzaCBmaXJzdCByZXNwb25kZXIgc3RhdHVzIHdoZW4g YSB1c2VyIGV4cGxpY2l0bHkgZGlzbWlzc2luZworICAgICAgICB0aGUga2V5Ym9hcmQuIE1vcmVv dmVyLCBkb2luZyBzbyBwcmV2ZW50cyBrZXkgY29tbWFuZHMgZnJvbSBiZWluZyBpbnRlcmNlcHRl ZCB3aGVuIGEKKyAgICAgICAgaGFyZHdhcmUga2V5Ym9hcmQgaXMgc3Vic2VxdWVudGx5IGF0dGFj aGVkLgorICAgICAgICAKKyAgICAgICAgRm9sbG93aW5nIHIyMzg2MzUgYSBwYWdlIGJlY29tZXMg Zm9jdXNlZCAoYWNjZXB0aW5nIG9mIGtleWJvYXJkIGlucHV0KSBhbmQgZGVmb2N1c2VkCisgICAg ICAgIHdoZW4gdGhlIFdLQ29udGVudFZpZXcgYmVjb21lcyBmaXJzdCByZXNwb25kZXIgYW5kIHJl c2lnbnMgZmlyc3QgcmVzcG9uZGVyLCByZXNwZWN0aXZlbHkuCisgICAgICAgIFdoZW4gYSB1c2Vy IGV4cGxpY2l0bHkgZGlzbWlzc2VzIHRoZSBrZXlib2FyZCBieSB0YXBwaW5nIERvbmUgKGlQaG9u ZSkgb3IgdGhlIGhpZGUga2V5Ym9hcmQKKyAgICAgICAgYnV0dG9uIChpUGFkKSB0aGVuIFVJS2l0 IHRlbGxzIFdLQ29udGVudFZpZXcgdG8gcmVzaWduIGl0cyBmaXJzdCByZXNwb25kZXIgc3RhdHVz IG9ubHkKKyAgICAgICAgdG8gbWFrZSBpdHMgc3VwZXJ2aWV3LCBXS1dlYlZpZXcsIGZpcnN0IHJl c3BvbmRlci4gV2hlbiBhIHBlcnNvbiBzdWJzZXF1ZW50bHkgdGFwcyBvbiB0aGUKKyAgICAgICAg cGFnZSBhZ2FpbiwgdGhlIFdLQ29udGVudFZpZXcgcmVxdWVzdHMgdG8gYmVjb21lIHRoZSBmaXJz dCByZXNwb25kZXIuIEhvd2V2ZXIgY2hhbmdlcyB0bworICAgICAgICBwYWdlIGZvY3VzIGFyZSBu b3QgZ3VhcmFudGVlZCB0byBiZSBzZW50IHRvIHRoZSBXZWJQcm9jZXNzIGltbWVkaWF0ZWx5IChX ZWJQYWdlUHJveHk6OmFjdGl2aXR5U3RhdGVEaWRDaGFuZ2UoKQorICAgICAgICB3aWxsIHNjaGVk dWxlIGFuIHVwZGF0ZSkuIEluIHBhcnRpY3VsYXIsIHRoZXkgYXJlIG5vdCBndWFyYW50ZWVkIHRv IGJlIHNlbnQgYmVmb3JlIHRoZQorICAgICAgICBXZWJQcm9jZXNzIGlzIHRvbGQgYWJvdXQgYSB0 YXAuIFRoZXJlZm9yZSwgdGhlIFdlYlByb2Nlc3MgaGFzIG91dC1vZi1kYXRlIGluZm9ybWF0aW9u IG9uCisgICAgICAgIGZvY3VzIHN0YXRlIG9mIHRoZSBwYWdlLiBJbnN0ZWFkIHdlIHNob3VsZCBk ZXRlY3Qgd2hlbiBXS1dlYlZpZXcgaXMgYmVpbmcgYXNrZWQgdG8gcmVzaWduCisgICAgICAgIGFz IGEgcmVzdWx0IG9mIHRoZSBrZXlib2FyZCBkaXNtaXNzYWwgYW5kIHJlZnVzZSB0aGUgcmVxdWVz dCwgdGFraW5nIGNhcmUgdG8gZW5kIHRoZSBjdXJyZW50CisgICAgICAgIGVkaXRpbmcgc2Vzc2lv biwgYmx1ciB0aGUgZm9jdXNlZCBlbGVtZW50LCBhbmQgZGlzbWlzcyB0aGUgb24tc2NyZWVuIGtl eWJvYXJkLgorCisgICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOiBFeHBvc2Ug c29tZSBTUEkuCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBzZXR1cEludGVyYWN0aW9uXSk6IFJlZ2lzdGVy IHRvIHJlY2VpdmUgbm90aWZpY2F0aW9ucyB3aGVuZXZlciBhIHVzZXIKKyAgICAgICAgZXhwbGlj aXRseSBkaXNtaXNzZXMgdGhlIGtleWJvYXJkLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHJl c2lnbkZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld10pOiBJZiB3ZSBhcmUgYmVpbmcgYXNrZWQgdG8g cmVzaWduIGFzIGEKKyAgICAgICAgcmVzdWx0IG9mIGEgdXNlciBleHBsaWNpdGx5IGRpc21pc3Np bmcgdGhlIGtleWJvYXJkIHRoZW4gcmVmdXNlIHRvIHJlc2lnbi4KKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBfa2V5Ym9hcmREaWRSZXF1ZXN0RGlzbWlzc2FsOl0pOiBVcGRhdGUgc3RhdGUsIGlm IGFwcGxpY2FibGUuCisKIDIwMTktMDEtMjMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIEtleXVwcyBmb3Igbm9uLW1vZGlmaWVyIGtleXMgaWRlbnRp ZmllZCBhcyAiRGVhZCIgd2hlbiBub3QgZm9jdXNlZCBpbiBhIGNvbnRlbnQtZWRpdGFibGUgZWxl bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJ LmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAppbmRleCBkNDQ3 OTA2OGI4NTNiOTM4ZWJiZDMwMGNjYjIyM2IwYmVhMzZlOWZjLi41M2YzZmY3MWUxZTg5MDBiMDJh ODdiMzUxZTUyOTkzNjVjN2Y5OWJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt L3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3Mv VUlLaXRTUEkuaApAQCAtMTE0NSw2ICsxMTQ1LDggQEAgZXh0ZXJuIE5TU3RyaW5nICogY29uc3Qg VUlXaW5kb3dEaWRSb3RhdGVOb3RpZmljYXRpb247CiBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBV SVdpbmRvd05ld1NjcmVlblVzZXJJbmZvS2V5OwogZXh0ZXJuIE5TU3RyaW5nICogY29uc3QgVUlX aW5kb3dXaWxsUm90YXRlTm90aWZpY2F0aW9uOwogCitleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBV SUtleWJvYXJkUHJpdmF0ZURpZFJlcXVlc3REaXNtaXNzYWxOb3RpZmljYXRpb247CisKIGV4dGVy biBOU1N0cmluZyAqIGNvbnN0IFVJS2V5Ym9hcmRJc0xvY2FsVXNlckluZm9LZXk7CiAKIGV4dGVy biBVSUFwcGxpY2F0aW9uICpVSUFwcDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAppbmRleCBiNWU2YWUyYTU3MzUwNDNh MjNhMzM1YTlkNjhjNWEzOGFlNWZjZDkwLi5hZjJmMTA5ZjcyMjMwZmExZjFiODYxMzJlMWU4ZTQ1 YzBiNWUyNTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5oCkBAIC0zMDYsNiArMzA2LDggQEAgc3RydWN0IFdLQXV0 b0NvcnJlY3Rpb25EYXRhIHsKICAgICBCT09MIF9zaG93RGVidWdUYXBIaWdobGlnaHRzRm9yRmFz dENsaWNraW5nOwogICAgIEJPT0wgX2lzWm9vbWluZ1RvUmV2ZWFsRm9jdXNlZEVsZW1lbnQ7CiAK KyAgICBCT09MIF9rZXlib2FyZERpZFJlcXVlc3REaXNtaXNzYWw7CisKICAgICBCT09MIF9iZWNv bWluZ0ZpcnN0UmVzcG9uZGVyOwogICAgIEJPT0wgX3Jlc2lnbmluZ0ZpcnN0UmVzcG9uZGVyOwog ICAgIEJPT0wgX25lZWRzRGVmZXJyZWRFbmRTY3JvbGxpbmdTZWxlY3Rpb25VcGRhdGU7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQppbmRleCBkNGYxYzUyOTMyNmVlMThhMzUyNzk4ODRlYTA4MjMyMmIyODU1ZWZhLi5k NzAwMTY4N2UwN2VhYWQ2YmUwYjkxZjk5NDExYWI0ZmNlMzJiYjU2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K QEAgLTczNCw3ICs3MzQsMTAgQEAgLSAodm9pZClzZXR1cEludGVyYWN0aW9uCiAgICAgW3NlbGYg X3JlZ2lzdGVyUHJldmlld107CiAjZW5kaWYKIAotICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIg ZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoX3Jlc2V0 U2hvd2luZ1RleHRTdHlsZTopIG5hbWU6VUlNZW51Q29udHJvbGxlckRpZEhpZGVNZW51Tm90aWZp Y2F0aW9uIG9iamVjdDpuaWxdOworICAgIE5TTm90aWZpY2F0aW9uQ2VudGVyICpjZW50ZXIgPSBb TlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl07CisgICAgW2NlbnRlciBhZGRPYnNl cnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3RvcihfcmVzZXRTaG93aW5nVGV4dFN0eWxlOikgbmFt ZTpVSU1lbnVDb250cm9sbGVyRGlkSGlkZU1lbnVOb3RpZmljYXRpb24gb2JqZWN0Om5pbF07Cisg ICAgW2NlbnRlciBhZGRPYnNlcnZlcjpzZWxmIHNlbGVjdG9yOkBzZWxlY3Rvcihfa2V5Ym9hcmRE aWRSZXF1ZXN0RGlzbWlzc2FsOikgbmFtZTpVSUtleWJvYXJkUHJpdmF0ZURpZFJlcXVlc3REaXNt aXNzYWxOb3RpZmljYXRpb24gb2JqZWN0Om5pbF07CisKICAgICBfc2hvd2luZ1RleHRTdHlsZU9w dGlvbnMgPSBOTzsKIAogICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBjYWxsZWQgd2hlbiB3 ZSBnZXQgbm90aWZpZWQgdGhhdCBsb2FkaW5nIGhhcyBjb21wbGV0ZWQuCkBAIC0xMTA4LDcgKzEx MTEsOCBAQCAtIChCT09MKXJlc2lnbkZpcnN0UmVzcG9uZGVyRm9yV2ViVmlldwogICAgIC8vIEZJ WE1FOiBNYXliZSB3ZSBzaG91bGQgY2FsbCByZXNpZ25GaXJzdFJlc3BvbmRlciBvbiB0aGUgc3Vw ZXJjbGFzcwogICAgIC8vIGFuZCBkbyBub3RoaW5nIGlmIHRoZSByZXR1cm4gdmFsdWUgaXMgTk8u CiAKLSAgICBfcmVzaWduaW5nRmlyc3RSZXNwb25kZXIgPSBZRVM7CisgICAgU2V0Rm9yU2NvcGU8 Qk9PTD4gcmVzaWduaW5nRmlyc3RSZXNwb25kZXJTY29wZSB7IF9yZXNpZ25pbmdGaXJzdFJlc3Bv bmRlciwgWUVTIH07CisKICAgICBpZiAoIV93ZWJWaWV3Ll9yZXRhaW5pbmdBY3RpdmVGb2N1c2Vk U3RhdGUpIHsKICAgICAgICAgLy8gV2UgbmVlZCB0byBjb21wbGV0ZSB0aGUgZWRpdGluZyBvcGVy YXRpb24gYmVmb3JlIHdlIGJsdXIgdGhlIGVsZW1lbnQuCiAgICAgICAgIFtzZWxmIF9lbmRFZGl0 aW5nXTsKQEAgLTExMjAsMTMgKzExMjQsMTggQEAgLSAoQk9PTClyZXNpZ25GaXJzdFJlc3BvbmRl ckZvcldlYlZpZXcKICAgICAKICAgICBfaW5wdXRWaWV3VXBkYXRlRGVmZXJyZXIgPSBudWxscHRy OwogCisgICAgLy8gSWYgdGhlIHVzZXIgZXhwbGljaXRseSBkaXNtaXNzZWQgdGhlIGtleWJvYXJk IHRoZW4gd2Ugd2lsbCBsb3NlIGZpcnN0IHJlc3BvbmRlcgorICAgIC8vIHN0YXR1cyBvbmx5IHRv IGdhaW4gaXQgYmFjayBhZ2Fpbi4gSnVzdCBkb24ndCByZXNpZ24gaW4gdGhhdCBjYXNlLgorICAg IGlmIChfa2V5Ym9hcmREaWRSZXF1ZXN0RGlzbWlzc2FsKSB7CisgICAgICAgIF9rZXlib2FyZERp ZFJlcXVlc3REaXNtaXNzYWwgPSBOTzsKKyAgICAgICAgcmV0dXJuIE5POworICAgIH0KKwogICAg IGJvb2wgc3VwZXJEaWRSZXNpZ24gPSBbc3VwZXIgcmVzaWduRmlyc3RSZXNwb25kZXJdOwogCiAg ICAgaWYgKHN1cGVyRGlkUmVzaWduKQogICAgICAgICBfcGFnZS0+YWN0aXZpdHlTdGF0ZURpZENo YW5nZShXZWJDb3JlOjpBY3Rpdml0eVN0YXRlOjpJc0ZvY3VzZWQpOwogCi0gICAgX3Jlc2lnbmlu Z0ZpcnN0UmVzcG9uZGVyID0gTk87Ci0KICAgICByZXR1cm4gc3VwZXJEaWRSZXNpZ247CiB9CiAK QEAgLTI3ODIsNiArMjc5MSwxMyBAQCAtICh2b2lkKV9yZXNldFNob3dpbmdUZXh0U3R5bGU6KE5T Tm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiAgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50 IGhpZGVUZXh0U3R5bGVPcHRpb25zXTsKIH0KIAorLSAodm9pZClfa2V5Ym9hcmREaWRSZXF1ZXN0 RGlzbWlzc2FsOihOU05vdGlmaWNhdGlvbiAqKW5vdGlmaWNhdGlvbgoreworICAgIGlmICghW3Nl bGYgaXNGaXJzdFJlc3BvbmRlcl0pCisgICAgICAgIHJldHVybjsKKyAgICBfa2V5Ym9hcmREaWRS ZXF1ZXN0RGlzbWlzc2FsID0gWUVTOworfQorCiAtICh2b2lkKWNvcHlGb3JXZWJWaWV3OihpZClz ZW5kZXIKIHsKICAgICBfcGFnZS0+ZXhlY3V0ZUVkaXRDb21tYW5kKCJjb3B5Il9zKTsK