193982 2019-01-29 14:10:52 -0800 Web Inspector: Improve API and documentation of ColumnChart 2019-02-01 13:26:38 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1499714 0 joepeck 2019-01-29 14:10:52 -0800 Improve API and documentation of ColumnChart Used to be "BarChart" and some remnants of "bar" still existed. 1499717 1 360500 joepeck 2019-01-29 14:11:51 -0800 Created attachment 360500 [PATCH] Proposed Fix 1499726 2 360500 hi 2019-01-29 14:24:59 -0800 Comment on attachment 360500 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360500&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + This used to be named "BarChart", convert remaining instances Grammar: this sentence is a fragment, so use a ";" or add some other conjunction. > Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:59 > + get columns() { return this._columns; } Considering that nobody calls this (and frankly the data it contains is really not very useful), I think we should just remove this. > Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:82 > + this._columns = []; I feel like this should call `this.needsLayout()` 🤔 > Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:85 > needsLayout() Perhaps this class should be a subclass of `WI.View`? > Source/WebInspectorUI/UserInterface/Views/StackedLineChart.js:63 > + get element() { return this._element; } Yes! ᕦ(ò_óˇ)ᕤ 1500729 3 joepeck 2019-01-31 13:15:49 -0800 (In reply to Devin Rousso from comment #2) > Comment on attachment 360500 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360500&action=review > > r=me > > > Source/WebInspectorUI/ChangeLog:8 > > + This used to be named "BarChart", convert remaining instances > > Grammar: this sentence is a fragment, so use a ";" or add some other > conjunction. kk. > > Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:59 > > + get columns() { return this._columns; } > > Considering that nobody calls this (and frankly the data it contains is > really not very useful), I think we should just remove this. Okay. > > Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:85 > > needsLayout() > > Perhaps this class should be a subclass of `WI.View`? Will do in a bit. 1501238 4 joepeck 2019-02-01 13:25:58 -0800 https://trac.webkit.org/changeset/240865/webkit 1501243 5 webkit-bug-importer 2019-02-01 13:26:38 -0800 <rdar://problem/47747238> 360500 2019-01-29 14:11:51 -0800 2019-01-31 13:15:55 -0800 [PATCH] Proposed Fix cleanup-1.patch text/plain 6416 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2YmUyOTdjYThiLi4xYWJlYzZmYjQ0MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzIgQEAKKzIwMTktMDEtMjkgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbXByb3ZlIEFQSSBhbmQgZG9jdW1lbnRhdGlvbiBvZiBDb2x1bW5DaGFydAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTgyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB1c2VkIHRvIGJlIG5h bWVkICJCYXJDaGFydCIsIGNvbnZlcnQgcmVtYWluaW5nIGluc3RhbmNlcworICAgICAgICBvZiAi YmFyIiB0byAiY29sdW1uIiBhbmQgY2xlYW4gdXAgcmVsYXRlZCB0aGluZ3MuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NQVVRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5jc3M6CisgICAg ICAgIChib2R5W2Rpcj1ydGxdIC50aW1lbGluZS1vdmVydmlldy1ncmFwaC5jcHUgPiAuY29sdW1u LWNoYXJ0KToKKyAgICAgICAgKC50aW1lbGluZS1vdmVydmlldy1ncmFwaC5jcHUgPiAuY29sdW1u LWNoYXJ0ID4gc3ZnID4gcmVjdCk6CisgICAgICAgIChib2R5W2Rpcj1ydGxdIC50aW1lbGluZS1v dmVydmlldy1ncmFwaC5jcHUgPiAuYmFyLWNoYXJ0KTogRGVsZXRlZC4KKyAgICAgICAgKC50aW1l bGluZS1vdmVydmlldy1ncmFwaC5jcHUgPiAuYmFyLWNoYXJ0ID4gc3ZnID4gcmVjdCk6IERlbGV0 ZWQuCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DUFVUaW1lbGluZU92ZXJ2aWV3R3Jh cGguanM6CisgICAgICAgIChXSS5DUFVUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJvdG90eXBlLmxh eW91dCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db2x1bW5DaGFydC5qczoKKyAg ICAgICAgKFdJLkNvbHVtbkNoYXJ0KToKKyAgICAgICAgKFdJLkNvbHVtbkNoYXJ0LnByb3RvdHlw ZS5nZXQgY29sdW1ucyk6CisgICAgICAgIChXSS5Db2x1bW5DaGFydC5wcm90b3R5cGUuYWRkQ29s dW1uKToKKyAgICAgICAgKFdJLkNvbHVtbkNoYXJ0LnByb3RvdHlwZS5jbGVhcik6CisgICAgICAg IChXSS5Db2x1bW5DaGFydC5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKyAgICAgICAgKFdJLkNv bHVtbkNoYXJ0LnByb3RvdHlwZS5nZXQgYmFycyk6IERlbGV0ZWQuCisgICAgICAgIChXSS5Db2x1 bW5DaGFydC5wcm90b3R5cGUuYWRkQmFyKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1N0YWNrZWRMaW5lQ2hhcnQuanM6CisgICAgICAgIChXSS5TdGFja2VkTGluZUNo YXJ0LnByb3RvdHlwZS5nZXQgZWxlbWVudCk6CisgICAgICAgIChXSS5TdGFja2VkTGluZUNoYXJ0 LnByb3RvdHlwZS5nZXQgcG9pbnRzKToKKwogMjAxOS0wMS0yOCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSB1bm5l Y2Vzc2FyeSBwcm9taXNlIHJlamVjdGlvbiBoYW5kbGVycyBub3cgdGhhdCB3ZSB1c2UgdGhlIGds b2JhbCBvbnVuaGFuZGxlZHJlamVjdGlvbiBoYW5kbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DUFVUaW1lbGluZU92ZXJ2aWV3R3JhcGgu Y3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxp bmVPdmVydmlld0dyYXBoLmNzcwppbmRleCBjY2RlMDFlMDc0Yi4uYzVkMTRjM2YzOWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NQVVRpbWVs aW5lT3ZlcnZpZXdHcmFwaC5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ1BVVGltZWxpbmVPdmVydmlld0dyYXBoLmNzcwpAQCAtNjcsMTEgKzY3LDEx IEBAIGJvZHlbZGlyPXJ0bF0gLnRpbWVsaW5lLW92ZXJ2aWV3LWdyYXBoLmNwdSA+IC5sZWdlbmQg ewogICAgIH0KIH0KIAotYm9keVtkaXI9cnRsXSAudGltZWxpbmUtb3ZlcnZpZXctZ3JhcGguY3B1 ID4gLmJhci1jaGFydCB7Citib2R5W2Rpcj1ydGxdIC50aW1lbGluZS1vdmVydmlldy1ncmFwaC5j cHUgPiAuY29sdW1uLWNoYXJ0IHsKICAgICB0cmFuc2Zvcm06IHNjYWxlWCgtMSk7CiB9CiAKLS50 aW1lbGluZS1vdmVydmlldy1ncmFwaC5jcHUgPiAuYmFyLWNoYXJ0ID4gc3ZnID4gcmVjdCB7Cisu dGltZWxpbmUtb3ZlcnZpZXctZ3JhcGguY3B1ID4gLmNvbHVtbi1jaGFydCA+IHN2ZyA+IHJlY3Qg ewogICAgIHN0cm9rZTogdmFyKC0tY3B1LXN0cm9rZS1jb2xvcik7CiAgICAgZmlsbDogdmFyKC0t Y3B1LWZpbGwtY29sb3IpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVPdmVydmlld0dyYXBoLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVPdmVydmlld0dyYXBo LmpzCmluZGV4IDMwNjU3MTBmOWU0Li5jNThmYThiYTQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1BVVGltZWxpbmVPdmVydmlld0dyYXBo LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NQVVRp bWVsaW5lT3ZlcnZpZXdHcmFwaC5qcwpAQCAtMTE2LDcgKzExNiw3IEBAIFdJLkNQVVRpbWVsaW5l T3ZlcnZpZXdHcmFwaCA9IGNsYXNzIENQVVRpbWVsaW5lT3ZlcnZpZXdHcmFwaCBleHRlbmRzIFdJ LlRpbWVsaW5lCiAgICAgICAgICAgICBsZXQgaCA9IE1hdGgubWF4KG1pbmltdW1EaXNwbGF5SGVp Z2h0LCB5U2NhbGUocmVjb3JkLnVzYWdlKSk7CiAgICAgICAgICAgICBsZXQgeCA9IHhTY2FsZShy ZWNvcmQuc3RhcnRUaW1lIC0gKHNhbXBsaW5nUmF0ZVBlclNlY29uZCAvIDIpKTsKICAgICAgICAg ICAgIGxldCB5ID0gaGVpZ2h0IC0gaDsKLSAgICAgICAgICAgIHRoaXMuX2NoYXJ0LmFkZEJhcih4 LCB5LCB3LCBoKTsKKyAgICAgICAgICAgIHRoaXMuX2NoYXJ0LmFkZENvbHVtbih4LCB5LCB3LCBo KTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX2NoYXJ0LnVwZGF0ZUxheW91dCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29sdW1u Q2hhcnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2x1 bW5DaGFydC5qcwppbmRleCAxM2QzNzU1YTlmNi4uYjk2NDJmZjZjNzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbHVtbkNoYXJ0LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbHVtbkNoYXJ0 LmpzCkBAIC0yMywxMCArMjMsMTAgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KICAqLwogCi0vLyBDb2x1bW5DaGFydCBjcmVhdGVzIGEgc2luZ2xlIGZpbGxlZCBsaW5lIGNo YXJ0LgorLy8gQ29sdW1uQ2hhcnQgY3JlYXRlcyBhIGNoYXJ0IGZpbGxlZCB3aXRoIHNpbmd1bGFy IGNvbHVtbnMuCiAvLwotLy8gSW5pdGlhbGl6ZSB0aGUgY2hhcnQgd2l0aCBhIHNpemUuIFlvdSBj YW4gdGhlbiBpbmNsdWRlIGEgbmV3IGJhcgotLy8gaW4gdGhlIGJhciBjaGFydCBieSBwcm92aWRp bmcgYW4gKHgsIHksIHcsIGgpIHZpYSBgYWRkQmFyYC4KKy8vIEluaXRpYWxpemUgdGhlIGNoYXJ0 IHdpdGggYSBzaXplLiBZb3UgY2FuIHRoZW4gaW5jbHVkZSBhIG5ldyBjb2x1bW4KKy8vIGluIHRo ZSBjb2x1bW4gY2hhcnQgYnkgcHJvdmlkaW5nIGFuICh4LCB5LCB3LCBoKSB2aWEgYGFkZENvbHVt bmAuCiAvLwogLy8gU1ZHOgogLy8KQEAgLTM2LDYgKzM2LDcgQEAKIC8vICAgICAgPHN2ZyB3aWR0 aD0iODAwIiBoZWlnaHQ9Ijc1IiB2aWV3Ym94PSIwIDAgODAwIDc1Ij4KIC8vICAgICAgICAgIDxy ZWN0IHdpZHRoPSI8dz4iIGhlaWdodD0iPGg+IiB0cmFuc2Zvcm09InRyYW5zbGF0ZSg8eD4sIDx5 PikiIC8+CiAvLyAgICAgICAgICA8cmVjdCB3aWR0aD0iPHc+IiBoZWlnaHQ9IjxoPiIgdHJhbnNm b3JtPSJ0cmFuc2xhdGUoPHg+LCA8eT4pIiAvPgorLy8gICAgICAgICAgLi4uCiAvLyAgICAgIDwv c3ZnPgogLy8gIDwvZGl2PgogCkBAIC00NCwxOCArNDUsMTggQEAgV0kuQ29sdW1uQ2hhcnQgPSBj bGFzcyBDb2x1bW5DaGFydAogICAgIGNvbnN0cnVjdG9yKHNpemUpCiAgICAgewogICAgICAgICB0 aGlzLl9lbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Ci0gICAgICAgIHRo aXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgiYmFyLWNoYXJ0Iik7CisgICAgICAgIHRoaXMuX2Vs ZW1lbnQuY2xhc3NMaXN0LmFkZCgiY29sdW1uLWNoYXJ0Iik7CiAKICAgICAgICAgdGhpcy5fc3Zn RWxlbWVudCA9IHRoaXMuX2VsZW1lbnQuYXBwZW5kQ2hpbGQoY3JlYXRlU1ZHRWxlbWVudCgic3Zn IikpOwogCi0gICAgICAgIHRoaXMuX2JhcnMgPSBbXTsKKyAgICAgICAgdGhpcy5fY29sdW1ucyA9 IFtdOwogICAgICAgICB0aGlzLnNpemUgPSBzaXplOwogICAgIH0KIAogICAgIC8vIFB1YmxpYwog CiAgICAgZ2V0IGVsZW1lbnQoKSB7IHJldHVybiB0aGlzLl9lbGVtZW50OyB9Ci0gICAgZ2V0IGJh cnMoKSB7IHJldHVybiB0aGlzLl9iYXJzOyB9CisgICAgZ2V0IGNvbHVtbnMoKSB7IHJldHVybiB0 aGlzLl9jb2x1bW5zOyB9CiAKICAgICBnZXQgc2l6ZSgpCiAgICAgewpAQCAtNzEsMTQgKzcyLDE0 IEBAIFdJLkNvbHVtbkNoYXJ0ID0gY2xhc3MgQ29sdW1uQ2hhcnQKICAgICAgICAgdGhpcy5fc3Zn RWxlbWVudC5zZXRBdHRyaWJ1dGUoInZpZXdib3giLCBgMCAwICR7c2l6ZS53aWR0aH0gJHtzaXpl LmhlaWdodH1gKTsKICAgICB9CiAKLSAgICBhZGRCYXIoeCwgeSwgd2lkdGgsIGhlaWdodCkKKyAg ICBhZGRDb2x1bW4oeCwgeSwgd2lkdGgsIGhlaWdodCkKICAgICB7Ci0gICAgICAgIHRoaXMuX2Jh cnMucHVzaCh7eCwgeSwgd2lkdGgsIGhlaWdodH0pOworICAgICAgICB0aGlzLl9jb2x1bW5zLnB1 c2goe3gsIHksIHdpZHRoLCBoZWlnaHR9KTsKICAgICB9CiAKICAgICBjbGVhcigpCiAgICAgewot ICAgICAgICB0aGlzLl9iYXJzID0gW107CisgICAgICAgIHRoaXMuX2NvbHVtbnMgPSBbXTsKICAg ICB9CiAKICAgICBuZWVkc0xheW91dCgpCkBAIC05OCw3ICs5OSw3IEBAIFdJLkNvbHVtbkNoYXJ0 ID0gY2xhc3MgQ29sdW1uQ2hhcnQKIAogICAgICAgICB0aGlzLl9zdmdFbGVtZW50LnJlbW92ZUNo aWxkcmVuKCk7CiAKLSAgICAgICAgZm9yIChsZXQge3gsIHksIHdpZHRoLCBoZWlnaHR9IG9mIHRo aXMuX2JhcnMpIHsKKyAgICAgICAgZm9yIChsZXQge3gsIHksIHdpZHRoLCBoZWlnaHR9IG9mIHRo aXMuX2NvbHVtbnMpIHsKICAgICAgICAgICAgIGxldCByZWN0ID0gdGhpcy5fc3ZnRWxlbWVudC5h cHBlbmRDaGlsZChjcmVhdGVTVkdFbGVtZW50KCJyZWN0IikpOwogICAgICAgICAgICAgcmVjdC5z ZXRBdHRyaWJ1dGUoIndpZHRoIiwgd2lkdGgpOwogICAgICAgICAgICAgcmVjdC5zZXRBdHRyaWJ1 dGUoImhlaWdodCIsIGhlaWdodCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TdGFja2VkTGluZUNoYXJ0LmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tlZExpbmVDaGFydC5qcwppbmRleCA2NDU0 YjU5MTIwMi4uOGRiZDYxYjFhZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1N0YWNrZWRMaW5lQ2hhcnQuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tlZExpbmVDaGFydC5qcwpAQCAtNjAs MTUgKzYwLDggQEAgV0kuU3RhY2tlZExpbmVDaGFydCA9IGNsYXNzIFN0YWNrZWRMaW5lQ2hhcnQK IAogICAgIC8vIFB1YmxpYwogCi0gICAgZ2V0IGVsZW1lbnQoKQotICAgIHsKLSAgICAgICAgcmV0 dXJuIHRoaXMuX2VsZW1lbnQ7Ci0gICAgfQotCi0gICAgZ2V0IHBvaW50cygpCi0gICAgewotICAg ICAgICByZXR1cm4gdGhpcy5fcG9pbnRzOwotICAgIH0KKyAgICBnZXQgZWxlbWVudCgpIHsgcmV0 dXJuIHRoaXMuX2VsZW1lbnQ7IH0KKyAgICBnZXQgcG9pbnRzKCkgeyByZXR1cm4gdGhpcy5fcG9p bnRzOyB9CiAKICAgICBnZXQgc2l6ZSgpCiAgICAgewo=