193979 2019-01-29 13:38:34 -0800 REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS 2019-01-30 19:57:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell rniwa ap jlewis3 lforschler rniwa ryanhaddad webkit-bug-importer wenson_hsieh oldest_to_newest 1499692 0 tsavell 2019-01-29 13:38:34 -0800 WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing on iOS after being introduced in https://trac.webkit.org/changeset/240541/webkit Failed TestWebKitAPI.WebKit.WebsitePoliciesCustomJavaScriptUserAgent Received data during response processing, queuing it. Received data during response processing, queuing it. Received data during response processing, queuing it. /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1142 Value of: [userAgentString hasPrefix:@"Mozilla/5.0 (Macintosh;"] Actual: false Expected: true /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1143 Value of: [userAgentString hasSuffix:@"(KHTML, like Gecko)"] Actual: false Expected: true 1500058 1 ap 2019-01-30 10:29:49 -0800 Ryosuke, can you look into this today, or should the change be rolled back? 1500320 2 rniwa 2019-01-30 17:45:03 -0800 Ugh... of course. iOS has a different UA string. 1500325 3 360660 rniwa 2019-01-30 17:51:36 -0800 Created attachment 360660 Fixes the test 1500380 4 360660 rniwa 2019-01-30 19:56:20 -0800 Comment on attachment 360660 Fixes the test Clearing flags on attachment: 360660 Committed r240756: <https://trac.webkit.org/changeset/240756> 1500381 5 rniwa 2019-01-30 19:56:22 -0800 All reviewed patches have been landed. Closing bug. 1500382 6 webkit-bug-importer 2019-01-30 19:57:29 -0800 <rdar://problem/47691812> 360660 2019-01-30 17:51:36 -0800 2019-01-30 19:56:20 -0800 Fixes the test fix193979.patch text/plain 1755 rniwa ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OGYx YzJhNDY5My4uZDY2YjE4YWY0NGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wMS0zMCAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDA1NDEpOiBXZWJL aXQuV2Vic2l0ZVBvbGljaWVzQ3VzdG9tSmF2YVNjcmlwdFVzZXJBZ2VudCBpcyBmYWlsaW5nIHNp bmNlIGludHJvZHVjdGlvbiBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Mzk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgdGVzdCBmb3IgaU9TLiBNYWtlIHRoZSB0ZXN0IHdvcmsg d2l0aCBpT1MgVUEgc3RyaW5nLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9XZWJzaXRlUG9saWNpZXMubW06CisKIDIwMTktMDEtMjkgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkb3B0IG5ldyBTUEkgdG8gZXZhbHVhdGUg c2VydmVyIGNlcnRpZmljYXRlIHRydXN0CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdENvY29hL1dlYnNpdGVQb2xpY2llcy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vic2l0ZVBvbGljaWVzLm1tCmluZGV4IGRiMTY2YzIyZmE0 Li5iOGI2YzZmYmI4MCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9XZWJzaXRlUG9saWNpZXMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9XZWJzaXRlUG9saWNpZXMubW0KQEAgLTExMzksOCArMTEzOSw4IEBAIFRF U1QoV2ViS2l0LCBXZWJzaXRlUG9saWNpZXNDdXN0b21KYXZhU2NyaXB0VXNlckFnZW50KQogICAg IFtzY2hlbWVIYW5kbGVyIGFkZE1hcHBpbmdGcm9tVVJMU3RyaW5nOkAidGVzdDovL3d3dy5hcHBs ZS5jb20vc3ViZnJhbWUuaHRtbCIgdG9EYXRhOmN1c3RvbVVzZXJBZ2VudFN1YkZyYW1lVGVzdEJ5 dGVzXTsKICAgICBbc2NoZW1lSGFuZGxlciBzZXRUYXNrSGFuZGxlcjpbXShpZCA8V0tVUkxTY2hl bWVUYXNrPiB0YXNrKSB7CiAgICAgICAgIGF1dG8qIHVzZXJBZ2VudFN0cmluZyA9IFt0YXNrLnJl cXVlc3QgdmFsdWVGb3JIVFRQSGVhZGVyRmllbGQ6QCJVc2VyLUFnZW50Il07Ci0gICAgICAgIEVY UEVDVF9UUlVFKFt1c2VyQWdlbnRTdHJpbmcgaGFzUHJlZml4OkAiTW96aWxsYS81LjAgKE1hY2lu dG9zaDsiXSk7Ci0gICAgICAgIEVYUEVDVF9UUlVFKFt1c2VyQWdlbnRTdHJpbmcgaGFzU3VmZml4 OkAiKEtIVE1MLCBsaWtlIEdlY2tvKSJdKTsKKyAgICAgICAgRVhQRUNUX1RSVUUoW3VzZXJBZ2Vu dFN0cmluZyBoYXNQcmVmaXg6QCJNb3ppbGxhLzUuMCAiXSk7CisgICAgICAgIEVYUEVDVF9UUlVF KFt1c2VyQWdlbnRTdHJpbmcgY29udGFpbnNTdHJpbmc6QCIoS0hUTUwsIGxpa2UgR2Vja28pIl0p OwogICAgIH1dOwogICAgIFtjb25maWd1cmF0aW9uIHNldFVSTFNjaGVtZUhhbmRsZXI6c2NoZW1l SGFuZGxlci5nZXQoKSBmb3JVUkxTY2hlbWU6QCJ0ZXN0Il07CiAgICAgW2NvbmZpZ3VyYXRpb24g cHJlZmVyZW5jZXNdLl9uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcyA9IFlFUzsK