193978 2019-01-29 13:38:28 -0800 ValueRecovery::recover() should purify NaN values it recovers. 2019-01-29 14:05:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1499691 0 mark.lam 2019-01-29 13:38:28 -0800 According to DFG::OSRExit::executeOSRExit() and DFG::OSRExit::compileExit(), recovered DoubleDisplacedInJSStack values need to be purified. ValueRecovery::recover() should do the same. <rdar://problem/47625488> 1499697 1 360496 mark.lam 2019-01-29 13:47:14 -0800 Created attachment 360496 proposed patch. 1499710 2 mark.lam 2019-01-29 14:05:53 -0800 Thanks for the review. Landed in r240681: <http://trac.webkit.org/r240681>. 360496 2019-01-29 13:47:14 -0800 2019-01-29 13:48:29 -0800 proposed patch. bug-193978.patch text/plain 3305 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA2NzgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBWYWx1ZVJlY292ZXJ5OjpyZWNvdmVyKCkgc2hvdWxkIHB1cmlmeSBOYU4g dmFsdWVzIGl0IHJlY292ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzOTc4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzYyNTQ4OD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy92 YWx1ZS1yZWNvdmVyeS1vZi1kb3VibGUtZGlzcGxhY2VkLWluLWpzc3RhY2stc2hvdWxkLWJlLXB1 cmlmaWVkLmpzOiBBZGRlZC4KKwogMjAxOS0wMS0yOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUgdGVzdCBhZnRlciByMjQw NTQzIG5vdCB0byB1c2UgQEVycm9yIC8gRXJyb3IgaW4gYnVpbHRpbnMKSW5kZXg6IEpTVGVzdHMv c3RyZXNzL3ZhbHVlLXJlY292ZXJ5LW9mLWRvdWJsZS1kaXNwbGFjZWQtaW4tanNzdGFjay1zaG91 bGQtYmUtcHVyaWZpZWQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvdmFsdWUtcmVj b3Zlcnktb2YtZG91YmxlLWRpc3BsYWNlZC1pbi1qc3N0YWNrLXNob3VsZC1iZS1wdXJpZmllZC5q cwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy92YWx1ZS1yZWNvdmVyeS1vZi1kb3Vi bGUtZGlzcGxhY2VkLWluLWpzc3RhY2stc2hvdWxkLWJlLXB1cmlmaWVkLmpzCSh3b3JraW5nIGNv cHkpCkBAIC0wLDAgKzEsMTMgQEAKK2xldCBidWZmZXIgPSBuZXcgQXJyYXlCdWZmZXIoNCk7Cits ZXQgaW50MzJWaWV3ID0gbmV3IEludDMyQXJyYXkoYnVmZmVyKTsKK2ludDMyVmlld1swXSA9IC0x OworbGV0IGZsb2F0VmlldyA9IG5ldyBGbG9hdDMyQXJyYXkoYnVmZmVyKTsKKworZnVuY3Rpb24g Zm9vKCkgeworICAgIGxldCB0bXAgPSBmbG9hdFZpZXdbMF07CisgICAgZm9yIChsZXQgaSA9IDA7 IGkgPCAxMDAwMDsgKytpKSB7IH0KKyAgICBpZiAodG1wKSB7fQorfQorCitmb3IgKGxldCBpID0g MDsgaSA8IDEwMDsgKytpKQorICAgIGZvbygpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA2NzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMjkgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFZhbHVlUmVjb3Zlcnk6OnJlY292ZXIoKSBzaG91 bGQgcHVyaWZ5IE5hTiB2YWx1ZXMgaXQgcmVjb3ZlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQ3NjI1NDg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFjY29yZGluZyB0byBERkc6Ok9TUkV4aXQ6OmV4ZWN1dGVPU1JFeGl0KCkgYW5kIERGRzo6 T1NSRXhpdDo6Y29tcGlsZUV4aXQoKSwKKyAgICAgICAgcmVjb3ZlcmVkIERvdWJsZURpc3BsYWNl ZEluSlNTdGFjayB2YWx1ZXMgbmVlZCB0byBiZSBwdXJpZmllZC4KKyAgICAgICAgVmFsdWVSZWNv dmVyeTo6cmVjb3ZlcigpIHNob3VsZCBkbyB0aGUgc2FtZS4KKworICAgICAgICAqIGJ5dGVjb2Rl L1ZhbHVlUmVjb3ZlcnkuY3BwOgorICAgICAgICAoSlNDOjpWYWx1ZVJlY292ZXJ5OjpyZWNvdmVy IGNvbnN0KToKKwogMjAxOS0wMS0yOSAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIC54Y2ZpbGVsaXN0cyB0byBSdW4gU2NyaXB0IGJ1aWxkIHBoYXNlcwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1ZhbHVlUmVjb3ZlcnkuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9WYWx1ZVJlY292ZXJ5 LmNwcAkocmV2aXNpb24gMjQwNjc1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L1ZhbHVlUmVjb3ZlcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAq IENvcHlyaWdodCAoQykgMjAxMSwgMjAxMywgMjAxNSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTQzLDcgKzQzLDcg QEAgSlNWYWx1ZSBWYWx1ZVJlY292ZXJ5OjpyZWNvdmVyKEV4ZWNTdGF0ZQogICAgIGNhc2UgU3Ry aWN0SW50NTJEaXNwbGFjZWRJbkpTU3RhY2s6CiAgICAgICAgIHJldHVybiBqc051bWJlcihleGVj LT5yKHZpcnR1YWxSZWdpc3RlcigpLm9mZnNldCgpKS51bmJveGVkU3RyaWN0SW50NTIoKSk7CiAg ICAgY2FzZSBEb3VibGVEaXNwbGFjZWRJbkpTU3RhY2s6Ci0gICAgICAgIHJldHVybiBqc051bWJl cihleGVjLT5yKHZpcnR1YWxSZWdpc3RlcigpLm9mZnNldCgpKS51bmJveGVkRG91YmxlKCkpOwor ICAgICAgICByZXR1cm4ganNOdW1iZXIocHVyaWZ5TmFOKGV4ZWMtPnIodmlydHVhbFJlZ2lzdGVy KCkub2Zmc2V0KCkpLnVuYm94ZWREb3VibGUoKSkpOwogICAgIGNhc2UgQ2VsbERpc3BsYWNlZElu SlNTdGFjazoKICAgICAgICAgcmV0dXJuIGV4ZWMtPnIodmlydHVhbFJlZ2lzdGVyKCkub2Zmc2V0 KCkpLnVuYm94ZWRDZWxsKCk7CiAgICAgY2FzZSBCb29sZWFuRGlzcGxhY2VkSW5KU1N0YWNrOgo=