193954 2019-01-28 21:39:56 -0800 [LFC][BFC] Do not ignore next sibling box while laying out BFC. 2019-01-29 06:56:26 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1499408 0 zalan 2019-01-28 21:39:56 -0800 ssia 1499410 1 360438 zalan 2019-01-28 21:44:14 -0800 Created attachment 360438 Patch 1499490 2 360438 koivisto 2019-01-29 02:46:14 -0800 Comment on attachment 360438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360438&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:158 > + auto computeInFlowPositionedPosition = [&]() { Unneeded () 1499522 3 360438 commit-queue 2019-01-29 06:55:22 -0800 Comment on attachment 360438 Patch Clearing flags on attachment: 360438 Committed r240654: <https://trac.webkit.org/changeset/240654> 1499523 4 commit-queue 2019-01-29 06:55:24 -0800 All reviewed patches have been landed. Closing bug. 1499524 5 webkit-bug-importer 2019-01-29 06:56:26 -0800 <rdar://problem/47631344> 360438 2019-01-28 21:44:14 -0800 2019-01-29 06:55:22 -0800 Patch Patch.txt text/plain 7256 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4OTNmYTdjYTZjOS4uZTA2OTU4YTQwMzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMS0yOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0JGQ10gRG8gbm90IGlnbm9yZSBuZXh0IHNpYmxpbmcgYm94IHdoaWxl IGxheWluZyBvdXQgQkZDLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkzOTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBhIGJsb2NrIGJveCBoYXMgbm8gY2hpbGQgKDxpbWcgc3R5bGU9ImRpc3Bs YXk6IGJsb2NrIj4pLCB3ZSBzaG91bGQgbm90IGlnbm9yZSB0aGUgbmV4dCBzaWJsaW5nIChtb3Zl IHRoZSBjb250YWluZXIgY2hlY2sgdG8gdGhlIGZ1bmN0aW9uIHRvIGtlZXAgbGF5b3V0IGxvZ2lj IHNpbXBsZSkKKyAgICAgICAgQWxzbyBpbkZsb3dOb25SZXBsYWNlZFdpZHRoQW5kTWFyZ2luKCkg aXMgY2FsbGVkIHRocm91Z2ggaW5GbG93UmVwbGFjZWRXaWR0aEFuZE1hcmdpbigpIHRvIGNvbXB1 dGUgbWFyZ2lucy4KKworICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3Jt YXR0aW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0 dGluZ0NvbnRleHQ6OmxheW91dCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJs b2NrRm9ybWF0dGluZ0NvbnRleHQ6OnBsYWNlSW5GbG93UG9zaXRpb25lZENoaWxkcmVuIGNvbnN0 KToKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRl eHQuaDoKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0Nv bnRleHRHZW9tZXRyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0 dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjppbkZsb3dOb25SZXBsYWNlZFdpZHRoQW5kTWFyZ2luKToK KwogMjAxOS0wMS0yOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtMRkNdW0JGQ11bTWFyZ2luQ29sbGFwc2luZ10gQW5vbnltb3VzIGJsb2NrIGNvbnRhaW5lcidz IG1hcmdpbiBiZWZvcmUgZG9lcyBub3QgY29sbGFwc2Ugd2l0aCBwcmV2aW91cyBpbmZsb3cgc2li bGluZyBtYXJnaW4gYWZ0ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxv Y2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCBi MWE5Njg1YWY4ZC4uOTU4ZWQzNTc0Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNw cApAQCAtMTA1LDEyICsxMDUsOSBAQCB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmxheW91 dCgpIGNvbnN0CiAgICAgICAgICAgICAvLyBGb3JtYXR0aW5nIHJvb3QgYm94ZXMgYXJlIHNwZWNp YWwtY2FzZWQgYW5kIHRoZXkgZG9uJ3QgY29tZSBoZXJlLgogICAgICAgICAgICAgQVNTRVJUKCFs YXlvdXRCb3guZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKTsKICAgICAgICAgICAgIGNv bXB1dGVIZWlnaHRBbmRNYXJnaW4obGF5b3V0Qm94KTsKLSAgICAgICAgICAgIGlmICghaXM8Q29u dGFpbmVyPihsYXlvdXRCb3gpKQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAg ICAgYXV0byYgY29udGFpbmVyID0gZG93bmNhc3Q8Q29udGFpbmVyPihsYXlvdXRCb3gpOwogICAg ICAgICAgICAgLy8gTW92ZSBpbi1mbG93IHBvc2l0aW9uZWQgY2hpbGRyZW4gdG8gdGhlaXIgZmlu YWwgcG9zaXRpb24uCi0gICAgICAgICAgICBwbGFjZUluRmxvd1Bvc2l0aW9uZWRDaGlsZHJlbihj b250YWluZXIpOwotICAgICAgICAgICAgaWYgKGF1dG8qIG5leHRTaWJsaW5nID0gY29udGFpbmVy Lm5leHRJbkZsb3dPckZsb2F0aW5nU2libGluZygpKSB7CisgICAgICAgICAgICBwbGFjZUluRmxv d1Bvc2l0aW9uZWRDaGlsZHJlbihsYXlvdXRCb3gpOworICAgICAgICAgICAgaWYgKGF1dG8qIG5l eHRTaWJsaW5nID0gbGF5b3V0Qm94Lm5leHRJbkZsb3dPckZsb2F0aW5nU2libGluZygpKSB7CiAg ICAgICAgICAgICAgICAgbGF5b3V0UXVldWUuYXBwZW5kKG5leHRTaWJsaW5nKTsKICAgICAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KQEAgLTE0NywxOCArMTQ0LDIyIEBAIHZvaWQg QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6bGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290KEZsb2F0 aW5nQ29udGV4dCYgZmxvYXRpCiAgICAgZm9ybWF0dGluZ0NvbnRleHQtPmxheW91dE91dE9mRmxv d0Rlc2NlbmRhbnRzKGxheW91dEJveCk7CiB9CiAKLXZvaWQgQmxvY2tGb3JtYXR0aW5nQ29udGV4 dDo6cGxhY2VJbkZsb3dQb3NpdGlvbmVkQ2hpbGRyZW4oY29uc3QgQ29udGFpbmVyJiBjb250YWlu ZXIpIGNvbnN0Cit2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OnBsYWNlSW5GbG93UG9zaXRp b25lZENoaWxkcmVuKGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAogewotICAgIExPR19XSVRI X1NUUkVBTShGb3JtYXR0aW5nQ29udGV4dExheW91dCwgc3RyZWFtIDw8ICJTdGFydDogbW92ZSBp bi1mbG93IHBvc2l0aW9uZWQgY2hpbGRyZW4gLT4gcGFyZW50OiAiIDw8ICZjb250YWluZXIpOwot ICAgIGZvciAoYXV0byYgbGF5b3V0Qm94IDogY2hpbGRyZW5PZlR5cGU8Qm94Pihjb250YWluZXIp KSB7Ci0gICAgICAgIGlmICghbGF5b3V0Qm94LmlzSW5GbG93UG9zaXRpb25lZCgpKQorICAgIGlm ICghaXM8Q29udGFpbmVyPihsYXlvdXRCb3gpKQorICAgICAgICByZXR1cm47CisKKyAgICBMT0df V0lUSF9TVFJFQU0oRm9ybWF0dGluZ0NvbnRleHRMYXlvdXQsIHN0cmVhbSA8PCAiU3RhcnQ6IG1v dmUgaW4tZmxvdyBwb3NpdGlvbmVkIGNoaWxkcmVuIC0+IHBhcmVudDogIiA8PCAmbGF5b3V0Qm94 KTsKKyAgICBhdXRvJiBjb250YWluZXIgPSBkb3duY2FzdDxDb250YWluZXI+KGxheW91dEJveCk7 CisgICAgZm9yIChhdXRvJiBjaGlsZEJveCA6IGNoaWxkcmVuT2ZUeXBlPEJveD4oY29udGFpbmVy KSkgeworICAgICAgICBpZiAoIWNoaWxkQm94LmlzSW5GbG93UG9zaXRpb25lZCgpKQogICAgICAg ICAgICAgY29udGludWU7CiAKLSAgICAgICAgYXV0byBjb21wdXRlSW5GbG93UG9zaXRpb25lZFBv c2l0aW9uID0gWyZdKGF1dG8mIGxheW91dEJveCkgeworICAgICAgICBhdXRvIGNvbXB1dGVJbkZs b3dQb3NpdGlvbmVkUG9zaXRpb24gPSBbJl0oKSB7CiAgICAgICAgICAgICBhdXRvJiBsYXlvdXRT dGF0ZSA9IHRoaXMtPmxheW91dFN0YXRlKCk7Ci0gICAgICAgICAgICBhdXRvIHBvc2l0aW9uT2Zm c2V0ID0gR2VvbWV0cnk6OmluRmxvd1Bvc2l0aW9uZWRQb3NpdGlvbk9mZnNldChsYXlvdXRTdGF0 ZSwgbGF5b3V0Qm94KTsKKyAgICAgICAgICAgIGF1dG8gcG9zaXRpb25PZmZzZXQgPSBHZW9tZXRy eTo6aW5GbG93UG9zaXRpb25lZFBvc2l0aW9uT2Zmc2V0KGxheW91dFN0YXRlLCBjaGlsZEJveCk7 CiAKLSAgICAgICAgICAgIGF1dG8mIGRpc3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94 Rm9yTGF5b3V0Qm94KGxheW91dEJveCk7CisgICAgICAgICAgICBhdXRvJiBkaXNwbGF5Qm94ID0g bGF5b3V0U3RhdGUuZGlzcGxheUJveEZvckxheW91dEJveChjaGlsZEJveCk7CiAgICAgICAgICAg ICBhdXRvIHRvcExlZnQgPSBkaXNwbGF5Qm94LnRvcExlZnQoKTsKIAogICAgICAgICAgICAgdG9w TGVmdC5tb3ZlKHBvc2l0aW9uT2Zmc2V0KTsKQEAgLTE2Niw5ICsxNjcsOSBAQCB2b2lkIEJsb2Nr Rm9ybWF0dGluZ0NvbnRleHQ6OnBsYWNlSW5GbG93UG9zaXRpb25lZENoaWxkcmVuKGNvbnN0IENv bnRhaW5lciYgY29udAogICAgICAgICAgICAgZGlzcGxheUJveC5zZXRUb3BMZWZ0KHRvcExlZnQp OwogICAgICAgICB9OwogCi0gICAgICAgIGNvbXB1dGVJbkZsb3dQb3NpdGlvbmVkUG9zaXRpb24o bGF5b3V0Qm94KTsKKyAgICAgICAgY29tcHV0ZUluRmxvd1Bvc2l0aW9uZWRQb3NpdGlvbigpOwog ICAgIH0KLSAgICBMT0dfV0lUSF9TVFJFQU0oRm9ybWF0dGluZ0NvbnRleHRMYXlvdXQsIHN0cmVh bSA8PCAiRW5kOiBtb3ZlIGluLWZsb3cgcG9zaXRpb25lZCBjaGlsZHJlbiAtPiBwYXJlbnQ6ICIg PDwgJmNvbnRhaW5lcik7CisgICAgTE9HX1dJVEhfU1RSRUFNKEZvcm1hdHRpbmdDb250ZXh0TGF5 b3V0LCBzdHJlYW0gPDwgIkVuZDogbW92ZSBpbi1mbG93IHBvc2l0aW9uZWQgY2hpbGRyZW4gLT4g cGFyZW50OiAiIDw8ICZsYXlvdXRCb3gpOwogfQogCiB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRl eHQ6OmNvbXB1dGVTdGF0aWNQb3NpdGlvbihjb25zdCBGbG9hdGluZ0NvbnRleHQmIGZsb2F0aW5n Q29udGV4dCwgY29uc3QgQm94JiBsYXlvdXRCb3gpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29u dGV4dC5oCmluZGV4IDNlOTljNDJiOThiLi5mNGNjNzAxZjVjNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmgK KysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRp bmdDb250ZXh0LmgKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIHZv aWQgbGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290KEZsb2F0aW5nQ29udGV4dCYsIGNvbnN0IEJv eCYpIGNvbnN0OwotICAgIHZvaWQgcGxhY2VJbkZsb3dQb3NpdGlvbmVkQ2hpbGRyZW4oY29uc3Qg Q29udGFpbmVyJikgY29uc3Q7CisgICAgdm9pZCBwbGFjZUluRmxvd1Bvc2l0aW9uZWRDaGlsZHJl bihjb25zdCBCb3gmKSBjb25zdDsKIAogICAgIHZvaWQgY29tcHV0ZVdpZHRoQW5kTWFyZ2luKGNv bnN0IEJveCYpIGNvbnN0OwogICAgIHZvaWQgY29tcHV0ZUhlaWdodEFuZE1hcmdpbihjb25zdCBC b3gmKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1h dHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNw cAppbmRleCA2NDg0ZGVkODRjZS4uMDVmMDdhNmNmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9y bWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKQEAgLTEwOSw3ICsxMDksNyBAQCBIZWlnaHRBbmRN YXJnaW4gQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmluRmxvd05vblJlcGxhY2Vk SGVpZ2h0QW5kTWFyZwogCiBXaWR0aEFuZE1hcmdpbiBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpH ZW9tZXRyeTo6aW5GbG93Tm9uUmVwbGFjZWRXaWR0aEFuZE1hcmdpbihjb25zdCBMYXlvdXRTdGF0 ZSYgbGF5b3V0U3RhdGUsIGNvbnN0IEJveCYgbGF5b3V0Qm94LCBPcHRpb25hbDxMYXlvdXRVbml0 PiB1c2VkV2lkdGgpCiB7Ci0gICAgQVNTRVJUKGxheW91dEJveC5pc0luRmxvdygpICYmICFsYXlv dXRCb3gucmVwbGFjZWQoKSk7CisgICAgQVNTRVJUKGxheW91dEJveC5pc0luRmxvdygpKTsKIAog ICAgIGF1dG8gY29tcHV0ZSA9IFsmXSgpIHsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGYxZDYwY2RlZTc0Li5iN2FhMWIyNzM4MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE5LTAxLTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgW0xGQ11bQkZDXSBEbyBub3QgaWdub3JlIG5leHQgc2libGluZyBib3ggd2hpbGUgbGF5aW5n IG91dCBCRkMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTM5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIExheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0OgorCiAyMDE5LTAx LTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lv bihQU09OKSBDcmFzaCB1bmRlciBXZWJQYWdlUHJveHk6OmRpZFN0YXJ0UHJvZ3Jlc3MoKQpkaWZm IC0tZ2l0IGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQg Yi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dAppbmRleCAx MzU5MzRlZTgyMy4uYWY1NTVkYTAwMzkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFJlbG9hZGVk L21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CisrKyBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21p c2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CkBAIC0xNDgsNiArMTQ4LDcgQEAgZmFzdC9ibG9jay9t YXJnaW4tY29sbGFwc2UvMDQwLmh0bWwKIGZhc3QvYmxvY2svbWFyZ2luLWNvbGxhcHNlLzA0My5o dG1sCiBmYXN0L2Jsb2NrL21hcmdpbi1jb2xsYXBzZS8wNDQuaHRtbAogZmFzdC9ibG9jay9tYXJn aW4tY29sbGFwc2UvMDYzLmh0bWwKK2Zhc3QvYmxvY2svbWFyZ2luLWNvbGxhcHNlLzEwMC5odG1s CiBmYXN0L2Jsb2NrL21hcmdpbi1jb2xsYXBzZS9jb2xsYXBzZWQtdGhyb3VnaC1jaGlsZC1zaW1w bGUuaHRtbAogZmFzdC9ibG9jay9wb3NpdGlvbmluZy8wMDMuaHRtbAogZmFzdC9ibG9jay9wb3Np dGlvbmluZy8wMDQuaHRtbAo=