193922 2019-01-28 13:28:30 -0800 REGRESSION (r240498): Storage Access API prompts result is not remembered 2019-01-28 14:34:28 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193297 InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham cdumez webkit-bug-importer wilander oldest_to_newest 1499157 0 bfulgham 2019-01-28 13:28:30 -0800 Accepting a Storage Access API dialog request is supposed to be remembered for a period of 30 browser use days. The changes in r240498 broke this 'memory' causing the prompt to fire each time. 1499165 1 webkit-bug-importer 2019-01-28 13:35:48 -0800 <rdar://problem/47608767> 1499175 2 360373 bfulgham 2019-01-28 13:53:53 -0800 Created attachment 360373 Patch 1499189 3 bfulgham 2019-01-28 14:34:28 -0800 Committed r240602: <https://trac.webkit.org/changeset/240602> 360373 2019-01-28 13:53:53 -0800 2019-01-28 14:16:39 -0800 Patch bug-193922-20190128135352.patch text/plain 5687 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5MGE0OWQ2OGFkNmVlMmY1 YTA3Y2Q4OGM0MTM2N2UxOTA1MjQyYTAuLjE1YTcxNzcwYTAzNGI0OWM4ZTRkMGU3YzkxNDkxNWIz NDg2OWE0ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDEtMjggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0MDQ5 OCk6IFN0b3JhZ2UgQWNjZXNzIEFQSSBwcm9tcHRzIHJlc3VsdCBpcyBub3QgcmVtZW1iZXJlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTIyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzYwODc2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcmVmYWN0b3JpbmcgaW4gcjI0MDQ5OCBieXBh c3NlZCBib29ra2VlcGluZyBpbiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmUKKyAg ICAgICAgdGhhdCBrZXB0IHRyYWNrIG9mIHdoZXRoZXIgYSBzdWNjZXNzZnVsIHVzZXIgcHJvbXB0 IGhhZCBiZWVuIGVuY291bnRlcmVkLiBUaGlzCisgICAgICAgIHBhdGNoIGNvcnJlY3RzIHRoaXMg Y29kZXBhdGggc28gdGhlIHVzZXIgaXMgbm90IHByb21wdGVkIHJlcGVhdGVkbHkgYWZ0ZXIgYXBw cm92aW5nCisgICAgICAgIHVzZSBvZiB0aGUgU3RvcmFnZSBBY2Nlc3MgQVBJLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3Rv cmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6 OmdyYW50U3RvcmFnZUFjY2Vzcyk6IFN3aXRjaCBmcm9tIE1vdmUgb3BlcmF0b3IgdG8KKyAgICAg ICAgY29uc3QgcmVmZXJlbmNlIHRvIGFsbG93IHRoZSBtZXRob2QgdG8gYmUgY2FsbGVkIGJ5IHRo ZSBOZXR3b3JrUHJvY2Vzcy4KKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dl YlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5oOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6Omdy YW50U3RvcmFnZUFjY2Vzcyk6IFJlcXVlc3QgYWNjZXNzIHRocm91Z2ggdGhlIFdlYlJlc291cmNl TG9hZFN0YXRpc3RpY3MKKyAgICAgICAgb2JqZWN0LCByYXRoZXIgdGhhbiBqdW1waW5nIGRpcmVj dGx5IHRvIHRoZSBOZXR3b3JrU3RvcmFnZVNlc3Npb24uCisKIDIwMTktMDEtMjggIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBMaW1pdCB1c2VyLWFnZW50IGlu dGVyYWN0aW9ucyBiYXNlZCBvbiB0aGUgdG91Y2gtYWN0aW9uIHByb3BlcnR5IG9uIGlPUwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291 cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcAppbmRleCAzM2Y1 ZjBkMDAyODcwMmQyMTVjNjQ1MGQ3Zjc3OGIwMzMzYzZhYjkyLi41Y2RmODMwMjY1MjcxMDE0YTk1 YzA0NTRiODdjNGNmMTg1NThmNTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2Fk U3RhdGlzdGljc1N0b3JlLmNwcApAQCAtMzM5LDcgKzMzOSw3IEBAIHZvaWQgV2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1N0b3JlOjpyZXF1ZXN0U3RvcmFnZUFjY2Vzc1VuZGVyT3BlbmVyKFN0cmlu ZyYmIHByCiAgICAgfSk7CiB9CiAKLXZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3Jl OjpncmFudFN0b3JhZ2VBY2Nlc3MoU3RyaW5nJiYgc3ViRnJhbWVIb3N0LCBTdHJpbmcmJiB0b3BG cmFtZUhvc3QsIHVpbnQ2NF90IGZyYW1lSUQsIHVpbnQ2NF90IHBhZ2VJRCwgYm9vbCB1c2VyV2Fz UHJvbXB0ZWROb3csIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoYm9vbCk+JiYgY29tcGxldGlvbkhh bmRsZXIpCit2b2lkIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6Z3JhbnRTdG9yYWdl QWNjZXNzKGNvbnN0IFN0cmluZyYgc3ViRnJhbWVIb3N0LCBjb25zdCBTdHJpbmcmIHRvcEZyYW1l SG9zdCwgdWludDY0X3QgZnJhbWVJRCwgdWludDY0X3QgcGFnZUlELCBib29sIHVzZXJXYXNQcm9t cHRlZE5vdywgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChib29sKT4mJiBjb21wbGV0aW9uSGFuZGxl cikKIHsKICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIHBvc3RUYXNrKFt0aGlz LCBzdWJGcmFtZUhvc3QgPSBjcm9zc1RocmVhZENvcHkoc3ViRnJhbWVIb3N0KSwgdG9wRnJhbWVI b3N0ID0gY3Jvc3NUaHJlYWRDb3B5KHRvcEZyYW1lSG9zdCksIGZyYW1lSUQsIHBhZ2VJRCwgdXNl cldhc1Byb21wdGVkTm93LCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhh bmRsZXIpXSgpIG11dGFibGUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5oIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZS5oCmluZGV4IGRmZDA2NWFkNTlhMWY4YTcwZTEzMzA2NmI2MTZkMWY5ZjIwZjdkM2Yu LmQyODg5MGViZTBiNGU2MzdmMDMxMzBkYWZhMGU3MGY0MjM2MzVjMjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzU3RvcmUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZp ZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmgKQEAgLTc2LDcgKzc2LDcgQEAgcHVi bGljOgogICAgIHZvaWQgc2V0U2hvdWxkU3VibWl0VGVsZW1ldHJ5KGJvb2wpOwogCiAgICAgdm9p ZCByZXF1ZXN0U3RvcmFnZUFjY2VzcyhTdHJpbmcmJiBzdWJGcmFtZUhvc3QsIFN0cmluZyYmIHRv cEZyYW1lSG9zdCwgdWludDY0X3QgZnJhbWVJRCwgdWludDY0X3QgcGFnZUlELCBib29sIHByb21w dEVuYWJsZWQsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoU3RvcmFnZUFjY2Vzc1N0YXR1cyk+JiYp OwotICAgIHZvaWQgZ3JhbnRTdG9yYWdlQWNjZXNzKFN0cmluZyYmIHN1YkZyYW1lSG9zdCwgU3Ry aW5nJiYgdG9wRnJhbWVIb3N0LCB1aW50NjRfdCBmcmFtZUlELCB1aW50NjRfdCBwYWdlSUQsIGJv b2wgdXNlcldhc1Byb21wdGVkTm93LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGJvb2wpPiYmKTsK KyAgICB2b2lkIGdyYW50U3RvcmFnZUFjY2Vzcyhjb25zdCBTdHJpbmcmIHN1YkZyYW1lSG9zdCwg Y29uc3QgU3RyaW5nJiB0b3BGcmFtZUhvc3QsIHVpbnQ2NF90IGZyYW1lSUQsIHVpbnQ2NF90IHBh Z2VJRCwgYm9vbCB1c2VyV2FzUHJvbXB0ZWROb3csIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoYm9v bCk+JiYpOwogICAgIHZvaWQgcmVxdWVzdFN0b3JhZ2VBY2Nlc3NDYWxsYmFjayhib29sIHdhc0dy YW50ZWQsIHVpbnQ2NF90IGNvbnRleHRJZCk7CiAKICAgICB2b2lkIGFwcGxpY2F0aW9uV2lsbFRl cm1pbmF0ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmNwcAppbmRleCBjZGNiMmFiMjRhYjM4OTlmNDNjYmJiNzQyN2IwZmUyOWNjMzVhMzhhLi45 NTQyODc5Y2Q3MGEzZGZlMDBjNjVmMGJkOWEzOGJhNzYyNDg1OTE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcApAQCAtOTgwLDE1ICs5ODAs MTUgQEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cmVxdWVzdFN0b3JhZ2VBY2Nlc3MoUEFMOjpTZXNz aW9uSUQgc2Vzc2lvbklELCBjb25zdCBTdHJpbmcKIAogdm9pZCBOZXR3b3JrUHJvY2Vzczo6Z3Jh bnRTdG9yYWdlQWNjZXNzKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCwgY29uc3QgU3RyaW5nJiBy ZXNvdXJjZURvbWFpbiwgY29uc3QgU3RyaW5nJiBmaXJzdFBhcnR5RG9tYWluLCBPcHRpb25hbDx1 aW50NjRfdD4gZnJhbWVJRCwgdWludDY0X3QgcGFnZUlELCBib29sIHVzZXJXYXNQcm9tcHRlZCwg Q29tcGxldGlvbkhhbmRsZXI8dm9pZChib29sKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKLSAg ICBib29sIGlzU3RvcmFnZUdyYW50ZWQgPSBmYWxzZTsKLSAgICBpZiAoYXV0byogbmV0d29ya1N0 b3JhZ2VTZXNzaW9uID0gc3RvcmFnZVNlc3Npb24oc2Vzc2lvbklEKSkgewotICAgICAgICBuZXR3 b3JrU3RvcmFnZVNlc3Npb24tPmdyYW50U3RvcmFnZUFjY2VzcyhyZXNvdXJjZURvbWFpbiwgZmly c3RQYXJ0eURvbWFpbiwgZnJhbWVJRCwgcGFnZUlEKTsKLSAgICAgICAgQVNTRVJUKG5ldHdvcmtT dG9yYWdlU2Vzc2lvbi0+aGFzU3RvcmFnZUFjY2VzcyhyZXNvdXJjZURvbWFpbiwgZmlyc3RQYXJ0 eURvbWFpbiwgZnJhbWVJRCwgcGFnZUlEKSk7Ci0gICAgICAgIGlzU3RvcmFnZUdyYW50ZWQgPSB0 cnVlOwotICAgIH0gZWxzZQorICAgIGlmIChhdXRvKiBuZXR3b3JrU2Vzc2lvbiA9IHRoaXMtPm5l dHdvcmtTZXNzaW9uKHNlc3Npb25JRCkpIHsKKyAgICAgICAgaWYgKGF1dG8qIHJlc291cmNlTG9h ZFN0YXRpc3RpY3MgPSBuZXR3b3JrU2Vzc2lvbi0+cmVzb3VyY2VMb2FkU3RhdGlzdGljcygpKQor ICAgICAgICAgICAgcmVzb3VyY2VMb2FkU3RhdGlzdGljcy0+Z3JhbnRTdG9yYWdlQWNjZXNzKHJl c291cmNlRG9tYWluLCBmaXJzdFBhcnR5RG9tYWluLCBmcmFtZUlELnZhbHVlKCksIHBhZ2VJRCwg dXNlcldhc1Byb21wdGVkLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CisgICAgICAgIGVs c2UKKyAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKKyAgICB9IGVsc2Ugewog ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLQotICAgIGNvbXBsZXRpb25IYW5kbGVyKGlz U3RvcmFnZUdyYW50ZWQpOworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihmYWxzZSk7CisgICAg fQogfQogCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpsb2dGcmFtZU5hdmlnYXRpb24oUEFMOjpTZXNz aW9uSUQgc2Vzc2lvbklELCBjb25zdCBTdHJpbmcmIHRhcmdldFByaW1hcnlEb21haW4sIGNvbnN0 IFN0cmluZyYgbWFpbkZyYW1lUHJpbWFyeURvbWFpbiwgY29uc3QgU3RyaW5nJiBzb3VyY2VQcmlt YXJ5RG9tYWluLCBjb25zdCBTdHJpbmcmIHRhcmdldEhvc3QsIGNvbnN0IFN0cmluZyYgbWFpbkZy YW1lSG9zdCwgYm9vbCBpc1JlZGlyZWN0LCBib29sIGlzTWFpbkZyYW1lKQo=