193921 2019-01-28 13:19:34 -0800 Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler 2019-01-29 00:03:53 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1499151 0 joepeck 2019-01-28 13:19:34 -0800 Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler 1499153 1 360364 joepeck 2019-01-28 13:20:26 -0800 Created attachment 360364 [PATCH] Proposed Fix 1499154 2 360364 hi 2019-01-28 13:21:53 -0800 Comment on attachment 360364 [PATCH] Proposed Fix r=me, awesome! 1499161 3 360366 joepeck 2019-01-28 13:31:29 -0800 Created attachment 360366 [PATCH] For Landing 1499452 4 360366 commit-queue 2019-01-28 23:55:47 -0800 Comment on attachment 360366 [PATCH] For Landing Clearing flags on attachment: 360366 Committed r240647: <https://trac.webkit.org/changeset/240647> 1499460 5 webkit-bug-importer 2019-01-29 00:03:53 -0800 <rdar://problem/47625300> 360364 2019-01-28 13:20:26 -0800 2019-01-28 13:31:33 -0800 [PATCH] Proposed Fix thing-1.patch text/plain 3450 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlkMmU2YThlMGJkLi4yY2UyNzNhZmVmYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMjggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW5uZWNlc3NhcnkgcHJvbWlzZSByZWplY3Rpb24gaGFuZGxlcnMgbm93IHRoYXQg d2UgdXNlIHRoZSBnbG9iYWwgb251bmhhbmRsZWRyZWplY3Rpb24gaGFuZGxlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTIxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jh c2UvVXRpbGl0aWVzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRF eGNlcHRpb25SZXBvcnRlci5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdv cmtUYWJsZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuTmV0d29ya1RhYmxlQ29udGVudFZp ZXcucHJvdG90eXBlLl9leHBvcnRIQVIpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdJLlRleHRFZGl0b3IucHJvdG90eXBlLnVwZGF0ZUZv cm1hdHRlZFN0YXRlKToKKwogMjAxOS0wMS0yNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcHJvdmUgRGFyayBNb2RlIGFw cGVhcmFuY2Ugd2l0aGluIE1lbW9yeSB0aW1lbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwppbmRleCA5YmYwODk0M2Rj Ny4uOWMyYTY3MGZmNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzCkBAIC0xNzA4LDEwICsxNzA4LDMgQEAgZnVuY3Rp b24gYmxvYkFzVGV4dChibG9iLCBjYWxsYmFjaykKICAgICBmaWxlUmVhZGVyLmFkZEV2ZW50TGlz dGVuZXIoImxvYWRlbmQiLCAoKSA9PiB7IGNhbGxiYWNrKGZpbGVSZWFkZXIucmVzdWx0KTsgfSk7 CiAgICAgZmlsZVJlYWRlci5yZWFkQXNUZXh0KGJsb2IpOwogfQotCi1pZiAoIXdpbmRvdy5oYW5k bGVQcm9taXNlRXhjZXB0aW9uKSB7Ci0gICAgd2luZG93LmhhbmRsZVByb21pc2VFeGNlcHRpb24g PSBmdW5jdGlvbiBoYW5kbGVQcm9taXNlRXhjZXB0aW9uKGVycm9yKQotICAgIHsKLSAgICAgICAg Y29uc29sZS5lcnJvcigiVW5jYXVnaHQgZXhjZXB0aW9uIGluIFByb21pc2UiLCBlcnJvcik7Ci0g ICAgfTsKLX0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0RlYnVnL1VuY2F1Z2h0RXhjZXB0aW9uUmVwb3J0ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9EZWJ1Zy9VbmNhdWdodEV4Y2VwdGlvblJlcG9ydGVyLmpzCmluZGV4 IDNmOGM4Njg4Y2EyLi5lNmE1ZWIzMzM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRpb25SZXBvcnRlci5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9VbmNhdWdodEV4Y2Vw dGlvblJlcG9ydGVyLmpzCkBAIC0yODgsNiArMjg4LDYgQEAgRG9jdW1lbnQgYW55IGFkZGl0aW9u YWwgaW5mb3JtYXRpb24gdGhhdCBtaWdodCBiZSB1c2VmdWwgaW4gcmVzb2x2aW5nIHRoZSBwcm9i bGUKIH0KIAogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImVycm9yIiwgaGFuZGxlVW5jYXVnaHRF eGNlcHRpb24pOwotd2luZG93LmhhbmRsZVByb21pc2VFeGNlcHRpb24gPSB3aW5kb3cuaGFuZGxl SW50ZXJuYWxFeGNlcHRpb24gPSBoYW5kbGVFcnJvcjsKK3dpbmRvdy5oYW5kbGVJbnRlcm5hbEV4 Y2VwdGlvbiA9IGhhbmRsZUVycm9yOwogCiB9KSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVD b250ZW50Vmlldy5qcwppbmRleCBhYTZmNDVlMzllNy4uZjRlNzZjYTVlOTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNv bnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCkBAIC0xOTIzLDcgKzE5MjMsNyBAQCBXSS5O ZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4 dGVuZHMgV0kuQ29udGVudFZpZQogICAgICAgICAgICAgICAgIGNvbnRlbnQ6IEpTT04uc3RyaW5n aWZ5KGhhciwgbnVsbCwgMiksCiAgICAgICAgICAgICAgICAgZm9yY2VTYXZlQXM6IHRydWUsCiAg ICAgICAgICAgICB9KTsKLSAgICAgICAgfSkuY2F0Y2goaGFuZGxlUHJvbWlzZUV4Y2VwdGlvbik7 CisgICAgICAgIH0pOwogICAgIH0KIAogICAgIF93YXRlcmZhbGxQb3BvdmVyQ29udGVudCgpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0 RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4 dEVkaXRvci5qcwppbmRleCA4ZWUzODJhMDc3Yi4uYWI5NmQzOWYzNzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5q cwpAQCAtMjAwLDcgKzIwMCw3IEBAIFdJLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4 dGVuZHMgV0kuVmlldwogCiAgICAgdXBkYXRlRm9ybWF0dGVkU3RhdGUoZm9ybWF0dGVkKQogICAg IHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX2Zvcm1hdChmb3JtYXR0ZWQpLmNhdGNoKGhhbmRsZVBy b21pc2VFeGNlcHRpb24pOworICAgICAgICByZXR1cm4gdGhpcy5fZm9ybWF0KGZvcm1hdHRlZCk7 CiAgICAgfQogCiAgICAgaGFzRm9ybWF0dGVyKCkK 360366 2019-01-28 13:31:29 -0800 2019-01-28 23:55:47 -0800 [PATCH] For Landing thing-2.patch text/plain 3526 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhZDdiYzNjMzY1Li5mNmJlMjk3Y2E4YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMjggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW5uZWNlc3NhcnkgcHJvbWlzZSByZWplY3Rpb24gaGFuZGxlcnMgbm93IHRoYXQg d2UgdXNlIHRoZSBnbG9iYWwgb251bmhhbmRsZWRyZWplY3Rpb24gaGFuZGxlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTIxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNl L1V0aWxpdGllcy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0RlYnVnL1VuY2F1Z2h0RXhj ZXB0aW9uUmVwb3J0ZXIuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3Jr VGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3 LnByb3RvdHlwZS5fZXhwb3J0SEFSKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Rl eHRFZGl0b3IuanM6CisgICAgICAgIChXSS5UZXh0RWRpdG9yLnByb3RvdHlwZS51cGRhdGVGb3Jt YXR0ZWRTdGF0ZSk6CisKIDIwMTktMDEtMjUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXByb3ZlIERhcmsgTW9kZSBhcHBl YXJhbmNlIHdpdGhpbiBNZW1vcnkgdGltZWxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKaW5kZXggYzFkZGVkNTMxMzku LjUyNGQzZjAzZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL1V0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qcwpAQCAtMTc2OSwxMCArMTc2OSwzIEBAIGZ1bmN0aW9u IGJsb2JBc1RleHQoYmxvYiwgY2FsbGJhY2spCiAgICAgZmlsZVJlYWRlci5hZGRFdmVudExpc3Rl bmVyKCJsb2FkZW5kIiwgKCkgPT4geyBjYWxsYmFjayhmaWxlUmVhZGVyLnJlc3VsdCk7IH0pOwog ICAgIGZpbGVSZWFkZXIucmVhZEFzVGV4dChibG9iKTsKIH0KLQotaWYgKCF3aW5kb3cuaGFuZGxl UHJvbWlzZUV4Y2VwdGlvbikgewotICAgIHdpbmRvdy5oYW5kbGVQcm9taXNlRXhjZXB0aW9uID0g ZnVuY3Rpb24gaGFuZGxlUHJvbWlzZUV4Y2VwdGlvbihlcnJvcikKLSAgICB7Ci0gICAgICAgIGNv bnNvbGUuZXJyb3IoIlVuY2F1Z2h0IGV4Y2VwdGlvbiBpbiBQcm9taXNlIiwgZXJyb3IpOwotICAg IH07Ci19CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9E ZWJ1Zy9VbmNhdWdodEV4Y2VwdGlvblJlcG9ydGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRpb25SZXBvcnRlci5qcwppbmRleCAw MjgzYmY1ZjdjNS4uNzYzNTJiMWQ5MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0RlYnVnL1VuY2F1Z2h0RXhjZXB0aW9uUmVwb3J0ZXIuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWcvVW5jYXVnaHRFeGNlcHRp b25SZXBvcnRlci5qcwpAQCAtMjk5LDYgKzI5OSw2IEBAIERvY3VtZW50IGFueSBhZGRpdGlvbmFs IGluZm9ybWF0aW9uIHRoYXQgbWlnaHQgYmUgdXNlZnVsIGluIHJlc29sdmluZyB0aGUgcHJvYmxl CiAKIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJlcnJvciIsIGhhbmRsZVVuY2F1Z2h0RXhjZXB0 aW9uKTsKIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJ1bmhhbmRsZWRyZWplY3Rpb24iLCBoYW5k bGVVbmhhbmRsZWRQcm9taXNlUmVqZWN0aW9uKTsKLXdpbmRvdy5oYW5kbGVQcm9taXNlRXhjZXB0 aW9uID0gd2luZG93LmhhbmRsZUludGVybmFsRXhjZXB0aW9uID0gaGFuZGxlRXJyb3I7Cit3aW5k b3cuaGFuZGxlSW50ZXJuYWxFeGNlcHRpb24gPSBoYW5kbGVFcnJvcjsKIAogfSkoKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtU YWJsZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggYWE2ZjQ1ZTM5ZTcuLmY0ZTc2 Y2E1ZTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAtMTky Myw3ICsxOTIzLDcgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3Jr VGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgICAgICAgICBj b250ZW50OiBKU09OLnN0cmluZ2lmeShoYXIsIG51bGwsIDIpLAogICAgICAgICAgICAgICAgIGZv cmNlU2F2ZUFzOiB0cnVlLAogICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0pLmNhdGNoKGhhbmRs ZVByb21pc2VFeGNlcHRpb24pOworICAgICAgICB9KTsKICAgICB9CiAKICAgICBfd2F0ZXJmYWxs UG9wb3ZlckNvbnRlbnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5kZXggOGVlMzgyYTA3N2IuLmFiOTZkMzlm Mzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTIwMCw3ICsyMDAsNyBAQCBXSS5UZXh0RWRpdG9yID0g Y2xhc3MgVGV4dEVkaXRvciBleHRlbmRzIFdJLlZpZXcKIAogICAgIHVwZGF0ZUZvcm1hdHRlZFN0 YXRlKGZvcm1hdHRlZCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLl9mb3JtYXQoZm9ybWF0 dGVkKS5jYXRjaChoYW5kbGVQcm9taXNlRXhjZXB0aW9uKTsKKyAgICAgICAgcmV0dXJuIHRoaXMu X2Zvcm1hdChmb3JtYXR0ZWQpOwogICAgIH0KIAogICAgIGhhc0Zvcm1hdHRlcigpCg==