193920 2019-01-28 12:47:06 -0800 ToString node actually does GC. 2019-01-28 16:41:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1499144 0 mark.lam 2019-01-28 12:47:06 -0800 Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC(). <rdar://problem/46695900> 1499152 1 saam 2019-01-28 13:19:56 -0800 (In reply to Mark Lam from comment #0) > Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC(). > > <rdar://problem/46695900> What does clobberize say? 1499160 2 mark.lam 2019-01-28 13:30:30 -0800 (In reply to Saam Barati from comment #1) > (In reply to Mark Lam from comment #0) > > Currently, ToString is incorrectly modeled as not GC'ing in DFG doesGC(). > > > > <rdar://problem/46695900> > > What does clobberize say? Cloberrize says: def(PureValue(node)); ... which defers to doesGC(), which says false. So, it's wrong. 1499218 3 360383 mark.lam 2019-01-28 15:14:14 -0800 Created attachment 360383 proposed patch. 1499230 4 360383 ysuzuki 2019-01-28 15:26:55 -0800 Comment on attachment 360383 proposed patch. r=me 1499254 5 mark.lam 2019-01-28 16:14:43 -0800 Thanks for the review. Landing now. 1499272 6 360383 commit-queue 2019-01-28 16:41:50 -0800 Comment on attachment 360383 proposed patch. Clearing flags on attachment: 360383 Committed r240616: <https://trac.webkit.org/changeset/240616> 1499273 7 commit-queue 2019-01-28 16:41:52 -0800 All reviewed patches have been landed. Closing bug. 360383 2019-01-28 15:14:14 -0800 2019-01-28 16:41:50 -0800 proposed patch. bug-193920.patch text/plain 6361 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA2MDUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUb1N0cmluZyBub2RlIGFjdHVhbGx5IGRvZXMgR0MuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5MjAKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ2Njk1OTAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3RyZXNzL2RmZy10by1zdHJpbmctb24taW50LWRvZXMtZ2MuanM6 IEFkZGVkLgorICAgICAgICAqIHN0cmVzcy9kZmctdG8tc3RyaW5nLW9uLXN0cmluZy1vYmplY3Qt ZG9lcy1ub3QtZ2MuanM6IEFkZGVkLgorICAgICAgICAqIHN0cmVzcy9kZmctdG8tc3RyaW5nLW9u LXN0cmluZy1vci1zdHJpbmctb2JqZWN0LWRvZXMtbm90LWdjLmpzOiBBZGRlZC4KKwogMjAxOS0w MS0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0Nd IE5hdGl2ZUVycm9yQ29uc3RydWN0b3Igc2hvdWxkIG5vdCBoYXZlIG93biBJc29TdWJzcGFjZQpJ bmRleDogSlNUZXN0cy9zdHJlc3MvZGZnLXRvLXN0cmluZy1vbi1pbnQtZG9lcy1nYy5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kZmctdG8tc3RyaW5nLW9uLWludC1kb2VzLWdjLmpz CShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2RmZy10by1zdHJpbmctb24taW50LWRv ZXMtZ2MuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNiBAQAorLy9AIHJlcXVpcmVPcHRp b25zKCItLWV4Y2VwdGlvblN0YWNrVHJhY2VMaW1pdD0wIiwgIi0tZGVmYXVsdEVycm9yU3RhY2tU cmFjZUxpbWl0PTAiLCAiLS1mb3JjZVJBTVNpemU9MTAwMDAwMCIsICItLWZvcmNlRGVidWdnZXJC eXRlY29kZUdlbmVyYXRpb249MSIsICItLXVzZVpvbWJpZU1vZGU9MSIsICItLWppdFBvbGljeVNj YWxlPTAiLCAiLS1jb2xsZWN0Q29udGludW91c2x5PTEiLCAiLS11c2VDb25jdXJyZW50SklUPTAi KQorCitmdW5jdGlvbiBhc3NlcnQoYikgeworICAgIGlmICghYikKKyAgICAgICAgdGhyb3cgbmV3 IEVycm9yKCdhYScpOworfQorCit2YXIgZXhjZXB0aW9uOwordHJ5IHsKKyAgICBsZXQgdGFyZ2V0 ID0gZnVuY3Rpb24gKHgsIHkpIHsKKyAgICAgICAgY29uc3QgYWN0dWFsID0gJycgKyB4OworICAg ICAgICB0YXJnZXQoeCk7CisgICAgfTsKKyAgICBsZXQgaGFuZGxlciA9IHsKKyAgICAgICAgYXBw bHk6IGZ1bmN0aW9uICh0aGVUYXJnZXQsIHRoaXNBcmcsIGFyZ0FycmF5KSB7CisgICAgICAgICAg ICByZXR1cm4gdGhlVGFyZ2V0LmFwcGx5KFtdLCBhcmdBcnJheSk7CisgICAgICAgIH0KKyAgICB9 OworICAgIGxldCBwcm94eSA9IG5ldyBQcm94eSh0YXJnZXQsIGhhbmRsZXIpOworICAgIGFzc2Vy dChwcm94eSgxMCwgMjApID09PSAnZm9vJyk7Cit9IGNhdGNoKGUpIHsKKyAgICBleGNlcHRpb24g PSBlOworfQorCitpZiAoZXhjZXB0aW9uICE9ICJSYW5nZUVycm9yOiBNYXhpbXVtIGNhbGwgc3Rh Y2sgc2l6ZSBleGNlZWRlZC4iKQorICAgIHRocm93ICJGQUlMRUQiOwpJbmRleDogSlNUZXN0cy9z dHJlc3MvZGZnLXRvLXN0cmluZy1vbi1zdHJpbmctb2JqZWN0LWRvZXMtbm90LWdjLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2RmZy10by1zdHJpbmctb24tc3RyaW5nLW9iamVjdC1k b2VzLW5vdC1nYy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9kZmctdG8tc3Ry aW5nLW9uLXN0cmluZy1vYmplY3QtZG9lcy1ub3QtZ2MuanMJKHdvcmtpbmcgY29weSkKQEAgLTAs MCArMSwyNiBAQAorLy9AIHJlcXVpcmVPcHRpb25zKCItLWV4Y2VwdGlvblN0YWNrVHJhY2VMaW1p dD0wIiwgIi0tZGVmYXVsdEVycm9yU3RhY2tUcmFjZUxpbWl0PTAiLCAiLS1mb3JjZVJBTVNpemU9 MTAwMDAwMCIsICItLWZvcmNlRGVidWdnZXJCeXRlY29kZUdlbmVyYXRpb249MSIsICItLXVzZVpv bWJpZU1vZGU9MSIsICItLWppdFBvbGljeVNjYWxlPTAiLCAiLS1jb2xsZWN0Q29udGludW91c2x5 PTEiLCAiLS11c2VDb25jdXJyZW50SklUPTAiKQorCitmdW5jdGlvbiBhc3NlcnQoYikgeworICAg IGlmICghYikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdhYScpOworfQorCit2YXIgZXhjZXB0 aW9uOwordHJ5IHsKKyAgICBsZXQgdGFyZ2V0ID0gZnVuY3Rpb24gKHgsIHkpIHsKKyAgICAgICAg Y29uc3QgYWN0dWFsID0gJycgKyB4OworICAgICAgICB0YXJnZXQoeCk7CisgICAgfTsKKyAgICBs ZXQgaGFuZGxlciA9IHsKKyAgICAgICAgYXBwbHk6IGZ1bmN0aW9uICh0aGVUYXJnZXQsIHRoaXNB cmcsIGFyZ0FycmF5KSB7CisgICAgICAgICAgICByZXR1cm4gdGhlVGFyZ2V0LmFwcGx5KFtdLCBh cmdBcnJheSk7CisgICAgICAgIH0KKyAgICB9OworICAgIGxldCBwcm94eSA9IG5ldyBQcm94eSh0 YXJnZXQsIGhhbmRsZXIpOworICAgIGFzc2VydChwcm94eShuZXcgU3RyaW5nKCIxMCIpLCBuZXcg U3RyaW5nKCIyMCIpKSA9PT0gJ2ZvbycpOworfSBjYXRjaChlKSB7CisgICAgZXhjZXB0aW9uID0g ZTsKK30KKworaWYgKGV4Y2VwdGlvbiAhPSAiUmFuZ2VFcnJvcjogTWF4aW11bSBjYWxsIHN0YWNr IHNpemUgZXhjZWVkZWQuIikKKyAgICB0aHJvdyAiRkFJTEVEIjsKSW5kZXg6IEpTVGVzdHMvc3Ry ZXNzL2RmZy10by1zdHJpbmctb24tc3RyaW5nLW9yLXN0cmluZy1vYmplY3QtZG9lcy1ub3QtZ2Mu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvZGZnLXRvLXN0cmluZy1vbi1zdHJpbmct b3Itc3RyaW5nLW9iamVjdC1kb2VzLW5vdC1nYy5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L3N0cmVzcy9kZmctdG8tc3RyaW5nLW9uLXN0cmluZy1vci1zdHJpbmctb2JqZWN0LWRvZXMtbm90 LWdjLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzQgQEAKKy8vQCByZXF1aXJlT3B0aW9u cygiLS1leGNlcHRpb25TdGFja1RyYWNlTGltaXQ9MCIsICItLWRlZmF1bHRFcnJvclN0YWNrVHJh Y2VMaW1pdD0wIiwgIi0tZm9yY2VSQU1TaXplPTEwMDAwMDAiLCAiLS1mb3JjZURlYnVnZ2VyQnl0 ZWNvZGVHZW5lcmF0aW9uPTEiLCAiLS11c2Vab21iaWVNb2RlPTEiLCAiLS1qaXRQb2xpY3lTY2Fs ZT0wIiwgIi0tY29sbGVjdENvbnRpbnVvdXNseT0xIiwgIi0tdXNlQ29uY3VycmVudEpJVD0wIikK KworZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIpCisgICAgICAgIHRocm93IG5ldyBF cnJvcignYWEnKTsKK30KKworbGV0IGFsdGVybmF0ZSA9IHRydWU7Cit2YXIgZXhjZXB0aW9uOwor dHJ5IHsKKyAgICBmdW5jdGlvbiBhbHRlcih4KSB7CisgICAgICAgIGFsdGVybmF0ZSA9ICFhbHRl cm5hdGU7CisgICAgICAgIGlmIChhbHRlcm5hdGUpCisgICAgICAgICAgICByZXR1cm4gbmV3IFN0 cmluZyh4KTsKKyAgICAgICAgcmV0dXJuIHg7CisgICAgfQorICAgIG5vSW5saW5lKGFsdGVyKTsK KyAgICBsZXQgdGFyZ2V0ID0gZnVuY3Rpb24gKHgsIHkpIHsKKyAgICAgICAgY29uc3QgYWN0dWFs ID0gJycgKyBhbHRlcih4KTsKKyAgICAgICAgdGFyZ2V0KHgpOworICAgIH07CisgICAgbGV0IGhh bmRsZXIgPSB7CisgICAgICAgIGFwcGx5OiBmdW5jdGlvbiAodGhlVGFyZ2V0LCB0aGlzQXJnLCBh cmdBcnJheSkgeworICAgICAgICAgICAgcmV0dXJuIHRoZVRhcmdldC5hcHBseShbXSwgYXJnQXJy YXkpOworICAgICAgICB9CisgICAgfTsKKyAgICBsZXQgcHJveHkgPSBuZXcgUHJveHkodGFyZ2V0 LCBoYW5kbGVyKTsKKyAgICBhc3NlcnQocHJveHkoIjEwIiwgIjIwIikgPT09ICdmb28nKTsKK30g Y2F0Y2goZSkgeworICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK2lmIChleGNlcHRpb24gIT0gIlJh bmdlRXJyb3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXplIGV4Y2VlZGVkLiIpCisgICAgdGhyb3cg IkZBSUxFRCI7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MDYwNCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMS0yOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisK KyAgICAgICAgVG9TdHJpbmcgbm9kZSBhY3R1YWxseSBkb2VzIEdDLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTIwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NjY5NTkwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBPdGhlciB0aGFuIGZvciBTdHJpbmdPYmplY3RVc2UgYW5kIFN0cmluZ09yU3Ry aW5nT2JqZWN0VXNlLCBUb1N0cmluZyBhbmQKKyAgICAgICAgQ2FsbFN0cmluZ0NvbnN0cnVjdG9y IGNhbiBhbGxvY2F0ZSBuZXcgSlNTdHJpbmdzLCBhbmQgaGVuY2UsIGNhbiBHQy4KKworICAgICAg ICAqIGRmZy9ERkdEb2VzR0MuY3BwOgorICAgICAgICAoSlNDOjpERkc6OmRvZXNHQyk6CisKIDIw MTktMDEtMjggIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBb SlNDXSBSZWdFeHBDb25zdHJ1Y3RvciBzaG91bGQgbm90IGhhdmUgb3duIElzb1N1YnNwYWNlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCShyZXZpc2lvbiAyNDA2 MDQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0RvZXNHQy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMTcgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMTkg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC0xOTEsOCArMTkxLDYgQEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2Rl KiBub2RlKQogICAgIGNhc2UgTG9naWNhbE5vdDoKICAgICBjYXNlIFRvUHJpbWl0aXZlOgogICAg IGNhc2UgVG9OdW1iZXI6Ci0gICAgY2FzZSBUb1N0cmluZzoKLSAgICBjYXNlIENhbGxTdHJpbmdD b25zdHJ1Y3RvcjoKICAgICBjYXNlIE51bWJlclRvU3RyaW5nV2l0aFJhZGl4OgogICAgIGNhc2Ug TnVtYmVyVG9TdHJpbmdXaXRoVmFsaWRSYWRpeENvbnN0YW50OgogICAgIGNhc2UgSW5CeVZhbDoK QEAgLTM4NCw2ICszODIsMTcgQEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2Rl KQogICAgIGNhc2UgVmFsdWVEaXY6CiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgY2FzZSBD YWxsU3RyaW5nQ29uc3RydWN0b3I6CisgICAgY2FzZSBUb1N0cmluZzoKKyAgICAgICAgc3dpdGNo IChub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkpIHsKKyAgICAgICAgY2FzZSBTdHJpbmdPYmplY3RV c2U6CisgICAgICAgIGNhc2UgU3RyaW5nT3JTdHJpbmdPYmplY3RVc2U6CisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgfQorICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAgIGNhc2UgR2V0SW5kZXhlZFByb3BlcnR5 U3RvcmFnZToKICAgICAgICAgaWYgKG5vZGUtPmFycmF5TW9kZSgpLnR5cGUoKSA9PSBBcnJheTo6 U3RyaW5nKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7Cg==