193918 2019-01-28 12:15:44 -0800 REGRESSION(r240351): Causes overlapping Timeline records, as some record types don't have an endTime (Requested by drousso on #webkit). 2019-01-28 12:22:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 192884 1 commit-queue commit-queue hi joepeck webkit-bug-importer oldest_to_newest 1499136 0 commit-queue 2019-01-28 12:15:44 -0800 https://trac.webkit.org/changeset/240351 broke the build: Causes overlapping Timeline records, as some record types don't have an endTime (Requested by drousso on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1499138 1 360362 commit-queue 2019-01-28 12:15:48 -0800 Created attachment 360362 ROLLOUT of r240351 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1499140 2 360362 commit-queue 2019-01-28 12:21:44 -0800 Comment on attachment 360362 ROLLOUT of r240351 Clearing flags on attachment: 360362 Committed r240598: <https://trac.webkit.org/changeset/240598> 1499141 3 commit-queue 2019-01-28 12:21:45 -0800 All reviewed patches have been landed. Closing bug. 1499142 4 webkit-bug-importer 2019-01-28 12:22:27 -0800 <rdar://problem/47606244> 360362 2019-01-28 12:15:48 -0800 2019-01-28 12:21:44 -0800 ROLLOUT of r240351 bug-193918-20190128121548.patch text/plain 4359 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj ZjE2MWVhOWU5ZmY5NzVlMDQ5MTczNmQ1OTIyODc5ZDdlNzBiZGYwLi4zY2IyOGQ0YTk3ZDE1ZmRl YjEwNjM3YWI1NzdlOGI0NThiNjQ1YWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wMS0yOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0MDM1MS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzkxOAorCisgICAg ICAgIENhdXNlcyBvdmVybGFwcGluZyBUaW1lbGluZSByZWNvcmRzLCBhcyBzb21lIHJlY29yZCB0 eXBlcworICAgICAgICBkb24ndCBoYXZlIGFuIGVuZFRpbWUgKFJlcXVlc3RlZCBieSBkcm91c3Nv IG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAi V2ViSW5zcGVjdG9yOiBDb25mdXNpbmdseSBuZXN0ZWQgZXZlbnRzIGluIHRoZSB0aW1lbGluZSBm b3IKKyAgICAgICAgTXV0YXRpb24gT2JzZXJ2ZXJzIgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyODg0CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJr aXQub3JnL2NoYW5nZXNldC8yNDAzNTEKKwogMjAxOS0wMS0yOCAgTWF0dCBCYWtlciAgPG1hdHRi YWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTig/KTogV2ViIEluc3BlY3Rvcjog Q2FuIGhhdmUgbXVsdGlwbGUgVGltZWxpbmVzIHNlbGVjdGVkIGFmdGVyIGVkaXQgbW9kZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv VGltZWxpbmVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IDI1OTIwNWVlMzk0YzBhMTIyZjMx NmE5ODMwYTVhODYzZTU3ZGRlNzYuLjIwYjc4NTRkNWZhMmNjYzVkYjVlMjhiYzhjMTQ1NmM5MjU1 ODQ0MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAgLTM1OSwyOCAr MzU5LDYgQEAgV0kuVGltZWxpbmVNYW5hZ2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVu ZHMgV0kuT2JqZWN0CiAgICAgICAgIGlmICghdGhpcy5faXNDYXB0dXJpbmcpCiAgICAgICAgICAg ICByZXR1cm47CiAKLSAgICAgICAgZnVuY3Rpb24gZml4TWljcm90YXNrUGxhY2VtZW50KGNoaWxk cmVuKQotICAgICAgICB7Ci0gICAgICAgICAgICBsZXQgbmV3Q2hpbGRyZW4gPSBbXTsKLSAgICAg ICAgICAgIGZvciAobGV0IGNoaWxkIG9mIGNoaWxkcmVuKSB7Ci0gICAgICAgICAgICAgICAgaWYg KGNoaWxkLnR5cGUgPT09IFRpbWVsaW5lQWdlbnQuRXZlbnRUeXBlLkV2YWx1YXRlU2NyaXB0KSB7 Ci0gICAgICAgICAgICAgICAgICAgIGxldCBbbWljcm90YXNrcywgZXZlbnRzXSA9IGNoaWxkLmNo aWxkcmVuLnBhcnRpdGlvbigoZ3JhbmRjaGlsZCkgPT4gewotICAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIGdyYW5kY2hpbGQudHlwZSA9PT0gVGltZWxpbmVBZ2VudC5FdmVudFR5cGUuT2Jz ZXJ2ZXJDYWxsYmFjazsKLSAgICAgICAgICAgICAgICAgICAgfSk7Ci0KLSAgICAgICAgICAgICAg ICAgICAgaWYgKGV2ZW50cy5sZW5ndGgpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIGNoaWxk LmNoaWxkcmVuID0gZXZlbnRzOwotICAgICAgICAgICAgICAgICAgICAgICAgY2hpbGQuZW5kVGlt ZSA9IGV2ZW50cy5sYXN0VmFsdWUuZW5kVGltZTsKLSAgICAgICAgICAgICAgICAgICAgICAgIG5l d0NoaWxkcmVuLnB1c2goY2hpbGQpOwotICAgICAgICAgICAgICAgICAgICB9Ci0KLSAgICAgICAg ICAgICAgICAgICAgbmV3Q2hpbGRyZW4gPSBuZXdDaGlsZHJlbi5jb25jYXQobWljcm90YXNrcyk7 Ci0gICAgICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgICAgIG5ld0NoaWxkcmVu LnB1c2goY2hpbGQpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgcmV0dXJuIG5ld0NoaWxk cmVuOwotICAgICAgICB9Ci0KICAgICAgICAgdmFyIHJlY29yZHMgPSBbXTsKIAogICAgICAgICAv LyBJdGVyYXRlIG92ZXIgdGhlIHJlY29yZHMgdHJlZSB1c2luZyBhIHN0YWNrLiBEb2luZyB0aGlz IHJlY3Vyc2l2ZWx5IGhhcwpAQCAtNDAxLDcgKzM3OSw3IEBAIFdJLlRpbWVsaW5lTWFuYWdlciA9 IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICAgICAgICAg IH0KIAogICAgICAgICAgICAgICAgIGlmIChyZWNvcmRQYXlsb2FkLmNoaWxkcmVuICYmIHJlY29y ZFBheWxvYWQuY2hpbGRyZW4ubGVuZ3RoKQotICAgICAgICAgICAgICAgICAgICBzdGFjay5wdXNo KHthcnJheTogZml4TWljcm90YXNrUGxhY2VtZW50KHJlY29yZFBheWxvYWQuY2hpbGRyZW4pLCBw YXJlbnQ6IHJlY29yZFBheWxvYWQsIHBhcmVudFJlY29yZDogcmVjb3JkIHx8IGVudHJ5LnBhcmVu dFJlY29yZCwgaW5kZXg6IDB9KTsKKyAgICAgICAgICAgICAgICAgICAgc3RhY2sucHVzaCh7YXJy YXk6IHJlY29yZFBheWxvYWQuY2hpbGRyZW4sIHBhcmVudDogcmVjb3JkUGF5bG9hZCwgcGFyZW50 UmVjb3JkOiByZWNvcmQgfHwgZW50cnkucGFyZW50UmVjb3JkLCBpbmRleDogMH0pOwogICAgICAg ICAgICAgICAgICsrZW50cnkuaW5kZXg7CiAgICAgICAgICAgICB9IGVsc2UKICAgICAgICAgICAg ICAgICBzdGFjay5wb3AoKTsKQEAgLTExMDIsMjMgKzEwODAsMTUgQEAgV0kuVGltZWxpbmVNYW5h Z2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAg ICAgICAgd2ViUmVjb3JkLnByb2ZpbGVQYXlsb2FkID0gcHJvZmlsZXJSZWNvcmQucHJvZmlsZVBh eWxvYWQ7CiAgICAgICAgICAgICAgICAgcHJvZmlsZXJSZWNvcmQgPSBuZXh0U2NyaXB0UHJvZmls ZXJSZWNvcmQoKTsKIAotICAgICAgICAgICAgICAgIGxldCBmaXJzdFByb2ZpbGVyUmVjb3JkRm9y V2ViUmVjb3JkID0gbnVsbDsKLQogICAgICAgICAgICAgICAgIC8vIElmIHRoZXJlIGFyZSBtb3Jl IHNjcmlwdCBwcm9maWxlIHJlY29yZHMgaW4gdGhlIHNhbWUgdGltZSBpbnRlcnZhbCwgYWRkIHRo ZW0KICAgICAgICAgICAgICAgICAvLyBhcyBpbmRpdmlkdWFsIHNjcmlwdCBldmFsdWF0ZWQgcmVj b3JkcyB3aXRoIHByb2ZpbGVzLiBUaGlzIGNhbiBoYXBwZW4gd2l0aAogICAgICAgICAgICAgICAg IC8vIHdlYiBtaWNyb3Rhc2sgY2hlY2twb2ludHMgdGhhdCBhcmUgdGVjaG5pY2FsbHkgaW5zaWRl IG9mIG90aGVyIHdlYiByZWNvcmRzLgogICAgICAgICAgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMTUyOTAzPiBXZWIgSW5zcGVjdG9yOiBUaW1lbGluZSBDbGVhbnVwOiBC ZXR0ZXIgVGltZWxpbmUgUmVjb3JkIGZvciBNaWNyb3Rhc2sgQ2hlY2twb2ludHMKICAgICAgICAg ICAgICAgICB3aGlsZSAocHJvZmlsZXJSZWNvcmQgJiYgcmVjb3JkRW5jbG9zZXNSZWNvcmQod2Vi UmVjb3JkLCBwcm9maWxlclJlY29yZCkpIHsKLSAgICAgICAgICAgICAgICAgICAgaWYgKCFmaXJz dFByb2ZpbGVyUmVjb3JkRm9yV2ViUmVjb3JkKQotICAgICAgICAgICAgICAgICAgICAgICAgZmly c3RQcm9maWxlclJlY29yZEZvcldlYlJlY29yZCA9IHByb2ZpbGVyUmVjb3JkOwotCiAgICAgICAg ICAgICAgICAgICAgIHRoaXMuX2FkZFJlY29yZChwcm9maWxlclJlY29yZCk7CiAgICAgICAgICAg ICAgICAgICAgIHByb2ZpbGVyUmVjb3JkID0gbmV4dFNjcmlwdFByb2ZpbGVyUmVjb3JkKCk7CiAg ICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgaWYgKGZpcnN0UHJvZmlsZXJSZWNv cmRGb3JXZWJSZWNvcmQpCi0gICAgICAgICAgICAgICAgICAgIHdlYlJlY29yZC5lbmRUaW1lID0g Zmlyc3RQcm9maWxlclJlY29yZEZvcldlYlJlY29yZC5zdGFydFRpbWU7Ci0KICAgICAgICAgICAg ICAgICB3ZWJSZWNvcmQgPSBuZXh0V2ViVGltZWxpbmVSZWNvcmQoKTsKICAgICAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgICAgIH0K