193913 2019-01-28 10:15:06 -0800 [macOS] Crash when control-clicking or copying text rendered with a web font 2019-01-31 13:41:06 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Mac macOS 10.13 RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue dbates ddkilzer mitz rniwa webkit-bug-importer oldest_to_newest 1499064 0 pvollan 2019-01-28 10:15:06 -0800 This was caused by <https://trac.webkit.org/r239963>. 1499065 1 pvollan 2019-01-28 10:15:27 -0800 rdar://problem/47541039 1499068 2 360349 pvollan 2019-01-28 10:18:47 -0800 Created attachment 360349 Patch 1499069 3 360349 mitz 2019-01-28 10:21:15 -0800 Comment on attachment 360349 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360349&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300 Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should always use either >= or <, never <= or >. 1499074 4 360354 pvollan 2019-01-28 10:28:50 -0800 Created attachment 360354 Patch 1499076 5 pvollan 2019-01-28 10:29:29 -0800 (In reply to mitz from comment #3) > Comment on attachment 360349 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360349&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:575 > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101300 > > Comparisons against VERSION_MIN_REQUIRED and VERSION_MAX_ALLOWED should > always use either >= or <, never <= or >. Thanks for reviewing! I have updated the patch. 1500697 6 pvollan 2019-01-31 12:04:37 -0800 I have confirmed locally that this patch fixes the crash. 1500728 7 360354 bfulgham 2019-01-31 13:15:38 -0800 Comment on attachment 360354 Patch r=me 1500734 8 360354 pvollan 2019-01-31 13:24:36 -0800 Comment on attachment 360354 Patch Thanks for reviewing! 1500752 9 360354 commit-queue 2019-01-31 13:41:04 -0800 Comment on attachment 360354 Patch Clearing flags on attachment: 360354 Committed r240810: <https://trac.webkit.org/changeset/240810> 1500753 10 commit-queue 2019-01-31 13:41:06 -0800 All reviewed patches have been landed. Closing bug. 360349 2019-01-28 10:18:47 -0800 2019-01-28 10:28:47 -0800 Patch bug-193913-20190128101846.patch text/plain 1427 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDA1ODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHdoZW4g Y29udHJvbC1jbGlja2luZyBvciBjb3B5aW5nIHRleHQgcmVuZGVyZWQgd2l0aCBhIHdlYiBmb250 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5MTMK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3NTQxMDM5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIG9sZGVyIHZlcnNpb25zIG9mIG1hY09TLCBh bGxvd2luZyBtYWNoIGxvb2t1cCB0byBjb20uYXBwbGUuRm9udE9iamVjdHNTZXJ2ZXIgaXMgbmVl ZGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoK KwogMjAxOS0wMS0yOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg ICAgIExpbWl0IHVzZXItYWdlbnQgaW50ZXJhY3Rpb25zIGJhc2VkIG9uIHRoZSB0b3VjaC1hY3Rp b24gcHJvcGVydHkgb24gaU9TCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyNDA1ODgpCisrKyBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTU3Miw2ICs1NzIsOSBAQAogCiA7OyBWYXJpb3VzIHNlcnZpY2VzIHJlcXVpcmVk IGJ5IEFwcEtpdCBhbmQgb3RoZXIgZnJhbWV3b3JrcwogKGFsbG93IG1hY2gtbG9va3VwCisjaWYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8PSAxMDEzMDAKKyAgICAgICAoZ2xvYmFs LW5hbWUgImNvbS5hcHBsZS5Gb250T2JqZWN0c1NlcnZlciIpCisjZW5kaWYKICAgICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5Qb3dlck1hbmFnZW1lbnQuY29udHJvbCIpCiAgICAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuU3lzdGVtQ29uZmlndXJhdGlvbi5jb25maWdkIikKICNpZiAh UExBVEZPUk0oTUFDKSB8fCBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMw MAo= 360354 2019-01-28 10:28:50 -0800 2019-01-31 13:41:04 -0800 Patch bug-193913-20190128102849.patch text/plain 1426 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDA1ODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI4ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHdoZW4g Y29udHJvbC1jbGlja2luZyBvciBjb3B5aW5nIHRleHQgcmVuZGVyZWQgd2l0aCBhIHdlYiBmb250 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5MTMK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3NTQxMDM5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIG9sZGVyIHZlcnNpb25zIG9mIG1hY09TLCBh bGxvd2luZyBtYWNoIGxvb2t1cCB0byBjb20uYXBwbGUuRm9udE9iamVjdHNTZXJ2ZXIgaXMgbmVl ZGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoK KwogMjAxOS0wMS0yOCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg ICAgIExpbWl0IHVzZXItYWdlbnQgaW50ZXJhY3Rpb25zIGJhc2VkIG9uIHRoZSB0b3VjaC1hY3Rp b24gcHJvcGVydHkgb24gaU9TCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyNDA1ODgpCisrKyBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTU3Miw2ICs1NzIsOSBAQAogCiA7OyBWYXJpb3VzIHNlcnZpY2VzIHJlcXVpcmVk IGJ5IEFwcEtpdCBhbmQgb3RoZXIgZnJhbWV3b3JrcwogKGFsbG93IG1hY2gtbG9va3VwCisjaWYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTQwMAorICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLkZvbnRPYmplY3RzU2VydmVyIikKKyNlbmRpZgogICAgICAgIChnbG9i YWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFuYWdlbWVudC5jb250cm9sIikKICAgICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5TeXN0ZW1Db25maWd1cmF0aW9uLmNvbmZpZ2QiKQogI2lmICFQ TEFURk9STShNQUMpIHx8IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAw Cg==