193892 2019-01-27 20:04:47 -0800 [ews-app] Allow certain fields to be empty 2019-01-28 11:55:28 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1498927 0 aakash_jain 2019-01-27 20:04:47 -0800 Certain fields in builds/steps table should be alllowed to be empty/null. For e.g.: build/step start event would not have completed_at or results information. So, on receiving build/step start event we need to save the information in database, while keeping these fields empty/null. These fields would be updated on build/step finish event. 1498928 1 360314 aakash_jain 2019-01-27 20:11:42 -0800 Created attachment 360314 Proposed patch 1499125 2 360314 commit-queue 2019-01-28 11:54:53 -0800 Comment on attachment 360314 Proposed patch Clearing flags on attachment: 360314 Committed r240595: <https://trac.webkit.org/changeset/240595> 1499126 3 commit-queue 2019-01-28 11:54:55 -0800 All reviewed patches have been landed. Closing bug. 1499127 4 webkit-bug-importer 2019-01-28 11:55:28 -0800 <rdar://problem/47605305> 360314 2019-01-27 20:11:42 -0800 2019-01-28 11:54:53 -0800 Proposed patch ews-app-empty-fields.patch text/plain 2427 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDU1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAxLTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gQWxsb3cgY2VydGFpbiBmaWVsZHMgdG8gYmUgZW1wdHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mzg5Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5OgorICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5OgorCiAyMDE4LTEyLTE1ICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBsYWNlIG1hbnkgdXNl cyBvZiBTdHJpbmc6OmZvcm1hdCB3aXRoIG1vcmUgdHlwZS1zYWZlIGFsdGVybmF0aXZlcwpJbmRl eDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9i dWlsZC5weQkocmV2aXNpb24gMjQwNTU4KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMSwxMCArMzEsMTAg QEAgY2xhc3MgQnVpbGQobW9kZWxzLk1vZGVsKToKICAgICBidWlsZGlkID0gbW9kZWxzLkludGVn ZXJGaWVsZChwcmltYXJ5X2tleT1UcnVlKQogICAgIGJ1aWxkZXJpZCA9IG1vZGVscy5JbnRlZ2Vy RmllbGQoKQogICAgIG51bWJlciA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQotICAgIHJlc3VsdCA9 IG1vZGVscy5JbnRlZ2VyRmllbGQoKQorICAgIHJlc3VsdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQo bnVsbD1UcnVlLCBibGFuaz1UcnVlKQogICAgIHN0YXRlX3N0cmluZyA9IG1vZGVscy5UZXh0Rmll bGQoKQotICAgIHN0YXJ0ZWRfYXQgPSBtb2RlbHMuSW50ZWdlckZpZWxkKCkKLSAgICBjb21wbGV0 ZV9hdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQorICAgIHN0YXJ0ZWRfYXQgPSBtb2RlbHMuSW50 ZWdlckZpZWxkKG51bGw9VHJ1ZSwgYmxhbms9VHJ1ZSkKKyAgICBjb21wbGV0ZV9hdCA9IG1vZGVs cy5JbnRlZ2VyRmllbGQobnVsbD1UcnVlLCBibGFuaz1UcnVlKQogICAgIGNyZWF0ZWQgPSBtb2Rl bHMuRGF0ZVRpbWVGaWVsZChhdXRvX25vd19hZGQ9VHJ1ZSkKICAgICBtb2RpZmllZCA9IG1vZGVs cy5EYXRlVGltZUZpZWxkKGF1dG9fbm93PVRydWUpCiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5CShyZXZpc2lvbiAyNDA1 NTgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcC5w eQkod29ya2luZyBjb3B5KQpAQCAtMjksMTAgKzI5LDEwIEBAIGZyb20gZXdzLm1vZGVscy5idWls ZCBpbXBvcnQgQnVpbGQKIGNsYXNzIFN0ZXAobW9kZWxzLk1vZGVsKToKICAgICBzdGVwaWQgPSBt b2RlbHMuSW50ZWdlckZpZWxkKHByaW1hcnlfa2V5PVRydWUpCiAgICAgYnVpbGQgPSBtb2RlbHMu Rm9yZWlnbktleShCdWlsZCwgb25fZGVsZXRlPW1vZGVscy5DQVNDQURFKQotICAgIHJlc3VsdCA9 IG1vZGVscy5JbnRlZ2VyRmllbGQoKQorICAgIHJlc3VsdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQo bnVsbD1UcnVlLCBibGFuaz1UcnVlKQogICAgIHN0YXRlX3N0cmluZyA9IG1vZGVscy5UZXh0Rmll bGQoKQotICAgIHN0YXJ0ZWRfYXQgPSBtb2RlbHMuSW50ZWdlckZpZWxkKCkKLSAgICBjb21wbGV0 ZV9hdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQorICAgIHN0YXJ0ZWRfYXQgPSBtb2RlbHMuSW50 ZWdlckZpZWxkKG51bGw9VHJ1ZSwgYmxhbms9VHJ1ZSkKKyAgICBjb21wbGV0ZV9hdCA9IG1vZGVs cy5JbnRlZ2VyRmllbGQobnVsbD1UcnVlLCBibGFuaz1UcnVlKQogICAgIGNyZWF0ZWQgPSBtb2Rl bHMuRGF0ZVRpbWVGaWVsZChhdXRvX25vd19hZGQ9VHJ1ZSkKICAgICBtb2RpZmllZCA9IG1vZGVs cy5EYXRlVGltZUZpZWxkKGF1dG9fbm93PVRydWUpCiAK