193887 2019-01-27 12:35:56 -0800 [ews-build] Add build step to print bot Configuration 2019-01-29 13:57:44 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1498892 0 aakash_jain 2019-01-27 12:35:56 -0800 We should add a build step in ews-build to print bot configuration (e.g.: Xcode version). This would help in debugging failures. 1498895 1 360306 aakash_jain 2019-01-27 12:41:55 -0800 Created attachment 360306 Proposed patch Sample run: https://ews-build.webkit-uat.org/#/builders/5/builds/1917 1498897 2 ews-watchlist 2019-01-27 12:44:29 -0800 Attachment 360306 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:23: No name 'plugins' in module 'buildbot' [pylint/E0611] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:760: [PrintConfiguration.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1499113 3 360306 lforschler 2019-01-28 11:34:06 -0800 Comment on attachment 360306 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=360306&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:759 > + These commands will not work for any Windows EWS bots. We should probably do a platform check, or at least put in a #FIXME to indicate any non Mac/unix work needed. (since halt/flunk/warn on failure is False, this won't break anything on those platforms...but it would be nice to do the right thing pending OS. 1499211 4 aakash_jain 2019-01-28 15:09:36 -0800 Committed r240605: <https://trac.webkit.org/changeset/240605> 1499212 5 webkit-bug-importer 2019-01-28 15:10:28 -0800 <rdar://problem/47612832> 1499704 6 aakash_jain 2019-01-29 13:57:26 -0800 > put in a #FIXME to indicate any non Mac/unix work needed. Done. 1499705 7 aakash_jain 2019-01-29 13:57:44 -0800 Committed r240680: <https://trac.webkit.org/changeset/240680> 360306 2019-01-27 12:41:55 -0800 2019-01-28 11:34:06 -0800 Proposed patch ews-build-print-configuration.patch text/plain 3328 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDU1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcCB0byBwcmludCBib3QgQ29u ZmlndXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzODg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChQcmlu dENvbmZpZ3VyYXRpb24pOiBCdWlsZCBzdGVwIHRvIHByaW50IGNvbmZpZ3VyYXRpb24uCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weToKKwogMjAxOS0w MS0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFY OiBJbnRyb2R1Y2UgYSBzdGF0aWMgYWNjZXNzaWJpbGl0eSB0cmVlCkluZGV4OiBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDI0MDU1 NCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHdv cmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0jIENvcHlyaWdodCAoQykgMjAxOCBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxOC0yMDE5IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlv biwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpA QCAtMzYsNiArMzYsNyBAQCBjbGFzcyBGYWN0b3J5KGZhY3RvcnkuQnVpbGRGYWN0b3J5KToKICAg ICAgICAgaWYgY2hlY2tSZWxldmFuY2U6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tQ YXRjaFJlbGV2YW5jZSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoVmFsaWRhdGVQYXRjaCgpKQor ICAgICAgICBzZWxmLmFkZFN0ZXAoUHJpbnRDb25maWd1cmF0aW9uKCkpCiAgICAgICAgIHNlbGYu YWRkU3RlcChDaGVja091dFNvdXJjZSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoQXBwbHlQYXRj aCgpKQogCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5 CShyZXZpc2lvbiAyNDA1NTQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0jIENvcHlyaWdodCAoQykg MjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAx OC0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAj IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucwpAQCAtMjAsNiArMjAsNyBAQAogIyBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgogCitmcm9tIGJ1aWxkYm90LnBsdWdpbnMgaW1wb3J0IHN0ZXBzLCB1dGlsCiBm cm9tIGJ1aWxkYm90LnByb2Nlc3MgaW1wb3J0IGJ1aWxkc3RlcCwgbG9nb2JzZXJ2ZXIsIHByb3Bl cnRpZXMKIGZyb20gYnVpbGRib3QucHJvY2Vzcy5yZXN1bHRzIGltcG9ydCBSZXN1bHRzLCBTVUND RVNTLCBGQUlMVVJFLCBXQVJOSU5HUywgU0tJUFBFRCwgRVhDRVBUSU9OLCBSRVRSWQogZnJvbSBi dWlsZGJvdC5zdGVwcyBpbXBvcnQgbWFzdGVyLCBzaGVsbCwgdHJhbnNmZXIKQEAgLTc0MSwzICs3 NDIsMjMgQEAgY2xhc3MgRXh0cmFjdFRlc3RSZXN1bHRzKG1hc3Rlci5NYXN0ZXJTaAogICAgIGRl ZiBmaW5pc2hlZChzZWxmLCByZXN1bHQpOgogICAgICAgICBzZWxmLmFkZEN1c3RvbVVSTHMoKQog ICAgICAgICByZXR1cm4gbWFzdGVyLk1hc3RlclNoZWxsQ29tbWFuZC5maW5pc2hlZChzZWxmLCBy ZXN1bHQpCisKKworY2xhc3MgUHJpbnRDb25maWd1cmF0aW9uKHN0ZXBzLlNoZWxsU2VxdWVuY2Up OgorICAgIG5hbWUgPSAnY29uZmlndXJhdGlvbicKKyAgICBkZXNjcmlwdGlvbiA9IFsnY29uZmln dXJhdGlvbiddCisgICAgZGVzY3JpcHRpb25Eb25lID0gWydjb25maWd1cmF0aW9uJ10KKyAgICBo YWx0T25GYWlsdXJlID0gRmFsc2UKKyAgICBmbHVua09uRmFpbHVyZSA9IEZhbHNlCisgICAgd2Fy bk9uRmFpbHVyZSA9IEZhbHNlCisgICAgY29tbWFuZF9saXN0ID0gW1snaG9zdG5hbWUnXSwKKyAg ICAgICAgICAgICAgICAgICAgWydkZicsICctaGwnXSwKKyAgICAgICAgICAgICAgICAgICAgWydk YXRlJ10sCisgICAgICAgICAgICAgICAgICAgIFsnc3dfdmVycyddLAorICAgICAgICAgICAgICAg ICAgICBbJ3hjb2RlYnVpbGQnLCAnLXNkaycsICctdmVyc2lvbiddXQorCisgICAgZGVmIF9faW5p dF9fKHNlbGYsICoqa3dhcmdzKToKKyAgICAgICAgc3VwZXIoUHJpbnRDb25maWd1cmF0aW9uLCBz ZWxmKS5fX2luaXRfXyh0aW1lb3V0PTYwLCAqKmt3YXJncykKKyAgICAgICAgc2VsZi5jb21tYW5k cyA9IFtdCisgICAgICAgIGZvciBjb21tYW5kIGluIHNlbGYuY29tbWFuZF9saXN0OgorICAgICAg ICAgICAgc2VsZi5jb21tYW5kcy5hcHBlbmQodXRpbC5TaGVsbEFyZyhjb21tYW5kPWNvbW1hbmQs IGxvZ2ZpbGU9Y29tbWFuZFswXSkpCg==