193814 2019-01-24 22:24:14 -0800 Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key prefix 2019-01-25 11:36:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1498143 0 hi 2019-01-24 22:24:14 -0800 All `WI.Setting` keys are prefixed with `com.apple.WebInspector`, followed by the inspection level, and finally the name of the setting. `WI.Setting.migrateValue` doesn't take that into account, meaning that it doesn't actually read the key it's supposed to be taking the value from. 1498145 1 360082 hi 2019-01-24 22:26:22 -0800 Created attachment 360082 Patch 1498334 2 360082 mattbaker 2019-01-25 11:09:41 -0800 Comment on attachment 360082 Patch r=me 1498350 3 360082 commit-queue 2019-01-25 11:35:35 -0800 Comment on attachment 360082 Patch Clearing flags on attachment: 360082 Committed r240487: <https://trac.webkit.org/changeset/240487> 1498351 4 commit-queue 2019-01-25 11:35:36 -0800 All reviewed patches have been landed. Closing bug. 1498352 5 webkit-bug-importer 2019-01-25 11:36:28 -0800 <rdar://problem/47556137> 360082 2019-01-24 22:26:22 -0800 2019-01-25 11:35:35 -0800 Patch bug-193814-20190124222621.patch text/plain 2654 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ0MDUzYTgwMDIyYTFkYWY0YzBmMzM1MTYxMWUw ZjhmZDk5Mzk0YjguLmY4MDIzYzJiOWQ1MWNlODFiOWMwOTk2MTcxOGY1ODI3YzZmMWMzODAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBg V0kuU2V0dGluZy5taWdyYXRlVmFsdWVgIGRvZXNuJ3QgdGFrZSBpbnRvIGFjY291bnQgdGhlIGtl eSBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MzgxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanM6CisgICAgICAgIChXSS5TZXR0aW5nKToK KyAgICAgICAgKFdJLlNldHRpbmcubWlncmF0ZVZhbHVlKToKKyAgICAgICAgKFdJLlNldHRpbmcu X2xvY2FsU3RvcmFnZUtleSk6IEFkZGVkLgorCiAyMDE5LTAxLTIzICBOaWtpdGEgVmFzaWx5ZXYg IDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZmFjdG9y IFdJLkNTU1N0eWxlRGVjbGFyYXRpb24ucHJvdG90eXBlLnVwZGF0ZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4IGM5ZDUx NDBmMTkxNDhlMTMyMGFiYjA3Y2RiZjEwN2Q5MmNmNjg0OTkuLjBhODQxNWFhZTJiMjYyMzg1Zjhh ZTlkMGU5YWQ4Mjk3NGYzOWNlYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKQEAgLTM3LDkgKzM3LDcgQEAgV0kuU2V0dGlu ZyA9IGNsYXNzIFNldHRpbmcgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgICAgICB0aGlzLl9uYW1l ID0gbmFtZTsKIAotICAgICAgICBsZXQgaW5zcGVjdGlvbkxldmVsID0gSW5zcGVjdG9yRnJvbnRl bmRIb3N0ID8gSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmluc3BlY3Rpb25MZXZlbCgpIDogMTsKLSAg ICAgICAgbGV0IGxldmVsU3RyaW5nID0gaW5zcGVjdGlvbkxldmVsID4gMSA/ICItIiArIGluc3Bl Y3Rpb25MZXZlbCA6ICIiOwotICAgICAgICB0aGlzLl9sb2NhbFN0b3JhZ2VLZXkgPSBgY29tLmFw cGxlLldlYkluc3BlY3RvciR7bGV2ZWxTdHJpbmd9LiR7bmFtZX1gOworICAgICAgICB0aGlzLl9s b2NhbFN0b3JhZ2VLZXkgPSBXSS5TZXR0aW5nLl9sb2NhbFN0b3JhZ2VLZXkodGhpcy5fbmFtZSk7 CiAgICAgICAgIHRoaXMuX2RlZmF1bHRWYWx1ZSA9IGRlZmF1bHRWYWx1ZTsKICAgICB9CiAKQEAg LTQ3LDE3ICs0NSwyNiBAQCBXSS5TZXR0aW5nID0gY2xhc3MgU2V0dGluZyBleHRlbmRzIFdJLk9i amVjdAogCiAgICAgc3RhdGljIG1pZ3JhdGVWYWx1ZShrZXkpCiAgICAgeworICAgICAgICBsZXQg bG9jYWxTdG9yYWdlS2V5ID0gV0kuU2V0dGluZy5fbG9jYWxTdG9yYWdlS2V5KGtleSk7CisKICAg ICAgICAgbGV0IHZhbHVlID0gdW5kZWZpbmVkOwotICAgICAgICBpZiAoIXdpbmRvdy5JbnNwZWN0 b3JUZXN0ICYmIHdpbmRvdy5sb2NhbFN0b3JhZ2UgJiYga2V5IGluIHdpbmRvdy5sb2NhbFN0b3Jh Z2UpIHsKKyAgICAgICAgaWYgKCF3aW5kb3cuSW5zcGVjdG9yVGVzdCAmJiB3aW5kb3cubG9jYWxT dG9yYWdlICYmIGxvY2FsU3RvcmFnZUtleSBpbiB3aW5kb3cubG9jYWxTdG9yYWdlKSB7CiAgICAg ICAgICAgICB0cnkgewotICAgICAgICAgICAgICAgIHZhbHVlID0gSlNPTi5wYXJzZSh3aW5kb3cu bG9jYWxTdG9yYWdlW2tleV0pOworICAgICAgICAgICAgICAgIHZhbHVlID0gSlNPTi5wYXJzZSh3 aW5kb3cubG9jYWxTdG9yYWdlW2xvY2FsU3RvcmFnZUtleV0pOwogICAgICAgICAgICAgfSBjYXRj aCB7IH0KIAotICAgICAgICAgICAgd2luZG93LmxvY2FsU3RvcmFnZS5yZW1vdmVJdGVtKGtleSk7 CisgICAgICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlLnJlbW92ZUl0ZW0obG9jYWxTdG9yYWdl S2V5KTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gdmFsdWU7CiAgICAgfQogCisgICAgc3Rh dGljIF9sb2NhbFN0b3JhZ2VLZXkobmFtZSkKKyAgICB7CisgICAgICAgIGxldCBpbnNwZWN0aW9u TGV2ZWwgPSBJbnNwZWN0b3JGcm9udGVuZEhvc3QgPyBJbnNwZWN0b3JGcm9udGVuZEhvc3QuaW5z cGVjdGlvbkxldmVsKCkgOiAxOworICAgICAgICBsZXQgbGV2ZWxTdHJpbmcgPSBpbnNwZWN0aW9u TGV2ZWwgPiAxID8gIi0iICsgaW5zcGVjdGlvbkxldmVsIDogIiI7CisgICAgICAgIHJldHVybiBg Y29tLmFwcGxlLldlYkluc3BlY3RvciR7bGV2ZWxTdHJpbmd9LiR7bmFtZX1gOworICAgIH0KKwog ICAgIC8vIFB1YmxpYwogCiAgICAgZ2V0IG5hbWUoKQo=