193808 2019-01-24 19:17:35 -0800 REGRESSION(?): Web Inspector: Can have multiple Timelines selected after edit mode 2019-01-28 11:53:27 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck mattbaker commit-queue hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1498095 0 joepeck 2019-01-24 19:17:35 -0800 REGRESSION: Can have multiple Timelines selected after edit mode Steps to Reproduce: 1. Inspect this page 2. Show Timelines tab with multiple timelines 3. Select 1st timeline 4. Enter edit mode => No selection visible 5. Leave edit mode => Selection visible 6. Select 2nd timeline => Multiple timelines selected (unexpected) 1498096 1 webkit-bug-importer 2019-01-24 19:17:59 -0800 <rdar://problem/47537734> 1498920 2 360312 mattbaker 2019-01-27 19:24:57 -0800 Created attachment 360312 Patch 1499083 3 360312 hi 2019-01-28 10:58:56 -0800 Comment on attachment 360312 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360312&action=review r=me, but I think we should write tests for patches that "fix a bug where...", so I'd like to see a test for this if possible > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:350 > + treeOutline._selectionController.didRemoveItems(removedIndexes); I'd personally rather have the early-return happen inside `didRemoveItems`. Requiring the caller to know that you should only ever pass a non-null `WI.IndexSet` seems unnecessary, and is likely to be forgotten in the future. Also, should we also be early-returning if `!removedIndexes.size`? 1499097 4 360359 mattbaker 2019-01-28 11:16:15 -0800 Created attachment 360359 Patch 1499120 5 360359 commit-queue 2019-01-28 11:53:25 -0800 Comment on attachment 360359 Patch Clearing flags on attachment: 360359 Committed r240594: <https://trac.webkit.org/changeset/240594> 1499121 6 commit-queue 2019-01-28 11:53:27 -0800 All reviewed patches have been landed. Closing bug. 360312 2019-01-27 19:24:57 -0800 2019-01-28 11:16:13 -0800 Patch bug-193808-20190127192448.patch text/plain 3731 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm ZmRkZjdjNGM2YmUyNjA5MWY4YTQzMTJmZDNkZGQyYWQwMTc0ZDRmLi5jNjU2ZDJlNjMxYTZiZmFk ZjRlMjdmNmQzNWIxYzkwM2ZmODRiMjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMS0yNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTig/KTogV2ViIEluc3BlY3RvcjogQ2FuIGhhdmUgbXVsdGlw bGUgVGltZWxpbmVzIHNlbGVjdGVkIGFmdGVyIGVkaXQgbW9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzODA4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzUzNzczND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanM6CisgICAgICAgIChX SS5UcmVlT3V0bGluZS5wcm90b3R5cGUucmVtb3ZlQ2hpbGRBdEluZGV4KToKKyAgICAgICAgKFdJ LlRyZWVPdXRsaW5lLnByb3RvdHlwZS5yZW1vdmVDaGlsZHJlbik6CisgICAgICAgIENoZWNrIGZv ciBudWxsIGJlZm9yZSBjYWxsaW5nIGRpZFJlbW92ZUl0ZW1zLiBQcmV2aW91c2x5IHdlIHBhc3Nl ZCBpbgorICAgICAgICBhbiBlbXB0eSBJbmRleFNldCByZXR1cm5lZCBieSBfaW5kZXhlc0ZvclN1 YnRyZWUuCisgICAgICAgIChXSS5UcmVlT3V0bGluZS5wcm90b3R5cGUuX2luZGV4ZXNGb3JTdWJ0 cmVlKToKKyAgICAgICAgRml4IGEgYnVnIHdoZXJlIG5vIEluZGV4U2V0IHdhcyByZXR1cm5lZCB3 aGVuIHBhc3NlZCBhIFRyZWVFbGVtZW50IHdpdGgKKyAgICAgICAgbm8gY2hpbGRyZW4uIFRoaXMg Y2F1c2VkIHRoZSBUaW1lbGluZXMgdHJlZSBzZWxlY3Rpb24gdG8gYmUgY29ycnVwdGVkIHdoZW4K KyAgICAgICAgZW50ZXJpbmcgYW5kIGV4aXRpbmcgZWRpdCBtb2RlLCBhcyBUcmVlRWxlbWVudHMg YXJlIGluc2VydGVkIGFuZCByZW1vdmVkLgorCiAyMDE5LTAxLTI2ICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBoYW5kbGUgQ1NTIENv bG9yIDQgY29sb3Igc3ludGF4ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggYTQ3ZTYwYjg5YWY2ZTBk ZWY1Yjg2OGE2NDQ3OTA1ZjVhYjI5ZWY5ZC4uZDUyMDJlYzgyZWQ3YjhlMGFmMTM5MzhjZWEyNjc2 NzA5MWQ0NGMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVHJlZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanMKQEAgLTM0Niw3ICszNDYsOCBAQCBXSS5UcmVl T3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgIGNo aWxkLnByZXZpb3VzU2libGluZyA9IG51bGw7CiAKICAgICAgICAgaWYgKHRyZWVPdXRsaW5lKSB7 Ci0gICAgICAgICAgICB0cmVlT3V0bGluZS5fc2VsZWN0aW9uQ29udHJvbGxlci5kaWRSZW1vdmVJ dGVtcyhyZW1vdmVkSW5kZXhlcyk7CisgICAgICAgICAgICBpZiAocmVtb3ZlZEluZGV4ZXMpCisg ICAgICAgICAgICAgICAgdHJlZU91dGxpbmUuX3NlbGVjdGlvbkNvbnRyb2xsZXIuZGlkUmVtb3Zl SXRlbXMocmVtb3ZlZEluZGV4ZXMpOwogICAgICAgICAgICAgdHJlZU91dGxpbmUuZGlzcGF0Y2hF dmVudFRvTGlzdGVuZXJzKFdJLlRyZWVPdXRsaW5lLkV2ZW50LkVsZW1lbnRSZW1vdmVkLCB7ZWxl bWVudDogY2hpbGR9KTsKICAgICAgICAgfQogICAgIH0KQEAgLTM5NCw3ICszOTUsOCBAQCBXSS5U cmVlT3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAg ICAgICB0aGlzLmNoaWxkcmVuLnNoaWZ0KCk7CiAKICAgICAgICAgICAgIGlmICh0cmVlT3V0bGlu ZSkgewotICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lLl9zZWxlY3Rpb25Db250cm9sbGVyLmRp ZFJlbW92ZUl0ZW1zKHJlbW92ZWRJbmRleGVzKTsKKyAgICAgICAgICAgICAgICBpZiAocmVtb3Zl ZEluZGV4ZXMpCisgICAgICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lLl9zZWxlY3Rpb25Db250 cm9sbGVyLmRpZFJlbW92ZUl0ZW1zKHJlbW92ZWRJbmRleGVzKTsKICAgICAgICAgICAgICAgICB0 cmVlT3V0bGluZS5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuVHJlZU91dGxpbmUuRXZlbnQu RWxlbWVudFJlbW92ZWQsIHtlbGVtZW50OiBjaGlsZH0pOwogICAgICAgICAgICAgfQogICAgICAg ICB9CkBAIC0xMDgyLDI3ICsxMDg0LDIzIEBAIFdJLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91 dGxpbmUgZXh0ZW5kcyBXSS5PYmplY3QKICAgICB7CiAgICAgICAgIGxldCB0cmVlT3V0bGluZSA9 IHRyZWVFbGVtZW50LnRyZWVPdXRsaW5lOwogICAgICAgICBpZiAoIXRyZWVPdXRsaW5lKQotICAg ICAgICAgICAgcmV0dXJuIG5ldyBXSS5JbmRleFNldDsKKyAgICAgICAgICAgIHJldHVybiBudWxs OwogCiAgICAgICAgIGxldCBmaXJzdENoaWxkID0gdHJlZUVsZW1lbnQuY2hpbGRyZW5bMF07Ci0g ICAgICAgIGlmICghZmlyc3RDaGlsZCkKLSAgICAgICAgICAgIHJldHVybiBuZXcgV0kuSW5kZXhT ZXQ7CisgICAgICAgIGlmICh0cmVlRWxlbWVudC5yb290ICYmICFmaXJzdENoaWxkKQorICAgICAg ICAgICAgcmV0dXJuIG51bGw7CiAKLSAgICAgICAgbGV0IHN0YXJ0SW5kZXggPSB0cmVlT3V0bGlu ZS5faW5kZXhPZlRyZWVFbGVtZW50KGZpcnN0Q2hpbGQpOworICAgICAgICBsZXQgY3VycmVudCA9 IGZpcnN0Q2hpbGQgfHwgdHJlZUVsZW1lbnQ7CisgICAgICAgIGxldCBzdGFydEluZGV4ID0gdHJl ZU91dGxpbmUuX2luZGV4T2ZUcmVlRWxlbWVudChjdXJyZW50KTsKICAgICAgICAgbGV0IGVuZElu ZGV4ID0gc3RhcnRJbmRleDsKIAogICAgICAgICBjb25zdCBza2lwVW5yZXZlYWxlZCA9IGZhbHNl OwogICAgICAgICBjb25zdCBzdGF5V2l0aGluID0gdHJlZUVsZW1lbnQ7CiAgICAgICAgIGNvbnN0 IGRvbnRQb3B1bGF0ZSA9IHRydWU7CiAKLSAgICAgICAgbGV0IGN1cnJlbnQgPSBmaXJzdENoaWxk OwogICAgICAgICB3aGlsZSAoY3VycmVudCA9IGN1cnJlbnQudHJhdmVyc2VOZXh0VHJlZUVsZW1l bnQoc2tpcFVucmV2ZWFsZWQsIHN0YXlXaXRoaW4sIGRvbnRQb3B1bGF0ZSkpCiAgICAgICAgICAg ICBlbmRJbmRleCsrOwogCi0gICAgICAgIC8vIEluY2x1ZGUgdGhlIGluZGV4IG9mIHRoZSBzdWJ0 cmVlJ3Mgcm9vdCwgdW5sZXNzIGl0J3MgdGhlIFRyZWVPdXRsaW5lIHJvb3QuCi0gICAgICAgIGlm ICghdHJlZUVsZW1lbnQucm9vdCkKLSAgICAgICAgICAgIHN0YXJ0SW5kZXgtLTsKLQogICAgICAg ICBsZXQgY291bnQgPSBlbmRJbmRleCAtIHN0YXJ0SW5kZXggKyAxOwogCiAgICAgICAgIGxldCBp bmRleGVzID0gbmV3IFdJLkluZGV4U2V0Owo= 360359 2019-01-28 11:16:15 -0800 2019-01-28 11:53:25 -0800 Patch bug-193808-20190128111602.patch text/plain 3485 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm OTU0OTU1ZDFjMDk2Y2NmZTUyZjU5NjM2NWZlNDIzZDg4MTRhMmI2Li5jZjE2MWVhOWU5ZmY5NzVl MDQ5MTczNmQ1OTIyODc5ZDdlNzBiZGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMS0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTig/KTogV2ViIEluc3BlY3RvcjogQ2FuIGhhdmUgbXVsdGlw bGUgVGltZWxpbmVzIHNlbGVjdGVkIGFmdGVyIGVkaXQgbW9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzODA4CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzUzNzczND4KKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIuanM6 CisgICAgICAgIChXSS5TZWxlY3Rpb25Db250cm9sbGVyLnByb3RvdHlwZS5kaWRSZW1vdmVJdGVt cyk6CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzOgorICAg ICAgICAoV0kuVHJlZU91dGxpbmUucHJvdG90eXBlLl9pbmRleGVzRm9yU3VidHJlZSk6CisgICAg ICAgIEZpeCBhIGJ1ZyB3aGVyZSBubyBJbmRleFNldCB3YXMgcmV0dXJuZWQgd2hlbiBwYXNzZWQg YSBUcmVlRWxlbWVudCB3aXRoCisgICAgICAgIG5vIGNoaWxkcmVuLiBUaGlzIGNhdXNlZCB0aGUg VGltZWxpbmVzIHRyZWUgc2VsZWN0aW9uIHRvIGJlIGNvcnJ1cHRlZCB3aGVuCisgICAgICAgIGVu dGVyaW5nIGFuZCBleGl0aW5nIGVkaXQgbW9kZSwgYXMgVHJlZUVsZW1lbnRzIGFyZSBpbnNlcnRl ZCBhbmQgcmVtb3ZlZC4KKwogMjAxOS0wMS0yOCAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgQ2hhbmdlcyBwYW5lbCB0 byBFbGVtZW50cyB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9TZWxlY3Rpb25Db250cm9sbGVyLmpz CmluZGV4IGI2NWY5ZjAzMWY3YzVlNTUyNzdmNTU0MDUyMjQ1MDgxZWI1MjZkNjYuLjc1Y2JjZjUw YmQzZGFjYWIwOGU0NTFmMTE4MzFjOTRlNGRlMjVjYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1NlbGVjdGlvbkNvbnRyb2xsZXIu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv U2VsZWN0aW9uQ29udHJvbGxlci5qcwpAQCAtMjIxLDkgKzIyMSwxMiBAQCBXSS5TZWxlY3Rpb25D b250cm9sbGVyID0gY2xhc3MgU2VsZWN0aW9uQ29udHJvbGxlciBleHRlbmRzIFdJLk9iamVjdAog CiAgICAgZGlkUmVtb3ZlSXRlbXMoaW5kZXhlcykKICAgICB7CisgICAgICAgIGlmICghaW5kZXhl cykKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBjb25zb2xlLmFzc2VydChpbmRleGVz IGluc3RhbmNlb2YgV0kuSW5kZXhTZXQpOwogCi0gICAgICAgIGlmICghdGhpcy5fc2VsZWN0ZWRJ bmRleGVzLnNpemUpCisgICAgICAgIGlmICghaW5kZXhlcy5zaXplIHx8ICF0aGlzLl9zZWxlY3Rl ZEluZGV4ZXMuc2l6ZSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBsZXQgZmlyc3RS ZW1vdmVkSW5kZXggPSBpbmRleGVzLmZpcnN0SW5kZXg7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCmluZGV4IGE0 N2U2MGI4OWFmNmUwZGVmNWI4NjhhNjQ0NzkwNWY1YWIyOWVmOWQuLjAyY2Q3YjQ5YzdhMGM0NDI5 OTQyYTM1ZjBkMzgxNzY5Y2Q2MzhkMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC0xMDgyLDI3ICsx MDgyLDIzIEBAIFdJLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91dGxpbmUgZXh0ZW5kcyBXSS5P YmplY3QKICAgICB7CiAgICAgICAgIGxldCB0cmVlT3V0bGluZSA9IHRyZWVFbGVtZW50LnRyZWVP dXRsaW5lOwogICAgICAgICBpZiAoIXRyZWVPdXRsaW5lKQotICAgICAgICAgICAgcmV0dXJuIG5l dyBXSS5JbmRleFNldDsKKyAgICAgICAgICAgIHJldHVybiBudWxsOwogCiAgICAgICAgIGxldCBm aXJzdENoaWxkID0gdHJlZUVsZW1lbnQuY2hpbGRyZW5bMF07Ci0gICAgICAgIGlmICghZmlyc3RD aGlsZCkKLSAgICAgICAgICAgIHJldHVybiBuZXcgV0kuSW5kZXhTZXQ7CisgICAgICAgIGlmICh0 cmVlRWxlbWVudC5yb290ICYmICFmaXJzdENoaWxkKQorICAgICAgICAgICAgcmV0dXJuIG51bGw7 CiAKLSAgICAgICAgbGV0IHN0YXJ0SW5kZXggPSB0cmVlT3V0bGluZS5faW5kZXhPZlRyZWVFbGVt ZW50KGZpcnN0Q2hpbGQpOworICAgICAgICBsZXQgY3VycmVudCA9IGZpcnN0Q2hpbGQgfHwgdHJl ZUVsZW1lbnQ7CisgICAgICAgIGxldCBzdGFydEluZGV4ID0gdHJlZU91dGxpbmUuX2luZGV4T2ZU cmVlRWxlbWVudChjdXJyZW50KTsKICAgICAgICAgbGV0IGVuZEluZGV4ID0gc3RhcnRJbmRleDsK IAogICAgICAgICBjb25zdCBza2lwVW5yZXZlYWxlZCA9IGZhbHNlOwogICAgICAgICBjb25zdCBz dGF5V2l0aGluID0gdHJlZUVsZW1lbnQ7CiAgICAgICAgIGNvbnN0IGRvbnRQb3B1bGF0ZSA9IHRy dWU7CiAKLSAgICAgICAgbGV0IGN1cnJlbnQgPSBmaXJzdENoaWxkOwogICAgICAgICB3aGlsZSAo Y3VycmVudCA9IGN1cnJlbnQudHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoc2tpcFVucmV2ZWFsZWQs IHN0YXlXaXRoaW4sIGRvbnRQb3B1bGF0ZSkpCiAgICAgICAgICAgICBlbmRJbmRleCsrOwogCi0g ICAgICAgIC8vIEluY2x1ZGUgdGhlIGluZGV4IG9mIHRoZSBzdWJ0cmVlJ3Mgcm9vdCwgdW5sZXNz IGl0J3MgdGhlIFRyZWVPdXRsaW5lIHJvb3QuCi0gICAgICAgIGlmICghdHJlZUVsZW1lbnQucm9v dCkKLSAgICAgICAgICAgIHN0YXJ0SW5kZXgtLTsKLQogICAgICAgICBsZXQgY291bnQgPSBlbmRJ bmRleCAtIHN0YXJ0SW5kZXggKyAxOwogCiAgICAgICAgIGxldCBpbmRleGVzID0gbmV3IFdJLklu ZGV4U2V0Owo=