193784 2019-01-24 14:42:34 -0800 [iOS] Add logging of calls 2019-01-25 09:59:04 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build iPhone / iPad All RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1497968 0 pvollan 2019-01-24 14:42:34 -0800 We already do this on macOS, we should do it on iOS as well. 1497969 1 360041 pvollan 2019-01-24 14:44:30 -0800 Created attachment 360041 Patch 1497970 2 webkit-bug-importer 2019-01-24 14:46:28 -0800 <rdar://problem/47529440> 1498274 3 360041 bfulgham 2019-01-25 09:22:18 -0800 Comment on attachment 360041 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360041&action=review r=me, assuming you tested on shipping iOS to make sure it doesn't break test bots. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560 > + (allow syscall-unix (with report)) Does this mean we will report, unless it is explicitly allowed below? 1498277 4 pvollan 2019-01-25 09:27:34 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 360041 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360041&action=review > > r=me, assuming you tested on shipping iOS to make sure it doesn't break test > bots. > I believe this is a low risk change, since we by default allow all calls. > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560 > > + (allow syscall-unix (with report)) > > Does this mean we will report, unless it is explicitly allowed below? Yes. Thanks for reviewing! 1498287 5 360041 commit-queue 2019-01-25 09:59:03 -0800 Comment on attachment 360041 Patch Clearing flags on attachment: 360041 Committed r240478: <https://trac.webkit.org/changeset/240478> 1498288 6 commit-queue 2019-01-25 09:59:04 -0800 All reviewed patches have been landed. Closing bug. 360041 2019-01-24 14:44:30 -0800 2019-01-25 09:59:03 -0800 Patch bug-193784-20190124144429.patch text/plain 6437 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDA0NDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAxLTI0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGQgbG9nZ2luZyBv ZiBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNzg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIHBlcm1pc3NpdmUgbG9nZ2luZyBvZiBjYWxscyBvbiBpT1MuCisKKyAgICAgICAgKiBSZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6 CisKIDIwMTktMDEtMTYgIEFsYW4gQ29vbiAgPGFsYW5jb29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBDaGVycnktcGljayByMjQwMDg3LiByZGFyOi8vcHJvYmxlbS80NzI5NzMwNApJbmRleDogU291 cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2Fu ZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9u IDI0MDM1NCkKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCSh3b3JraW5nIGNvcHkpCkBAIC01NTUsMyAr NTU1LDEzNyBAQAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndlYmluc3BlY3RvciIpCiAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUud2Via2l0LmNhbWVyYSIpCiApCisKKyh3aGVuIChk ZWZpbmVkPyAnc3lzY2FsbC11bml4KQorICAgIChhbGxvdyBzeXNjYWxsLXVuaXggKHdpdGggcmVw b3J0KSkKKyAgICAoYWxsb3cgc3lzY2FsbC11bml4CisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfZXhpdCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19yZWFkKQorICAgICAgICAoc3lz Y2FsbC1udW1iZXIgU1lTX3dyaXRlKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX29wZW4p CisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfY2xvc2UpCisgICAgICAgIChzeXNjYWxsLW51 bWJlciBTWVNfdW5saW5rKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2NobW9kKQorICAg ICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHVpZCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU19nZXRldWlkKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3JlY3Zmcm9tKQorICAg ICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHBlZXJuYW1lKQorICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX2FjY2VzcykKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19kdXApCisgICAg ICAgIChzeXNjYWxsLW51bWJlciBTWVNfcGlwZSkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZ U19nZXRlZ2lkKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldGdpZCkKKyAgICAgICAg KHN5c2NhbGwtbnVtYmVyIFNZU19zaWdwcm9jbWFzaykKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU19zaWdhbHRzdGFjaykKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19pb2N0bCkKKyAg ICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19yZWFkbGluaykKKyAgICAgICAgKHN5c2NhbGwtbnVt YmVyIFNZU191bWFzaykKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19tc3luYykKKyAgICAg ICAgKHN5c2NhbGwtbnVtYmVyIFNZU19tdW5tYXApCisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfbXByb3RlY3QpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfbWFkdmlzZSkKKyAgICAg ICAgKHN5c2NhbGwtbnVtYmVyIFNZU19mY250bCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZ U19zZWxlY3QpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZnN5bmMpCisgICAgICAgIChz eXNjYWxsLW51bWJlciBTWVNfc2V0cHJpb3JpdHkpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfc29ja2V0KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2Nvbm5lY3QpCisgICAgICAg IChzeXNjYWxsLW51bWJlciBTWVNfc2V0c29ja29wdCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU19nZXR0aW1lb2ZkYXkpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZ2V0cnVzYWdl KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHNvY2tvcHQpCisgICAgICAgIChzeXNj YWxsLW51bWJlciBTWVNfd3JpdGV2KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2ZjaG1v ZCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19yZW5hbWUpCisgICAgICAgIChzeXNjYWxs LW51bWJlciBTWVNfZmxvY2spCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfc2VuZHRvKQor ICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3NodXRkb3duKQorICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX3NvY2tldHBhaXIpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfbWtkaXIp CisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfcm1kaXIpCisgICAgICAgIChzeXNjYWxsLW51 bWJlciBTWVNfcHJlYWQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfcHdyaXRlKQorICAg ICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2Nzb3BzKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIg U1lTX2Nzb3BzX2F1ZGl0dG9rZW4pCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfa2RlYnVn X3RyYWNlNjQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfa2RlYnVnX3RyYWNlKQorICAg ICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3NpZ3JldHVybikKKyAgICAgICAgKHN5c2NhbGwtbnVt YmVyIFNZU19wYXRoY29uZikKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19nZXRybGltaXQp CisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfc2V0cmxpbWl0KQorICAgICAgICAoc3lzY2Fs bC1udW1iZXIgU1lTX21tYXApCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfbHNlZWspCisg ICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZnRydW5jYXRlKQorICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX3N5c2N0bCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19tbG9jaykKKyAg ICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19tdW5sb2NrKQorICAgICAgICAoc3lzY2FsbC1udW1i ZXIgU1lTX2dldGF0dHJsaXN0KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHhhdHRy KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2ZnZXR4YXR0cikKKyAgICAgICAgKHN5c2Nh bGwtbnVtYmVyIFNZU19saXN0eGF0dHIpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfc2ht X29wZW4pCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfc2VtX3dhaXQpCisgICAgICAgIChz eXNjYWxsLW51bWJlciBTWVNfc2VtX3Bvc3QpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNf c3lzY3RsYnluYW1lKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3BzeW5jaF9tdXRleHdh aXQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfcHN5bmNoX211dGV4ZHJvcCkKKyAgICAg ICAgKHN5c2NhbGwtbnVtYmVyIFNZU19wc3luY2hfY3Zicm9hZCkKKyAgICAgICAgKHN5c2NhbGwt bnVtYmVyIFNZU19wc3luY2hfY3ZzaWduYWwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNf cHN5bmNoX2N2d2FpdCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19wc3luY2hfcndfd3Js b2NrKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3BzeW5jaF9yd191bmxvY2spCisgICAg ICAgIChzeXNjYWxsLW51bWJlciBTWVNfcHN5bmNoX2N2Y2xycHJlcG9zdCkKKyAgICAgICAgKHN5 c2NhbGwtbnVtYmVyIFNZU19wcm9jZXNzX3BvbGljeSkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU19pc3NldHVnaWQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfX19wdGhyZWFkX2tp bGwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfX19wdGhyZWFkX3NpZ21hc2spCisgICAg ICAgIChzeXNjYWxsLW51bWJlciBTWVNfX19kaXNhYmxlX3RocmVhZHNpZ25hbCkKKyAgICAgICAg KHN5c2NhbGwtbnVtYmVyIFNZU19fX3NlbXdhaXRfc2lnbmFsKQorICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX3Byb2NfaW5mbykKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19zdGF0NjQp CisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZnN0YXQ2NCkKKyAgICAgICAgKHN5c2NhbGwt bnVtYmVyIFNZU19sc3RhdDY0KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldGRpcmVu dHJpZXM2NCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19zdGF0ZnM2NCkKKyAgICAgICAg KHN5c2NhbGwtbnVtYmVyIFNZU19mc3RhdGZzNjQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfZ2V0ZnNzdGF0NjQpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZ2V0YXVkaXRfYWRk cikKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19ic2R0aHJlYWRfY3JlYXRlKQorICAgICAg ICAoc3lzY2FsbC1udW1iZXIgU1lTX2JzZHRocmVhZF90ZXJtaW5hdGUpCisgICAgICAgIChzeXNj YWxsLW51bWJlciBTWVNfd29ya3Ffa2VybnJldHVybikKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU190aHJlYWRfc2VsZmlkKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2tldmVudF9x b3MpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfa2V2ZW50X2lkKQorICAgICAgICAoc3lz Y2FsbC1udW1iZXIgU1lTX19fbWFjX3N5c2NhbGwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfcmVhZF9ub2NhbmNlbCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU193cml0ZV9ub2Nh bmNlbCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19vcGVuX25vY2FuY2VsKQorICAgICAg ICAoc3lzY2FsbC1udW1iZXIgU1lTX2Nsb3NlX25vY2FuY2VsKQorICAgICAgICAoc3lzY2FsbC1u dW1iZXIgU1lTX3NlbmRtc2dfbm9jYW5jZWwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNf cmVjdmZyb21fbm9jYW5jZWwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfZmNudGxfbm9j YW5jZWwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfc2VsZWN0X25vY2FuY2VsKQorICAg ICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2Nvbm5lY3Rfbm9jYW5jZWwpCisgICAgICAgIChzeXNj YWxsLW51bWJlciBTWVNfc2VuZHRvX25vY2FuY2VsKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIg U1lTX2ZzZ2V0cGF0aCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19maWxlcG9ydF9tYWtl cG9ydCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19ndWFyZGVkX29wZW5fbnApCisgICAg ICAgIChzeXNjYWxsLW51bWJlciBTWVNfZ3VhcmRlZF9jbG9zZV9ucCkKKyAgICAgICAgKHN5c2Nh bGwtbnVtYmVyIFNZU19jaGFuZ2VfZmRndWFyZF9ucCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVy IFNZU19wcm9jX3JsaW1pdF9jb250cm9sKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2Nv bm5lY3R4KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldGF0dHJsaXN0YnVsaykKKyAg ICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19vcGVuYXQpCisgICAgICAgIChzeXNjYWxsLW51bWJl ciBTWVNfb3BlbmF0X25vY2FuY2VsKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2ZzdGF0 YXQ2NCkKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19ta2RpcmF0KQorICAgICAgICAoc3lz Y2FsbC1udW1iZXIgU1lTX2JzZHRocmVhZF9jdGwpCisgICAgICAgIChzeXNjYWxsLW51bWJlciBT WVNfY3NyY3RsKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2d1YXJkZWRfcHdyaXRlX25w KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldGVudHJvcHkpCisgICAgICAgIChzeXNj YWxsLW51bWJlciBTWVNfbmVjcF9vcGVuKQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX25l Y3BfY2xpZW50X2FjdGlvbikKKyAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU191bG9ja193YWl0 KQorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX3Vsb2NrX3dha2UpCisgICAgKQorKQo=