193783 2019-01-24 14:28:07 -0800 Fix missing dependencies in extract-dependencies-from-makefile 2019-01-25 13:51:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen ap commit-queue jeffm lforschler webkit-bug-importer oldest_to_newest 1497958 0 krollin 2019-01-24 14:28:07 -0800 The extract-dependencies-from-makefile script generates .xcfilelists for XCBuild by invoking a makefile in --debug mode, parsing the dependency information in the output, and extracting information regarding targets and dependents. However, the way `make` emits this dependency information is not rigorous, and so we need to determine what lines to look for and parse by trial and error. This approach didn't catch all the information we needed to collect, so update the script to look for the additional lines we now know to look for. rdar://problem/47201571 1498040 1 360052 krollin 2019-01-24 16:50:11 -0800 Created attachment 360052 Patch 1498438 2 360052 commit-queue 2019-01-25 13:51:08 -0800 Comment on attachment 360052 Patch Clearing flags on attachment: 360052 Committed r240503: <https://trac.webkit.org/changeset/240503> 1498439 3 commit-queue 2019-01-25 13:51:10 -0800 All reviewed patches have been landed. Closing bug. 360052 2019-01-24 16:50:11 -0800 2019-01-25 13:51:08 -0800 Patch bug-193783-20190124165010.patch text/plain 3004 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDQ0ZmRiYzcyZDRiYjFkN2Q1MTQxMzFhNTEyMDRlYzVm NDkyYWVhMC4uYWJlMGM4YmEwYzI5MDE4NjAzYzhlZjE0YTg5ZTc5MDk2ODkwOTgwNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE5LTAxLTI0ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggbWlzc2luZyBkZXBlbmRlbmNpZXMgaW4gZXh0cmFjdC1kZXBlbmRlbmNpZXMtZnJv bS1tYWtlZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzNzgzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzIwMTU3MT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZXh0cmFjdC1kZXBlbmRl bmNpZXMtZnJvbS1tYWtlZmlsZSBzY3JpcHQgZ2VuZXJhdGVzIC54Y2ZpbGVsaXN0cworICAgICAg ICBmb3IgWENCdWlsZCBieSBpbnZva2luZyBhIG1ha2VmaWxlIGluIC0tZGVidWcgbW9kZSwgcGFy c2luZyB0aGUKKyAgICAgICAgZGVwZW5kZW5jeSBpbmZvcm1hdGlvbiBpbiB0aGUgb3V0cHV0LCBh bmQgZXh0cmFjdGluZyBpbmZvcm1hdGlvbgorICAgICAgICByZWdhcmRpbmcgdGFyZ2V0cyBhbmQg ZGVwZW5kZW50cy4gSG93ZXZlciwgdGhlIHdheSBgbWFrZWAgZW1pdHMgdGhpcworICAgICAgICBk ZXBlbmRlbmN5IGluZm9ybWF0aW9uIGlzIG5vdCByaWdvcm91cywgYW5kIHNvIHdlIG5lZWQgdG8g ZGV0ZXJtaW5lCisgICAgICAgIHdoYXQgbGluZXMgdG8gbG9vayBmb3IgYW5kIHBhcnNlIGJ5IHRy aWFsIGFuZCBlcnJvci4gVGhpcyBhcHByb2FjaAorICAgICAgICBkaWRuJ3QgY29yaWdpbmFsbHkg YXRjaCBhbGwgdGhlIGluZm9ybWF0aW9uIHdlIG5lZWRlZCB0byBjb2xsZWN0LCBzbworICAgICAg ICB1cGRhdGUgdGhlIHNjcmlwdCB0byBsb29rIGZvciB0aGUgYWRkaXRpb25hbCBsaW5lcyB3ZSBu b3cga25vdyB0byBsb29rCisgICAgICAgIGZvci4KKworICAgICAgICAqIFNjcmlwdHMvZXh0cmFj dC1kZXBlbmRlbmNpZXMtZnJvbS1tYWtlZmlsZToKKyAgICAgICAgKFBhcnNlcik6CisgICAgICAg IChQYXJzZXIuYWRkVGFyZ2V0KToKKyAgICAgICAgKFBhcnNlci5hZGRQcmVyZXEpOgorICAgICAg ICAoUGFyc2VyLmRvUGFyc2UpOgorCiAyMDE5LTAxLTI0ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGlu QGFwcGxlLmNvbT4KIAogICAgICAgICBDb21wbGV0ZSB0aGUgaW1wbGVtZW50YXRpb24gb2YgZ2Vu ZXJhdGUteGNmaWxlbGlzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZXh0cmFjdC1kZXBl bmRlbmNpZXMtZnJvbS1tYWtlZmlsZSBiL1Rvb2xzL1NjcmlwdHMvZXh0cmFjdC1kZXBlbmRlbmNp ZXMtZnJvbS1tYWtlZmlsZQppbmRleCA3ODA3MzdiMjMyNDE4NDBlMWRlYzA1MDY4MjI4NjlkNTZh NDhlY2MzLi5lMDdmYmM5Y2NkYjVhZDAwZTRlNWM0YzViMzEyMTM0NjMzNGI3ZTUyIDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL2V4dHJhY3QtZGVwZW5kZW5jaWVzLWZyb20tbWFrZWZpbGUKKysr IGIvVG9vbHMvU2NyaXB0cy9leHRyYWN0LWRlcGVuZGVuY2llcy1mcm9tLW1ha2VmaWxlCkBAIC00 NSw2ICs0NSw3IEBAIGNsYXNzIFBhcnNlcihvYmplY3QpOgogCiAgICAgZmlsZU5hbWVQYXR0ZXJu ICAgICAgICAgPSByImAoW14nXSspJyIKICAgICByZVByZXJlcXVpc2l0ZSAgICAgICAgICA9IHJl LmNvbXBpbGUociJQcmVyZXF1aXNpdGUge30gaXMgLiogdGhhbiB0YXJnZXQge30iLmZvcm1hdChm aWxlTmFtZVBhdHRlcm4sIGZpbGVOYW1lUGF0dGVybikpCisgICAgcmVNdXN0UmVtYWtlVGFyZ2V0 ICAgICAgPSByZS5jb21waWxlKHIiTXVzdCByZW1ha2UgdGFyZ2V0IHt9Ii5mb3JtYXQoZmlsZU5h bWVQYXR0ZXJuKSkKICAgICByZVdhc0NvbnNpZGVyZWRBbHJlYWR5ICA9IHJlLmNvbXBpbGUociJ7 fSB3YXMgY29uc2lkZXJlZCBhbHJlYWR5LiIuZm9ybWF0KGZpbGVOYW1lUGF0dGVybikpCiAgICAg cmVQcnVuaW5nRmlsZSAgICAgICAgICAgPSByZS5jb21waWxlKHIiUHJ1bmluZyBmaWxlIHt9LiIu Zm9ybWF0KGZpbGVOYW1lUGF0dGVybikpCiAKQEAgLTYwLDEwICs2MSwxMiBAQCBjbGFzcyBQYXJz ZXIob2JqZWN0KToKICAgICAgICAgICAgIGlmIGxpbmU6IHlpZWxkIGxpbmUKIAogICAgIGRlZiBh ZGRUYXJnZXQoc2VsZiwgdGFyZ2V0KToKLSAgICAgICAgc2VsZi50YXJnZXRzW3RhcmdldF0gPSAx CisgICAgICAgIGlmIHRhcmdldCAhPSAnYWxsJyBhbmQgdGFyZ2V0ICE9ICdmb3JjZSc6CisgICAg ICAgICAgICBzZWxmLnRhcmdldHNbdGFyZ2V0XSA9IDEKIAogICAgIGRlZiBhZGRQcmVyZXEoc2Vs ZiwgcHJlcmVxKToKLSAgICAgICAgc2VsZi5wcmVyZXFzW3ByZXJlcV0gPSAxCisgICAgICAgIGlm IHByZXJlcSAhPSAnYWxsJyBhbmQgcHJlcmVxICE9ICdmb3JjZSc6CisgICAgICAgICAgICBzZWxm LnByZXJlcXNbcHJlcmVxXSA9IDEKIAogICAgIGRlZiBkb1BhcnNlKHNlbGYsIGlucHV0KToKIApA QCAtNzYsNiArNzksMTEgQEAgY2xhc3MgUGFyc2VyKG9iamVjdCk6CiAgICAgICAgICAgICAgICAg c2VsZi5hZGRQcmVyZXEobS5ncm91cCgxKSkKICAgICAgICAgICAgICAgICBjb250aW51ZQogCisg ICAgICAgICAgICBtID0gUGFyc2VyLnJlTXVzdFJlbWFrZVRhcmdldC5zZWFyY2gobGluZSkKKyAg ICAgICAgICAgIGlmIG06CisgICAgICAgICAgICAgICAgc2VsZi5hZGRUYXJnZXQobS5ncm91cCgx KSkKKyAgICAgICAgICAgICAgICBjb250aW51ZQorCiAgICAgICAgICAgICBtID0gUGFyc2VyLnJl V2FzQ29uc2lkZXJlZEFscmVhZHkuc2VhcmNoKGxpbmUpCiAgICAgICAgICAgICBpZiBtOgogICAg ICAgICAgICAgICAgIHNlbGYuYWRkVGFyZ2V0KG0uZ3JvdXAoMSkpCg==