193780 2019-01-24 14:05:01 -0800 [iOS] Silence MediaPlayer compile warnings 2019-01-24 18:00:08 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ap commit-queue ews-watchlist jer.noble webkit-bug-importer oldest_to_newest 1497945 0 eric.carlson 2019-01-24 14:05:01 -0800 Silence MediaPlayer compile warnings 1497947 1 eric.carlson 2019-01-24 14:05:27 -0800 <rdar://problem/47518428> 1497957 2 360038 eric.carlson 2019-01-24 14:25:44 -0800 Created attachment 360038 Patch 1497960 3 ews-watchlist 2019-01-24 14:28:37 -0800 Attachment 360038 did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/ios/MediaPlayerSPI.h:37: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1498073 4 360038 commit-queue 2019-01-24 18:00:06 -0800 Comment on attachment 360038 Patch Clearing flags on attachment: 360038 Committed r240461: <https://trac.webkit.org/changeset/240461> 1498074 5 commit-queue 2019-01-24 18:00:08 -0800 All reviewed patches have been landed. Closing bug. 360038 2019-01-24 14:25:44 -0800 2019-01-24 18:00:06 -0800 Patch mediplayer-compile-warnings-patch.txt text/plain 2496 eric.carlson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9QQUwvQ2hhbmdlTG9nCmluZGV4IGVhNDkwNjBkNTg1Li5iZjI1OWVlM2FkZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEtMjQgIEVyaWMgQ2FybHNvbiAgPGVy aWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gU2lsZW5jZSBNZWRpYVBsYXll ciBjb21waWxlIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTM3ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3NTE4NDI4PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL3NwaS9p b3MvTWVkaWFQbGF5ZXJTUEkuaDoKKwogMjAxOS0wMS0yNCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mu a2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgTW92ZSBGaWxlU3lzdGVtIHRvIFdURgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvaW9zL01lZGlhUGxheWVyU1BJLmgg Yi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9pb3MvTWVkaWFQbGF5ZXJTUEkuaAppbmRleCA4 MmM4YTIwNzIzOC4uZGM0MTNhZWE1YmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9w YWwvc3BpL2lvcy9NZWRpYVBsYXllclNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwv c3BpL2lvcy9NZWRpYVBsYXllclNQSS5oCkBAIC0zNCw2ICszNCwxMCBAQAogCiAjaW1wb3J0IDxN ZWRpYVBsYXllci9NUEFWUm91dGluZ0NvbnRyb2xsZXIuaD4KIAorI2lmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMAorI2ltcG9ydCA8TWVkaWFQbGF5ZXIvTVBNZWRp YUNvbnRyb2xzQ29uZmlndXJhdGlvbi5oPgorI2VuZGlmCisKICNpZiBfX0lQSE9ORV9PU19WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDAgJiYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFU Rk9STShBUFBMRVRWKQogI2ltcG9ydCA8TWVkaWFQbGF5ZXIvTVBNZWRpYUNvbnRyb2xzVmlld0Nv bnRyb2xsZXIuaD4KICNlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgyZGJhYzVmOGY0Li45OWMwNjkwNGVjOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wMS0yNCAgRXJpYyBDYXJsc29uICA8ZXJp Yy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBTaWxlbmNlIE1lZGlhUGxheWVy IGNvbXBpbGUgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5Mzc4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc1MTg0Mjg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2VyLm1tOgorCiAyMDE5LTAxLTI0ICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBBZCBDbGljayBBdHRy aWJ1dGlvbiBhcyBhbiBpbnRlcm5hbC9leHBlcmltZW50YWwgZmVhdHVyZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2VyLm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2Vy Lm1tCmluZGV4IDNmYjRhN2MxYTVjLi4zMWY1NjA0NDIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLQWlyUGxheVJvdXRlUGlja2VyLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0FpclBsYXlSb3V0ZVBpY2tlci5tbQpA QCAtMTY1LDYgKzE2NSw4IEBAIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAogCiAj ZWxzZSAKIAorQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KKwogU09GVF9MSU5L X0ZSQU1FV09SSyhNZWRpYVBsYXllcikKIFNPRlRfTElOS19DTEFTUyhNZWRpYVBsYXllciwgTVBB VlJvdXRpbmdDb250cm9sbGVyKQogU09GVF9MSU5LX0NMQVNTKE1lZGlhUGxheWVyLCBNUE1lZGlh Q29udHJvbHNDb25maWd1cmF0aW9uKQpAQCAtMjMwLDYgKzIzMiw4IEBAIHR5cGVkZWYgTlNJbnRl Z2VyIFdLQWlyUGxheVJvdXRlUGlja2VyUm91dGVTaGFyaW5nUG9saWN5OwogCiBAZW5kCiAKK0FM TE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAorCiAjZW5kaWYKIAogI2VuZGlmIC8vIFBM QVRGT1JNKElPU19GQU1JTFkpICYmIEVOQUJMRShBSVJQTEFZX1BJQ0tFUikK