193779 2019-01-24 14:01:37 -0800 Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction() 2019-02-03 20:24:52 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ews-watchlist ggaren johnt519 koivisto webkit-bug-importer oldest_to_newest 1497942 0 cdumez 2019-01-24 14:01:37 -0800 Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction(): Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x0000000000000020) [ 0] 0x00007fff4a23502e WebKit`WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction(WebKit::WebPageProxy&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::Ref<WebKit::WebFramePolicyListenerProxy, WTF::DumbPtrTraits<WebKit::WebFramePolicyListenerProxy> >&&, API::Object*) [inlined] WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::RefPtr(WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > const&) at RefPtr.h:58:53 0x00007fff4a23501e: movq %rdx, %r15 0x00007fff4a235021: movq %rsi, %rbx 0x00007fff4a235024: movq %rdi, %r12 0x00007fff4a235027: movq 0x138(%rsi), %rax -> 0x00007fff4a23502e: movq 0x20(%rax), %r13 0x00007fff4a235032: testq %r13, %r13 0x00007fff4a235035: je 0x1c603c ; <+50> [inlined] WTF::DumbPtrTraits<API::NavigationAction>::unwrap(API::NavigationAction* const&) at Ref.h:119 0x00007fff4a235037: addl $0x2, (%r13) 0x00007fff4a23503c: movq (%r15), %rax [ 0] 0x00007fff4a23502e WebKit`WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction(WebKit::WebPageProxy&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::Ref<WebKit::WebFramePolicyListenerProxy, WTF::DumbPtrTraits<WebKit::WebFramePolicyListenerProxy> >&&, API::Object*) [inlined] WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> >::RefPtr(WTF::RefPtr<WTF::StringImpl, WTF::DumbPtrTraits<WTF::StringImpl> > const&) at RefPtr.h:58 [ 0] 0x00007fff4a23502e WebKit`WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction(WebKit::WebPageProxy&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::Ref<WebKit::WebFramePolicyListenerProxy, WTF::DumbPtrTraits<WebKit::WebFramePolicyListenerProxy> >&&, API::Object*) [inlined] WTF::String::String(WTF::String const&) at WTFString.h:129 [ 0] 0x00007fff4a23502e WebKit`WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction(WebKit::WebPageProxy&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::Ref<WebKit::WebFramePolicyListenerProxy, WTF::DumbPtrTraits<WebKit::WebFramePolicyListenerProxy> >&&, API::Object*) [inlined] WTF::String::String(WTF::String const&) at WTFString.h:129 [ 0] 0x00007fff4a23502e WebKit`WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction(WebKit::WebPageProxy&, WTF::Ref<API::NavigationAction, WTF::DumbPtrTraits<API::NavigationAction> >&&, WTF::Ref<WebKit::WebFramePolicyListenerProxy, WTF::DumbPtrTraits<WebKit::WebFramePolicyListenerProxy> >&&, API::Object*) + 36 at NavigationState.mm:490 486 487 void NavigationState::NavigationClient::decidePolicyForNavigationAction(WebPageProxy& webPageProxy, Ref<API::NavigationAction>&& navigationAction, Ref<WebFramePolicyListenerProxy>&& listener, API::Object* userInfo) 488 { 489 ASSERT(webPageProxy.mainFrame()); -> 490 String mainFrameURLString = webPageProxy.mainFrame()->url(); 491 bool subframeNavigation = navigationAction->targetFrame() && !navigationAction->targetFrame()->isMainFrame(); 492 493 if (!m_navigationState.m_navigationDelegateMethods.webViewDecidePolicyForNavigationActionDecisionHandler 494 && !m_navigationState.m_navigationDelegateMethods.webViewDecidePolicyForNavigationActionDecisionHandlerWebsitePolicies [ 1] 0x00007fff4a28ec10 WebKit`WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&) + 3212 at WebPageProxy.cpp:4327:29 4323 bool shouldOpenAppLinks = !m_shouldSuppressAppLinksInNextNavigationPolicyDecision && destinationFrameInfo->isMainFrame() && !hostsAreEqual(URL({ }, m_mainFrame->url()), request.url()) && navigationActionData.navigationType != WebCore::NavigationType::BackForward; 4324 4325 auto navigationAction = API::NavigationAction::create(WTFMove(navigationActionData), sourceFrameInfo.get(), destinationFrameInfo.ptr(), std::nullopt, WTFMove(request), originalRequest.url(), shouldOpenAppLinks, WTFMove(userInitiatedActivity), mainFrameNavigation); 4326 -> 4327 m_navigationClient->decidePolicyForNavigationAction(*this, WTFMove(navigationAction), WTFMove(listener), m_process->transformHandlesToObjects(userData.object()).get()); 4328 } 4329 4330 m_shouldSuppressAppLinksInNextNavigationPolicyDecision = false; 4331 } 1497943 1 cdumez 2019-01-24 14:01:53 -0800 <rdar://problem/46170903> 1497949 2 360036 cdumez 2019-01-24 14:05:55 -0800 Created attachment 360036 Patch 1497953 3 ews-watchlist 2019-01-24 14:09:12 -0800 Attachment 360036 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2139: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2146: Semicolon defining empty statement for this loop. Use { } instead. [whitespace/semicolon] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2164: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1498264 4 360036 cdumez 2019-01-25 08:55:40 -0800 Comment on attachment 360036 Patch ping review? 1498269 5 360036 koivisto 2019-01-25 09:06:24 -0800 Comment on attachment 360036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360036&action=review > Source/WebKit/ChangeLog:13 > + We were crashing when trying to get the URL of the main frame, which was sad because we never > + ended up using the main frame URL. Therefore, this patch drops the code in question. The best fix. 1498278 6 360036 commit-queue 2019-01-25 09:32:59 -0800 Comment on attachment 360036 Patch Clearing flags on attachment: 360036 Committed r240477: <https://trac.webkit.org/changeset/240477> 1498279 7 commit-queue 2019-01-25 09:33:00 -0800 All reviewed patches have been landed. Closing bug. 1501731 8 ap 2019-02-03 20:24:52 -0800 *** Bug 194018 has been marked as a duplicate of this bug. *** 360036 2019-01-24 14:05:55 -0800 2019-01-25 09:32:59 -0800 Patch bug-193779-20190124140554.patch text/plain 10347 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAzNGM2NTQ1Yzg5Njk2MzAx OTQzNzdiMGYyZDdlOGNhNTY5NTBkMTUuLjI0ZjdkMzVjZmE4Y2ZjZmVlYzIzZWNmODc0MmJhYjUy N2M3MjMxY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDEtMjQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKFBTT04/KSBDcmFz aCB1bmRlciBOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25DbGllbnQ6OmRlY2lkZVBvbGljeUZv ck5hdmlnYXRpb25BY3Rpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzNzc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjE3MDkwMz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW06CisgICAgICAgIChXZWJLaXQ6OnRyeUFwcExpbmsp OgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25DbGllbnQ6OmRl Y2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pOgorICAgICAgICBXZSB3ZXJlIGNyYXNoaW5n IHdoZW4gdHJ5aW5nIHRvIGdldCB0aGUgVVJMIG9mIHRoZSBtYWluIGZyYW1lLCB3aGljaCB3YXMg c2FkIGJlY2F1c2Ugd2UgbmV2ZXIKKyAgICAgICAgZW5kZWQgdXAgdXNpbmcgdGhlIG1haW4gZnJh bWUgVVJMLiBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggZHJvcHMgdGhlIGNvZGUgaW4gcXVlc3Rpb24u CisKKyAgICAgICAgKiBVSVByb2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpQcm92aXNpb25hbFBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlv bkFjdGlvbkFzeW5jKToKKyAgICAgICAgQWRkIGFzc2VydGlvbiB0byBtYWtlIHN1cmUgdGhhdCB0 aGUgRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbkFzeW5jIElQQyBpdCBpcyBnZXR0aW5n CisgICAgICAgIGZyb20gdGhlIHByb2Nlc3MgaXMgcmVsYXRlZCB0byBpdHMgbWFpbiBmcmFtZS4K KwogMjAxOS0wMS0yNCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAg ICAgW1BTT05dIEZsYXNoIG9uIGJhY2sgbmF2aWdhdGlvbiBvbiBNYWMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQppbmRleCAyODVkNjZiNzg0 YzNiMjU4MjU0YzVlMzZjMzliZGQzNDQxNGQzM2VlLi4xZjczMmNhNjY1ODMxMTJkZTc2NzQyYmE3 NThjYjIxNDQzOTVjZDBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9OYXZpZ2F0aW9uU3RhdGUubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev TmF2aWdhdGlvblN0YXRlLm1tCkBAIC00NjQsNyArNDY0LDcgQEAgYm9vbCBOYXZpZ2F0aW9uU3Rh dGU6Ok5hdmlnYXRpb25DbGllbnQ6OndpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbShXZWJQYWdl UHJveHkKIH0KICNlbmRpZgogCi1zdGF0aWMgdm9pZCB0cnlBcHBMaW5rKFJlZjxBUEk6Ok5hdmln YXRpb25BY3Rpb24+JiYgbmF2aWdhdGlvbkFjdGlvbiwgY29uc3QgU3RyaW5nJiBjdXJyZW50TWFp bkZyYW1lVVJMLCBXVEY6OkZ1bmN0aW9uPHZvaWQoYm9vbCk+JiYgY29tcGxldGlvbkhhbmRsZXIp CitzdGF0aWMgdm9pZCB0cnlBcHBMaW5rKFJlZjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+JiYgbmF2 aWdhdGlvbkFjdGlvbiwgV1RGOjpGdW5jdGlvbjx2b2lkKGJvb2wpPiYmIGNvbXBsZXRpb25IYW5k bGVyKQogewogI2lmIEhBVkUoQVBQX0xJTktTKQogICAgIGlmICghbmF2aWdhdGlvbkFjdGlvbi0+ c2hvdWxkT3BlbkFwcExpbmtzKCkpIHsKQEAgLTQ4Niw4ICs0ODYsNiBAQCBzdGF0aWMgdm9pZCB0 cnlBcHBMaW5rKFJlZjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+JiYgbmF2aWdhdGlvbkFjdGlvbiwg Y29uc3QgU3RyaQogCiB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6ZGVj aWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihXZWJQYWdlUHJveHkmIHdlYlBhZ2VQcm94eSwg UmVmPEFQSTo6TmF2aWdhdGlvbkFjdGlvbj4mJiBuYXZpZ2F0aW9uQWN0aW9uLCBSZWY8V2ViRnJh bWVQb2xpY3lMaXN0ZW5lclByb3h5PiYmIGxpc3RlbmVyLCBBUEk6Ok9iamVjdCogdXNlckluZm8p CiB7Ci0gICAgQVNTRVJUKHdlYlBhZ2VQcm94eS5tYWluRnJhbWUoKSk7Ci0gICAgU3RyaW5nIG1h aW5GcmFtZVVSTFN0cmluZyA9IHdlYlBhZ2VQcm94eS5tYWluRnJhbWUoKS0+dXJsKCk7CiAgICAg Ym9vbCBzdWJmcmFtZU5hdmlnYXRpb24gPSBuYXZpZ2F0aW9uQWN0aW9uLT50YXJnZXRGcmFtZSgp ICYmICFuYXZpZ2F0aW9uQWN0aW9uLT50YXJnZXRGcmFtZSgpLT5pc01haW5GcmFtZSgpOwogCiAg ICAgaWYgKCFtX25hdmlnYXRpb25TdGF0ZS5tX25hdmlnYXRpb25EZWxlZ2F0ZU1ldGhvZHMud2Vi Vmlld0RlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb25EZWNpc2lvbkhhbmRsZXIKQEAgLTUy MSw3ICs1MTksNyBAQCB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6ZGVj aWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihXZWJQYWdlUAogI2VuZGlmCiAgICAgICAgICAg ICBsaXN0ZW5lci0+aWdub3JlKCk7CiAgICAgICAgIH07Ci0gICAgICAgIHRyeUFwcExpbmsoV1RG TW92ZShuYXZpZ2F0aW9uQWN0aW9uKSwgbWFpbkZyYW1lVVJMU3RyaW5nLCBXVEZNb3ZlKGNvbXBs ZXRpb25IYW5kbGVyKSk7CisgICAgICAgIHRyeUFwcExpbmsoV1RGTW92ZShuYXZpZ2F0aW9uQWN0 aW9uKSwgV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwogICAgICAgICByZXR1cm47CiAgICAg fQogCkBAIC01MzMsNyArNTMxLDcgQEAgdm9pZCBOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25D bGllbnQ6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV2ViUGFnZVAKICAgICAKICAg ICBhdXRvIGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVja2VyOjpjcmVhdGUobmF2 aWdhdGlvbkRlbGVnYXRlLmdldCgpLCBkZWxlZ2F0ZUhhc1dlYnNpdGVQb2xpY2llcyA/IEBzZWxl Y3Rvcihfd2ViVmlldzpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOmRlY2lzaW9uSGFu ZGxlcjopIDogQHNlbGVjdG9yKHdlYlZpZXc6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlv bjpkZWNpc2lvbkhhbmRsZXI6KSk7CiAgICAgCi0gICAgYXV0byBkZWNpc2lvbkhhbmRsZXJXaXRo UG9saWNpZXMgPSBbbG9jYWxMaXN0ZW5lciA9IFdURk1vdmUobGlzdGVuZXIpLCBuYXZpZ2F0aW9u QWN0aW9uID0gbmF2aWdhdGlvbkFjdGlvbi5jb3B5UmVmKCksIGNoZWNrZXIgPSBXVEZNb3ZlKGNo ZWNrZXIpLCBtYWluRnJhbWVVUkxTdHJpbmcsIHdlYlBhZ2VQcm94eSA9IG1ha2VSZWYod2ViUGFn ZVByb3h5KSwgc3ViZnJhbWVOYXZpZ2F0aW9uXShXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3kgYWN0 aW9uUG9saWN5LCBfV0tXZWJzaXRlUG9saWNpZXMgKndlYnNpdGVQb2xpY2llcykgbXV0YWJsZSB7 CisgICAgYXV0byBkZWNpc2lvbkhhbmRsZXJXaXRoUG9saWNpZXMgPSBbbG9jYWxMaXN0ZW5lciA9 IFdURk1vdmUobGlzdGVuZXIpLCBuYXZpZ2F0aW9uQWN0aW9uID0gbmF2aWdhdGlvbkFjdGlvbi5j b3B5UmVmKCksIGNoZWNrZXIgPSBXVEZNb3ZlKGNoZWNrZXIpLCB3ZWJQYWdlUHJveHkgPSBtYWtl UmVmKHdlYlBhZ2VQcm94eSksIHN1YmZyYW1lTmF2aWdhdGlvbl0oV0tOYXZpZ2F0aW9uQWN0aW9u UG9saWN5IGFjdGlvblBvbGljeSwgX1dLV2Vic2l0ZVBvbGljaWVzICp3ZWJzaXRlUG9saWNpZXMp IG11dGFibGUgewogICAgICAgICBpZiAoY2hlY2tlci0+Y29tcGxldGlvbkhhbmRsZXJIYXNCZWVu Q2FsbGVkKCkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIGNoZWNrZXItPmRpZENhbGxD b21wbGV0aW9uSGFuZGxlcigpOwpAQCAtNTU2LDcgKzU1NCw3IEBAIHZvaWQgTmF2aWdhdGlvblN0 YXRlOjpOYXZpZ2F0aW9uQ2xpZW50OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdl YlBhZ2VQCiAgICAgICAgIHN3aXRjaCAoYWN0aW9uUG9saWN5KSB7CiAgICAgICAgIGNhc2UgV0tO YXZpZ2F0aW9uQWN0aW9uUG9saWN5QWxsb3c6CiAgICAgICAgIGNhc2UgX1dLTmF2aWdhdGlvbkFj dGlvblBvbGljeUFsbG93SW5OZXdQcm9jZXNzOgotICAgICAgICAgICAgdHJ5QXBwTGluayhXVEZN b3ZlKG5hdmlnYXRpb25BY3Rpb24pLCBtYWluRnJhbWVVUkxTdHJpbmcsIFthY3Rpb25Qb2xpY3ks IGxvY2FsTGlzdGVuZXIgPSBXVEZNb3ZlKGxvY2FsTGlzdGVuZXIpLCB3ZWJzaXRlUG9saWNpZXMg PSBXVEZNb3ZlKGFwaVdlYnNpdGVQb2xpY2llcyldKGJvb2wgZm9sbG93ZWRMaW5rVG9BcHApIG11 dGFibGUgeworICAgICAgICAgICAgdHJ5QXBwTGluayhXVEZNb3ZlKG5hdmlnYXRpb25BY3Rpb24p LCBbYWN0aW9uUG9saWN5LCBsb2NhbExpc3RlbmVyID0gV1RGTW92ZShsb2NhbExpc3RlbmVyKSwg d2Vic2l0ZVBvbGljaWVzID0gV1RGTW92ZShhcGlXZWJzaXRlUG9saWNpZXMpXShib29sIGZvbGxv d2VkTGlua1RvQXBwKSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICBpZiAoZm9sbG93ZWRMaW5r VG9BcHApIHsKICAgICAgICAgICAgICAgICAgICAgbG9jYWxMaXN0ZW5lci0+aWdub3JlKCk7CiAg ICAgICAgICAgICAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1Byb3Zpc2lvbmFsUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1Byb3Zpc2lvbmFsUGFnZVByb3h5LmNwcAppbmRleCBlMGZjNThiODFmODljOGY1NDFkMDBhZWI2 MWMzYzliYzk1YWM2YWIxLi44ZDQ0ODI5Y2RhMTQ2ZmYxYTI5NTMyYzc0M2Y3NmY3OGIyMWM3ZWZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHku Y3BwCkBAIC0yNjQsNiArMjY0LDggQEAgdm9pZCBQcm92aXNpb25hbFBhZ2VQcm94eTo6ZGlkQ2hh bmdlUHJvdmlzaW9uYWxVUkxGb3JGcmFtZSh1aW50NjRfdCBmcmFtZUlELCB1aW4KIAogdm9pZCBQ cm92aXNpb25hbFBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbkFzeW5j KHVpbnQ2NF90IGZyYW1lSUQsIFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luRGF0YSYmIGZyYW1lU2Vj dXJpdHlPcmlnaW4sIHVpbnQ2NF90IG5hdmlnYXRpb25JRCwgTmF2aWdhdGlvbkFjdGlvbkRhdGEm JiBuYXZpZ2F0aW9uQWN0aW9uRGF0YSwgRnJhbWVJbmZvRGF0YSYmIGZyYW1lSW5mb0RhdGEsIHVp bnQ2NF90IG9yaWdpbmF0aW5nUGFnZUlELCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Qm IG9yaWdpbmFsUmVxdWVzdCwgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwgSVBD OjpGb3JtRGF0YVJlZmVyZW5jZSYmIHJlcXVlc3RCb2R5LCBXZWJDb3JlOjpSZXNvdXJjZVJlc3Bv bnNlJiYgcmVkaXJlY3RSZXNwb25zZSwgY29uc3QgVXNlckRhdGEmIHVzZXJEYXRhLCB1aW50NjRf dCBsaXN0ZW5lcklEKQogeworICAgIEFTU0VSVChtX21haW5GcmFtZSk7CisgICAgQVNTRVJUKG1f bWFpbkZyYW1lLT5mcmFtZUlEKCkgPT0gZnJhbWVJRCk7CiAgICAgbV9wYWdlLmRlY2lkZVBvbGlj eUZvck5hdmlnYXRpb25BY3Rpb25Bc3luY1NoYXJlZChtX3Byb2Nlc3MuY29weVJlZigpLCBmcmFt ZUlELCBXVEZNb3ZlKGZyYW1lU2VjdXJpdHlPcmlnaW4pLCBuYXZpZ2F0aW9uSUQsIFdURk1vdmUo bmF2aWdhdGlvbkFjdGlvbkRhdGEpLCBXVEZNb3ZlKGZyYW1lSW5mb0RhdGEpLCBvcmlnaW5hdGlu Z1BhZ2VJRCwgb3JpZ2luYWxSZXF1ZXN0LCBXVEZNb3ZlKHJlcXVlc3QpLCBXVEZNb3ZlKHJlcXVl c3RCb2R5KSwgV1RGTW92ZShyZWRpcmVjdFJlc3BvbnNlKSwgdXNlckRhdGEsIGxpc3RlbmVySUQp OwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggMTMwNzNjNWNmMDQyYTgxMzcyYjk5ZDg0YzgzMWUxNjVjOTQxNzNkNC4uNGRhZGUzODViZjcy YTI4ZTczMjhhZTI1YjAxOGY3ZDM3ZTZkYmQ5MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihQU09OPykg Q3Jhc2ggdW5kZXIgTmF2aWdhdGlvblN0YXRlOjpOYXZpZ2F0aW9uQ2xpZW50OjpkZWNpZGVQb2xp Y3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Mzc3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDYxNzA5MDM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEFQ SSB0ZXN0IHRoYXQgcXVpY2tseSBuYXZpZ2F0ZXMgZm9yd2FyZCB0byBhIHByZXZpb3VzIHByb2Nl c3Mgd2l0aG91dCB3YWl0aW5nIGZvciBpdCB0bworICAgICAgICBzdXNwZW5kLiBJIHN1c3BlY3Qg dGhlIGNyYXNoIGNvdWxkIGhhdmUgYmVlbiBoYXBwZW5pbmcgZHVlIHRvIHJlY2VpdmluZyBsZWZ0 b3ZlciBJUEMgZnJvbQorICAgICAgICB0aGUgcHJvY2VzcycgcHJldmlvdXMgcGFnZSB3aGVuIHJl Y29ubmVjdGluZyB0aGUgaXQgZm9yIHRoZSBmb3J3YXJkIG5hdmlnYXRpb24uCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9u Lm1tOgorCiAyMDE5LTAxLTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBbUFNPTl0gRmxhc2ggb24gYmFjayBuYXZpZ2F0aW9uIG9uIE1hYwpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2 aWdhdGlvbi5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vz c1N3YXBPbk5hdmlnYXRpb24ubW0KaW5kZXggMmUxYjRkMmI3ODAzMWI0MDg5Y2JjZDBmNmVjM2I4 ZTcwODZhMWM1Ni4uYzE2NjE4NzliZWEyYWFiY2E5ZDk5MTdmMjg2NTgzNmU1MzkwODYyOCAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dh cE9uTmF2aWdhdGlvbi5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCkBAIC0yMTM2LDYgKzIxMzYsNzUgQEAgVEVT VChQcm9jZXNzU3dhcCwgSGlzdG9yeUl0ZW1JRENvbmZ1c2lvbikKICAgICBFWFBFQ1RfV0tfU1RS RVEoQCJwc29uOi8vd3d3Lmdvb2dsZS5jb20vbWFpbi5odG1sIiwgW2JhY2tGb3J3YXJkTGlzdC5m b3J3YXJkTGlzdFsxXS5VUkwgYWJzb2x1dGVTdHJpbmddKTsKIH0KIAorc3RhdGljIGNvbnN0IGNo YXIqIGtlZXBOYXZpZ2F0aW5nRnJhbWVCeXRlcyA9IFIiUFNPTlJFU09VUkNFKAorPGJvZHk+Cis8 aWZyYW1lIGlkPSJ0ZXN0RnJhbWUxIiBzcmM9ImFib3V0OmJsYW5rIj48L2lmcmFtZT4KKzxpZnJh bWUgaWQ9InRlc3RGcmFtZTIiIHNyYz0iYWJvdXQ6YmxhbmsiPjwvaWZyYW1lPgorPGlmcmFtZSBp ZD0idGVzdEZyYW1lMyIgc3JjPSJhYm91dDpibGFuayI+PC9pZnJhbWU+Cis8c2NyaXB0Pgord2lu ZG93LmFkZEV2ZW50TGlzdGVuZXIoJ3BhZ2VoaWRlJywgZnVuY3Rpb24oZXZlbnQpIHsKKyAgICBm b3IgKHZhciBqID0gMDsgaiA8IDEwMDAwOyBqKyspOworfSk7CisKK3ZhciBpID0gMDsKK2Z1bmN0 aW9uIG5hdmlnYXRlRnJhbWVzKCkKK3sKKyAgICB0ZXN0RnJhbWUxLnNyYyA9ICJwc29uOi8vd3d3 Lmdvb2dsZS5jb20vbWFpbiIgKyBpICsgIi5odG1sIjsKKyAgICB0ZXN0RnJhbWUyLnNyYyA9ICJw c29uOi8vd3d3Lmdvb2dsZS5jb20vbWFpbiIgKyBpICsgIi5odG1sIjsKKyAgICB0ZXN0RnJhbWUz LnNyYyA9ICJwc29uOi8vd3d3Lmdvb2dsZS5jb20vbWFpbiIgKyBpICsgIi5odG1sIjsKKyAgICBp Kys7Cit9CisKK25hdmlnYXRlRnJhbWVzKCk7CitzZXRJbnRlcnZhbCgoKSA9PiB7CisgICAgbmF2 aWdhdGVGcmFtZXMoKTsKK30sIDApOworPC9zY3JpcHQ+Cis8L2JvZHk+CispUFNPTlJFU09VUkNF IjsKKworVEVTVChQcm9jZXNzU3dhcCwgUmV1c2VTdXNwZW5kZWRQcm9jZXNzRm9yUmVndWxhck5h dmlnYXRpb24pCit7CisgICAgYXV0byBwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24gPSBhZG9wdE5T KFtbX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CisgICAgW3Byb2Nl c3NQb29sQ29uZmlndXJhdGlvbiBzZXRQcm9jZXNzU3dhcHNPbk5hdmlnYXRpb246WUVTXTsKKyAg ICBhdXRvIHByb2Nlc3NQb29sID0gYWRvcHROUyhbW1dLUHJvY2Vzc1Bvb2wgYWxsb2NdIF9pbml0 V2l0aENvbmZpZ3VyYXRpb246cHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmdldCgpXSk7CisKKyAg ICBhdXRvIHdlYlZpZXdDb25maWd1cmF0aW9uID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3Vy YXRpb24gYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlld0NvbmZpZ3VyYXRpb24gc2V0UHJvY2Vz c1Bvb2w6cHJvY2Vzc1Bvb2wuZ2V0KCldOworICAgIGF1dG8gaGFuZGxlciA9IGFkb3B0TlMoW1tQ U09OU2NoZW1lIGFsbG9jXSBpbml0XSk7CisgICAgW2hhbmRsZXIgYWRkTWFwcGluZ0Zyb21VUkxT dHJpbmc6QCJwc29uOi8vd3d3LndlYmtpdC5vcmcvbWFpbjEuaHRtbCIgdG9EYXRhOmtlZXBOYXZp Z2F0aW5nRnJhbWVCeXRlc107CisgICAgW3dlYlZpZXdDb25maWd1cmF0aW9uIHNldFVSTFNjaGVt ZUhhbmRsZXI6aGFuZGxlci5nZXQoKSBmb3JVUkxTY2hlbWU6QCJQU09OIl07CisKKyAgICBhdXRv IHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFr ZVJlY3QoMCwgMCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246d2ViVmlld0NvbmZpZ3VyYXRpb24u Z2V0KCldKTsKKyAgICBhdXRvIGRlbGVnYXRlID0gYWRvcHROUyhbW1BTT05OYXZpZ2F0aW9uRGVs ZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXROYXZpZ2F0aW9uRGVsZWdhdGU6 ZGVsZWdhdGUuZ2V0KCldOworCisgICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVx dWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAInBzb246Ly93d3cud2Vi a2l0Lm9yZy9tYWluMS5odG1sIl1dOworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3Rd OworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKyAgICBkb25lID0gZmFs c2U7CisKKyAgICBhdXRvIHdlYmtpdFBJRCA9IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmll cl07CisKKyAgICByZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwg VVJMV2l0aFN0cmluZzpAInBzb246Ly93d3cuYXBwbGUuY29tL21haW4uaHRtbCJdXTsKKyAgICBb d2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKKworICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6 OnJ1bigmZG9uZSk7CisgICAgZG9uZSA9IGZhbHNlOworCisgICAgYXV0byBhcHBsZVBJRCA9IFt3 ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl07CisgICAgRVhQRUNUX05FKHdlYmtpdFBJRCwg YXBwbGVQSUQpOworCisgICAgcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6 W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJwc29uOi8vd3d3LndlYmtpdC5vcmcvbWFpbjIuaHRtbCJd XTsKKyAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKKworICAgIFRlc3RXZWJLaXRB UEk6OlV0aWw6OnJ1bigmZG9uZSk7CisgICAgZG9uZSA9IGZhbHNlOworCisgICAgRVhQRUNUX0VR KHdlYmtpdFBJRCwgW3dlYlZpZXcgX3dlYlByb2Nlc3NJZGVudGlmaWVyXSk7Cit9CisKIHN0YXRp YyBjb25zdCBjaGFyKiBtYWluRnJhbWVzT25seU1haW5GcmFtZSA9IFIiUFNPTlJFU09VUkNFKAog PHNjcmlwdD4KIGZ1bmN0aW9uIGxvYWRlZCgpIHsK