193760 2019-01-23 21:30:02 -0800 Change some RenderLayerCompositor functions to use references 2019-01-23 22:11:40 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1497730 0 simon.fraser 2019-01-23 21:30:02 -0800 Change some RenderLayerCompositor functions to use references 1497731 1 359992 simon.fraser 2019-01-23 21:30:32 -0800 Created attachment 359992 Patch 1497742 2 359992 commit-queue 2019-01-23 22:10:59 -0800 Comment on attachment 359992 Patch Clearing flags on attachment: 359992 Committed r240407: <https://trac.webkit.org/changeset/240407> 1497743 3 commit-queue 2019-01-23 22:11:01 -0800 All reviewed patches have been landed. Closing bug. 1497744 4 webkit-bug-importer 2019-01-23 22:11:40 -0800 <rdar://problem/47505510> 359992 2019-01-23 21:30:32 -0800 2019-01-23 22:10:59 -0800 Patch bug-193760-20190123213031.patch text/plain 6008 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY2ZTRiYmZlNGRhMDU4 MmJlODMyMzRhOTE1OWJiODFlYmEwYTM5My4uNWQwOTYzZTA4Zjk1NjEyZDBmMjUyODRhODEyYTE4 ZDEyYzQzNGRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAxLTIzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBzb21l IFJlbmRlckxheWVyQ29tcG9zaXRvciBmdW5jdGlvbnMgdG8gdXNlIHJlZmVyZW5jZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mzc2MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlcldpZGdldCog LT4gUmVuZGVyV2lkZ2V0JgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2lu Zy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUFmdGVy V2lkZ2V0UmVzaXplKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBk YXRlQ29uZmlndXJhdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0 ZUJhY2tpbmdBbmRIaWVyYXJjaHkpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVCYWNraW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29t cG9zaXRvcjo6ZnJhbWVDb250ZW50c0NvbXBvc2l0b3IpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpwYXJlbnRGcmFtZUNvbnRlbnRMYXllcnMpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaDoKKwogMjAxOS0wMS0yMyAgQmVuamFt aW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI3Njg2NDMwPiBSZXZlcnQgd29ya2Fyb3VuZCBBVlBsYXllci5zZXRNdXRlZCBidWcgb24g bWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKaW5kZXggOWNmOGM2ODY1NjBjZjY0OTdlYWMyNTE2MWNmMDNlNWExYTJjY2JmNC4uMThkZGM2 N2ZmNzg1MTcyNzY3NzZiODE5NGQ2MDVkMzU0OTdkYTAwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTYzNCw3ICs2MzQsNyBAQCB2 b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlQWZ0ZXJXaWRnZXRSZXNpemUoKQogICAgIGlm ICghaXM8UmVuZGVyV2lkZ2V0PihyZW5kZXJlcigpKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg aWYgKGF1dG8qIGlubmVyQ29tcG9zaXRvciA9IFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZnJhbWVD b250ZW50c0NvbXBvc2l0b3IoJmRvd25jYXN0PFJlbmRlcldpZGdldD4ocmVuZGVyZXIoKSkpKSB7 CisgICAgaWYgKGF1dG8qIGlubmVyQ29tcG9zaXRvciA9IFJlbmRlckxheWVyQ29tcG9zaXRvcjo6 ZnJhbWVDb250ZW50c0NvbXBvc2l0b3IoZG93bmNhc3Q8UmVuZGVyV2lkZ2V0PihyZW5kZXJlcigp KSkpIHsKICAgICAgICAgaW5uZXJDb21wb3NpdG9yLT5mcmFtZVZpZXdEaWRDaGFuZ2VTaXplKCk7 CiAgICAgICAgIGlubmVyQ29tcG9zaXRvci0+ZnJhbWVWaWV3RGlkQ2hhbmdlTG9jYXRpb24oZmxv b3JlZEludFBvaW50KGNvbnRlbnRzQm94KCkubG9jYXRpb24oKSkpOwogICAgIH0KQEAgLTc4Myw3 ICs3ODMsNyBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlQ29uZmlndXJhdGlvbigp CiAgICAgICAgIGxheWVyQ29uZmlnQ2hhbmdlZCA9IHRydWU7CiAgICAgfQogI2VuZGlmCi0gICAg aWYgKGlzPFJlbmRlcldpZGdldD4ocmVuZGVyZXIoKSkgJiYgUmVuZGVyTGF5ZXJDb21wb3NpdG9y OjpwYXJlbnRGcmFtZUNvbnRlbnRMYXllcnMoJmRvd25jYXN0PFJlbmRlcldpZGdldD4ocmVuZGVy ZXIoKSkpKSB7CisgICAgaWYgKGlzPFJlbmRlcldpZGdldD4ocmVuZGVyZXIoKSkgJiYgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjpwYXJlbnRGcmFtZUNvbnRlbnRMYXllcnMoZG93bmNhc3Q8UmVuZGVy V2lkZ2V0PihyZW5kZXJlcigpKSkpIHsKICAgICAgICAgbV9vd25pbmdMYXllci5zZXROZWVkc0Nv bXBvc2l0aW5nR2VvbWV0cnlVcGRhdGUoKTsKICAgICAgICAgbGF5ZXJDb25maWdDaGFuZ2VkID0g dHJ1ZTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuY3BwCmluZGV4IDlhNzgzZGMxNmM0NTFiM2JkM2Q0MDAzNDk1NjUwNzJkMGY4 MWM4ZDUuLjEyOTQ5ZTZiZTVmYzJkOTkzZTUyNjIzOWZmMjhmY2RiY2FlMzIzMDggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBA IC0xMTk0LDcgKzExOTQsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFj a2luZ0FuZEhpZXJhcmNoeShSZW5kZXJMYXllciYgbGF5ZXIsIFZlY3RvcgogICAgICAgICBpZiAo cmVxdWlyZURlc2NlbmRhbnRUcmF2ZXJzYWwgfHwgcmVxdWlyZXNDaGlsZFJlYnVpbGQpIHsKICAg ICAgICAgICAgIGJvb2wgcGFyZW50ZWQgPSBmYWxzZTsKICAgICAgICAgICAgIGlmIChpczxSZW5k ZXJXaWRnZXQ+KGxheWVyLnJlbmRlcmVyKCkpKQotICAgICAgICAgICAgICAgIHBhcmVudGVkID0g cGFyZW50RnJhbWVDb250ZW50TGF5ZXJzKCZkb3duY2FzdDxSZW5kZXJXaWRnZXQ+KGxheWVyLnJl bmRlcmVyKCkpKTsKKyAgICAgICAgICAgICAgICBwYXJlbnRlZCA9IHBhcmVudEZyYW1lQ29udGVu dExheWVycyhkb3duY2FzdDxSZW5kZXJXaWRnZXQ+KGxheWVyLnJlbmRlcmVyKCkpKTsKIAogICAg ICAgICAgICAgaWYgKCFwYXJlbnRlZCkKICAgICAgICAgICAgICAgICBsYXllckJhY2tpbmctPnBh cmVudEZvclN1YmxheWVycygpLT5zZXRDaGlsZHJlbihXVEZNb3ZlKGxheWVyQ2hpbGRyZW4pKTsK QEAgLTE1NTcsNyArMTU1Nyw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVC YWNraW5nKFJlbmRlckxheWVyJiBsYXllciwgUmVxdWlyZXNDb21wb3NpdGluCiAjZW5kaWYKIAog ICAgIGlmIChsYXllckNoYW5nZWQgJiYgaXM8UmVuZGVyV2lkZ2V0PihsYXllci5yZW5kZXJlcigp KSkgewotICAgICAgICBhdXRvKiBpbm5lckNvbXBvc2l0b3IgPSBmcmFtZUNvbnRlbnRzQ29tcG9z aXRvcigmZG93bmNhc3Q8UmVuZGVyV2lkZ2V0PihsYXllci5yZW5kZXJlcigpKSk7CisgICAgICAg IGF1dG8qIGlubmVyQ29tcG9zaXRvciA9IGZyYW1lQ29udGVudHNDb21wb3NpdG9yKGRvd25jYXN0 PFJlbmRlcldpZGdldD4obGF5ZXIucmVuZGVyZXIoKSkpOwogICAgICAgICBpZiAoaW5uZXJDb21w b3NpdG9yICYmIGlubmVyQ29tcG9zaXRvci0+dXNlc0NvbXBvc2l0aW5nKCkpCiAgICAgICAgICAg ICBpbm5lckNvbXBvc2l0b3ItPnVwZGF0ZVJvb3RMYXllckF0dGFjaG1lbnQoKTsKICAgICB9CkBA IC0xOTI4LDIyICsxOTI4LDIyIEBAIFN0cmluZyBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmxheWVy VHJlZUFzVGV4dChMYXllclRyZWVGbGFncyBmbGFncykKICAgICByZXR1cm4gbGF5ZXJUcmVlVGV4 dDsKIH0KIAotUmVuZGVyTGF5ZXJDb21wb3NpdG9yKiBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZy YW1lQ29udGVudHNDb21wb3NpdG9yKFJlbmRlcldpZGdldCogcmVuZGVyZXIpCitSZW5kZXJMYXll ckNvbXBvc2l0b3IqIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZnJhbWVDb250ZW50c0NvbXBvc2l0 b3IoUmVuZGVyV2lkZ2V0JiByZW5kZXJlcikKIHsKLSAgICBpZiAoYXV0byogY29udGVudERvY3Vt ZW50ID0gcmVuZGVyZXItPmZyYW1lT3duZXJFbGVtZW50KCkuY29udGVudERvY3VtZW50KCkpIHsK KyAgICBpZiAoYXV0byogY29udGVudERvY3VtZW50ID0gcmVuZGVyZXIuZnJhbWVPd25lckVsZW1l bnQoKS5jb250ZW50RG9jdW1lbnQoKSkgewogICAgICAgICBpZiAoYXV0byogdmlldyA9IGNvbnRl bnREb2N1bWVudC0+cmVuZGVyVmlldygpKQogICAgICAgICAgICAgcmV0dXJuICZ2aWV3LT5jb21w b3NpdG9yKCk7CiAgICAgfQogICAgIHJldHVybiBudWxscHRyOwogfQogCi1ib29sIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6cGFyZW50RnJhbWVDb250ZW50TGF5ZXJzKFJlbmRlcldpZGdldCogcmVu ZGVyZXIpCitib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cGFyZW50RnJhbWVDb250ZW50TGF5 ZXJzKFJlbmRlcldpZGdldCYgcmVuZGVyZXIpCiB7CiAgICAgYXV0byogaW5uZXJDb21wb3NpdG9y ID0gZnJhbWVDb250ZW50c0NvbXBvc2l0b3IocmVuZGVyZXIpOwogICAgIGlmICghaW5uZXJDb21w b3NpdG9yIHx8ICFpbm5lckNvbXBvc2l0b3ItPnVzZXNDb21wb3NpdGluZygpIHx8IGlubmVyQ29t cG9zaXRvci0+cm9vdExheWVyQXR0YWNobWVudCgpICE9IFJvb3RMYXllckF0dGFjaGVkVmlhRW5j bG9zaW5nRnJhbWUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKLSAgICBhdXRvKiBsYXll ciA9IHJlbmRlcmVyLT5sYXllcigpOworICAgIGF1dG8qIGxheWVyID0gcmVuZGVyZXIubGF5ZXIo KTsKICAgICBpZiAoIWxheWVyLT5pc0NvbXBvc2l0ZWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNl OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9y LmgKaW5kZXggZDczZmUxYjlhOThjMDhlNWQ2MzEzZWNhNmFmZTc3ZTczNjg4NzE0YS4uNzgzZmVk NzIzOWE5MzJmOGJjMGJlMzM3ZDgyZjlhMjkxODI5ZTIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMjY5LDkgKzI2OSw5IEBA IHB1YmxpYzoKICAgICAvLyB0byBrbm93IGlmIHRoZXJlIGlzIG5vbi1hZmZpbmUgY29udGVudCwg ZS5nLiBmb3IgZHJhd2luZyBpbnRvIGFuIGltYWdlLgogICAgIGJvb2wgaGFzM0RDb250ZW50KCkg Y29uc3Q7CiAgICAgCi0gICAgc3RhdGljIFJlbmRlckxheWVyQ29tcG9zaXRvciogZnJhbWVDb250 ZW50c0NvbXBvc2l0b3IoUmVuZGVyV2lkZ2V0Kik7CisgICAgc3RhdGljIFJlbmRlckxheWVyQ29t cG9zaXRvciogZnJhbWVDb250ZW50c0NvbXBvc2l0b3IoUmVuZGVyV2lkZ2V0Jik7CiAgICAgLy8g UmV0dXJuIHRydWUgaWYgdGhlIGxheWVycyBjaGFuZ2VkLgotICAgIHN0YXRpYyBib29sIHBhcmVu dEZyYW1lQ29udGVudExheWVycyhSZW5kZXJXaWRnZXQqKTsKKyAgICBzdGF0aWMgYm9vbCBwYXJl bnRGcmFtZUNvbnRlbnRMYXllcnMoUmVuZGVyV2lkZ2V0Jik7CiAKICAgICAvLyBVcGRhdGUgdGhl IGdlb21ldHJ5IG9mIHRoZSBsYXllcnMgdXNlZCBmb3IgY2xpcHBpbmcgYW5kIHNjcm9sbGluZyBp biBmcmFtZXMuCiAgICAgdm9pZCBmcmFtZVZpZXdEaWRDaGFuZ2VMb2NhdGlvbihjb25zdCBJbnRQ b2ludCYgY29udGVudHNPZmZzZXQpOwo=