193757 2019-01-23 20:28:43 -0800 REGRESSION(r240403): "Causes multiple crashes on macOS port (probably used wrong ENABLE macro)" (Requested by ddkilzer on #webkit). 2019-01-23 20:32:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 commit-queue commit-queue ddkilzer ross.kirsling webkit-bug-importer oldest_to_newest 1497712 0 commit-queue 2019-01-23 20:28:43 -0800 https://trac.webkit.org/changeset/240403 broke the build: "Causes multiple crashes on macOS port (probably used wrong ENABLE macro)" (Requested by ddkilzer on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1497713 1 359990 commit-queue 2019-01-23 20:28:47 -0800 Created attachment 359990 ROLLOUT of r240403 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1497714 2 359990 commit-queue 2019-01-23 20:31:42 -0800 Comment on attachment 359990 ROLLOUT of r240403 Clearing flags on attachment: 359990 Committed r240404: <https://trac.webkit.org/changeset/240404> 1497715 3 commit-queue 2019-01-23 20:31:44 -0800 All reviewed patches have been landed. Closing bug. 1497716 4 ddkilzer 2019-01-23 20:32:48 -0800 Note that it was WK1 tests that were crashing: <https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r240403%20(2387)/results.html> <https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r240403%20(1686)/results.html> 1497717 5 webkit-bug-importer 2019-01-23 20:32:50 -0800 <rdar://problem/47504194> 359990 2019-01-23 20:28:47 -0800 2019-01-23 20:31:42 -0800 ROLLOUT of r240403 bug-193757-20190123202847.patch text/plain 5239 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjMWI2ZjZiNGZiYWY3ZGQ3 M2M3YzU5NDA0NjcxOWFjOGYyMWRkMmUuLmM3YmIwZDIxY2E5M2VlNWE0ZmE5MjBhMGVlMDZiYmRi NTkwZjEzMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDEtMjMgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyNDA0MDMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTM3NTcKKworICAgICAgICAiQ2F1c2VzIG11bHRpcGxlIGNyYXNoZXMgb24g bWFjT1MgcG9ydCAocHJvYmFibHkgdXNlZCB3cm9uZworICAgICAgICBFTkFCTEUgbWFjcm8pIiAo UmVxdWVzdGVkIGJ5IGRka2lsemVyIG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNo YW5nZXNldDoKKworICAgICAgICAiW0N1cmxdIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciByMjQw MjkyIGFuZCBmcmllbmRzLiIKKyAgICAgICAgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzI0MDQwMworCiAyMDE5LTAxLTIzICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBbQ3VybF0gVW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIHIyNDAy OTIgYW5kIGZyaWVuZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IGM4ZTZkZDk3ODVjNzJlOGE3 NGVmNzg2ZjI3NzkzMjljNDQzMmJiODAuLjBlOGU4NjAzZTk1ZTQ0NzJkYjc3YTkxYzNjNTJlY2I1 YjZlMGVlOGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDEt MjMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgorCisgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDA0MDMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM3NTcKKworICAgICAgICAiQ2F1c2VzIG11bHRpcGxl IGNyYXNoZXMgb24gbWFjT1MgcG9ydCAocHJvYmFibHkgdXNlZCB3cm9uZworICAgICAgICBFTkFC TEUgbWFjcm8pIiAoUmVxdWVzdGVkIGJ5IGRka2lsemVyIG9uICN3ZWJraXQpLgorCisgICAgICAg IFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiW0N1cmxdIFVucmV2aWV3ZWQgYnVpbGQg Zml4IGZvciByMjQwMjkyIGFuZCBmcmllbmRzLiIKKyAgICAgICAgaHR0cHM6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzI0MDQwMworCiAyMDE5LTAxLTIzICBSb3NzIEtpcnNsaW5nICA8cm9z cy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbQ3VybF0gVW5yZXZpZXdlZCBidWlsZCBm aXggZm9yIHIyNDAyOTIgYW5kIGZyaWVuZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2N1cmwvTmV0d29ya1Byb2Nlc3NDdXJsLmNwcCBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrUHJvY2Vzc0N1cmwuY3BwCmluZGV4IDkxZmZhNDli MzdhMmJiNTA1ZTU5OWE2ZWNjMWZmZGY5ODRjMGVmNTguLmZkNWQ2ZTVlZDVmZTk2MTA2YWFjOWY5 MzMwM2YyNzFhYmFlN2NlODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY3VybC9OZXR3b3JrUHJvY2Vzc0N1cmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY3VybC9OZXR3b3JrUHJvY2Vzc0N1cmwuY3BwCkBAIC00MSw3ICs0MSw3IEBAIHZv aWQgTmV0d29ya1Byb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKGNvbnN0 IE5ldHdvcmtQcm9jZXNzQ3JlYXRpCiAKIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpOZXR3b3Jr U3RvcmFnZVNlc3Npb24+IE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybUNyZWF0ZURlZmF1bHRTdG9y YWdlU2Vzc2lvbigpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8V2ViQ29y ZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uPihQQUw6OlNlc3Npb25JRDo6ZGVmYXVsdFNlc3Npb25J RCgpLCBudWxscHRyKTsKKyAgICByZXR1cm4gc3RkOjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpOZXR3 b3JrU3RvcmFnZVNlc3Npb24+KFBBTDo6U2Vzc2lvbklEOjpkZWZhdWx0U2Vzc2lvbklEKCksIEN1 cmxDb250ZXh0OjpzaW5nbGV0b24oKSk7CiB9CiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmFsbG93 U3BlY2lmaWNIVFRQU0NlcnRpZmljYXRlRm9ySG9zdChjb25zdCBDZXJ0aWZpY2F0ZUluZm8mIGNl cnRpZmljYXRlSW5mbywgY29uc3QgU3RyaW5nJiBob3N0KQpAQCAtODgsNyArODgsNyBAQCB2b2lk IE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVByb2Nlc3NEaWRUcmFuc2l0aW9uVG9CYWNrZ3JvdW5k KCkKIAogdm9pZCBOZXR3b3JrUHJvY2Vzczo6c2V0TmV0d29ya1Byb3h5U2V0dGluZ3MoUEFMOjpT ZXNzaW9uSUQgc2Vzc2lvbklELCBXZWJDb3JlOjpDdXJsUHJveHlTZXR0aW5ncyYmIHNldHRpbmdz KQogewotICAgIGlmIChhdXRvKiBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBzdG9yYWdlU2Vzc2lv bihzZXNzaW9uSUQpKQorICAgIGlmIChhdXRvKiBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBOZXR3 b3JrU3RvcmFnZVNlc3Npb246OnN0b3JhZ2VTZXNzaW9uKHNlc3Npb25JRCkpCiAgICAgICAgIG5l dHdvcmtTdG9yYWdlU2Vzc2lvbi0+c2V0UHJveHlTZXR0aW5ncyhXVEZNb3ZlKHNldHRpbmdzKSk7 CiAgICAgZWxzZQogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXRMZWdhY3kvV2ViQ29yZVN1cHBvcnQvTmV0d29ya1N0b3JhZ2VTZXNzaW9uTWFw LmNwcCBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvV2ViQ29yZVN1cHBvcnQvTmV0d29ya1N0b3JhZ2VT ZXNzaW9uTWFwLmNwcAppbmRleCBmZGIxYjI0MTFlOTdjMmUwMTBhMmU4MzcxMzFlMmZjMTk0MDU1 NGE3Li40ZWNhMzRkNTg0MmIwY2YxYTAxYWYyYTUxNTFjMTk5MTgwNGM0M2Q4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0TGVnYWN5L1dlYkNvcmVTdXBwb3J0L05ldHdvcmtTdG9yYWdlU2Vzc2lv bk1hcC5jcHAKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9XZWJDb3JlU3VwcG9ydC9OZXR3b3Jr U3RvcmFnZVNlc3Npb25NYXAuY3BwCkBAIC01MywxOSArNTMsMTMgQEAgV2ViQ29yZTo6TmV0d29y a1N0b3JhZ2VTZXNzaW9uKiBOZXR3b3JrU3RvcmFnZVNlc3Npb25NYXA6OnN0b3JhZ2VTZXNzaW9u KGNvbnN0IFAKIAogV2ViQ29yZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBOZXR3b3JrU3RvcmFn ZVNlc3Npb25NYXA6OmRlZmF1bHRTdG9yYWdlU2Vzc2lvbigpCiB7Ci0gICAgaWYgKCFkZWZhdWx0 TmV0d29ya1N0b3JhZ2VTZXNzaW9uKCkpIHsKLSNpZiBVU0UoQ1VSTCkKLSAgICAgICAgZGVmYXVs dE5ldHdvcmtTdG9yYWdlU2Vzc2lvbigpID0gc3RkOjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpOZXR3 b3JrU3RvcmFnZVNlc3Npb24+KFBBTDo6U2Vzc2lvbklEOjpkZWZhdWx0U2Vzc2lvbklEKCksIG51 bGxwdHIpOwotI2Vsc2UKKyAgICBpZiAoIWRlZmF1bHROZXR3b3JrU3RvcmFnZVNlc3Npb24oKSkK ICAgICAgICAgZGVmYXVsdE5ldHdvcmtTdG9yYWdlU2Vzc2lvbigpID0gc3RkOjptYWtlX3VuaXF1 ZTxXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb24+KFBBTDo6U2Vzc2lvbklEOjpkZWZhdWx0 U2Vzc2lvbklEKCkpOwotI2VuZGlmCi0gICAgfQogICAgIHJldHVybiAqZGVmYXVsdE5ldHdvcmtT dG9yYWdlU2Vzc2lvbigpOwogfQogCiB2b2lkIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbk1hcDo6c3dp dGNoVG9OZXdUZXN0aW5nU2Vzc2lvbigpCiB7Ci0jaWYgVVNFKENGVVJMQ09OTkVDVElPTikKICAg ICAvLyBTZXNzaW9uIG5hbWUgc2hvdWxkIGJlIHNob3J0IGVub3VnaCBmb3Igc2hhcmVkIG1lbW9y eSByZWdpb24gbmFtZSB0byBiZSB1bmRlciB0aGUgbGltaXQsIG90ZWhyd2lzZSBzYW5kYm94IHJ1 bGVzIHdvbid0IHdvcmsgKHNlZSA8cmRhcjovL3Byb2JsZW0vMTM2NDI4NTI+KS4KICAgICBTdHJp bmcgc2Vzc2lvbk5hbWUgPSBTdHJpbmc6OmZvcm1hdCgiV2ViS2l0IFRlc3QtJXUiLCBzdGF0aWNf Y2FzdDx1aW50MzJfdD4oZ2V0Q3VycmVudFByb2Nlc3NJRCgpKSk7CiAKQEAgLTc5LDEyICs3Mywx MCBAQCB2b2lkIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbk1hcDo6c3dpdGNoVG9OZXdUZXN0aW5nU2Vz c2lvbigpCiAgICAgfQogCiAgICAgZGVmYXVsdE5ldHdvcmtTdG9yYWdlU2Vzc2lvbigpID0gc3Rk OjptYWtlX3VuaXF1ZTxXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb24+KFBBTDo6U2Vzc2lv bklEOjpkZWZhdWx0U2Vzc2lvbklEKCksIFdURk1vdmUoc2Vzc2lvbiksIFdURk1vdmUoY29va2ll U3RvcmFnZSkpOwotI2VuZGlmCiB9CiAKIHZvaWQgTmV0d29ya1N0b3JhZ2VTZXNzaW9uTWFwOjpl bnN1cmVTZXNzaW9uKGNvbnN0IFBBTDo6U2Vzc2lvbklEJiBzZXNzaW9uSUQsIGNvbnN0IFN0cmlu ZyYgaWRlbnRpZmllckJhc2UpCiB7Ci0jaWYgVVNFKENGVVJMQ09OTkVDVElPTikKICAgICBhdXRv IGFkZFJlc3VsdCA9IGdsb2JhbFNlc3Npb25NYXAoKS5hZGQoc2Vzc2lvbklELCBudWxscHRyKTsK ICAgICBpZiAoIWFkZFJlc3VsdC5pc05ld0VudHJ5KQogICAgICAgICByZXR1cm47CkBAIC0xMDUs NyArOTcsNiBAQCB2b2lkIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbk1hcDo6ZW5zdXJlU2Vzc2lvbihj b25zdCBQQUw6OlNlc3Npb25JRCYgc2Vzc2lvbklELCBjbwogICAgIH0KIAogICAgIGFkZFJlc3Vs dC5pdGVyYXRvci0+dmFsdWUgPSBzdGQ6Om1ha2VfdW5pcXVlPFdlYkNvcmU6Ok5ldHdvcmtTdG9y YWdlU2Vzc2lvbj4oc2Vzc2lvbklELCBXVEZNb3ZlKHN0b3JhZ2VTZXNzaW9uKSwgV1RGTW92ZShj b29raWVTdG9yYWdlKSk7Ci0jZW5kaWYKIH0KIAogdm9pZCBOZXR3b3JrU3RvcmFnZVNlc3Npb25N YXA6OmRlc3Ryb3lTZXNzaW9uKGNvbnN0IFBBTDo6U2Vzc2lvbklEJiBzZXNzaW9uSUQpCg==