193750 2019-01-23 16:56:17 -0800 check-webkit-style should warn when using soft-linking macros in a header 2019-01-27 11:02:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193815 https://bugs.webkit.org/show_bug.cgi?id=193866 https://bugs.webkit.org/show_bug.cgi?id=193868 https://bugs.webkit.org/show_bug.cgi?id=193884 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen ap commit-queue darin ddkilzer ews-watchlist glenn lforschler thorton webkit-bug-importer oldest_to_newest 1497658 0 ddkilzer 2019-01-23 16:56:17 -0800 check-webkit-style should warn when using soft-linking macros in a header. Using the soft-linking macros in a header will lead to code being compiled in every translation unit (source file) that the header is included in, which is usually not what the author intends, and leads to duplicate code. Example output on pre-existing files: $ ./Tools/Scripts/check-webkit-style -f '-,+softlink/header' Source/WebCore/PAL ERROR: Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h:65: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:109: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:110: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h:38: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/mac/LookupSPI.h:33: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:34: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h:32: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] ERROR: Source/WebCore/PAL/pal/spi/cocoa/RevealSPI.h:33: Never soft-link frameworks in headers since this results in duplicate code in each source file where it is included. [softlink/header] [5] Total errors found: 8 in 176 files 1497667 1 359977 ddkilzer 2019-01-23 17:40:33 -0800 Created attachment 359977 Patch v1 1497694 2 359977 commit-queue 2019-01-23 18:47:58 -0800 Comment on attachment 359977 Patch v1 Clearing flags on attachment: 359977 Committed r240402: <https://trac.webkit.org/changeset/240402> 1497695 3 commit-queue 2019-01-23 18:48:00 -0800 All reviewed patches have been landed. Closing bug. 1497696 4 webkit-bug-importer 2019-01-23 18:48:28 -0800 <rdar://problem/47502698> 359977 2019-01-23 17:40:33 -0800 2019-01-23 18:47:58 -0800 Patch v1 bug-193750-20190123174032.patch text/plain 8427 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODg1MmFjYTliYmQ2MGJmNDNkMjJkYmVkOWU3MDU2OGQz ZTY2MTk3YS4uYWIyZGJmZmRiNjVmZTU0MGFmZmQ0NjU5YTRhZDI0Mjk4YTkwOTVmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE5LTAxLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCB3YXJuIHdoZW4gdXNpbmcgc29mdC1saW5r aW5nIG1hY3JvcyBpbiBhIGhlYWRlcgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTkz NzUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19s YW5ndWFnZSk6IEFkZCBzb2Z0bGluay9oZWFkZXIgY2hlY2sgYnkgcmVmYWN0b3JpbmcgdGhlCisg ICAgICAgIHNvZnRsaW5rL2ZyYW1ld29yayBjaGVjay4KKyAgICAgICAgKENwcENoZWNrZXIpOiBF bmFibGUgc29mdGxpbmsvaGVhZGVyIGNoZWNrIGJ5IGRlZmF1bHQuCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChDcHBT dHlsZVRlc3QudGVzdF9zb2Z0bGlua19mcmFtZXdvcmspOiBSZW5hbWUgZnJvbQorICAgICAgICBD cHBTdHlsZVRlc3QudGVzdF9zb2Z0bGluaygpIGFuZCBjaGFuZ2UgdGVzdCBmcmFtZXdvcmsgbmFt ZSBpbgorICAgICAgICBjYXNlIEFWRm91bmRhdGlvbiBnZXRzIGl0cyBvd24gQVZGb3VuZGF0aW9u U29mdExpbmsue2gsbW19CisgICAgICAgIGZpbGVzLiBTZXQgZmlsZV9uYW1lIGZvciBtYWNyb3Mg dGhhdCBvbmx5IGFwcGVhciBpbiBoZWFkZXJzLgorICAgICAgICAoQ3BwU3R5bGVUZXN0LnRlc3Rf c29mdGxpbmtfaGVhZGVyKTogQWRkIHRlc3RzIGZvciB1c2luZworICAgICAgICBzb2Z0LWxpbmsg bWFjcm9zIGluIGhlYWRlcnMuCisKIDIwMTgtMTItMDcgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KIAogICAgICAgICBJZ25vcmUgZmFsc2UtcG9zaXRpdmUgbGVha3MgdW5kZXIg Ym1hbGxvYzo6SGVhcDo6SGVhcApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQppbmRleCBiZTM3M2NmOGE4OWVlNDQ5ZDk3OTc2MDc5YTM2MmE0MjQ4NmYxMmFm Li44YjBhOGRjMTdmNTU0YmJjNWM2YTNjNzk0MjQwYzRiODVjYTJhYjdjIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzMzMiwxMSArMzMzMiwx NSBAQCBkZWYgY2hlY2tfbGFuZ3VhZ2UoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZmlsZV9leHRlbnNpb24sIGluY2x1ZGVfcwogICAgICAgICAgICAgICAgICAgICAgICAgICAn UmV0YWluUHRyPD4gc2hvdWxkIG5ldmVyIGNvbnRhaW4gYSB0eXBlIHdpdGggXCcqXCcuIENvcnJl Y3Q6IFJldGFpblB0cjxOU1N0cmluZz4sIFJldGFpblB0cjxDRlN0cmluZ1JlZj4uJykKICAgICAg ICAgICAgICAgICBicmVhawogCi0gICAgZnJhbWV3b3Jrc193aXRoX3NvZnRfbGlua3MgPSBbJ0Nv cmVNZWRpYScsICdDb3JlVmlkZW8nLCAnRGF0YURldGVjdG9yc0NvcmUnLCAnTWVkaWFBY2Nlc3Np YmlsaXR5JywgJ01lZGlhUmVtb3RlJywgJ1Bhc3NLaXQnLCAnUXVpY2tMb29rJywgJ1VJS2l0Jywg J1ZpZGVvVG9vbGJveCddCi0gICAgbWF0Y2hlZCA9IHJlLmNvbXBpbGUoJ15ccypTT0ZUX0xJTktf RlJBTUVXT1JLLipcKCh7fSlcKScuZm9ybWF0KCd8Jy5qb2luKGZyYW1ld29ya3Nfd2l0aF9zb2Z0 X2xpbmtzKSkpLnNlYXJjaChsaW5lKQorICAgIG1hdGNoZWQgPSByZS5jb21waWxlKCdeXHMqU09G VF9MSU5LXyhQUklWQVRFXyk/RlJBTUVXT1JLLipcKChcUyspXCknKS5zZWFyY2gobGluZSkKICAg ICBpZiBtYXRjaGVkOgotICAgICAgICBmcmFtZXdvcmtfbmFtZSA9IG1hdGNoZWQuZ3JvdXAoMSkK LSAgICAgICAgaWYgbm90IHJlLmNvbXBpbGUoJ15ccypTT0ZUX0xJTktfRlJBTUVXT1JLX0ZPUl8o SEVBREVSfFNPVVJDRSkoX1dJVEhfRVhQT1JUKT9cKHt9XCknLmZvcm1hdChmcmFtZXdvcmtfbmFt ZSkpLnNlYXJjaChsaW5lKToKKyAgICAgICAgZnJhbWV3b3JrX25hbWUgPSBtYXRjaGVkLmdyb3Vw KDIpCisgICAgICAgIGlmIGZpbGVfZXh0ZW5zaW9uID09ICdoJyBhbmQgbm90IHNlYXJjaChyJ15c cypTT0ZUX0xJTktfKFBSSVZBVEVfKT9GUkFNRVdPUktfRk9SX0hFQURFUi4qXCgnLCBsaW5lKToK KyAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnc29mdGxpbmsvaGVhZGVyJywgNSwKKyAg ICAgICAgICAgICAgICAgICdOZXZlciBzb2Z0LWxpbmsgZnJhbWV3b3JrcyBpbiBoZWFkZXJzLiBQ dXQgdGhlIHNvZnQtbGluayBtYWNyb3MgaW4gYSBzb3VyY2UgZmlsZSwgb3IgY3JlYXRlIHtmcmFt ZXdvcmt9U29mdExpbmsue3tjcHAsbW19fSBpbnN0ZWFkLicuZm9ybWF0KGZyYW1ld29yaz1mcmFt ZXdvcmtfbmFtZSkpCisKKyAgICAgICAgZnJhbWV3b3Jrc193aXRoX3NvZnRfbGlua3MgPSBbJ0Nv cmVNZWRpYScsICdDb3JlVmlkZW8nLCAnRGF0YURldGVjdG9yc0NvcmUnLCAnTWVkaWFBY2Nlc3Np YmlsaXR5JywgJ01lZGlhUmVtb3RlJywgJ1Bhc3NLaXQnLCAnUXVpY2tMb29rJywgJ1VJS2l0Jywg J1ZpZGVvVG9vbGJveCddCisgICAgICAgIGlmIGZyYW1ld29ya19uYW1lIGluIGZyYW1ld29ya3Nf d2l0aF9zb2Z0X2xpbmtzIGFuZCBub3QgcmUuY29tcGlsZSgnXlxzKlNPRlRfTElOS18oUFJJVkFU RV8pP0ZSQU1FV09SS19GT1JfKEhFQURFUnxTT1VSQ0UpKF9XSVRIX0VYUE9SVCk/XCh7fVwpJy5m b3JtYXQoZnJhbWV3b3JrX25hbWUpKS5zZWFyY2gobGluZSk6CiAgICAgICAgICAgICBlcnJvcihs aW5lX251bWJlciwgJ3NvZnRsaW5rL2ZyYW1ld29yaycsIDUsCiAgICAgICAgICAgICAgICAgICAn VXNlIHtmcmFtZXdvcmt9U29mdExpbmsue3tjcHAsaCxtbX19IHRvIHNvZnQtbGluayB0byB7ZnJh bWV3b3JrfS5mcmFtZXdvcmsuJy5mb3JtYXQoZnJhbWV3b3JrPWZyYW1ld29ya19uYW1lKSkKIApA QCAtNDA5Myw2ICs0MDk3LDcgQEAgY2xhc3MgQ3BwQ2hlY2tlcihvYmplY3QpOgogICAgICAgICAn c2VjdXJpdHkvcHJpbnRmJywKICAgICAgICAgJ3NlY3VyaXR5L3RlbXBfZmlsZScsCiAgICAgICAg ICdzb2Z0bGluay9mcmFtZXdvcmsnLAorICAgICAgICAnc29mdGxpbmsvaGVhZGVyJywKICAgICAg ICAgJ3doaXRlc3BhY2UvYmxhbmtfbGluZScsCiAgICAgICAgICd3aGl0ZXNwYWNlL2JyYWNlcycs CiAgICAgICAgICd3aGl0ZXNwYWNlL2JyYWNrZXRzJywKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNzhmMmYxZGM0 OTViMzE2MTIxOTg2OWQzODAzMDgxZWY2MjIxNTRmNi4uZTE0NGQ3OTNhZTgyNGZmNTFjODgyYjkz OGU5MGI5Y2E5MzhlYmUwMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTE2ODgsMjQgKzE2ODgsMzUgQEAgY2xh c3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJyAgW3J1bnRp bWUvcmV0YWlucHRyXSBbNV0nKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCcnJ1JldGFpblB0 cjxOU0RpY3Rpb25hcnk8TlNTdHJpbmcgKiwgTlNBcnJheTxOU1N0cmluZyAqPj4+IGRpY3Rpb25h cnk7JycnLCAnJykKIAotICAgIGRlZiB0ZXN0X3NvZnRsaW5rKHNlbGYpOgorICAgIGRlZiB0ZXN0 X3NvZnRsaW5rX2ZyYW1ld29yayhzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKLSAg ICAgICAgICAgICcnJ1NPRlRfTElOS19GUkFNRVdPUksoQVZGb3VuZGF0aW9uKScnJywKKyAgICAg ICAgICAgICcnJ1NPRlRfTElOS19GUkFNRVdPUksoRm91bmRhdGlvbiknJycsCiAgICAgICAgICAg ICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKLSAgICAgICAgICAgICcnJ1NPRlRfTElO S19GUkFNRVdPUktfT1BUSU9OQUwoQVZGb3VuZGF0aW9uKScnJywKKyAgICAgICAgICAgICcnJ1NP RlRfTElOS19GUkFNRVdPUktfT1BUSU9OQUwoRm91bmRhdGlvbiknJycsCiAgICAgICAgICAgICAn JykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKLSAgICAgICAgICAgICcnJ1NPRlRfTElOS19G UkFNRVdPUktfT1BUSU9OQUxfUFJFRkxJR0hUKEFWRm91bmRhdGlvbiknJycsCisgICAgICAgICAg ICAnJydTT0ZUX0xJTktfRlJBTUVXT1JLX09QVElPTkFMX1BSRUZMSUdIVChGb3VuZGF0aW9uKScn JywKICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAotICAgICAgICAg ICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19GT1JfSEVBREVSKEFWRm91bmRhdGlvbiknJycsCisg ICAgICAgICAgICAnJydTT0ZUX0xJTktfRlJBTUVXT1JLX0ZPUl9IRUFERVIoRm91bmRhdGlvbikn JycsCisgICAgICAgICAgICAnJywKKyAgICAgICAgICAgICBmaWxlX25hbWU9J2Zvby5oJykKKyAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICcnJ1NPRlRfTElOS19GUkFNRVdP UktfRk9SX1NPVVJDRShGb3VuZGF0aW9uKScnJywKICAgICAgICAgICAgICcnKQogICAgICAgICBz ZWxmLmFzc2VydF9saW50KAotICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19GT1Jf U09VUkNFKEFWRm91bmRhdGlvbiknJycsCisgICAgICAgICAgICAnJydTT0ZUX0xJTktfRlJBTUVX T1JLX0ZPUl9TT1VSQ0VfV0lUSF9FWFBPUlQoRm91bmRhdGlvbiknJycsCiAgICAgICAgICAgICAn JykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKLSAgICAgICAgICAgICcnJ1NPRlRfTElOS19G UkFNRVdPUktfRk9SX1NPVVJDRV9XSVRIX0VYUE9SVChBVkZvdW5kYXRpb24pJycnLAorICAgICAg ICAgICAgJycnU09GVF9MSU5LX1BSSVZBVEVfRlJBTUVXT1JLX0ZPUl9IRUFERVIoRm91bmRhdGlv biknJycsCisgICAgICAgICAgICAnJywKKyAgICAgICAgICAgICBmaWxlX25hbWU9J2Zvby5oJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICcnJ1NPRlRfTElOS19QUklW QVRFX0ZSQU1FV09SS19GT1JfU09VUkNFKEZvdW5kYXRpb24pJycnLAorICAgICAgICAgICAgJycp CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnJydTT0ZUX0xJTktfUFJJ VkFURV9GUkFNRVdPUktfRk9SX1NPVVJDRV9XSVRIX0VYUE9SVChGb3VuZGF0aW9uKScnJywKICAg ICAgICAgICAgICcnKQogCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCkBAIC0xNzIyLDcgKzE3 MzMsOCBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAg ICAnICBbc29mdGxpbmsvZnJhbWV3b3JrXSBbNV0nKQogICAgICAgICBzZWxmLmFzc2VydF9saW50 KAogICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19GT1JfSEVBREVSKFVJS2l0KScn JywKLSAgICAgICAgICAgICcnKQorICAgICAgICAgICAgJycsCisgICAgICAgICAgICAgZmlsZV9u YW1lPSdmb28uaCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAnJydT T0ZUX0xJTktfRlJBTUVXT1JLX0ZPUl9TT1VSQ0UoVUlLaXQpJycnLAogICAgICAgICAgICAgJycp CkBAIC0xNzMwLDYgKzE3NDIsNDMgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJh c2UpOgogICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19GT1JfU09VUkNFX1dJVEhf RVhQT1JUKFVJS2l0KScnJywKICAgICAgICAgICAgICcnKQogCisgICAgZGVmIHRlc3Rfc29mdGxp bmtfaGVhZGVyKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAg JycnU09GVF9MSU5LX0ZSQU1FV09SSyhNeUZyYW1ld29yayknJycsCisgICAgICAgICAgICAnTmV2 ZXIgc29mdC1saW5rIGZyYW1ld29ya3MgaW4gaGVhZGVycy4gUHV0IHRoZSBzb2Z0LWxpbmsgbWFj cm9zIGluIGEgc291cmNlIGZpbGUsIG9yIGNyZWF0ZSBNeUZyYW1ld29ya1NvZnRMaW5rLntjcHAs bW19IGluc3RlYWQuJworICAgICAgICAgICAgJyAgW3NvZnRsaW5rL2hlYWRlcl0gWzVdJywKKyAg ICAgICAgICAgIGZpbGVfbmFtZT0nZm9vLmgnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KAor ICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19PUFRJT05BTChNeUZyYW1ld29yaykn JycsCisgICAgICAgICAgICAnTmV2ZXIgc29mdC1saW5rIGZyYW1ld29ya3MgaW4gaGVhZGVycy4g UHV0IHRoZSBzb2Z0LWxpbmsgbWFjcm9zIGluIGEgc291cmNlIGZpbGUsIG9yIGNyZWF0ZSBNeUZy YW1ld29ya1NvZnRMaW5rLntjcHAsbW19IGluc3RlYWQuJworICAgICAgICAgICAgJyAgW3NvZnRs aW5rL2hlYWRlcl0gWzVdJywKKyAgICAgICAgICAgIGZpbGVfbmFtZT0nZm9vLmgnKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19P UFRJT05BTF9QUkVGTElHSFQoTXlGcmFtZXdvcmspJycnLAorICAgICAgICAgICAgJ05ldmVyIHNv ZnQtbGluayBmcmFtZXdvcmtzIGluIGhlYWRlcnMuIFB1dCB0aGUgc29mdC1saW5rIG1hY3JvcyBp biBhIHNvdXJjZSBmaWxlLCBvciBjcmVhdGUgTXlGcmFtZXdvcmtTb2Z0TGluay57Y3BwLG1tfSBp bnN0ZWFkLicKKyAgICAgICAgICAgICcgIFtzb2Z0bGluay9oZWFkZXJdIFs1XScsCisgICAgICAg ICAgICBmaWxlX25hbWU9J2Zvby5oJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAg ICAgICAgICcnJ1NPRlRfTElOS19QUklWQVRFX0ZSQU1FV09SSyhNeVByaXZhdGVGcmFtZXdvcmsp JycnLAorICAgICAgICAgICAgJ05ldmVyIHNvZnQtbGluayBmcmFtZXdvcmtzIGluIGhlYWRlcnMu IFB1dCB0aGUgc29mdC1saW5rIG1hY3JvcyBpbiBhIHNvdXJjZSBmaWxlLCBvciBjcmVhdGUgTXlQ cml2YXRlRnJhbWV3b3JrU29mdExpbmsue2NwcCxtbX0gaW5zdGVhZC4nCisgICAgICAgICAgICAn ICBbc29mdGxpbmsvaGVhZGVyXSBbNV0nLAorICAgICAgICAgICAgZmlsZV9uYW1lPSdmb28uaCcp CisKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICcnJ1NPRlRfTElOS19G UkFNRVdPUktfRk9SX0hFQURFUihNeUZyYW1ld29yayknJycsCisgICAgICAgICAgICAnJywKKyAg ICAgICAgICAgIGZpbGVfbmFtZT0nZm9vLmgnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KAor ICAgICAgICAgICAgJycnU09GVF9MSU5LX0ZSQU1FV09SS19GT1JfU09VUkNFKE15RnJhbWV3b3Jr KScnJywKKyAgICAgICAgICAgICdOZXZlciBzb2Z0LWxpbmsgZnJhbWV3b3JrcyBpbiBoZWFkZXJz LiBQdXQgdGhlIHNvZnQtbGluayBtYWNyb3MgaW4gYSBzb3VyY2UgZmlsZSwgb3IgY3JlYXRlIE15 RnJhbWV3b3JrU29mdExpbmsue2NwcCxtbX0gaW5zdGVhZC4nCisgICAgICAgICAgICAnICBbc29m dGxpbmsvaGVhZGVyXSBbNV0nLAorICAgICAgICAgICAgZmlsZV9uYW1lPSdmb28uaCcpCisgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnJydTT0ZUX0xJTktfRlJBTUVXT1JL X0ZPUl9TT1VSQ0VfV0lUSF9FWFBPUlQoTXlGcmFtZXdvcmspJycnLAorICAgICAgICAgICAgJ05l dmVyIHNvZnQtbGluayBmcmFtZXdvcmtzIGluIGhlYWRlcnMuIFB1dCB0aGUgc29mdC1saW5rIG1h Y3JvcyBpbiBhIHNvdXJjZSBmaWxlLCBvciBjcmVhdGUgTXlGcmFtZXdvcmtTb2Z0TGluay57Y3Bw LG1tfSBpbnN0ZWFkLicKKyAgICAgICAgICAgICcgIFtzb2Z0bGluay9oZWFkZXJdIFs1XScsCisg ICAgICAgICAgICBmaWxlX25hbWU9J2Zvby5oJykKKwogICAgICMgVmFyaWFibGUtbGVuZ3RoIGFy cmF5cyBhcmUgbm90IHBlcm1pdHRlZC4KICAgICBkZWYgdGVzdF92YXJpYWJsZV9sZW5ndGhfYXJy YXlfZGV0ZWN0aW9uKHNlbGYpOgogICAgICAgICBlcnJtc2cgPSAoJ0RvIG5vdCB1c2UgdmFyaWFi bGUtbGVuZ3RoIGFycmF5cy4gIFVzZSBhbiBhcHByb3ByaWF0ZWx5IG5hbWVkICcK