193745 2019-01-23 16:11:46 -0800 [iOS] Enable media element volume on iPad 2019-01-24 07:31:09 -0800 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble jonlee webkit-bug-importer oldest_to_newest 1497634 0 eric.carlson 2019-01-23 16:11:46 -0800 Enable media element volume on iPad 1497635 1 eric.carlson 2019-01-23 16:12:17 -0800 <rdar://problem/47452297> 1497638 2 359969 eric.carlson 2019-01-23 16:20:55 -0800 Created attachment 359969 Patch 1497645 3 359969 jonlee 2019-01-23 16:29:12 -0800 Comment on attachment 359969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359969&action=review > Source/WebCore/html/HTMLMediaElement.cpp:5341 > + Why shouldn't this be preserved if not iPad? 1497804 4 359969 commit-queue 2019-01-24 07:31:07 -0800 Comment on attachment 359969 Patch Clearing flags on attachment: 359969 Committed r240434: <https://trac.webkit.org/changeset/240434> 1497805 5 commit-queue 2019-01-24 07:31:09 -0800 All reviewed patches have been landed. Closing bug. 359969 2019-01-23 16:20:55 -0800 2019-01-24 07:31:07 -0800 Patch bug-193745-20190123162053.patch text/plain 4983 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzNhOTI4YzdiNzk1OWMz ZjIxYTBlYmZlNGNhMzlkNWJmODZkYmNkMC4uYWZkZDczODZhZWE4YjQyMmE4YzIxNDkwMTEzY2Jj YzAyODdiY2Q2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTIzICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEVuYWJs ZSBtZWRpYSBlbGVtZW50IHZvbHVtZSBvbiBpUGFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM3NDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3 NDUyMjk3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRp YUVsZW1lbnQ6OnNldFZvbHVtZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 OjptZWRpYVBsYXllclZvbHVtZUNoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6dXBkYXRlVm9sdW1lKToKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW06Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpzZXRW b2x1bWUpOgorCiAyMDE5LTAxLTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBBbm90aGVyIGF0dGVtcHQgdG8gZml4IHRoZSBpT1MgYnVpbGQgZm9sbG93aW5n IDxodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjQwMTc0PgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMTgwYzQzZDE1ODk2OTVkOTY2ZGUwOTAz ZTlkZTJiMmM0NTE4YzMwZi4uOTFiMGYwZDY1M2U5NzgwNjUzMjNhM2RjNmI2ZmNiNWU2YzRjYTlh NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0zNzEyLDcg KzM3MTIsMTEgQEAgRXhjZXB0aW9uT3I8dm9pZD4gSFRNTE1lZGlhRWxlbWVudDo6c2V0Vm9sdW1l KGRvdWJsZSB2b2x1bWUpCiAgICAgaWYgKCEodm9sdW1lID49IDAgJiYgdm9sdW1lIDw9IDEpKQog ICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSW5kZXhTaXplRXJyb3IgfTsKIAotI2lmICFQTEFU Rk9STShJT1NfRkFNSUxZKQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgaWYgKCFwcm9j ZXNzaW5nVXNlckdlc3R1cmVGb3JNZWRpYSgpKQorICAgICAgICByZXR1cm4geyB9OworI2VuZGlm CisKICAgICBpZiAobV92b2x1bWUgPT0gdm9sdW1lKQogICAgICAgICByZXR1cm4geyB9OwogCkBA IC0zNzI4LDcgKzM3MzIsNyBAQCBFeGNlcHRpb25Pcjx2b2lkPiBIVE1MTWVkaWFFbGVtZW50Ojpz ZXRWb2x1bWUoZG91YmxlIHZvbHVtZSkKICAgICAgICAgcGF1c2VJbnRlcm5hbCgpOwogICAgICAg ICBzZXRBdXRvcGxheUV2ZW50UGxheWJhY2tTdGF0ZShBdXRvcGxheUV2ZW50UGxheWJhY2tTdGF0 ZTo6UHJldmVudGVkQXV0b3BsYXkpOwogICAgIH0KLSNlbmRpZgorCiAgICAgcmV0dXJuIHsgfTsK IH0KIApAQCAtNDkxOSw5ICs0OTIzLDkgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjptZWRpYVBs YXllclZvbHVtZUNoYW5nZWQoTWVkaWFQbGF5ZXIqKQogCiAgICAgYmVnaW5Qcm9jZXNzaW5nTWVk aWFQbGF5ZXJDYWxsYmFjaygpOwogICAgIGlmIChtX3BsYXllcikgewotICAgICAgICBkb3VibGUg dm9sID0gbV9wbGF5ZXItPnZvbHVtZSgpOwotICAgICAgICBpZiAodm9sICE9IG1fdm9sdW1lKSB7 Ci0gICAgICAgICAgICBtX3ZvbHVtZSA9IHZvbDsKKyAgICAgICAgZG91YmxlIHZvbHVtZSA9IG1f cGxheWVyLT52b2x1bWUoKTsKKyAgICAgICAgaWYgKHZvbHVtZSAhPSBtX3ZvbHVtZSkgeworICAg ICAgICAgICAgbV92b2x1bWUgPSB2b2x1bWU7CiAgICAgICAgICAgICB1cGRhdGVWb2x1bWUoKTsK ICAgICAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLnZvbHVtZWNoYW5nZUV2ZW50 KTsKICAgICAgICAgfQpAQCAtNTMzNCwxNCArNTMzOCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVu dDo6dXBkYXRlVm9sdW1lKCkKIHsKICAgICBpZiAoIW1fcGxheWVyKQogICAgICAgICByZXR1cm47 Ci0jaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICAvLyBPbmx5IHRoZSB1c2VyIGNhbiBjaGFu Z2UgYXVkaW8gdm9sdW1lIHNvIHVwZGF0ZSB0aGUgY2FjaGVkIHZvbHVtZSBhbmQgcG9zdCB0aGUg Y2hhbmdlZCBldmVudC4KLSAgICBmbG9hdCB2b2x1bWUgPSBtX3BsYXllci0+dm9sdW1lKCk7Ci0g ICAgaWYgKG1fdm9sdW1lICE9IHZvbHVtZSkgewotICAgICAgICBtX3ZvbHVtZSA9IHZvbHVtZTsK LSAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkudm9sdW1lY2hhbmdlRXZlbnQpOwot ICAgIH0KLSNlbHNlCisKICAgICAvLyBBdm9pZCByZWN1cnNpb24gd2hlbiB0aGUgcGxheWVyIHJl cG9ydHMgdm9sdW1lIGNoYW5nZXMuCiAgICAgaWYgKCFwcm9jZXNzaW5nTWVkaWFQbGF5ZXJDYWxs YmFjaygpKSB7CiAgICAgICAgIFBhZ2UqIHBhZ2UgPSBkb2N1bWVudCgpLnBhZ2UoKTsKQEAgLTUz NzAsNyArNTM2Nyw2IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlVm9sdW1lKCkKIAog ICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpCiAgICAgICAgIG1lZGlhQ29udHJvbHMoKS0+Y2hh bmdlZFZvbHVtZSgpOwotI2VuZGlmCiB9CiAKIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2NoZWR1 bGVVcGRhdGVQbGF5U3RhdGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u T2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9v YmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KaW5kZXggNzU4YzVjNDhm MmQzYmE0OGE2YWU3ZWIzOWI0YzM2M2Y2ZTJiNzg3NC4uNGE3MzU0M2Q1ZTlhZjIxYmRiZTEwYjFj MmI0ZjMxZGM1ZGIyNjg5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24v b2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC0zMDUsNyArMzA1 LDYgQEAgU09GVF9MSU5LX09QVElPTkFMKE1lZGlhVG9vbGJveCwgTVRFbmFibGVDYXB0aW9uMjAx NUJlaGF2aW9yLCBCb29sZWFuLCAoKSwgKCkpCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKIAog I2lmIEhBVkUoQ0VMRVNUSUFMKQotCiBTT0ZUX0xJTktfUFJJVkFURV9GUkFNRVdPUksoQ2VsZXN0 aWFsKQogU09GVF9MSU5LX0NPTlNUQU5UKENlbGVzdGlhbCwgQVZDb250cm9sbGVyX1JvdXRlRGVz Y3JpcHRpb25LZXlfUm91dGVDdXJyZW50bHlQaWNrZWQsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktf Q09OU1RBTlQoQ2VsZXN0aWFsLCBBVkNvbnRyb2xsZXJfUm91dGVEZXNjcmlwdGlvbktleV9Sb3V0 ZU5hbWUsIE5TU3RyaW5nICopCkBAIC0zMTMsNyArMzEyLDYgQEAgU09GVF9MSU5LX0NPTlNUQU5U KENlbGVzdGlhbCwgQVZDb250cm9sbGVyX1JvdXRlRGVzY3JpcHRpb25LZXlfQVZBdWRpb1JvdXRl TmFtZSwKICNkZWZpbmUgQVZDb250cm9sbGVyX1JvdXRlRGVzY3JpcHRpb25LZXlfUm91dGVDdXJy ZW50bHlQaWNrZWQgZ2V0QVZDb250cm9sbGVyX1JvdXRlRGVzY3JpcHRpb25LZXlfUm91dGVDdXJy ZW50bHlQaWNrZWQoKQogI2RlZmluZSBBVkNvbnRyb2xsZXJfUm91dGVEZXNjcmlwdGlvbktleV9S b3V0ZU5hbWUgZ2V0QVZDb250cm9sbGVyX1JvdXRlRGVzY3JpcHRpb25LZXlfUm91dGVOYW1lKCkK ICNkZWZpbmUgQVZDb250cm9sbGVyX1JvdXRlRGVzY3JpcHRpb25LZXlfQVZBdWRpb1JvdXRlTmFt ZSBnZXRBVkNvbnRyb2xsZXJfUm91dGVEZXNjcmlwdGlvbktleV9BVkF1ZGlvUm91dGVOYW1lKCkK LQogI2VuZGlmIC8vIEhBVkUoQ0VMRVNUSUFMKQogCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZB TUlMWSkKQEAgLTEzODIsMTQgKzEzODAsMTQgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb25PYmpDOjpzZWVrVG9UaW1lKGNvbnN0IE1lZGlhVGltZSYgdGltZSwgY29uc3QKIHZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6c2V0Vm9sdW1lKGZsb2F0IHZv bHVtZSkKIHsKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIFVOVVNFRF9QQVJBTSh2b2x1 bWUpOwotICAgIHJldHVybjsKLSNlbHNlCisgICAgaWYgKFtbUEFMOjpnZXRVSURldmljZUNsYXNz KCkgY3VycmVudERldmljZV0gdXNlckludGVyZmFjZUlkaW9tXSAhPSBVSVVzZXJJbnRlcmZhY2VJ ZGlvbVBhZCkKKyAgICAgICAgcmV0dXJuOworI2VuZGlmCisKICAgICBpZiAoIW1fYXZQbGF5ZXIp CiAgICAgICAgIHJldHVybjsKIAogICAgIFttX2F2UGxheWVyLmdldCgpIHNldFZvbHVtZTp2b2x1 bWVdOwotI2VuZGlmCiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qzo6c2V0TXV0ZWQoYm9vbCBtdXRlZCkK