193744 2019-01-23 16:08:58 -0800 ARM64E should not ENABLE(SEPARATED_WX_HEAP). 2019-01-23 17:18:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo dbates ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1497632 0 mark.lam 2019-01-23 16:08:58 -0800 <rdar://problem/46262952> 1497636 1 359968 mark.lam 2019-01-23 16:12:29 -0800 Created attachment 359968 proposed patch. 1497665 2 mark.lam 2019-01-23 17:18:43 -0800 Thanks for the review. Landed in r240370: <http://trac.webkit.org/r240370>. 359968 2019-01-23 16:12:29 -0800 2019-01-23 16:14:27 -0800 proposed patch. bug-193744.patch text/plain 5607 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQwMzYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE5LTAxLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB Uk02NEUgc2hvdWxkIG5vdCBFTkFCTEUoU0VQQVJBVEVEX1dYX0hFQVApLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNzQ0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NjI2Mjk1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGFzc2VtYmxlci9MaW5rQnVmZmVyLmNwcDoKKyAgICAgICAgKEpTQzo6 TGlua0J1ZmZlcjo6Y29weUNvbXBhY3RBbmRMaW5rQ29kZSk6CisKIDIwMTktMDEtMjMgIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBEdXBsaWNhdGUg Z2xvYmFsIHZhcmlhYmxlczogSlNDOjpvcGNvZGVMZW5ndGhzCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAJKHJldmlzaW9uIDI0MDM2MykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEyLTIwMTgg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyLTIw MTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICog bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCkBAIC00MSwxMCArNDEsNiBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAotI2lmIEVO QUJMRShTRVBBUkFURURfV1hfSEVBUCkKLWV4dGVybiBKU19FWFBPUlRfUFJJVkFURSBib29sIHVz ZUZhc3RQZXJtaXNpb25zSklUQ29weTsKLSNlbmRpZiAvLyBFTkFCTEUoU0VQQVJBVEVEX1dYX0hF QVApCi0KIGJvb2wgc2hvdWxkRHVtcERpc2Fzc2VtYmx5Rm9yKENvZGVCbG9jayogY29kZUJsb2Nr KQogewogICAgIGlmIChjb2RlQmxvY2sgJiYgSklUQ29kZTo6aXNPcHRpbWl6aW5nSklUKGNvZGVC bG9jay0+aml0VHlwZSgpKSAmJiBPcHRpb25zOjpkdW1wREZHRGlzYXNzZW1ibHkoKSkKQEAgLTEy MCwxNCArMTE2LDYgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdm9pZCByZWNvcmRMaW5rT2Zmcwog dGVtcGxhdGUgPHR5cGVuYW1lIEluc3RydWN0aW9uVHlwZT4KIHZvaWQgTGlua0J1ZmZlcjo6Y29w eUNvbXBhY3RBbmRMaW5rQ29kZShNYWNyb0Fzc2VtYmxlciYgbWFjcm9Bc3NlbWJsZXIsIHZvaWQq IG93bmVyVUlELCBKSVRDb21waWxhdGlvbkVmZm9ydCBlZmZvcnQpCiB7Ci0jaWYgQ1BVKEFSTTY0 RSkgJiYgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKQotI2lmIEVOQUJMRShTRVBBUkFURURf V1hfSEVBUCkKLSAgICBjb25zdCBib29sIGlzVXNpbmdGYXN0UGVybWlzc2lvbnNKSVRDb3B5ID0g dXNlRmFzdFBlcm1pc2lvbnNKSVRDb3B5OwotI2Vsc2UKLSAgICBjb25zdCBib29sIGlzVXNpbmdG YXN0UGVybWlzc2lvbnNKSVRDb3B5ID0gdHJ1ZTsKLSNlbmRpZgotI2VuZGlmCi0KICAgICBhbGxv Y2F0ZShtYWNyb0Fzc2VtYmxlciwgb3duZXJVSUQsIGVmZm9ydCk7CiAgICAgY29uc3Qgc2l6ZV90 IGluaXRpYWxTaXplID0gbWFjcm9Bc3NlbWJsZXIubV9hc3NlbWJsZXIuY29kZVNpemUoKTsKICAg ICBpZiAoZGlkRmFpbFRvQWxsb2NhdGUoKSkKQEAgLTE0MiwxMSArMTMwLDYgQEAgdm9pZCBMaW5r QnVmZmVyOjpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKAogICAgIGNvbnN0IHVpbnQzMl90IGV4cGVj dGVkRmluYWxIYXNoID0gbWFjcm9Bc3NlbWJsZXIubV9hc3NlbWJsZXIuYnVmZmVyKCkuaGFzaCgp LmZpbmFsSGFzaCgpOwogICAgIEFSTTY0RUhhc2ggdmVyaWZ5VW5jb21wYWN0ZWRIYXNoOwogICAg IHVpbnQ4X3QqIG91dERhdGEgPSBjb2RlT3V0RGF0YTsKLSNpZiBFTkFCTEUoU0VQQVJBVEVEX1dY X0hFQVApCi0gICAgQXNzZW1ibGVyRGF0YSBvdXRCdWZmZXIobV9zaXplKTsKLSAgICBpZiAoIWlz VXNpbmdGYXN0UGVybWlzc2lvbnNKSVRDb3B5KQotICAgICAgICBvdXREYXRhID0gcmVpbnRlcnBy ZXRfY2FzdDx1aW50OF90Kj4ob3V0QnVmZmVyLmJ1ZmZlcigpKTsKLSNlbmRpZiAvLyBFTkFCTEUo U0VQQVJBVEVEX1dYX0hFQVApCiAjZWxzZQogICAgIEFzc2VtYmxlckRhdGEgb3V0QnVmZmVyKG1f c2l6ZSk7CiAgICAgdWludDhfdCogb3V0RGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+ KG91dEJ1ZmZlci5idWZmZXIoKSk7CkBAIC0xNjEsOCArMTQ0LDcgQEAgdm9pZCBMaW5rQnVmZmVy Ojpjb3B5Q29tcGFjdEFuZExpbmtDb2RlKAogICAgIHVuc2lnbmVkIGp1bXBDb3VudCA9IGp1bXBz VG9MaW5rLnNpemUoKTsKIAogI2lmIENQVShBUk02NEUpICYmIEVOQUJMRShGQVNUX0pJVF9QRVJN SVNTSU9OUykKLSAgICBpZiAoaXNVc2luZ0Zhc3RQZXJtaXNzaW9uc0pJVENvcHkpCi0gICAgICAg IG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19ydygpOworICAgIG9zX3RocmVhZF9zZWxm X3Jlc3RyaWN0X3J3eF90b19ydygpOwogI2VuZGlmCiAKICAgICBpZiAobV9zaG91bGRQZXJmb3Jt QnJhbmNoQ29tcGFjdGlvbikgewpAQCAtMjQ5LDggKzIzMSw2IEBAIHZvaWQgTGlua0J1ZmZlcjo6 Y29weUNvbXBhY3RBbmRMaW5rQ29kZSgKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwganVt cENvdW50OyArK2kpIHsKICNpZiBDUFUoQVJNNjRFKSAmJiBFTkFCTEUoRkFTVF9KSVRfUEVSTUlT U0lPTlMpCiAgICAgICAgIGF1dG8gbWVtY3B5RnVuY3Rpb24gPSBtZW1jcHk7Ci0gICAgICAgIGlm ICghaXNVc2luZ0Zhc3RQZXJtaXNzaW9uc0pJVENvcHkpCi0gICAgICAgICAgICBtZW1jcHlGdW5j dGlvbiA9IHBlcmZvcm1KSVRNZW1jcHk7CiAjZWxzZQogICAgICAgICBhdXRvIG1lbWNweUZ1bmN0 aW9uID0gcGVyZm9ybUpJVE1lbWNweTsKICNlbmRpZgpAQCAtMjY3LDggKzI0Nyw3IEBAIHZvaWQg TGlua0J1ZmZlcjo6Y29weUNvbXBhY3RBbmRMaW5rQ29kZSgKICAgICB9CiAKICNpZiBDUFUoQVJN NjRFKSAmJiBFTkFCTEUoRkFTVF9KSVRfUEVSTUlTU0lPTlMpCi0gICAgaWYgKGlzVXNpbmdGYXN0 UGVybWlzc2lvbnNKSVRDb3B5KQotICAgICAgICBvc190aHJlYWRfc2VsZl9yZXN0cmljdF9yd3hf dG9fcngoKTsKKyAgICBvc190aHJlYWRfc2VsZl9yZXN0cmljdF9yd3hfdG9fcngoKTsKICNlbmRp ZgogCiAgICAgaWYgKG1fZXhlY3V0YWJsZU1lbW9yeSkgewpAQCAtMjgwLDEyICsyNTksNyBAQCB2 b2lkIExpbmtCdWZmZXI6OmNvcHlDb21wYWN0QW5kTGlua0NvZGUoCiAgICAgQVNTRVJUKGNvZGVP dXREYXRhICE9IG91dERhdGEpOwogICAgIHBlcmZvcm1KSVRNZW1jcHkoY29kZU91dERhdGEsIG91 dERhdGEsIG1fc2l6ZSk7CiAjZWxzZQotICAgIGlmIChpc1VzaW5nRmFzdFBlcm1pc3Npb25zSklU Q29weSkKLSAgICAgICAgQVNTRVJUKGNvZGVPdXREYXRhID09IG91dERhdGEpOwotICAgIGVsc2Ug ewotICAgICAgICBBU1NFUlQoY29kZU91dERhdGEgIT0gb3V0RGF0YSk7Ci0gICAgICAgIHBlcmZv cm1KSVRNZW1jcHkoY29kZU91dERhdGEsIG91dERhdGEsIG1fc2l6ZSk7Ci0gICAgfQorICAgIEFT U0VSVChjb2RlT3V0RGF0YSA9PSBvdXREYXRhKTsKICNlbmRpZgogCiAgICAganVtcHNUb0xpbmsu Y2xlYXIoKTsKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDAzNjMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTIzICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBBUk02NEUgc2hvdWxkIG5vdCBFTkFCTEUo U0VQQVJBVEVEX1dYX0hFQVApLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzNzQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjI2Mjk1Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0 Zm9ybS5oOgorCiAyMDE5LTAxLTIzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CiAKICAgICAgICAgU3dpdGNoIHJlbWFpbmluZyBDb3JlTWVkaWEgc29mdC1saW5raW5nIGluIFdl YktpdCBvdmVyIHRvIENvcmVNZWRpYVNvZnRMaW5rLntjcHAsaH0KSW5kZXg6IFNvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAko cmV2aXNpb24gMjQwMzYzKQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBj b3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDYtMjAxOCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDYtMjAxOSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDctMjAw OSBUb3JjaCBNb2JpbGUsIEluYy4KICAqIENvcHlyaWdodCAoQykgMjAxMCwgMjAxMSBSZXNlYXJj aCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCkBAIC05NTgsMTMg Kzk1OCwxMSBAQAogI2RlZmluZSBKSVRfT1BFUkFUSU9OCiAjZW5kaWYKIAotI2lmbmRlZiBFTkFC TEVfU0VQQVJBVEVEX1dYX0hFQVAKLSNpZiAoIUVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykg fHwgIUNQVShBUk02NEUpKSAmJiBQTEFURk9STShJT1NfRkFNSUxZKSAmJiBDUFUoQVJNNjQpCisj aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgQ1BVKEFSTTY0KSAmJiAoIUVOQUJMRShGQVNUX0pJ VF9QRVJNSVNTSU9OUykgfHwgIUNQVShBUk02NEUpKQogI2RlZmluZSBFTkFCTEVfU0VQQVJBVEVE X1dYX0hFQVAgMQogI2Vsc2UKICNkZWZpbmUgRU5BQkxFX1NFUEFSQVRFRF9XWF9IRUFQIDAKICNl bmRpZgotI2VuZGlmCiAKIC8qIENvbmZpZ3VyZSB0aGUgaW50ZXJwcmV0ZXIgKi8KICNpZiBDT01Q SUxFUihHQ0NfQ09NUEFUSUJMRSkK