193743 2019-01-23 15:52:37 -0800 Web Inspector: Audit: remove experimental setting 2019-01-25 13:49:10 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1497625 0 hi 2019-01-23 15:52:37 -0800 Turn the Audit tab on by default \(0.0)/ 1497626 1 hi 2019-01-23 15:52:46 -0800 <rdar://problem/28234022> 1497629 2 359967 hi 2019-01-23 16:03:47 -0800 Created attachment 359967 Patch 1497631 3 hi 2019-01-23 16:07:23 -0800 Should we do anything for the situation where the user had already opened WebInspector? In that case, they'd already have a list of open tabs, and we wouldn't add the Audit tab to that list (it's only in the `defaultValue` list). If so, that would probably mean adding another semi-permanent setting 😅 that gets set when we force-add the Audit tab (so it only get's added once and won't reappear if the user then removes it themselves). 1498109 4 359967 joepeck 2019-01-24 19:33:35 -0800 Comment on attachment 359967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359967&action=review > Source/WebInspectorUI/ChangeLog:13 > + (WI.Setting.migrateValue): > + Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`. This should really be done separately, since you aren't using it here the drive-by is totally unrelated. > Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js:-53 > - static isTabAllowed() > - { > - return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value; > - } I still think we will want to disable this for ServiceWorkers and JSContexts... basically only allow this for Web Pages: static isTabAllowed() { return WI.sharedApp.debuggableType === WI.DebuggableType.Web; } 1498414 5 360151 hi 2019-01-25 13:23:27 -0800 Created attachment 360151 Patch 1498433 6 360151 commit-queue 2019-01-25 13:49:08 -0800 Comment on attachment 360151 Patch Clearing flags on attachment: 360151 Committed r240502: <https://trac.webkit.org/changeset/240502> 1498434 7 commit-queue 2019-01-25 13:49:10 -0800 All reviewed patches have been landed. Closing bug. 359967 2019-01-23 16:03:47 -0800 2019-01-25 13:23:25 -0800 Patch bug-193743-20190123160346.patch text/plain 8421 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJjMDM3MWYwYzFiZjg5MjU2Y2Y2YTE5ZDI4ZTMy NzgzYmE5N2QwM2YuLjBjZDE5MDI1Y2MzNTlmNTdhNDU2NjExZDU0YzNiNmZkODk5YjM3MGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTAxLTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogcmVtb3ZlIGV4cGVyaW1lbnRhbCBzZXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM3NDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzI4MjM0MDIyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanM6CisgICAgICAgIChXSS5TZXR0aW5n KToKKyAgICAgICAgKFdJLlNldHRpbmcubG9jYWxTdG9yYWdlS2V5KTogQWRkZWQuCisgICAgICAg IChXSS5TZXR0aW5nLm1pZ3JhdGVWYWx1ZSk6CisgICAgICAgIERyaXZlLWJ5OiBhZGQgdGhlIGxv Y2FsU3RvcmFnZSBrZXkgcHJlZml4IHRvIHRoZSBrZXkgcGFzc2VkIGludG8gYFdJLlNldHRpbmcu bWlncmF0ZVZhbHVlYC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgor ICAgICAgICAoV0kubG9hZGVkKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQXVk aXRUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkF1ZGl0VGFiQ29udGVudFZpZXcuaXNU YWJBbGxvd2VkKTogRGVsZXRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2V0 dGluZ3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVudFZp ZXcucHJvdG90eXBlLl9jcmVhdGVFeHBlcmltZW50YWxTZXR0aW5nc1ZpZXcpOgorCisgICAgICAg ICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorCiAyMDE5LTAx LTIzICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJJbnNw ZWN0b3I6IENvbmZ1c2luZ2x5IG5lc3RlZCBldmVudHMgaW4gdGhlIHRpbWVsaW5lIGZvciBNdXRh dGlvbiBPYnNlcnZlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6 YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGE2YWMz YjJjYTJkNjU0NmU2ODYxNDYyNDVjYjM1MWEwM2I2NmM1ZWQuLjMyZTIxMTIyYjI5ZmJhNDlmMTNi ZDI1Mzg4ZTMzYzRlNTY1NDgwMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9M b2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpA QCAtMTMyLDcgKzEzMiw2IEBAIGxvY2FsaXplZFN0cmluZ3NbIkF0dHJpYnV0ZSBNb2RpZmllZCJd ID0gIkF0dHJpYnV0ZSBNb2RpZmllZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdHRyaWJ1dGVzIl0g PSAiQXR0cmlidXRlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdWRpdCJdID0gIkF1ZGl0IjsKIGxv Y2FsaXplZFN0cmluZ3NbIkF1ZGl0IGVycm9yOiAlcyJdID0gIkF1ZGl0IGVycm9yOiAlcyI7Ci1s b2NhbGl6ZWRTdHJpbmdzWyJBdWRpdDoiXSA9ICJBdWRpdDoiOwogbG9jYWxpemVkU3RyaW5nc1si QXVkaXRzIl0gPSAiQXVkaXRzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkF1dGhvciBTdHlsZXNoZWV0 Il0gPSAiQXV0aG9yIFN0eWxlc2hlZXQiOwogbG9jYWxpemVkU3RyaW5nc1siQXV0byBJbmNyZW1l bnQiXSA9ICJBdXRvIEluY3JlbWVudCI7CkBAIC0zNTcsNyArMzU2LDYgQEAgbG9jYWxpemVkU3Ry aW5nc1siRWxlbWVudCBpcyB0aGUgcm9vdCBlbGVtZW50Il0gPSAiRWxlbWVudCBpcyB0aGUgcm9v dCBlbGVtZW50IjsKIGxvY2FsaXplZFN0cmluZ3NbIkVsZW1lbnQgbWF5IG92ZXJsYXAgYW5vdGhl ciBjb21wb3NpdGluZyBlbGVtZW50Il0gPSAiRWxlbWVudCBtYXkgb3ZlcmxhcCBhbm90aGVyIGNv bXBvc2l0aW5nIGVsZW1lbnQiOwogbG9jYWxpemVkU3RyaW5nc1siRWxlbWVudCBvdmVybGFwcyBv dGhlciBjb21wb3NpdGluZyBlbGVtZW50Il0gPSAiRWxlbWVudCBvdmVybGFwcyBvdGhlciBjb21w b3NpdGluZyBlbGVtZW50IjsKIGxvY2FsaXplZFN0cmluZ3NbIkVsZW1lbnRzIl0gPSAiRWxlbWVu dHMiOwotbG9jYWxpemVkU3RyaW5nc1siRW5hYmxlIEF1ZGl0IFRhYiJdID0gIkVuYWJsZSBBdWRp dCBUYWIiOwogbG9jYWxpemVkU3RyaW5nc1siRW5hYmxlIEJyZWFrcG9pbnQiXSA9ICJFbmFibGUg QnJlYWtwb2ludCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbmFibGUgQnJlYWtwb2ludHMiXSA9ICJF bmFibGUgQnJlYWtwb2ludHMiOwogbG9jYWxpemVkU3RyaW5nc1siRW5hYmxlIENvbXB1dGVkIFN0 eWxlIENhc2NhZGVzIl0gPSAiRW5hYmxlIENvbXB1dGVkIFN0eWxlIENhc2NhZGVzIjsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCA4 MWIwNmRkNTAyZThhZTU3OTNjYTI2Y2MxNzQ1ZjA3ZmMyZWIzZTZhLi5lNmU3NzhhNWY0OWYyNTE0 NDFiNzljYjdiZmNkM2RlZTg3OGYwZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xNDYsNiArMTQ2LDcgQEAgV0kubG9hZGVk ID0gZnVuY3Rpb24oKQogICAgICAgICBXSS5UaW1lbGluZVRhYkNvbnRlbnRWaWV3LlR5cGUsCiAg ICAgICAgIFdJLlN0b3JhZ2VUYWJDb250ZW50Vmlldy5UeXBlLAogICAgICAgICBXSS5DYW52YXNU YWJDb250ZW50Vmlldy5UeXBlLAorICAgICAgICBXSS5BdWRpdFRhYkNvbnRlbnRWaWV3LlR5cGUs CiAgICAgICAgIFdJLkNvbnNvbGVUYWJDb250ZW50Vmlldy5UeXBlLAogICAgIF0pOwogICAgIHRo aXMuX3NlbGVjdGVkVGFiSW5kZXhTZXR0aW5nID0gbmV3IFdJLlNldHRpbmcoInNlbGVjdGVkLXRh Yi1pbmRleCIsIDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4IGM5ZDUxNDBmMTkxNDhlMTMyMGFiYjA3Y2RiZjEwN2Q5 MmNmNjg0OTkuLjE3YzY3ZTFiOGJjZjc2ZjBjOWU4YjczNzBhOTM2YTlkYzI5ODI5MDMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcu anMKQEAgLTM3LDIzICszNywzMCBAQCBXSS5TZXR0aW5nID0gY2xhc3MgU2V0dGluZyBleHRlbmRz IFdJLk9iamVjdAogCiAgICAgICAgIHRoaXMuX25hbWUgPSBuYW1lOwogCi0gICAgICAgIGxldCBp bnNwZWN0aW9uTGV2ZWwgPSBJbnNwZWN0b3JGcm9udGVuZEhvc3QgPyBJbnNwZWN0b3JGcm9udGVu ZEhvc3QuaW5zcGVjdGlvbkxldmVsKCkgOiAxOwotICAgICAgICBsZXQgbGV2ZWxTdHJpbmcgPSBp bnNwZWN0aW9uTGV2ZWwgPiAxID8gIi0iICsgaW5zcGVjdGlvbkxldmVsIDogIiI7Ci0gICAgICAg IHRoaXMuX2xvY2FsU3RvcmFnZUtleSA9IGBjb20uYXBwbGUuV2ViSW5zcGVjdG9yJHtsZXZlbFN0 cmluZ30uJHtuYW1lfWA7CisgICAgICAgIHRoaXMuX2xvY2FsU3RvcmFnZUtleSA9IFdJLlNldHRp bmcubG9jYWxTdG9yYWdlS2V5KHRoaXMuX25hbWUpOwogICAgICAgICB0aGlzLl9kZWZhdWx0VmFs dWUgPSBkZWZhdWx0VmFsdWU7CiAgICAgfQogCiAgICAgLy8gU3RhdGljCiAKKyAgICBzdGF0aWMg bG9jYWxTdG9yYWdlS2V5KG5hbWUpCisgICAgeworICAgICAgICBsZXQgaW5zcGVjdGlvbkxldmVs ID0gSW5zcGVjdG9yRnJvbnRlbmRIb3N0ID8gSW5zcGVjdG9yRnJvbnRlbmRIb3N0Lmluc3BlY3Rp b25MZXZlbCgpIDogMTsKKyAgICAgICAgbGV0IGxldmVsU3RyaW5nID0gaW5zcGVjdGlvbkxldmVs ID4gMSA/ICItIiArIGluc3BlY3Rpb25MZXZlbCA6ICIiOworICAgICAgICByZXR1cm4gYGNvbS5h cHBsZS5XZWJJbnNwZWN0b3Ike2xldmVsU3RyaW5nfS4ke25hbWV9YDsKKyAgICB9CisKICAgICBz dGF0aWMgbWlncmF0ZVZhbHVlKGtleSkKICAgICB7CisgICAgICAgIGxldCBsb2NhbFN0b3JhZ2VL ZXkgPSBXSS5TZXR0aW5nLmxvY2FsU3RvcmFnZUtleShrZXkpOworCiAgICAgICAgIGxldCB2YWx1 ZSA9IHVuZGVmaW5lZDsKLSAgICAgICAgaWYgKCF3aW5kb3cuSW5zcGVjdG9yVGVzdCAmJiB3aW5k b3cubG9jYWxTdG9yYWdlICYmIGtleSBpbiB3aW5kb3cubG9jYWxTdG9yYWdlKSB7CisgICAgICAg IGlmICghd2luZG93Lkluc3BlY3RvclRlc3QgJiYgd2luZG93LmxvY2FsU3RvcmFnZSAmJiBsb2Nh bFN0b3JhZ2VLZXkgaW4gd2luZG93LmxvY2FsU3RvcmFnZSkgewogICAgICAgICAgICAgdHJ5IHsK LSAgICAgICAgICAgICAgICB2YWx1ZSA9IEpTT04ucGFyc2Uod2luZG93LmxvY2FsU3RvcmFnZVtr ZXldKTsKKyAgICAgICAgICAgICAgICB2YWx1ZSA9IEpTT04ucGFyc2Uod2luZG93LmxvY2FsU3Rv cmFnZVtsb2NhbFN0b3JhZ2VLZXldKTsKICAgICAgICAgICAgIH0gY2F0Y2ggeyB9CiAKLSAgICAg ICAgICAgIHdpbmRvdy5sb2NhbFN0b3JhZ2UucmVtb3ZlSXRlbShrZXkpOworICAgICAgICAgICAg d2luZG93LmxvY2FsU3RvcmFnZS5yZW1vdmVJdGVtKGxvY2FsU3RvcmFnZUtleSk7CiAgICAgICAg IH0KICAgICAgICAgcmV0dXJuIHZhbHVlOwogICAgIH0KQEAgLTE0OCw3ICsxNTUsNiBAQCBXSS5z ZXR0aW5ncyA9IHsKICAgICBleHBlcmltZW50YWxFbmFibGVDb21wdXRlZFN0eWxlQ2FzY2FkZXM6 IG5ldyBXSS5TZXR0aW5nKCJleHBlcmltZW50YWwtZW5hYmxlLWNvbXB1dGVkLXN0eWxlLWNhc2Nh ZGVzIiwgZmFsc2UpLAogICAgIGV4cGVyaW1lbnRhbEVuYWJsZUxheWVyc1RhYjogbmV3IFdJLlNl dHRpbmcoImV4cGVyaW1lbnRhbC1lbmFibGUtbGF5ZXJzLXRhYiIsIGZhbHNlKSwKICAgICBleHBl cmltZW50YWxFbmFibGVOZXdUYWJCYXI6IG5ldyBXSS5TZXR0aW5nKCJleHBlcmltZW50YWwtZW5h YmxlLW5ldy10YWItYmFyIiwgZmFsc2UpLAotICAgIGV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFi OiBuZXcgV0kuU2V0dGluZygiZXhwZXJpbWVudGFsLWVuYWJsZS1hdWRpdC10YWIiLCBmYWxzZSks CiAKICAgICAvLyBEZWJ1Z1VJCiAgICAgYXV0b0xvZ1Byb3RvY29sTWVzc2FnZXM6IG5ldyBXSS5T ZXR0aW5nKCJhdXRvLWNvbGxlY3QtcHJvdG9jb2wtbWVzc2FnZXMiLCBmYWxzZSksCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRhYkNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv QXVkaXRUYWJDb250ZW50Vmlldy5qcwppbmRleCA4YzQyMjY4MjNjMTRhNDY3ODg3NzViODVlYzZj Y2RiZjMzMzNkYWM2Li5kNTk2YTRkYWQ5YzQ4NzY4ZDhhNjkzYWRmNDAwMDE3OGRmNjYyODdjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRp dFRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0F1ZGl0VGFiQ29udGVudFZpZXcuanMKQEAgLTQ3LDExICs0Nyw2IEBAIFdJLkF1 ZGl0VGFiQ29udGVudFZpZXcgPSBjbGFzcyBBdWRpdFRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0ku Q29udGVudEJyb3dzZXJUYWJDCiAgICAgICAgIH07CiAgICAgfQogCi0gICAgc3RhdGljIGlzVGFi QWxsb3dlZCgpCi0gICAgewotICAgICAgICByZXR1cm4gISF3aW5kb3cuUnVudGltZUFnZW50ICYm IFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiLnZhbHVlOwotICAgIH0KLQog ICAgIC8vIFB1YmxpYwogCiAgICAgZ2V0IHR5cGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29u dGVudFZpZXcuanMKaW5kZXggZDEyM2RjMDBiNzVjNmU5NmRmZTQ0MTVlNzI3NDI3NGFlYjFhODJl MS4uZjVmODE1YjJhNDE4MWVhMGNjMGIzY2FjNTJiZjliMzU1ZDJmMDUwOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC0yNjQsOSArMjY0LDYgQEAgV0kuU2V0dGlu Z3NUYWJDb250ZW50VmlldyA9IGNsYXNzIFNldHRpbmdzVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBX SS5UYWJDb250ZW50VmkKICAgICAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRT ZXBhcmF0b3IoKTsKICAgICAgICAgfQogCi0gICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmll dy5hZGRTZXR0aW5nKFdJLlVJU3RyaW5nKCJBdWRpdDoiKSwgV0kuc2V0dGluZ3MuZXhwZXJpbWVu dGFsRW5hYmxlQXVkaXRUYWIsIFdJLlVJU3RyaW5nKCJFbmFibGUgQXVkaXQgVGFiIikpOwotICAg ICAgICBleHBlcmltZW50YWxTZXR0aW5nc1ZpZXcuYWRkU2VwYXJhdG9yKCk7Ci0KICAgICAgICAg ZXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIlVzZXIgSW50 ZXJmYWNlOiIpLCBXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVOZXdUYWJCYXIsIFdJLlVJ U3RyaW5nKCJFbmFibGUgTmV3IFRhYiBCYXIiKSk7CiAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRp bmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKIApAQCAtMjc3LDggKzI3NCw2IEBAIFdJLlNldHRpbmdz VGFiQ29udGVudFZpZXcgPSBjbGFzcyBTZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0ku VGFiQ29udGVudFZpCiAgICAgICAgICAgICBsZXQgbmV3VGFicyA9IFdJLl9vcGVuVGFic1NldHRp bmcudmFsdWUuc2xpY2UoKTsKICAgICAgICAgICAgIGlmICghaW5pdGlhbFZhbHVlcy5nZXQoV0ku c2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5ZXJzVGFiKSAmJiB3aW5kb3cuTGF5ZXJUcmVl QWdlbnQgJiYgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5ZXJzVGFiLnZhbHVlKQog ICAgICAgICAgICAgICAgIG5ld1RhYnMucHVzaChXSS5MYXllcnNUYWJDb250ZW50Vmlldy5UeXBl KTsKLSAgICAgICAgICAgIGlmICghaW5pdGlhbFZhbHVlcy5nZXQoV0kuc2V0dGluZ3MuZXhwZXJp bWVudGFsRW5hYmxlQXVkaXRUYWIpICYmIFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1 ZGl0VGFiLnZhbHVlKQotICAgICAgICAgICAgICAgIG5ld1RhYnMucHVzaChXSS5BdWRpdFRhYkNv bnRlbnRWaWV3LlR5cGUpOwogICAgICAgICAgICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZSA9 IG5ld1RhYnM7CiAKICAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5yZW9wZW4oKTsK QEAgLTI5Niw3ICsyOTEsNiBAQCBXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0 dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaQogCiAgICAgICAgIGxp c3RlbkZvckNoYW5nZShXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVDb21wdXRlZFN0eWxl Q2FzY2FkZXMpOwogICAgICAgICBsaXN0ZW5Gb3JDaGFuZ2UoV0kuc2V0dGluZ3MuZXhwZXJpbWVu dGFsRW5hYmxlTGF5ZXJzVGFiKTsKLSAgICAgICAgbGlzdGVuRm9yQ2hhbmdlKFdJLnNldHRpbmdz LmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiKTsKICAgICAgICAgbGlzdGVuRm9yQ2hhbmdlKFdJ LnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZU5ld1RhYkJhcik7CiAKICAgICAgICAgdGhpcy5h ZGRTZXR0aW5nc1ZpZXcoZXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3KTsK 360151 2019-01-25 13:23:27 -0800 2019-01-25 13:49:08 -0800 Patch bug-193743-20190125132326.patch text/plain 6123 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg2OGNiM2Q4Yzk3ZmRkZDFlMmYwNGY0NjdkMjI0 N2Y1ODcxODdiY2IuLjljMThjZTEwNzhjZGU3Y2I5NWM0YjYyNTQ5ZDg2ODgwYzgwZmY3YTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTAxLTI1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogcmVtb3ZlIGV4cGVyaW1lbnRhbCBzZXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM3NDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzI4MjM0MDIyPgorCisgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzOgorICAgICAgICAoV0kuU2V0dGlu Zyk6CisgICAgICAgIChXSS5TZXR0aW5nLmxvY2FsU3RvcmFnZUtleSk6IEFkZGVkLgorICAgICAg ICAoV0kuU2V0dGluZy5taWdyYXRlVmFsdWUpOgorICAgICAgICBEcml2ZS1ieTogYWRkIHRoZSBs b2NhbFN0b3JhZ2Uga2V5IHByZWZpeCB0byB0aGUga2V5IHBhc3NlZCBpbnRvIGBXSS5TZXR0aW5n Lm1pZ3JhdGVWYWx1ZWAuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoK KyAgICAgICAgKFdJLmxvYWRlZCk6CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0F1 ZGl0VGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5BdWRpdFRhYkNvbnRlbnRWaWV3Lmlz VGFiQWxsb3dlZCk6CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFi Q29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LnByb3Rv dHlwZS5fY3JlYXRlRXhwZXJpbWVudGFsU2V0dGluZ3NWaWV3KToKKworICAgICAgICAqIExvY2Fs aXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKwogMjAxOS0wMS0yNSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog UkVHUkVTU0lPTiAocjIzNzgwOCk6IG9mZnNjcmVlbiBwYXRoIHdhcm5pbmcgZG9lc24ndCB3b3Jr CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlv bnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCAxNDE1MGNkMzFmZTkzNWEzZjM2 YWZkNzcxNTljOTE5MTllNWRhYTI5Li5iNDk2MmI4NTM0OTk2ODBiMTU0ZjdmYjhlMzE0NDRlM2Uz OGZkYzA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9l bi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9M b2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKQEAgLTEzMyw3ICsxMzMs NiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJBdHRyaWJ1dGVzIl0gPSAiQXR0cmlidXRlcyI7CiBsb2Nh bGl6ZWRTdHJpbmdzWyJBdWRpdCJdID0gIkF1ZGl0IjsKIGxvY2FsaXplZFN0cmluZ3NbIkF1ZGl0 IEVycm9yOiAlcyJdID0gIkF1ZGl0IEVycm9yOiAlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdWRp dCBXYXJuaW5nOiAlcyJdID0gIkF1ZGl0IFdhcm5pbmc6ICVzIjsKLWxvY2FsaXplZFN0cmluZ3Nb IkF1ZGl0OiJdID0gIkF1ZGl0OiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdWRpdHMiXSA9ICJBdWRp dHMiOwogbG9jYWxpemVkU3RyaW5nc1siQXV0aG9yIFN0eWxlc2hlZXQiXSA9ICJBdXRob3IgU3R5 bGVzaGVldCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBdXRvIEluY3JlbWVudCJdID0gIkF1dG8gSW5j cmVtZW50IjsKQEAgLTM2MSw3ICszNjAsNiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJFbGVtZW50IGlz IHRoZSByb290IGVsZW1lbnQiXSA9ICJFbGVtZW50IGlzIHRoZSByb290IGVsZW1lbnQiOwogbG9j YWxpemVkU3RyaW5nc1siRWxlbWVudCBtYXkgb3ZlcmxhcCBhbm90aGVyIGNvbXBvc2l0aW5nIGVs ZW1lbnQiXSA9ICJFbGVtZW50IG1heSBvdmVybGFwIGFub3RoZXIgY29tcG9zaXRpbmcgZWxlbWVu dCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbGVtZW50IG92ZXJsYXBzIG90aGVyIGNvbXBvc2l0aW5n IGVsZW1lbnQiXSA9ICJFbGVtZW50IG92ZXJsYXBzIG90aGVyIGNvbXBvc2l0aW5nIGVsZW1lbnQi OwogbG9jYWxpemVkU3RyaW5nc1siRWxlbWVudHMiXSA9ICJFbGVtZW50cyI7Ci1sb2NhbGl6ZWRT dHJpbmdzWyJFbmFibGUgQXVkaXQgVGFiIl0gPSAiRW5hYmxlIEF1ZGl0IFRhYiI7CiBsb2NhbGl6 ZWRTdHJpbmdzWyJFbmFibGUgQnJlYWtwb2ludCJdID0gIkVuYWJsZSBCcmVha3BvaW50IjsKIGxv Y2FsaXplZFN0cmluZ3NbIkVuYWJsZSBCcmVha3BvaW50cyJdID0gIkVuYWJsZSBCcmVha3BvaW50 cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbmFibGUgQ29tcHV0ZWQgU3R5bGUgQ2FzY2FkZXMiXSA9 ICJFbmFibGUgQ29tcHV0ZWQgU3R5bGUgQ2FzY2FkZXMiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDcxY2I4ZWQ2YmYxMjhkMTE5 NGMwODhmOTE1OTBjNWQyMTA2MzQ5MzMuLmU4Y2FkNTIxMGEzNDM1NWJlODEyYzI4MjZmOGY4ZGY5 OGNjZTk3NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKQEAgLTE0OCw2ICsxNDgsNyBAQCBXSS5sb2FkZWQgPSBmdW5jdGlvbigpCiAg ICAgICAgIFdJLlRpbWVsaW5lVGFiQ29udGVudFZpZXcuVHlwZSwKICAgICAgICAgV0kuU3RvcmFn ZVRhYkNvbnRlbnRWaWV3LlR5cGUsCiAgICAgICAgIFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3LlR5 cGUsCisgICAgICAgIFdJLkF1ZGl0VGFiQ29udGVudFZpZXcuVHlwZSwKICAgICAgICAgV0kuQ29u c29sZVRhYkNvbnRlbnRWaWV3LlR5cGUsCiAgICAgXSk7CiAgICAgdGhpcy5fc2VsZWN0ZWRUYWJJ bmRleFNldHRpbmcgPSBuZXcgV0kuU2V0dGluZygic2VsZWN0ZWQtdGFiLWluZGV4IiwgMCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRp dFRhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQXVkaXRUYWJDb250ZW50Vmlldy5qcwppbmRleCA4YzQyMjY4MjNjMTRhNDY3ODg3NzVi ODVlYzZjY2RiZjMzMzNkYWM2Li45YTllNjhlOWUxOTg1MjI3MTRkNWFkNjU5YzE2ZTExNzM1ZWZi ZDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9BdWRpdFRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGFiQ29udGVudFZpZXcuanMKQEAgLTQ5LDcgKzQ5LDcgQEAg V0kuQXVkaXRUYWJDb250ZW50VmlldyA9IGNsYXNzIEF1ZGl0VGFiQ29udGVudFZpZXcgZXh0ZW5k cyBXSS5Db250ZW50QnJvd3NlclRhYkMKIAogICAgIHN0YXRpYyBpc1RhYkFsbG93ZWQoKQogICAg IHsKLSAgICAgICAgcmV0dXJuICEhd2luZG93LlJ1bnRpbWVBZ2VudCAmJiBXSS5zZXR0aW5ncy5l eHBlcmltZW50YWxFbmFibGVBdWRpdFRhYi52YWx1ZTsKKyAgICAgICAgcmV0dXJuIFdJLnNoYXJl ZEFwcC5kZWJ1Z2dhYmxlVHlwZSA9PT0gV0kuRGVidWdnYWJsZVR5cGUuV2ViOwogICAgIH0KIAog ICAgIC8vIFB1YmxpYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKaW5kZXgg ZDEyM2RjMDBiNzVjNmU5NmRmZTQ0MTVlNzI3NDI3NGFlYjFhODJlMS4uZjVmODE1YjJhNDE4MWVh MGNjMGIzY2FjNTJiZjliMzU1ZDJmMDUwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRl bnRWaWV3LmpzCkBAIC0yNjQsOSArMjY0LDYgQEAgV0kuU2V0dGluZ3NUYWJDb250ZW50VmlldyA9 IGNsYXNzIFNldHRpbmdzVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5UYWJDb250ZW50VmkKICAg ICAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKICAgICAg ICAgfQogCi0gICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXR0aW5nKFdJLlVJ U3RyaW5nKCJBdWRpdDoiKSwgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlQXVkaXRUYWIs IFdJLlVJU3RyaW5nKCJFbmFibGUgQXVkaXQgVGFiIikpOwotICAgICAgICBleHBlcmltZW50YWxT ZXR0aW5nc1ZpZXcuYWRkU2VwYXJhdG9yKCk7Ci0KICAgICAgICAgZXhwZXJpbWVudGFsU2V0dGlu Z3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIlVzZXIgSW50ZXJmYWNlOiIpLCBXSS5zZXR0 aW5ncy5leHBlcmltZW50YWxFbmFibGVOZXdUYWJCYXIsIFdJLlVJU3RyaW5nKCJFbmFibGUgTmV3 IFRhYiBCYXIiKSk7CiAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0 b3IoKTsKIApAQCAtMjc3LDggKzI3NCw2IEBAIFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcgPSBj bGFzcyBTZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuVGFiQ29udGVudFZpCiAgICAg ICAgICAgICBsZXQgbmV3VGFicyA9IFdJLl9vcGVuVGFic1NldHRpbmcudmFsdWUuc2xpY2UoKTsK ICAgICAgICAgICAgIGlmICghaW5pdGlhbFZhbHVlcy5nZXQoV0kuc2V0dGluZ3MuZXhwZXJpbWVu dGFsRW5hYmxlTGF5ZXJzVGFiKSAmJiB3aW5kb3cuTGF5ZXJUcmVlQWdlbnQgJiYgV0kuc2V0dGlu Z3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5ZXJzVGFiLnZhbHVlKQogICAgICAgICAgICAgICAgIG5l d1RhYnMucHVzaChXSS5MYXllcnNUYWJDb250ZW50Vmlldy5UeXBlKTsKLSAgICAgICAgICAgIGlm ICghaW5pdGlhbFZhbHVlcy5nZXQoV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlQXVkaXRU YWIpICYmIFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJsZUF1ZGl0VGFiLnZhbHVlKQotICAg ICAgICAgICAgICAgIG5ld1RhYnMucHVzaChXSS5BdWRpdFRhYkNvbnRlbnRWaWV3LlR5cGUpOwog ICAgICAgICAgICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZSA9IG5ld1RhYnM7CiAKICAgICAg ICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5yZW9wZW4oKTsKQEAgLTI5Niw3ICsyOTEsNiBA QCBXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50Vmll dyBleHRlbmRzIFdJLlRhYkNvbnRlbnRWaQogCiAgICAgICAgIGxpc3RlbkZvckNoYW5nZShXSS5z ZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVDb21wdXRlZFN0eWxlQ2FzY2FkZXMpOwogICAgICAg ICBsaXN0ZW5Gb3JDaGFuZ2UoV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTGF5ZXJzVGFi KTsKLSAgICAgICAgbGlzdGVuRm9yQ2hhbmdlKFdJLnNldHRpbmdzLmV4cGVyaW1lbnRhbEVuYWJs ZUF1ZGl0VGFiKTsKICAgICAgICAgbGlzdGVuRm9yQ2hhbmdlKFdJLnNldHRpbmdzLmV4cGVyaW1l bnRhbEVuYWJsZU5ld1RhYkJhcik7CiAKICAgICAgICAgdGhpcy5hZGRTZXR0aW5nc1ZpZXcoZXhw ZXJpbWVudGFsU2V0dGluZ3NWaWV3KTsK