193734 2019-01-23 12:44:31 -0800 webkitpy: Wait longer when launching WebKitTestRunner 2019-01-24 08:37:05 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dbates ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1497500 0 jbedard 2019-01-23 12:44:31 -0800 Originally, I only saw this problem when booting simulators. Recently, I saw this timeout hit well after the simulators were booted. The wait time was a bit arbitrary in the first place, I'd like to increase it. 1497502 1 359924 jbedard 2019-01-23 12:49:33 -0800 Created attachment 359924 Patch 1497535 2 359924 commit-queue 2019-01-23 13:28:41 -0800 Comment on attachment 359924 Patch Clearing flags on attachment: 359924 Committed r240356: <https://trac.webkit.org/changeset/240356> 1497536 3 commit-queue 2019-01-23 13:28:42 -0800 All reviewed patches have been landed. Closing bug. 1497537 4 webkit-bug-importer 2019-01-23 13:29:29 -0800 <rdar://problem/47491778> 1497668 5 359924 dbates 2019-01-23 17:41:22 -0800 Comment on attachment 359924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359924&action=review > Tools/Scripts/webkitpy/port/simulator_process.py:98 > + with Timeout(15, RuntimeError('Timed out waiting for pid {} to connect at port {}'.format(self._pid, self._target_host.listening_port()))): I did a double take when I saw this change. This timeout value seems to be following Moore's law. Check it out: 3 seconds @ <http://trac.webkit.org/r211370> (01/30/2017) 6 seconds @ <http://trac.webkit.org/r214896 > (04/04/2017) *NOW* 15 seconds (01/23/2019) We are wasting engineering hours progressively increasing this value. I think we should just save us 10 years and pick ~3072 seconds :P. All joking aside, too bad we cannot do anything better. 1497818 6 jbedard 2019-01-24 08:37:05 -0800 (In reply to Daniel Bates from comment #5) > Comment on attachment 359924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359924&action=review > > > Tools/Scripts/webkitpy/port/simulator_process.py:98 > > + with Timeout(15, RuntimeError('Timed out waiting for pid {} to connect at port {}'.format(self._pid, self._target_host.listening_port()))): > > I did a double take when I saw this change. This timeout value seems to be > following Moore's law. Check it out: > > 3 seconds @ <http://trac.webkit.org/r211370> (01/30/2017) > 6 seconds @ <http://trac.webkit.org/r214896 > (04/04/2017) > *NOW* 15 seconds (01/23/2019) > > We are wasting engineering hours progressively increasing this value. I > think we should just save us 10 years and pick ~3072 seconds :P. All joking > aside, too bad we cannot do anything better. I wish I had a better answer. This is closely related to problems booting simulators, basically, simulators are quite slow. We were getting into cases where bots where 30 minutes into a test run and hit this timeout because the machine was stuck gathering crashlogs from another test run while trying to start up the test runner. 359924 2019-01-23 12:49:33 -0800 2019-01-23 13:28:41 -0800 Patch bug-193734-20190123124933.patch text/plain 1794 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDM1MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAxLTIzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogV2FpdCBsb25nZXIgd2hlbiBsYXVuY2hpbmcgV2ViS2l0 VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzNzM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHk6CisgICAgICAg IChTaW11bGF0b3JQcm9jZXNzLl9zdGFydCk6IEluY3JlYXNlIHRpbWVvdXQgZnJvbSA2IHNlY29u ZHMgdG8gMTUgc2Vjb25kcy4KKwogMjAxOS0wMS0yMyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBmYXN0L2V2ZW50cy90b3VjaC9pb3MvaG92 ZXItd2hlbi1zdHlsZS1jaGFuZ2UtaXMtYXN5bmMuaHRtbCB0aW1lcyBvdXQKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHJldmlz aW9uIDI0MDM1MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJv Y2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAy MDE3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDE3 LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMg bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCkBAIC05NSw3ICs5NSw3IEBAIGNsYXNzIFNpbXVsYXRvclByb2Nlc3MoU2VydmVy UHJvY2Vzcyk6CiAgICAgICAgIHNlbGYuX3RhcmdldF9ob3N0Lmxpc3RlbmluZ19zb2NrZXQubGlz dGVuKDMpCiAgICAgICAgIHNlbGYuX3BpZCA9IHNlbGYuX3RhcmdldF9ob3N0LmxhdW5jaF9hcHAo c2VsZi5fYnVuZGxlX2lkLCBzZWxmLl9jbWRbMTpdLCBlbnY9c2VsZi5fZW52KQogCi0gICAgICAg IHdpdGggVGltZW91dCg2LCBSdW50aW1lRXJyb3IoJ1RpbWVkIG91dCB3YWl0aW5nIGZvciBwaWQg e30gdG8gY29ubmVjdCBhdCBwb3J0IHt9Jy5mb3JtYXQoc2VsZi5fcGlkLCBzZWxmLl90YXJnZXRf aG9zdC5saXN0ZW5pbmdfcG9ydCgpKSkpOgorICAgICAgICB3aXRoIFRpbWVvdXQoMTUsIFJ1bnRp bWVFcnJvcignVGltZWQgb3V0IHdhaXRpbmcgZm9yIHBpZCB7fSB0byBjb25uZWN0IGF0IHBvcnQg e30nLmZvcm1hdChzZWxmLl9waWQsIHNlbGYuX3RhcmdldF9ob3N0Lmxpc3RlbmluZ19wb3J0KCkp KSk6CiAgICAgICAgICAgICBzdGRpbiA9IE5vbmUKICAgICAgICAgICAgIHN0ZG91dCA9IE5vbmUK ICAgICAgICAgICAgIHN0ZGVyciA9IE5vbmUK