193723 2019-01-23 08:54:39 -0800 REGRESSION (Probably r240243): CrashTracer: WebKitTestRunnerApp at com.apple.WebKit: WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const + 32 2019-01-23 10:44:41 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193556 1 bfulgham bfulgham bfulgham commit-queue ddkilzer wilander oldest_to_newest 1497357 0 bfulgham 2019-01-23 08:54:39 -0800 The new code in Bug 193556 could attempt to submit telemetry after the relevant WebResourceLoadStatisticsStore was destroyed. We should guard against this possibility. 1497358 1 bfulgham 2019-01-23 08:55:09 -0800 <rdar://problem/47476802> 1497359 2 359893 bfulgham 2019-01-23 08:57:08 -0800 Created attachment 359893 Patch 1497402 3 359893 ddkilzer 2019-01-23 10:19:13 -0800 Comment on attachment 359893 Patch r=me 1497420 4 359893 commit-queue 2019-01-23 10:44:40 -0800 Comment on attachment 359893 Patch Clearing flags on attachment: 359893 Committed r240346: <https://trac.webkit.org/changeset/240346> 1497421 5 commit-queue 2019-01-23 10:44:41 -0800 All reviewed patches have been landed. Closing bug. 359893 2019-01-23 08:57:08 -0800 2019-01-23 10:44:40 -0800 Patch bug-193723-20190123085707.patch text/plain 4204 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1ZDkzYTZiOGVhOGQ5YjIw NWViMGE4NTA3Njg3ZDUzYTA2ZWFlMTIuLjljNTI3M2M4ODMxMDg3N2NmMzc3NzBkNWU4MmQ4YjBm NzEyZmQwOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMjMgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI0MDI0 Myk6IENyYXNoVHJhY2VyOiBXZWJLaXRUZXN0UnVubmVyQXBwIGF0IGNvbS5hcHBsZS5XZWJLaXQ6 IFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpzZW5kRGlhZ25vc3RpY01l c3NhZ2VXaXRoVmFsdWUgY29uc3QgKyAzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNzIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzQ3Njgw Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg bmV3IGNvZGUgYWRkZWQgaW4gcjI0MDI0MyBjb3VsZCBhdHRlbXB0IHRvIHN1Ym1pdCB0ZWxlbWV0 cnkgYWZ0ZXIgdGhlIHJlbGV2YW50CisgICAgICAgIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZSB3YXMgZGVzdHJveWVkLiBXZSBzaG91bGQgZ3VhcmQgYWdhaW5zdCB0aGlzIHBvc3NpYmls aXR5LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxv YWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1RlbGVtZXRyeTo6Y2FsY3VsYXRlQW5kU3VibWl0KToKKwogMjAxOS0wMS0y MyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN3aXRjaCBy ZW1haW5pbmcgQ29yZU1lZGlhIHNvZnQtbGlua2luZyBpbiBXZWJLaXQgb3ZlciB0byBDb3JlTWVk aWFTb2Z0TGluay57Y3BwLGh9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeS5jcHAgYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvV2ViUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1RlbGVtZXRyeS5jcHAKaW5kZXggZGEwMGViODU0NGEwNzFmNDU0OTdlYTQ4ZGZlMTRm NTMzM2IxNGRkMC4uOWMzMTM5ZDA2ZWNkMjJkZDRlZGE2YWNiMDQxMTFlMjIyY2Y3ZjUzMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291 cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNw cApAQCAtMjQxLDE2ICsyNDEsMTkgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVs ZW1ldHJ5OjpjYWxjdWxhdGVBbmRTdWJtaXQoY29uc3QgUmVzb3VyY2VMb2FkU3QKICAgICB9CiAg ICAgCiAgICAgLy8gRGlzcGF0Y2ggb24gdGhlIG1haW4gdGhyZWFkIHRvIG1ha2Ugc3VyZSB0aGUg V2ViUGFnZVByb3h5IHdlJ3JlIHVzaW5nIGRvZXNuJ3QgZ28gYXdheS4KLSAgICBSdW5Mb29wOjpt YWluKCkuZGlzcGF0Y2goW3NvcnRlZFByZXZhbGVudFJlc291cmNlcyA9IFdURk1vdmUoc29ydGVk UHJldmFsZW50UmVzb3VyY2VzKSwgc29ydGVkUHJldmFsZW50UmVzb3VyY2VzV2l0aG91dFVzZXJJ bnRlcmFjdGlvbiA9IFdURk1vdmUoc29ydGVkUHJldmFsZW50UmVzb3VyY2VzV2l0aG91dFVzZXJJ bnRlcmFjdGlvbiksIHByZXZhbGVudFJlc291cmNlc0RheXNTaW5jZVVzZXJJbnRlcmFjdGlvbiA9 IFdURk1vdmUocHJldmFsZW50UmVzb3VyY2VzRGF5c1NpbmNlVXNlckludGVyYWN0aW9uKSwgJnJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZV0gKCkgeworICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNw YXRjaChbc29ydGVkUHJldmFsZW50UmVzb3VyY2VzID0gV1RGTW92ZShzb3J0ZWRQcmV2YWxlbnRS ZXNvdXJjZXMpLCBzb3J0ZWRQcmV2YWxlbnRSZXNvdXJjZXNXaXRob3V0VXNlckludGVyYWN0aW9u ID0gV1RGTW92ZShzb3J0ZWRQcmV2YWxlbnRSZXNvdXJjZXNXaXRob3V0VXNlckludGVyYWN0aW9u KSwgcHJldmFsZW50UmVzb3VyY2VzRGF5c1NpbmNlVXNlckludGVyYWN0aW9uID0gV1RGTW92ZShw cmV2YWxlbnRSZXNvdXJjZXNEYXlzU2luY2VVc2VySW50ZXJhY3Rpb24pLCByZXNvdXJjZUxvYWRT dGF0aXN0aWNzU3RvcmUgPSBtYWtlV2Vha1B0cihyZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUp XSAoKSB7CisgICAgICAgIGlmICghcmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlKQorICAgICAg ICAgICAgcmV0dXJuOworCiAgICAgICAgIGF1dG8gd2ViUGFnZVByb3h5ID0gV2ViUGFnZVByb3h5 Ojpub25FcGhlbWVyYWxXZWJQYWdlUHJveHkoKTsKICAgICAgICAgaWYgKCF3ZWJQYWdlUHJveHkp IHsKICAgICAgICAgICAgIGlmIChub3RpZnlQYWdlc1doZW5UZWxlbWV0cnlXYXNDYXB0dXJlZCkK LSAgICAgICAgICAgICAgICBub3RpZnlQYWdlcygwLCAwLCAwLCByZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmUuc3RvcmUoKSk7CisgICAgICAgICAgICAgICAgbm90aWZ5UGFnZXMoMCwgMCwgMCwg cmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLT5zdG9yZSgpKTsKICAgICAgICAgICAgIHJldHVy bjsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgaWYgKG5vdGlmeVBhZ2VzV2hlblRlbGVt ZXRyeVdhc0NhcHR1cmVkKSB7Ci0gICAgICAgICAgICBub3RpZnlQYWdlcyhzb3J0ZWRQcmV2YWxl bnRSZXNvdXJjZXMsIHNvcnRlZFByZXZhbGVudFJlc291cmNlc1dpdGhvdXRVc2VySW50ZXJhY3Rp b24sIHByZXZhbGVudFJlc291cmNlc0RheXNTaW5jZVVzZXJJbnRlcmFjdGlvbi5zaXplKCksIHJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5zdG9yZSgpKTsKKyAgICAgICAgICAgIG5vdGlmeVBh Z2VzKHNvcnRlZFByZXZhbGVudFJlc291cmNlcywgc29ydGVkUHJldmFsZW50UmVzb3VyY2VzV2l0 aG91dFVzZXJJbnRlcmFjdGlvbiwgcHJldmFsZW50UmVzb3VyY2VzRGF5c1NpbmNlVXNlckludGVy YWN0aW9uLnNpemUoKSwgcmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLT5zdG9yZSgpKTsKICAg ICAgICAgICAgIC8vIFRoZSBub3RpZnkgcGFnZXMgZnVuY3Rpb24gaXMgZm9yIHRlc3Rpbmcgc28g d2UgZG9uJ3QgbmVlZCB0byBkbyBhbiBhY3R1YWwgc3VibWlzc2lvbi4KICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQpAQCAtMjYzLDcgKzI2Niw3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2Fk U3RhdGlzdGljc1RlbGVtZXRyeTo6Y2FsY3VsYXRlQW5kU3VibWl0KGNvbnN0IFJlc291cmNlTG9h ZFN0CiAgICAgICAgIGlmIChwcmV2YWxlbnRSZXNvdXJjZXNEYXlzU2luY2VVc2VySW50ZXJhY3Rp b24uc2l6ZSgpID4gMSkKICAgICAgICAgICAgIHdlYlBhZ2VQcm94eS0+bG9nRGlhZ25vc3RpY01l c3NhZ2VXaXRoVmFsdWUoRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpyZXNvdXJjZUxvYWRTdGF0aXN0 aWNzVGVsZW1ldHJ5S2V5KCksICJtZWRpYW5QcmV2YWxlbnRSZXNvdXJjZXNXaXRoVXNlckludGVy YWN0aW9uRGF5c1NpbmNlVXNlckludGVyYWN0aW9uIl9zLCBtZWRpYW4ocHJldmFsZW50UmVzb3Vy Y2VzRGF5c1NpbmNlVXNlckludGVyYWN0aW9uKSwgc2lnbmlmaWNhbnRGaWd1cmVzRm9yTG9nZ2Vk VmFsdWVzLCBTaG91bGRTYW1wbGU6Ok5vKTsKICAgICAgICAgCi0gICAgICAgIHN1Ym1pdFRvcExp c3RzKHNvcnRlZFByZXZhbGVudFJlc291cmNlcywgc29ydGVkUHJldmFsZW50UmVzb3VyY2VzV2l0 aG91dFVzZXJJbnRlcmFjdGlvbiwgcmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLnN0b3JlKCkp OworICAgICAgICBzdWJtaXRUb3BMaXN0cyhzb3J0ZWRQcmV2YWxlbnRSZXNvdXJjZXMsIHNvcnRl ZFByZXZhbGVudFJlc291cmNlc1dpdGhvdXRVc2VySW50ZXJhY3Rpb24sIHJlc291cmNlTG9hZFN0 YXRpc3RpY3NTdG9yZS0+c3RvcmUoKSk7CiAgICAgfSk7CiB9CiAgICAgCg==