193714 2019-01-23 03:49:03 -0800 [JSC] Duplicate global variables: JSC::opcodeLengths 2019-01-23 07:41:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1497283 0 ddkilzer 2019-01-23 03:49:03 -0800 Because JSC::opcodeLengths is defined in the Source/JavaScriptCore/bytecode/Opcode.h header, there are 11 copies of it created on Release-iphoneos builds: $ nm -a $BUILD_ROOT/Release-iphoneos/JavaScriptCore.framework/JavaScriptCore | grep opcodeLengths 0000000000bfdb54 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bfdb54 s __ZN3JSCL13opcodeLengthsE 0000000000bfde2c s __ZN3JSCL13opcodeLengthsE 0000000000bfde2c - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bfe130 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bfe130 s __ZN3JSCL13opcodeLengthsE 0000000000bfe5e8 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bfe5e8 s __ZN3JSCL13opcodeLengthsE 0000000000bfe930 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bfe930 s __ZN3JSCL13opcodeLengthsE 0000000000bff1f0 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000bff1f0 s __ZN3JSCL13opcodeLengthsE 0000000000c08684 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000c08684 s __ZN3JSCL13opcodeLengthsE 0000000000c08970 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000c08970 s __ZN3JSCL13opcodeLengthsE 0000000000c08c98 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000c08c98 s __ZN3JSCL13opcodeLengthsE 0000000000c09100 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE 0000000000c09100 s __ZN3JSCL13opcodeLengthsE 0000000000c09880 s __ZN3JSCL13opcodeLengthsE 0000000000c09880 - 04 0000 STSYM __ZN3JSCL13opcodeLengthsE After moving JSC::opcodeLengths to Source/JavaScriptCore/bytecode/Opcode.cpp, we have only one copy: $ nm -a $BUILD_ROOT/Release-iphoneos/JavaScriptCore.framework/JavaScriptCore | grep opcodeLengths 0000000000000000 - 00 0000 GSYM __ZN3JSC13opcodeLengthsE 0000000000bfd878 s __ZN3JSC13opcodeLengthsE 1497284 1 ddkilzer 2019-01-23 03:49:16 -0800 <rdar://problem/47340200> 1497285 2 359869 ddkilzer 2019-01-23 03:53:25 -0800 Created attachment 359869 Patch v1 1497313 3 359869 mark.lam 2019-01-23 07:15:41 -0800 Comment on attachment 359869 Patch v1 r=me 1497320 4 359869 commit-queue 2019-01-23 07:41:01 -0800 Comment on attachment 359869 Patch v1 Clearing flags on attachment: 359869 Committed r240335: <https://trac.webkit.org/changeset/240335> 1497321 5 commit-queue 2019-01-23 07:41:03 -0800 All reviewed patches have been landed. Closing bug. 359869 2019-01-23 03:53:25 -0800 2019-01-23 07:41:01 -0800 Patch v1 bug-193714-20190123035324.patch text/plain 2269 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MzRjZWQ0ODU5ZmUzOTMxZmJiYzJhMmFhNWY3Y2I1Y2UwM2JlYjk0Li45MGMwNjM4ODE3YzkxNjU4 NDY4NDdjNTE4ZTYyYjljOTBiOTcwYWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMS0yMyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIER1cGxpY2F0ZSBnbG9iYWwgdmFyaWFibGVzOiBKU0M6Om9wY29k ZUxlbmd0aHMKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE5MzcxND4KKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ3MzQwMjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmNwcDoKKyAgICAgICAgKEpTQzo6 b3Bjb2RlTGVuZ3Rocyk6IE1vdmUgYXJyYXkgaW1wbGVtZW50YXRpb24gaGVyZSBhbmQgbWFyawor ICAgICAgICBjb25zdC4KKyAgICAgICAgKiBieXRlY29kZS9PcGNvZGUuaDoKKyAgICAgICAgKEpT Qzo6b3Bjb2RlTGVuZ3Rocyk6IENoYW5nZSB0byBleHRlcm4gZGVjbGFyYXRpb24uCisKIDIwMTkt MDEtMjIgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlND XSBJbnRsIGNvbnN0cnVjdG9ycyBzaG91bGQgZml0IGluIHNpemVvZihJbnRlcm5hbEZ1bmN0aW9u KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmNwcAppbmRleCA5N2Q0N2Q0 NWVjYzcxMjI5ZTBiNzgwMTlhOGNmODgxYmU0YTVlYjZlLi4yZGQ5MzQ0OGZhYTA4YzhiZjJkNmFi M2I4ZGJjNjZkZDNmMzY1MzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvT3Bjb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bj b2RlLmNwcApAQCAtNDAsNiArNDAsMTIgQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKK2NvbnN0IHVu c2lnbmVkIG9wY29kZUxlbmd0aHNbXSA9IHsKKyNkZWZpbmUgT1BDT0RFX0xFTkdUSChvcGNvZGUs IGxlbmd0aCkgbGVuZ3RoLAorICAgIEZPUl9FQUNIX09QQ09ERV9JRChPUENPREVfTEVOR1RIKQor I3VuZGVmIE9QQ09ERV9MRU5HVEgKK307CisKIGNvbnN0IGNoYXIqIGNvbnN0IG9wY29kZU5hbWVz W10gPSB7CiAjZGVmaW5lIE9QQ09ERV9OQU1FX0VOVFJZKG9wY29kZSwgc2l6ZSkgI29wY29kZSwK ICAgICBGT1JfRUFDSF9PUENPREVfSUQoT1BDT0RFX05BTUVfRU5UUlkpCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgKaW5kZXggMWYzOWI3ZjlkOWMzMjAwOGVkYWVlYWVlNjRi NTI5NzY5MWRhMjhhNS4uZmVlYjQ0MjdmNjg1OTU0MWU1NzhmZTUwOWRhZmI1YzNjY2Y1YThmNiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaApAQCAtNzEsMTUgKzcxLDcg QEAgY29uc3QgaW50IG51bU9wY29kZUlEcyA9IE5VTUJFUl9PRl9CWVRFQ09ERV9JRFMgKyBOVU1C RVJfT0ZfQllURUNPREVfSEVMUEVSX0lEUzsKICN1bmRlZiBPUENPREVfSURfRU5VTQogI2VuZGlm CiAKLUlHTk9SRV9XQVJOSU5HU19CRUdJTigidW51c2VkLXZhcmlhYmxlIikKLQotI2RlZmluZSBP UENPREVfTEVOR1RIKG9wY29kZSwgbGVuZ3RoKSBsZW5ndGgsCi0gICAgc3RhdGljIHVuc2lnbmVk IG9wY29kZUxlbmd0aHNbXSA9IHsKLSAgICAgICAgRk9SX0VBQ0hfT1BDT0RFX0lEKE9QQ09ERV9M RU5HVEgpCi0gICAgfTsKLSN1bmRlZiBPUENPREVfTEVOR1RICi0KLUlHTk9SRV9XQVJOSU5HU19F TkQKK2V4dGVybiBjb25zdCB1bnNpZ25lZCBvcGNvZGVMZW5ndGhzW107CiAKICNkZWZpbmUgT1BD T0RFX0lEX0xFTkdUSFMoaWQsIGxlbmd0aCkgY29uc3QgaW50IGlkIyNfbGVuZ3RoID0gbGVuZ3Ro OwogICAgIEZPUl9FQUNIX09QQ09ERV9JRChPUENPREVfSURfTEVOR1RIUyk7Cg==