193697 2019-01-22 16:08:32 -0800 [ews-app] Rename ews model steps to step 2019-01-23 13:55:33 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193695 https://bugs.webkit.org/show_bug.cgi?id=193729 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1497060 0 aakash_jain 2019-01-22 16:08:32 -0800 The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'steps' to 'step' in ews-app model. 1497107 1 359813 aakash_jain 2019-01-22 17:04:44 -0800 Created attachment 359813 Proposed patch 1497442 2 359909 aakash_jain 2019-01-23 11:18:38 -0800 Created attachment 359909 Proposed patch 1497448 3 359909 kocsen_chung 2019-01-23 11:21:24 -0800 Comment on attachment 359909 Proposed patch r+; looks good to me. 1497547 4 aakash_jain 2019-01-23 13:54:49 -0800 Committed r240359: <https://trac.webkit.org/changeset/240359> 1497548 5 webkit-bug-importer 2019-01-23 13:55:33 -0800 <rdar://problem/47492748> 359813 2019-01-22 17:04:44 -0800 2019-01-23 11:18:38 -0800 Proposed patch 0001-ews-app-Rename-ews-model-steps-to-step.patch text/plain 2056 aakash_jain RnJvbSAwZGI1MzNhNzgxYTg2OTlmOTZlMjA5N2QxOWU4ZGU1YjcxN2IzY2VjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBUdWUsIDIyIEphbiAyMDE5IDE5OjE4OjMyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gW2V3 cy1hcHBdIFJlbmFtZSBld3MgbW9kZWwgc3RlcHMgdG8gc3RlcAogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY5NwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgoqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5OiBSZW5hbWVk IGZyb20gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXBzLnB5 LgooU3RlcCk6IFJlbmFtZWQgU3RlcHMgdG8gU3RlcC4KLS0tCiAuLi4vZXdzLWFwcC9ld3MvbW9k ZWxzL3tzdGVwcy5weSA9PiBzdGVwLnB5fSAgICAgICAgICAgfCAgMiArLQogVG9vbHMvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrKysr KwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiByZW5h bWUgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3tzdGVwcy5weSA9 PiBzdGVwLnB5fSAoOTglKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL21vZGVscy9zdGVwLnB5CnNpbWlsYXJpdHkgaW5kZXggOTglCnJlbmFtZSBmcm9tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weQpyZW5hbWUg dG8gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHkKaW5k ZXggZGQzM2Q0YTA0YmUuLmEyMTFjODU4ZTljIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHkKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHkKQEAgLTI2LDcgKzI2LDcgQEAgZnJv bSBkamFuZ28uZGIgaW1wb3J0IG1vZGVscwogZnJvbSBld3MubW9kZWxzLmJ1aWxkcyBpbXBvcnQg QnVpbGQKIAogCi1jbGFzcyBTdGVwcyhtb2RlbHMuTW9kZWwpOgorY2xhc3MgU3RlcChtb2RlbHMu TW9kZWwpOgogICAgIHN0ZXBpZCA9IG1vZGVscy5JbnRlZ2VyRmllbGQocHJpbWFyeV9rZXk9VHJ1 ZSkKICAgICBidWlsZCA9IG1vZGVscy5Gb3JlaWduS2V5KEJ1aWxkLCBvbl9kZWxldGU9bW9kZWxz LkNBU0NBREUpCiAgICAgcmVzdWx0ID0gbW9kZWxzLkludGVnZXJGaWVsZCgpCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDI1NjcyYTc0ZjYuLjlj N2YyNzhjYjliIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEtMjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2ph aW5AYXBwbGUuY29tPgorCisgICAgICAgIFtld3MtYXBwXSBSZW5hbWUgZXdzIG1vZGVsIHN0ZXBz IHRvIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MzY5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHk6IFJlbmFtZWQg ZnJvbSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHku CisgICAgICAgIChTdGVwKTogUmVuYW1lZCBTdGVwcyB0byBTdGVwLgorCiAyMDE5LTAxLTIyICBB YWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0g UmVuYW1lIGV3cyBtb2RlbCBCdWlsZHMgdG8gQnVpbGQKLS0gCjIuMTcuMiAoQXBwbGUgR2l0LTEx MykKCg== 359909 2019-01-23 11:18:38 -0800 2019-01-23 13:16:37 -0800 Proposed patch 0002-ews-app-Rename-ews-model-steps-to-step.patch text/plain 2539 aakash_jain RnJvbSA2MTIxNjgzMzdkNjExYzYwZGNlMzEwYWEzMjdjOWUzZTU0YzY2N2EwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBXZWQsIDIzIEphbiAyMDE5IDEzOjMyOjIzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCAyLzNd IFtld3MtYXBwXSBSZW5hbWUgZXdzIG1vZGVsIHN0ZXBzIHRvIHN0ZXAKIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM2OTcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcC5weTogUmVu YW1lZCBmcm9tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVw cy5weS4KKFN0ZXApOiBSZW5hbWVkIFN0ZXBzIHRvIFN0ZXAuCi0tLQogVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL19faW5pdF9fLnB5IHwgIDIgKy0KIC4uLi9ld3Mt YXBwL2V3cy9tb2RlbHMve3N0ZXBzLnB5ID0+IHN0ZXAucHl9ICAgICAgICAgICB8ICAyICstCiBU b29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx MCArKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCiByZW5hbWUgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxz L3tzdGVwcy5weSA9PiBzdGVwLnB5fSAoOTglKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5weSBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5weQppbmRleCA0ODY0ODRkNzU1 Yy4uYTE4NzdhNjZmMmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL21vZGVscy9fX2luaXRfXy5weQorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYXBwL2V3cy9tb2RlbHMvX19pbml0X18ucHkKQEAgLTEsNCArMSw0IEBACiBmcm9tIGJ1aWxk ZXJtYXBwaW5ncyBpbXBvcnQgKgogZnJvbSBidWlsZCBpbXBvcnQgKgogZnJvbSBwYXRjaCBpbXBv cnQgKgotZnJvbSBzdGVwcyBpbXBvcnQgKgorZnJvbSBzdGVwIGltcG9ydCAqCmRpZmYgLS1naXQg YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHkgYi9U b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcC5weQpzaW1pbGFy aXR5IGluZGV4IDk4JQpyZW5hbWUgZnJvbSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy9tb2RlbHMvc3RlcHMucHkKcmVuYW1lIHRvIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5CmluZGV4IDgyMWIyOTU4MmJiLi4yMDMxYTQ1YmY3OCAx MDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0 ZXBzLnB5CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9z dGVwLnB5CkBAIC0yNiw3ICsyNiw3IEBAIGZyb20gZGphbmdvLmRiIGltcG9ydCBtb2RlbHMKIGZy b20gZXdzLm1vZGVscy5idWlsZCBpbXBvcnQgQnVpbGQKIAogCi1jbGFzcyBTdGVwcyhtb2RlbHMu TW9kZWwpOgorY2xhc3MgU3RlcChtb2RlbHMuTW9kZWwpOgogICAgIHN0ZXBpZCA9IG1vZGVscy5J bnRlZ2VyRmllbGQocHJpbWFyeV9rZXk9VHJ1ZSkKICAgICBidWlsZCA9IG1vZGVscy5Gb3JlaWdu S2V5KEJ1aWxkLCBvbl9kZWxldGU9bW9kZWxzLkNBU0NBREUpCiAgICAgcmVzdWx0ID0gbW9kZWxz LkludGVnZXJGaWVsZCgpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggNDI1NjcyYTc0ZjYuLjljN2YyNzhjYjliIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEt MjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtld3Mt YXBwXSBSZW5hbWUgZXdzIG1vZGVsIHN0ZXBzIHRvIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY5NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3MvbW9kZWxzL3N0ZXAucHk6IFJlbmFtZWQgZnJvbSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHkuCisgICAgICAgIChTdGVwKTogUmVuYW1lZCBTdGVw cyB0byBTdGVwLgorCiAyMDE5LTAxLTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxl LmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0gUmVuYW1lIGV3cyBtb2RlbCBCdWlsZHMgdG8gQnVp bGQKLS0gCjIuMTcuMiAoQXBwbGUgR2l0LTExMykKCg==