193687 2019-01-22 14:44:44 -0800 Long presses on YouTube links incorrectly trigger a load 2019-01-22 18:12:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin commit-queue thorton wenson_hsieh oldest_to_newest 1496991 0 megan_gardner 2019-01-22 14:44:44 -0800 Cancel Web Touches Properly 1496996 1 359780 megan_gardner 2019-01-22 14:50:25 -0800 Created attachment 359780 Patch 1497013 2 359780 thorton 2019-01-22 15:08:40 -0800 Comment on attachment 359780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359780&action=review > Source/WebKit/ChangeLog:3 > + Cancel Web Touches Properly Can(cel) This Bug & Patch Have A Title That Describes The Symptom? > Source/WebKit/ChangeLog:5 > + And Probably A Radar #? 1497017 3 359786 megan_gardner 2019-01-22 15:13:01 -0800 Created attachment 359786 Patch 1497021 4 359786 thorton 2019-01-22 15:16:28 -0800 Comment on attachment 359786 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359786&action=review > Source/WebKit/Platform/spi/ios/UIKitSPI.h:761 > +- (void)cancel; Was this here forever into the past, or do you need some ifdefs? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1354 > +- (void)_cancelWebGestureRecognizer > +{ > + [_touchEventGestureRecognizer cancel]; > +} Why the indirection? Why "Web" gesture recognizer? Aren't they all technically about the web? :D I could see _cancelTouchEventsGestureRecognizer or something, but also think you just don't need this function. 1497036 5 359791 megan_gardner 2019-01-22 15:48:27 -0800 Created attachment 359791 Patch 1497064 6 359791 thorton 2019-01-22 16:10:46 -0800 Comment on attachment 359791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359791&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1351 > +- (void)_cancelWebGestureRecognizer Still not sure why the method. Are you thinking it will have more callers? And my other complaint about the method name stills stands. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1353 > +#if HAVE(CANCEL_WEB_TOUCH_EVENTS_GESTURE) I think the name I provided before was closer to the other names in e.g. Platform.h, but I guess this is OK. 1497084 7 359791 megan_gardner 2019-01-22 16:30:55 -0800 Comment on attachment 359791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359791&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1351 >> +- (void)_cancelWebGestureRecognizer > > Still not sure why the method. Are you thinking it will have more callers? > And my other complaint about the method name stills stands. They are this is the Web Gesture in all other instances, because it is the gesture that passes the touches to the web. I think this helps clear up that is this the gesture we are talking about. And while there are no additional callers today, there might be in the future, so I'd like to encapsulate the need for feature defines. Also, several other gestures use this exact layout of code to do the exact same thing. 1497091 8 359791 thorton 2019-01-22 16:38:51 -0800 Comment on attachment 359791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359791&action=review >>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1351 >>> +- (void)_cancelWebGestureRecognizer >> >> Still not sure why the method. Are you thinking it will have more callers? >> And my other complaint about the method name stills stands. > > They are this is the Web Gesture in all other instances, because it is the gesture that passes the touches to the web. I think this helps clear up that is this the gesture we are talking about. > And while there are no additional callers today, there might be in the future, so I'd like to encapsulate the need for feature defines. Also, several other gestures use this exact layout of code to do the exact same thing. I don't think it's ever called just "Web", that would be crazy. It is "WebTouchEvent" in UIKit, and "TouchEvent" in WebKit. You can decide what to call it. 1497137 9 359825 megan_gardner 2019-01-22 17:57:05 -0800 Created attachment 359825 Patch for landing 1497139 10 megan_gardner 2019-01-22 17:59:12 -0800 <rdar://problem/47056717> 1497147 11 359825 commit-queue 2019-01-22 18:12:14 -0800 Comment on attachment 359825 Patch for landing Clearing flags on attachment: 359825 Committed r240316: <https://trac.webkit.org/changeset/240316> 1497148 12 commit-queue 2019-01-22 18:12:15 -0800 All reviewed patches have been landed. Closing bug. 359780 2019-01-22 14:50:25 -0800 2019-01-22 15:12:56 -0800 Patch bug-193687-20190122145024.patch text/plain 2467 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5YWZkOWQ3NDViNjAzOTI2 N2I4MzM5NThlZjg0N2E0OTQyZGZmMDguLmMxMGVkZjYzNTM4MDgyNjA3YzQzN2NjMzljN2QwZGQ3 YzNkYzczNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5jZWwgV2ViIFRv dWNoZXMgUHJvcGVybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MzY4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENhbmNlbCB3ZWIgZ2VzdHVyZXMgd2hlbiBhIGxvbmcgcHJlc3MgaXMgcmVjb2duaXpl ZC4KKworICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBfY2FuY2VsV2ViR2VzdHVyZVJlY29nbml6ZXJdKToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBfbG9uZ1ByZXNzUmVjb2duaXplZDpdKToKKwogMjAxOS0wMS0yMiAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBtb3Jl IGJ1aWxkcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtp dFNQSS5oIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKaW5kZXgg N2E4ZTg3MGI5NTI0ZTk1OTk4Y2UxZWQxZGU4Y2RiMzEwZDNhN2I5NC4uYjVjM2UzNGMyMWNjMDlk YzBjZDNlYThjNGQ3YWZmMmU1OGZiNDVkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0 Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkv aW9zL1VJS2l0U1BJLmgKQEAgLTc1OCw2ICs3NTgsNyBAQCBzdHJ1Y3QgX1VJV2ViVG91Y2hFdmVu dCB7CiAKIEBpbnRlcmZhY2UgVUlXZWJUb3VjaEV2ZW50c0dlc3R1cmVSZWNvZ25pemVyICgpCiAt IChpZClpbml0V2l0aFRhcmdldDooaWQpdGFyZ2V0IGFjdGlvbjooU0VMKWFjdGlvbiB0b3VjaERl bGVnYXRlOihpZCA8VUlXZWJUb3VjaEV2ZW50c0dlc3R1cmVSZWNvZ25pemVyRGVsZWdhdGU+KWRl bGVnYXRlOworLSAodm9pZCljYW5jZWw7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgZ2V0dGVyPWlz RGVmYXVsdFByZXZlbnRlZCkgQk9PTCBkZWZhdWx0UHJldmVudGVkOwogQHByb3BlcnR5IChub25h dG9taWMsIHJlYWRvbmx5KSBCT09MIGluSmF2YVNjcmlwdEdlc3R1cmU7CiBAcHJvcGVydHkgKG5v bmF0b21pYywgcmVhZG9ubHkpIENHUG9pbnQgbG9jYXRpb25JbldpbmRvdzsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CmluZGV4IDY2ODE4YzZlYWU4OTcxYzdhNGMwZTI2MDU5OWMzNTdmZjFhODM2YzguLmZkOWI4NGYx ZTdkMGMyMWU1NzA2MGIwNWRmNTRiNDk4Yjg4NmNkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTM0 OCw2ICsxMzQ4LDExIEBAIC0gKHZvaWQpX2NhbmNlbExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVy CiAgICAgW19oaWdobGlnaHRMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplciBjYW5jZWxdOwogfQog CistICh2b2lkKV9jYW5jZWxXZWJHZXN0dXJlUmVjb2duaXplcgoreworICAgIFtfdG91Y2hFdmVu dEdlc3R1cmVSZWNvZ25pemVyIGNhbmNlbF07Cit9CisKIC0gKHZvaWQpX2RpZFNjcm9sbAogewog ICAgIFtzZWxmIF9jYW5jZWxMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplcl07CkBAIC0xOTc5LDYg KzE5ODQsNyBAQCAtICh2b2lkKV9sb25nUHJlc3NSZWNvZ25pemVkOihVSUxvbmdQcmVzc0dlc3R1 cmVSZWNvZ25pemVyICopZ2VzdHVyZVJlY29nbml6ZXIKIHsKICAgICBBU1NFUlQoZ2VzdHVyZVJl Y29nbml6ZXIgPT0gX2xvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyKTsKICAgICBbc2VsZiBfcmVz ZXRJc0RvdWJsZVRhcFBlbmRpbmddOworICAgIFtzZWxmIF9jYW5jZWxXZWJHZXN0dXJlUmVjb2du aXplcl07CiAKICAgICBfbGFzdEludGVyYWN0aW9uTG9jYXRpb24gPSBnZXN0dXJlUmVjb2duaXpl ci5zdGFydFBvaW50OwogCg== 359786 2019-01-22 15:13:01 -0800 2019-01-22 15:48:26 -0800 Patch bug-193687-20190122151301.patch text/plain 2574 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5YWZkOWQ3NDViNjAzOTI2 N2I4MzM5NThlZjg0N2E0OTQyZGZmMDguLmFhMmYxYjVmMjdmMTBjYTE3MjgzMGM2N2VmMzZlNTAz OGNlOGRhOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5jZWwgV2ViIFRv dWNoZXMgUHJvcGVybHkgc28gdGhhdCBsb25nIHByZXNzZXMgb24gWW91VHViZSBsaW5rcyBkbyBu b3QgaW5jb3JyZWN0bHkgdHJpZ2dlciBhIGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcw NTY3MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2FuY2VsIHdlYiBnZXN0dXJlcyB3aGVuIGEgbG9uZyBwcmVzcyBpcyByZWNvZ25pemVkLgorCisg ICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9jYW5jZWxXZWJHZXN0dXJlUmVjb2duaXplcl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9sb25nUHJlc3NSZWNvZ25pemVkOl0pOgorCiAyMDE5LTAxLTIyICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IG1vcmUgYnVpbGRz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgg Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAppbmRleCA3YThlODcw Yjk1MjRlOTU5OThjZTFlZDFkZThjZGIzMTBkM2E3Yjk0Li5iNWMzZTM0YzIxY2MwOWRjMGNkM2Vh OGM0ZDdhZmYyZTU4ZmI0NWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3Nw aS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaApAQCAtNzU4LDYgKzc1OCw3IEBAIHN0cnVjdCBfVUlXZWJUb3VjaEV2ZW50IHsKIAog QGludGVyZmFjZSBVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJlY29nbml6ZXIgKCkKIC0gKGlkKWlu aXRXaXRoVGFyZ2V0OihpZCl0YXJnZXQgYWN0aW9uOihTRUwpYWN0aW9uIHRvdWNoRGVsZWdhdGU6 KGlkIDxVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJlY29nbml6ZXJEZWxlZ2F0ZT4pZGVsZWdhdGU7 CistICh2b2lkKWNhbmNlbDsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBnZXR0ZXI9aXNEZWZhdWx0 UHJldmVudGVkKSBCT09MIGRlZmF1bHRQcmV2ZW50ZWQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywg cmVhZG9ubHkpIEJPT0wgaW5KYXZhU2NyaXB0R2VzdHVyZTsKIEBwcm9wZXJ0eSAobm9uYXRvbWlj LCByZWFkb25seSkgQ0dQb2ludCBsb2NhdGlvbkluV2luZG93OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXgg NjY4MThjNmVhZTg5NzFjN2E0YzBlMjYwNTk5YzM1N2ZmMWE4MzZjOC4uZmQ5Yjg0ZjFlN2QwYzIx ZTU3MDYwYjA1ZGY1NGI0OThiODg2Y2RiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xMzQ4LDYgKzEz NDgsMTEgQEAgLSAodm9pZClfY2FuY2VsTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIKICAgICBb X2hpZ2hsaWdodExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyIGNhbmNlbF07CiB9CiAKKy0gKHZv aWQpX2NhbmNlbFdlYkdlc3R1cmVSZWNvZ25pemVyCit7CisgICAgW190b3VjaEV2ZW50R2VzdHVy ZVJlY29nbml6ZXIgY2FuY2VsXTsKK30KKwogLSAodm9pZClfZGlkU2Nyb2xsCiB7CiAgICAgW3Nl bGYgX2NhbmNlbExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyXTsKQEAgLTE5NzksNiArMTk4NCw3 IEBAIC0gKHZvaWQpX2xvbmdQcmVzc1JlY29nbml6ZWQ6KFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29n bml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogewogICAgIEFTU0VSVChnZXN0dXJlUmVjb2duaXpl ciA9PSBfbG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIpOwogICAgIFtzZWxmIF9yZXNldElzRG91 YmxlVGFwUGVuZGluZ107CisgICAgW3NlbGYgX2NhbmNlbFdlYkdlc3R1cmVSZWNvZ25pemVyXTsK IAogICAgIF9sYXN0SW50ZXJhY3Rpb25Mb2NhdGlvbiA9IGdlc3R1cmVSZWNvZ25pemVyLnN0YXJ0 UG9pbnQ7CiAK 359791 2019-01-22 15:48:27 -0800 2019-01-22 17:57:04 -0800 Patch bug-193687-20190122154826.patch text/plain 2625 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5YWZkOWQ3NDViNjAzOTI2 N2I4MzM5NThlZjg0N2E0OTQyZGZmMDguLmFhMmYxYjVmMjdmMTBjYTE3MjgzMGM2N2VmMzZlNTAz OGNlOGRhOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5jZWwgV2ViIFRv dWNoZXMgUHJvcGVybHkgc28gdGhhdCBsb25nIHByZXNzZXMgb24gWW91VHViZSBsaW5rcyBkbyBu b3QgaW5jb3JyZWN0bHkgdHJpZ2dlciBhIGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcw NTY3MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2FuY2VsIHdlYiBnZXN0dXJlcyB3aGVuIGEgbG9uZyBwcmVzcyBpcyByZWNvZ25pemVkLgorCisg ICAgICAgICogUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9jYW5jZWxXZWJHZXN0dXJlUmVjb2duaXplcl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9sb25nUHJlc3NSZWNvZ25pemVkOl0pOgorCiAyMDE5LTAxLTIyICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IG1vcmUgYnVpbGRz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgg Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAppbmRleCA3YThlODcw Yjk1MjRlOTU5OThjZTFlZDFkZThjZGIzMTBkM2E3Yjk0Li5iNWMzZTM0YzIxY2MwOWRjMGNkM2Vh OGM0ZDdhZmYyZTU4ZmI0NWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3Nw aS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaApAQCAtNzU4LDYgKzc1OCw3IEBAIHN0cnVjdCBfVUlXZWJUb3VjaEV2ZW50IHsKIAog QGludGVyZmFjZSBVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJlY29nbml6ZXIgKCkKIC0gKGlkKWlu aXRXaXRoVGFyZ2V0OihpZCl0YXJnZXQgYWN0aW9uOihTRUwpYWN0aW9uIHRvdWNoRGVsZWdhdGU6 KGlkIDxVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJlY29nbml6ZXJEZWxlZ2F0ZT4pZGVsZWdhdGU7 CistICh2b2lkKWNhbmNlbDsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBnZXR0ZXI9aXNEZWZhdWx0 UHJldmVudGVkKSBCT09MIGRlZmF1bHRQcmV2ZW50ZWQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywg cmVhZG9ubHkpIEJPT0wgaW5KYXZhU2NyaXB0R2VzdHVyZTsKIEBwcm9wZXJ0eSAobm9uYXRvbWlj LCByZWFkb25seSkgQ0dQb2ludCBsb2NhdGlvbkluV2luZG93OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXgg NjY4MThjNmVhZTg5NzFjN2E0YzBlMjYwNTk5YzM1N2ZmMWE4MzZjOC4uMmVjMzc4MTJhNzVmY2Qz OGQxYTcwYjI2ZmI3MjNhYTQ1YmE0NDU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xMzQ4LDYgKzEz NDgsMTMgQEAgLSAodm9pZClfY2FuY2VsTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIKICAgICBb X2hpZ2hsaWdodExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyIGNhbmNlbF07CiB9CiAKKy0gKHZv aWQpX2NhbmNlbFdlYkdlc3R1cmVSZWNvZ25pemVyCit7CisjaWYgSEFWRShDQU5DRUxfV0VCX1RP VUNIX0VWRU5UU19HRVNUVVJFKQorICAgIFtfdG91Y2hFdmVudEdlc3R1cmVSZWNvZ25pemVyIGNh bmNlbF07CisjZW5kaWYKK30KKwogLSAodm9pZClfZGlkU2Nyb2xsCiB7CiAgICAgW3NlbGYgX2Nh bmNlbExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyXTsKQEAgLTE5NzksNiArMTk4Niw3IEBAIC0g KHZvaWQpX2xvbmdQcmVzc1JlY29nbml6ZWQ6KFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIg KilnZXN0dXJlUmVjb2duaXplcgogewogICAgIEFTU0VSVChnZXN0dXJlUmVjb2duaXplciA9PSBf bG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIpOwogICAgIFtzZWxmIF9yZXNldElzRG91YmxlVGFw UGVuZGluZ107CisgICAgW3NlbGYgX2NhbmNlbFdlYkdlc3R1cmVSZWNvZ25pemVyXTsKIAogICAg IF9sYXN0SW50ZXJhY3Rpb25Mb2NhdGlvbiA9IGdlc3R1cmVSZWNvZ25pemVyLnN0YXJ0UG9pbnQ7 CiAK 359825 2019-01-22 17:57:05 -0800 2019-01-22 18:12:14 -0800 Patch for landing bug-193687-20190122175705.patch text/plain 2635 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5YWZkOWQ3NDViNjAzOTI2 N2I4MzM5NThlZjg0N2E0OTQyZGZmMDguLjY3MzA3NTQxZTQ0NTE5NDVmY2NjMDEyZjhmMzlkNjQw MDc4YTcyY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDEtMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5jZWwgV2ViIFRv dWNoZXMgUHJvcGVybHkgc28gdGhhdCBsb25nIHByZXNzZXMgb24gWW91VHViZSBsaW5rcyBkbyBu b3QgaW5jb3JyZWN0bHkgdHJpZ2dlciBhIGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcw NTY3MTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBDYW5j ZWwgd2ViIGdlc3R1cmVzIHdoZW4gYSBsb25nIHByZXNzIGlzIHJlY29nbml6ZWQuCisKKyAgICAg ICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg X2NhbmNlbFdlYkdlc3R1cmVSZWNvZ25pemVyXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg X2xvbmdQcmVzc1JlY29nbml6ZWQ6XSk6CisKIDIwMTktMDEtMjIgIEFsZXggQ2hyaXN0ZW5zZW4g IDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggbW9yZSBidWlsZHMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1Nv dXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDdhOGU4NzBiOTUy NGU5NTk5OGNlMWVkMWRlOGNkYjMxMGQzYTdiOTQuLmI1YzNlMzRjMjFjYzA5ZGMwY2QzZWE4YzRk N2FmZjJlNThmYjQ1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lv cy9VSUtpdFNQSS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ SS5oCkBAIC03NTgsNiArNzU4LDcgQEAgc3RydWN0IF9VSVdlYlRvdWNoRXZlbnQgewogCiBAaW50 ZXJmYWNlIFVJV2ViVG91Y2hFdmVudHNHZXN0dXJlUmVjb2duaXplciAoKQogLSAoaWQpaW5pdFdp dGhUYXJnZXQ6KGlkKXRhcmdldCBhY3Rpb246KFNFTClhY3Rpb24gdG91Y2hEZWxlZ2F0ZTooaWQg PFVJV2ViVG91Y2hFdmVudHNHZXN0dXJlUmVjb2duaXplckRlbGVnYXRlPilkZWxlZ2F0ZTsKKy0g KHZvaWQpY2FuY2VsOwogQHByb3BlcnR5IChub25hdG9taWMsIGdldHRlcj1pc0RlZmF1bHRQcmV2 ZW50ZWQpIEJPT0wgZGVmYXVsdFByZXZlbnRlZDsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFk b25seSkgQk9PTCBpbkphdmFTY3JpcHRHZXN0dXJlOwogQHByb3BlcnR5IChub25hdG9taWMsIHJl YWRvbmx5KSBDR1BvaW50IGxvY2F0aW9uSW5XaW5kb3c7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA2Njgx OGM2ZWFlODk3MWM3YTRjMGUyNjA1OTljMzU3ZmYxYTgzNmM4Li5kM2Y5ZjEyZWZjNjk0M2JjMGE0 MTk4NWIyZmFhMDc3OWVmMzRiNTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTEzNDgsNiArMTM0OCwx MyBAQCAtICh2b2lkKV9jYW5jZWxMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplcgogICAgIFtfaGln aGxpZ2h0TG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIgY2FuY2VsXTsKIH0KIAorLSAodm9pZClf Y2FuY2VsVG91Y2hFdmVudEdlc3R1cmVSZWNvZ25pemVyCit7CisjaWYgSEFWRShDQU5DRUxfV0VC X1RPVUNIX0VWRU5UU19HRVNUVVJFKQorICAgIFtfdG91Y2hFdmVudEdlc3R1cmVSZWNvZ25pemVy IGNhbmNlbF07CisjZW5kaWYKK30KKwogLSAodm9pZClfZGlkU2Nyb2xsCiB7CiAgICAgW3NlbGYg X2NhbmNlbExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyXTsKQEAgLTE5NzksNiArMTk4Niw3IEBA IC0gKHZvaWQpX2xvbmdQcmVzc1JlY29nbml6ZWQ6KFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6 ZXIgKilnZXN0dXJlUmVjb2duaXplcgogewogICAgIEFTU0VSVChnZXN0dXJlUmVjb2duaXplciA9 PSBfbG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIpOwogICAgIFtzZWxmIF9yZXNldElzRG91Ymxl VGFwUGVuZGluZ107CisgICAgW3NlbGYgX2NhbmNlbFRvdWNoRXZlbnRHZXN0dXJlUmVjb2duaXpl cl07CiAKICAgICBfbGFzdEludGVyYWN0aW9uTG9jYXRpb24gPSBnZXN0dXJlUmVjb2duaXplci5z dGFydFBvaW50OwogCg==