193676 2019-01-22 11:16:22 -0800 check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters 2019-01-22 14:52:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193654 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen ap commit-queue ddkilzer ews-watchlist glenn lforschler thorton webkit-bug-importer oldest_to_newest 1496843 0 ddkilzer 2019-01-22 11:16:22 -0800 check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters. Happens with Bug 193654 Attachment 359696 patch on these lines: PreviewConverter::PreviewConverter(id delegate, const ResourceResponse& response, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithConnection:nil delegate:delegate response:response.nsURLResponse() options:optionsWithPassword(password)]) } PreviewConverter::PreviewConverter(NSData *data, const String& uti, const String& password) - : m_platformConverter { adoptNS([allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } + : m_platformConverter { adoptNS([PAL::allocQLPreviewConverterInstance() initWithData:data name:nil uti:uti options:optionsWithPassword(password)]) } Basically, the whitespace/init method needs to ignore the colon at the beginning of the line inside the first C++ initialization parameter. 1496866 1 359759 ddkilzer 2019-01-22 11:57:34 -0800 Created attachment 359759 Patch v1 1496998 2 359759 commit-queue 2019-01-22 14:51:24 -0800 Comment on attachment 359759 Patch v1 Clearing flags on attachment: 359759 Committed r240299: <https://trac.webkit.org/changeset/240299> 1496999 3 commit-queue 2019-01-22 14:51:26 -0800 All reviewed patches have been landed. Closing bug. 1497000 4 webkit-bug-importer 2019-01-22 14:52:28 -0800 <rdar://problem/47461487> 359759 2019-01-22 11:57:34 -0800 2019-01-22 14:51:24 -0800 Patch v1 bug-193676-20190122115734.patch text/plain 6433 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjZmMWYwMDM2YzE1OGFhYzk0Y2Q5NTNlMzQ5ZTkwMjEz NGIzYzg3Ni4uNWU4YTY0ODVhZTBjNTMxOTE1MjRhZjY1NDI2OWRjZjcyYzlhMTg2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTAxLTIyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHJlcG9ydHMgZmFsc2UtcG9zaXRpdmUgd2hpdGVzcGFj ZS9pbml0IHdhcm5pbmcgaW4gQysrIGluaXRpYWxpemF0aW9uIHBhcmFtZXRlcnMKKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE5MzY3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5OgorICAgICAgICAoY2hlY2tfbWVtYmVyX2luaXRpYWxpemF0aW9uX2xpc3QpOgorICAg ICAgICAtIERvbid0IHJlcG9ydCBtaXNzaW5nIHdoaXRlc3BhY2UgYXJvdW5kIGNvbG9uIGlmIHRo ZSBjb2xvbiBhdAorICAgICAgICAgIHRoZSBzdGFydCBvZiB0aGUgbGluZSBpcyBmb3JtYXR0ZWQg Y29ycmVjdGx5LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfbWVtYmVyX2luaXRp YWxpemF0aW9uX2xpc3QpOgorICAgICAgICAtIEFkZCBhIHRlc3QgZm9yIGEgbWlzc2luZyBwZXJt dXRhdGlvbiBvZiBleGlzdGluZyB0ZXN0cy4KKyAgICAgICAgLSBBZGQgYSB0ZXN0IHRoaXMgZmFs c2UtcG9zaXRpdmUuCisgICAgICAgIC0gQWRkIGJsYW5rIGxpbmVzIGJldHdlZW4gc3VidGVzdHMg dG8gbWFrZSB0aGVtIGVhc2llciB0byByZWFkLgorCiAyMDE5LTAxLTIxICBGdWppaSBIaXJvbm9y aSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV0gbGliZ2Ny eXB0LTEuNy42IGNhbid0IGJlIGNvbXBpbGVkIG9uIFVidW50dSAxOC4xMApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBiZTM3M2NmOGE4OWVlNDQ5 ZDk3OTc2MDc5YTM2MmE0MjQ4NmYxMmFmLi5iZjA3NTkyZWIwNmQ5YzEzOWM5MzZkNGJkYjRlYTE5 N2YwMGZjNWM2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weQpAQCAtMjEwNCw3ICsyMTA0LDcgQEAgZGVmIGNoZWNrX21lbWJlcl9pbml0aWFsaXphdGlv bl9saXN0KGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgIGJlZ2luX2xpbmUg PSBsaW5lCiAgICAgIyBtYXRjaCB0aGUgc3RhcnQgb2YgaW5pdGlhbGl6YXRpb24gbGlzdAogICAg IGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgoZXhwbGljaXRccyspP1teKFxzfFw/ KV0rXChbXlw/XSpcKVxzP1w6fF4oXHN8XD8pKlw6KShbXlw6XXxcWilbXjtdKiQnLCBsaW5lKToK LSAgICAgICAgaWYgc2VhcmNoKHInW146XVw6W15cOlxzXSsnLCBsaW5lKToKKyAgICAgICAgaWYg c2VhcmNoKHInW146XVw6W15cOlxzXSsnLCBsaW5lKSBhbmQgbm90IHNlYXJjaChyJ15ccyo6XHNc UysnLCBsaW5lKToKICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9p bml0JywgNCwKICAgICAgICAgICAgICAgICAnTWlzc2luZyBzcGFjZXMgYXJvdW5kIDonKQogICAg ICAgICBpZiAobm90IGxpbmUubHN0cmlwKCkuc3RhcnRzd2l0aCgnOicpKSBhbmQgc2VhcmNoKHIn W15cc11cKC4qXClccz9cOi4qW147XSokJywgbGluZSk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDc4ZjJmMWRj NDk1YjMxNjEyMTk4NjlkMzgwMzA4MWVmNjIyMTU0ZjYuLmViZmYwNTFkMzJmNzAwZGFkZWY1NDY4 YzM4MmNlYTYzODczOTI1MTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC01NTAzLDI2ICs1NTAzLDMxIEBAIGNs YXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgnZXhwbGljaXQgTXlDbGFzcyhEb2N1bWVudCogZG9jKSA6IE15U3VwZXJDbGFzcygp IHsgfScsCiAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0ZSBsaW5lLCB3 aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwogICAgICAgICAnICBb d2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCisKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnTXlD bGFzczo6TXlDbGFzcyhEb2N1bWVudCogZG9jKSA6IE15U3VwZXJDbGFzcygpIHsgfScsCiAgICAg ICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0ZSBsaW5lLCB3aXRoIHRoZSBjb2xv biBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwogICAgICAgICAnICBbd2hpdGVzcGFjZS9p bmRlbnRdIFs0XScpCisKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KCgKICAg ICAgICAgICAgICdNeUNsYXNzOjpNeUNsYXNzKERvY3VtZW50KiBkb2MpXG4nCiAgICAgICAgICAg ICAnICAgIDogbV9teU1lbWJlcihiID8gYmFyKCkgOiBiYXooKSlcbicKICAgICAgICAgICAgICcg ICAgLCBNeVN1cGVyQ2xhc3MoKVxuJwogICAgICAgICAgICAgJyAgICAsIG1fZG9jKDApXG4nCiAg ICAgICAgICAgICAneyB9JyksICcnKQorCiAgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVf bGludCgnJydcCiAgICAgICAgIE15Q2xhc3M6Ok15Q2xhc3MoRG9jdW1lbnQqIGRvYykgOiBNeVN1 cGVyQ2xhc3MoKQogICAgICAgICB7IH0nJycsCiAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQg b24gYSBzZXBhcmF0ZSBsaW5lLCB3aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0 IGxpbmUuJwogICAgICAgICAnICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCisKICAgICAgICAg c2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KCcnJ1wKICAgICAgICAgTXlDbGFzczo6TXlDbGFz cyhEb2N1bWVudCogZG9jKQogICAgICAgICA6IE15U3VwZXJDbGFzcygpCiAgICAgICAgIHsgfScn JywKICAgICAgICAgJ1dyb25nIG51bWJlciBvZiBzcGFjZXMgYmVmb3JlIHN0YXRlbWVudC4gKGV4 cGVjdGVkOiAxMiknCiAgICAgICAgICcgIFt3aGl0ZXNwYWNlL2luZGVudF0gWzRdJykKKwogICAg ICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJycnXAogICAgICAgICBNeUNsYXNzOjpN eUNsYXNzKERvY3VtZW50KiBkb2MpIDoKICAgICAgICAgICAgIE15U3VwZXJDbGFzcygpLApAQCAt NTUzMiwxOCArNTUzNywyNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFz ZSk6CiAgICAgICAgICAnICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScsCiAgICAgICAgICAnQ29t bWEgc2hvdWxkIGJlIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGxpbmUgaW4gYSBtZW1iZXIgaW5p dGlhbGl6YXRpb24gbGlzdC4nCiAgICAgICAgICAnICBbd2hpdGVzcGFjZS9pbml0XSBbNF0nXSkK KworICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJycnXAorICAgICAgICAgICAg TXlDbGFzczo6TXlDbGFzcyhEb2N1bWVudCogZG9jKTogTXlTdXBlckNsYXNzKCkKKyAgICAgICAg ICAgIHsgfScnJywKKyAgICAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0 ZSBsaW5lLCB3aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJworICAg ICAgICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nKQorCiAgICAgICAgIHNlbGYuYXNz ZXJ0X211bHRpX2xpbmVfbGludCgnJydcCiAgICAgICAgIE15Q2xhc3M6Ok15Q2xhc3MoRG9jdW1l bnQqIGRvYykgOk15U3VwZXJDbGFzcygpCiAgICAgICAgIHsgfScnJywKICAgICAgICAgWydNaXNz aW5nIHNwYWNlcyBhcm91bmQgOiAgW3doaXRlc3BhY2UvaW5pdF0gWzRdJywKICAgICAgICAgICdT aG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0ZSBsaW5lLCB3aXRoIHRoZSBjb2xvbiBvciBj b21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwogICAgICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50 XSBbNF0nXSkKKwogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJycnXAogICAg ICAgICBNeUNsYXNzOjpNeUNsYXNzKERvY3VtZW50KiBkb2MpOk15U3VwZXJDbGFzcygpCiAgICAg ICAgIHsgfScnJywKICAgICAgICAgWydNaXNzaW5nIHNwYWNlcyBhcm91bmQgOiAgW3doaXRlc3Bh Y2UvaW5pdF0gWzRdJywKICAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0 ZSBsaW5lLCB3aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwogICAg ICAgICAgJyAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nXSkKKwogICAgICAgICBzZWxmLmFzc2Vy dF9tdWx0aV9saW5lX2xpbnQoJycnXAogICAgICAgICBNeUNsYXNzOjpNeUNsYXNzKERvY3VtZW50 KiBkb2MpIDogTXlTdXBlckNsYXNzKCkKICAgICAgICAgLE15U3VwZXJDbGFzcygpCkBAIC01NTgy LDYgKzU1OTYsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAg ICAgICAgICAgICA6TXlTdXBlckNsYXNzKCkKICAgICAgICAgeyB9JycnLAogICAgICAgICAnTWlz c2luZyBzcGFjZXMgYXJvdW5kIDogIFt3aGl0ZXNwYWNlL2luaXRdIFs0XScpCisKICAgICAgICAg c2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KCcnJ1wKICAgICAgICAgTXlDbGFzczo6TXlDbGFz cyhEb2N1bWVudCogZG9jKQogICAgICAgICAgICAgOiBNeVN1cGVyQ2xhc3MoKSAsCkBAIC01NTg5 LDIzICs1NjA0LDM1IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToK ICAgICAgICAgeyB9JycnLAogICAgICAgICAnQ29tbWEgc2hvdWxkIGJlIGF0IHRoZSBiZWdpbm5p bmcgb2YgdGhlIGxpbmUgaW4gYSBtZW1iZXIgaW5pdGlhbGl6YXRpb24gbGlzdC4nCiAgICAgICAg ICcgIFt3aGl0ZXNwYWNlL2luaXRdIFs0XScpCisKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlf bGluZV9saW50KCcnJ1wKICAgICAgICAgY2xhc3MgTXlDbGFzcyA6IHB1YmxpYyBHb28gewogICAg ICAgICB9OycnJywKICAgICAgICAgJycpCisKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGlu ZV9saW50KCcnJ1wKICAgICAgICAgY2xhc3MgTXlDbGFzcwogICAgICAgICA6IHB1YmxpYyBHb28K ICAgICAgICAgLCBwdWJsaWMgZm9vIHsKICAgICAgICAgfTsnJycsCiAgICAgICAgICcnKQorCiAg ICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgnJydcCiAgICAgICAgIE15Q2xhc3M6 Ok15Q2xhc3MoRG9jdW1lbnQqIGRvYykKICAgICAgICAgICAgIDogTXlTdXBlckNsYXNzKGRvYywg ZG9jKQogICAgICAgICB7IH0nJycsCiAgICAgICAgICcnKQorCisgICAgICAgIHNlbGYuYXNzZXJ0 X211bHRpX2xpbmVfbGludCgnJydcCisgICAgICAgICAgICBQcmV2aWV3Q29udmVydGVyOjpQcmV2 aWV3Q29udmVydGVyKE5TRGF0YSAqZGF0YSwgY29uc3QgU3RyaW5nJiB1dGksIGNvbnN0IFN0cmlu ZyYgcGFzc3dvcmQpCisgICAgICAgICAgICAgICAgOiBtX3BsYXRmb3JtQ29udmVydGVyIHsgYWRv cHROUyhbYWxsb2NRTFByZXZpZXdDb252ZXJ0ZXJJbnN0YW5jZSgpIGluaXRXaXRoRGF0YTpkYXRh IG5hbWU6bmlsIHV0aTp1dGkgb3B0aW9uczpvcHRpb25zV2l0aFBhc3N3b3JkKHBhc3N3b3JkKV0p IH0KKyAgICAgICAgICAgIHsgfScnJywKKyAgICAgICAgICAgICcnKQorCiAgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJzo6U2hvd1dpbmRvdyhtX292ZXJsYXkpOycsICcnKQorCiAgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJ28gPSBmb28oYiA/IGJhcigpIDogYmF6KCkpOycsICcnKQorCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ01ZTUFDUk8oYSA/IGIoKSA6IGMpOycsICcnKQogCiAgICAg ZGVmIHRlc3RfbWluX3ZlcnNpb25zX29mX3drX2FwaV9hdmFpbGFibGUoc2VsZik6Cg==