193660 2019-01-21 15:50:11 -0800 REGRESSION (r240243): Caused an API tests to fail 2019-01-22 16:32:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193556 1 bfulgham webkit-unassigned ap bfulgham mcatanzaro ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1496664 0 bfulgham 2019-01-21 15:50:11 -0800 Correct an API test failure introduced by my changes in r240243. 1496665 1 webkit-bug-importer 2019-01-21 15:50:42 -0800 <rdar://problem/47433602> 1496692 2 bfulgham 2019-01-21 17:41:13 -0800 My original patch was incrementing the pending callback count before deciding if a callback was actually needed. This left it out of balance, preventing the callback from ever firing. 1496693 3 bfulgham 2019-01-21 17:55:55 -0800 Committed r240247: <https://trac.webkit.org/changeset/240247> 1496789 4 ap 2019-01-22 09:29:41 -0800 Yay tests! 1496791 5 bfulgham 2019-01-22 09:34:14 -0800 (In reply to Alexey Proskuryakov from comment #4) > Yay tests! And for actually paying attention to them! :-) 1497086 6 mcatanzaro 2019-01-22 16:32:30 -0800 Committed r240308: <https://trac.webkit.org/changeset/240308>