193643 2019-01-20 20:03:51 -0800 [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10 2019-02-05 08:03:31 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii agomez aperez bugs-noreply clopez ews-watchlist ltilve mcatanzaro webkit-bug-importer oldest_to_newest 1496495 0 fujii 2019-01-20 20:03:51 -0800 [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10 update-webkitgtk-libs is failing with the following error. > /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher -I.. -I../src -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/src -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Root/include -Wno-error -O2 -g1 -fvisibility=hidden -Wall -MT camellia.lo -MD -MP -MF .deps/camellia.Tpo -c -o camellia.lo /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/camellia.c > In file included from /usr/include/features.h:424, > from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, > from /usr/include/stdio.h:27, > from /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/rijndael-ssse3-amd64.c:38: > /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/rijndael-ssse3-amd64.c: In function '_gcry_aes_ssse3_do_setkey': > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:31:1: error: inlining failed in call to always_inline 'memcpy': target specific option mismatch > __NTH (memcpy (void *__restrict __dest, const void *__restrict __src, > ^~~~~ 1496496 1 fujii 2019-01-20 20:04:26 -0800 I'm using GCC 8.2.0 and Ubuntu 18.10. > fujii@ubuntu $ gcc --version ~/tmp/libgcrypt-1.8.4 > gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0 > Copyright (C) 2018 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > fujii@ubuntu $ lsb_release -a ~/tmp/libgcrypt-1.8.4 > No LSB modules are available. > Distributor ID: Ubuntu > Description: Ubuntu 18.10 > Release: 18.10 > Codename: cosmic > fujii@ubuntu $ ~/tmp/libgcrypt-1.8.4 1496497 2 fujii 2019-01-20 20:05:45 -0800 I've confirmed libgcrypt-1.8.4.tar.bz2 can compile. The following commit removed the memcpy of _gcry_aes_ssse3_do_setkey. https://github.com/gpg/libgcrypt/commit/54c57bc49edb5c00e9ed8103cc4837bb72c5e863 1496499 3 fujii 2019-01-20 20:14:04 -0800 I've found openSUSE is working around a similar issue by setting -U_FORTIFY_SOURCE to CFLAGS. https://www.mail-archive.com/opensuse-commit@opensuse.org/msg135244.html I've confirmed this trick can address the issue of libgcrypt-1.7.6.tar.bz2 for me. 1496509 4 359669 fujii 2019-01-20 21:01:43 -0800 Created attachment 359669 Patch to bump libgcrypt 1496679 5 359669 fujii 2019-01-21 17:19:32 -0800 Comment on attachment 359669 Patch to bump libgcrypt Clearing flags on attachment: 359669 Committed r240245: <https://trac.webkit.org/changeset/240245> 1496680 6 fujii 2019-01-21 17:19:35 -0800 All reviewed patches have been landed. Closing bug. 359669 2019-01-20 21:01:43 -0800 2019-01-21 17:19:32 -0800 Patch to bump libgcrypt bug-193643-20190121140143.patch text/plain 2372 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmJiNDEwMDkzNDY0MDljNjg4OTI3NmI4MzY1NWMyYzY2 MjllODgzOS4uNDRhM2M4NGRiNGE2NWRlNWZkODhiZTViNzM1NWIzNTMyY2ZiNGQyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTAxLTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtHVEtdW1dQRV0gbGliZ2NyeXB0LTEuNy42IGNhbid0IGJlIGNvbXBpbGVk IG9uIFVidW50dSAxOC4xMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkzNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOiBCdW1wZWQgdG8gbGliZ2NyeXB0LTEuOC40 LgorICAgICAgICAqIHdwZS9qaGJ1aWxkLm1vZHVsZXM6IERpdHRvLgorCiAyMDE5LTAxLTE3ICBX ZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIENv bnRlbnQgb2Zmc2V0IGp1bXBzIGVycmF0aWNhbGx5IHdoZW4gYXV0b3Njcm9sbGluZyBuZWFyIHNj cm9sbCB2aWV3IGNvbnRlbnQgaW5zZXQgYXJlYXMKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1 aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IGEzM2I1ZjMzMDVi ZTRiZTA0ODkyM2MwMmJhMjdjNGNkNTc4YmYyNGMuLmYzMmJmYWYxNWFkOWVhNGFkOTI4YWNjYmY2 NzY2MGVhY2IwNzQxNWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysr IGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtNDQ1LDEwICs0NDUsMTAgQEAKIAogICA8 YXV0b3Rvb2xzIGlkPSJsaWJnY3J5cHQiCiAgICAgICAgICAgICAgYXV0b2dlbi1zaD0iY29uZmln dXJlIj4KLSAgICA8YnJhbmNoIG1vZHVsZT0ibGliZ2NyeXB0L2xpYmdjcnlwdC0xLjcuNi50YXIu YnoyIgotICAgICAgICAgICAgdmVyc2lvbj0iMS43LjYiCisgICAgPGJyYW5jaCBtb2R1bGU9Imxp YmdjcnlwdC9saWJnY3J5cHQtJHt2ZXJzaW9ufS50YXIuYnoyIgorICAgICAgICAgICAgdmVyc2lv bj0iMS44LjQiCiAgICAgICAgICAgICByZXBvPSJnbnVwZy5vcmciCi0gICAgICAgICAgICBoYXNo PSJzaGEyNTY6NjI2YWFmZWU4NGFmOWQyY2UyNTNkMmMxNDNkYzFjMDkwMmRkYTA0NTc4MGNjMjQx ZjM5OTcwZmM2MGJlMDViYyI+CisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZjYzODE0M2EwNjcy NjI4ZmRlMGNhZDc0NWU5YjE0ZGViODVkZmZiMTc1NzA5Y2FjYzFmNGZlMjRiOTNmMjIyNyI+CiAg ICAgICAgIDxwYXRjaCBmaWxlPSJsaWJnY3J5cHQtdXNlLW9ubHktZGV2LXVyYW5kb20tZm9yLXRl c3RpbmcucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAgPC9icmFuY2g+CiAgICAgPGRlcGVuZGVuY2ll cz4KZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy93cGUvamhi dWlsZC5tb2R1bGVzCmluZGV4IGFmYWVhZDhkYmVhNDIxNDc2ZDc2NGE1YzliYWQ0MGNiY2NkZTEz YTQuLjYxN2NlM2UwNmI2YjlkM2UxY2VhZjVkNTM3MDRjMzU1MjI3YWE4MGQgMTAwNjQ0Ci0tLSBh L1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxl cwpAQCAtMTk0LDEwICsxOTQsMTAgQEAKICAgPC9hdXRvdG9vbHM+CiAKICAgPGF1dG90b29scyBp ZD0ibGliZ2NyeXB0IiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgotICAgIDxicmFuY2ggbW9kdWxl PSJsaWJnY3J5cHQvbGliZ2NyeXB0LTEuNy42LnRhci5iejIiCi0gICAgICAgICAgICB2ZXJzaW9u PSIxLjcuNiIKKyAgICA8YnJhbmNoIG1vZHVsZT0ibGliZ2NyeXB0L2xpYmdjcnlwdC0ke3ZlcnNp b259LnRhci5iejIiCisgICAgICAgICAgICB2ZXJzaW9uPSIxLjguNCIKICAgICAgICAgICAgIHJl cG89ImdudXBnLm9yZyIKLSAgICAgICAgICAgIGhhc2g9InNoYTI1Njo2MjZhYWZlZTg0YWY5ZDJj ZTI1M2QyYzE0M2RjMWMwOTAyZGRhMDQ1NzgwY2MyNDFmMzk5NzBmYzYwYmUwNWJjIj4KKyAgICAg ICAgICAgIGhhc2g9InNoYTI1NjpmNjM4MTQzYTA2NzI2MjhmZGUwY2FkNzQ1ZTliMTRkZWI4NWRm ZmIxNzU3MDljYWNjMWY0ZmUyNGI5M2YyMjI3Ij4KICAgICAgICAgPHBhdGNoIGZpbGU9ImxpYmdj cnlwdC11c2Utb25seS1kZXYtdXJhbmRvbS1mb3ItdGVzdGluZy5wYXRjaCIgc3RyaXA9IjEiLz4K ICAgICA8L2JyYW5jaD4KICAgICA8ZGVwZW5kZW5jaWVzPgo=