193630 2019-01-20 14:38:48 -0800 REGRESSION(r240174): Wrong preprocessor guards in RenderImage::paintAreaElementFocusRing 2019-02-07 01:47:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193583 InRadar, Regression P1 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue dbates magomez mcatanzaro webkit-bug-importer oldest_to_newest 1496400 0 mcatanzaro 2019-01-20 14:38:48 -0800 Layout test fast/images/image-map-outline-in-positioned-container.html is failing for GTK since r240174 "CSS auto focus-ring outlines don't render on iOS". The autofocus is no longer rendered: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r240208%20(9437)/fast/images/image-map-outline-in-positioned-container-diffs.html I think the problem is in RenderImage::paintAreaElementFocusRing. Here some code that used to be cross-platform was changed to be Cocoa-specific by moving it inside the Cocoa-specific ENABLE(FULL_KEYBOARD_ACCESS) guard. I'm not sure what the right guard would be here, but perhaps !PLATFORM(IOS_FAMILY) || ENABLE(FULL_KEYBOARD_ACCESS) would do the trick. 1496401 1 mcatanzaro 2019-01-20 14:40:08 -0800 Note: I'm adding a failure expectation for this test, which should be removed when fixed. 1496426 2 dbates 2019-01-20 15:39:43 -0800 (In reply to Michael Catanzaro from comment #0) > Layout test fast/images/image-map-outline-in-positioned-container.html is > failing for GTK since r240174 "CSS auto focus-ring outlines don't render on > iOS". The autofocus is no longer rendered: > > https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/ > r240208%20(9437)/fast/images/image-map-outline-in-positioned-container-diffs. > html > > I think the problem is in RenderImage::paintAreaElementFocusRing. Yes, there is a problem here. Oops! Shouldn't have tried to do two things at once: inverting the if-else and get this code working for PLATFORM(IOS_FAMILY) && ENABLE(FULL_KEYBOARD_ACCESS). > Here some > code that used to be cross-platform was changed to be Cocoa-specific by > moving it inside the Cocoa-specific ENABLE(FULL_KEYBOARD_ACCESS) guard. I'm > not sure what the right guard would be here, but perhaps > !PLATFORM(IOS_FAMILY) || ENABLE(FULL_KEYBOARD_ACCESS) would do the trick. Yes, that would fix it! I am not near a computer with a checkout. If you can fix I would appreciate it. 1496427 3 mcatanzaro 2019-01-20 15:40:30 -0800 OK! 1496428 4 dbates 2019-01-20 15:45:37 -0800 (In reply to Michael Catanzaro from comment #3) > OK! Thank you, Michael! 1496459 5 mcatanzaro 2019-01-20 17:52:24 -0800 (In reply to Michael Catanzaro from comment #1) > Note: I'm adding a failure expectation for this test, which should be > removed when fixed. I didn't actually commit the expectation yet, so nevermind that. 1496460 6 359663 mcatanzaro 2019-01-20 17:58:15 -0800 Created attachment 359663 Patch 1496481 7 359663 commit-queue 2019-01-20 19:25:49 -0800 Comment on attachment 359663 Patch Clearing flags on attachment: 359663 Committed r240221: <https://trac.webkit.org/changeset/240221> 1496482 8 commit-queue 2019-01-20 19:25:51 -0800 All reviewed patches have been landed. Closing bug. 1496483 9 webkit-bug-importer 2019-01-20 19:26:28 -0800 <rdar://problem/47419540> 1503677 10 magomez 2019-02-07 01:47:42 -0800 This made fast/images/image-map-outline-in-positioned-container.html to properly pass, so updating expectation. 359663 2019-01-20 17:58:15 -0800 2019-01-20 19:25:49 -0800 Patch bug-193630-20190120195814.patch text/plain 1581 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU0OTFmNmQ3MGQ3MmE1 YjQzOTJmZGFkNWJjMWY2ZjYzMTQ4NjNiMS4uNTZjZDlkOTQyYTgyNjU5M2E4NzEwNzNlNWVjMWNk YWQ4Y2IyMGZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIyNDAxNzQpOiBXcm9uZyBwcmVwcm9jZXNzb3IgZ3VhcmRzIGluIFJlbmRlckltYWdlOjpw YWludEFyZWFFbGVtZW50Rm9jdXNSaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICByMjQwMTc0IGluYWR2ZXJ0ZW50bHkgZGlzYWJsZWQgdGhpcyBmdW5j dGlvbiBvbiBub24tQXBwbGUgcGxhdGZvcm1zLgorCisgICAgICAgIFRoaXMgZml4ZXMgbGF5b3V0 IHRlc3QgZmFzdC9pbWFnZXMvaW1hZ2UtbWFwLW91dGxpbmUtaW4tcG9zaXRpb25lZC1jb250YWlu ZXIuaHRtbC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJJbWFnZTo6cGFpbnRBcmVhRWxlbWVudEZvY3VzUmluZyk6CisKIDIw MTktMDEtMjAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzgyNzUuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckltYWdlLmNwcAppbmRleCAxODNhOTM0MTk0OGNiMmRmMDZjOGQzYmJiYjM0 NjI1NTc1NGZiMTU3Li41MTYyYWMzZGI4NjEzNTZjMWI5MzI3MWI3OTYzMGM2Y2M0ZjU3MGVhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKQEAgLTU1MCw3ICs1NTAs NyBAQCB2b2lkIFJlbmRlckltYWdlOjpwYWludChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3Qg TGF5b3V0UG9pbnQmIHBhaW50T2Zmc2V0KQogICAgIAogdm9pZCBSZW5kZXJJbWFnZTo6cGFpbnRB cmVhRWxlbWVudEZvY3VzUmluZyhQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9p bnQmIHBhaW50T2Zmc2V0KQogewotI2lmIEVOQUJMRShGVUxMX0tFWUJPQVJEX0FDQ0VTUykKKyNp ZiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkgfHwgRU5BQkxFKEZVTExfS0VZQk9BUkRfQUNDRVNTKQog ICAgIGlmIChkb2N1bWVudCgpLnByaW50aW5nKCkgfHwgIWZyYW1lKCkuc2VsZWN0aW9uKCkuaXNG b2N1c2VkQW5kQWN0aXZlKCkpCiAgICAgICAgIHJldHVybjsKICAgICAK