193596 2019-01-18 15:15:10 -0800 Cleanup undo options 2021-08-17 17:48:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 megan_gardner megan_gardner wenson_hsieh oldest_to_newest 1496059 0 megan_gardner 2019-01-18 15:15:10 -0800 Cleanup undo options 1496063 1 359546 megan_gardner 2019-01-18 15:18:49 -0800 Created attachment 359546 Patch 1496082 2 359551 megan_gardner 2019-01-18 16:04:20 -0800 Created attachment 359551 Patch 1496108 3 359551 wenson_hsieh 2019-01-18 17:01:48 -0800 Comment on attachment 359551 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359551&action=review > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=193596 Radar link? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:161 > +enum WKUndoOption { : uint8_t > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:162 > + WKUndoTypeDefault = 0, Nit - extra space before 0 here. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5109 > + if (_suppressSelectionAssistantReasons.contains(WebKit::FocusedElementIsTransparentOrFullyClipped)) We probably want to return Smaller for WebKit::FocusedElementIsTooSmall too. 1785007 4 megan_gardner 2021-08-17 17:48:14 -0700 Old and not relevant anymore. 359546 2019-01-18 15:18:49 -0800 2019-01-18 16:04:19 -0800 Patch bug-193596-20190118151848.patch text/plain 2837 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjOTYwYTVlODZmMjIxZjIy MzNkZjU0ZTc1ZWU5MmIwN2EwNjMyMWQuLjAzMmIyMmI0ZTRiNDNmOGZiNWQ0NjMyMjg3NDVlYmI1 NzMyYmE3MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDEtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwIHVuZG8g b3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmV0dXJuIHRvIGdldCBjb3JyZWN0IHVuZG8gYmVoYXZpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbToKKyAgICAgICAgCiAyMDE5LTAxLTE3ICBKb2huIFdpbGFuZGVyICA8d2ls YW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbmZyYXN0cnVjdHVyZSB0byBlbmFibGUv ZGlzYWJsZSBJVFAgRGVidWcgTW9kZSB0aHJvdWdoIFByZWZlcmVuY2VzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDFmNjNhMzJhNTM5ZGQ2OWEwMTQ5M2Yy OWY0MDBlNDkzNmExNjg1NzguLmZmMjQ0NGEyZWZkZmY0NDg3OWNmMmQ2OTllNGI5ZWE2NjRmMTcw NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC0zMTcs NiArMzE3LDcgQEAgdHlwZWRlZiBlbnVtIHsKIEBlbmQKIAogQGludGVyZmFjZSBVSVJlc3BvbmRl ciAoKQorQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU0ludGVnZXIgdW5kb09wdGlv bjsKIC0gKHZvaWQpX2hhbmRsZUtleVVJRXZlbnQ6KFVJRXZlbnQgKilldmVudDsKIC0gKHZvaWQp X3doZWVsQ2hhbmdlZFdpdGhFdmVudDooVUlFdmVudCAqKWV2ZW50OwogQGVuZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5o IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5o CmluZGV4IGE3ZmZmZjc4ZjMwYTcwZjRmYzU5MGQ3MDVhMWQxOWUzYTM4ODFiZWYuLmJhYjRiYWY1 Y2U3Y2M1OTVlMGFhZWVkZWRiZTNkMDI1NDcyNjQ1ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKQEAgLTE1Nyw2 ICsxNTcsMTEgQEAgZW51bSBTdXBwcmVzc1NlbGVjdGlvbkFzc2lzdGFudFJlYXNvbiA6IHVpbnQ4 X3QgewogICAgIEZvY3VzZWRFbGVtZW50SXNUb29TbWFsbCA9IDEgPDwgMSwKICAgICBEcm9wQW5p bWF0aW9uSXNSdW5uaW5nID0gMSA8PCAyCiB9OworICAgIAorZW51bSBXS1VuZG9PcHRpb24gewor ICAgIFdLVW5kb1R5cGVEZWZhdWx0ID0gIDAsCisgICAgV0tVbmRvVHlwZVNtYWxsZXIgPSAxLAor fTsKIAogc3RydWN0IFdLU2VsZWN0aW9uRHJhd2luZ0luZm8gewogICAgIGVudW0gY2xhc3MgU2Vs ZWN0aW9uVHlwZSB7IE5vbmUsIFBsdWdpbiwgUmFuZ2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDNl NTI5MmE3OGMyYWNmNDYxYTY4MjkzYjNhYWM0MjJjOTBkN2IzYzUuLmZjOWQxYzFiMGIyZWE1ZmEw OGVkZjkzZDAyNmJmYjZjZDhmZWI0YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNTEwNCw2ICs1MTA0 LDEzIEBAIC0gKHZvaWQpc2V0RGF0YUxpc3RUZXh0U3VnZ2VzdGlvbnM6KE5TQXJyYXk8VUlUZXh0 U3VnZ2VzdGlvbiAqPiAqKXRleHRTdWdnZXN0aW9uCiAKICNlbmRpZgogCistIChOU0ludGVnZXIp dW5kb09wdGlvbgoreworICAgIGlmIChfc3VwcHJlc3NTZWxlY3Rpb25Bc3Npc3RhbnRSZWFzb25z LmNvbnRhaW5zKFdlYktpdDo6Rm9jdXNlZEVsZW1lbnRJc1RyYW5zcGFyZW50T3JGdWxseUNsaXBw ZWQpKSB7CisgICAgICAgIHJldHVybiBXZWJLaXQ6OldLVW5kb1R5cGVTbWFsbGVyOworICAgIHJl dHVybiBXZWJLaXQ6OldLVW5kb1R5cGVEZWZhdWx0OworfQorCiAtICh2b2lkKXVwZGF0ZVRleHRT dWdnZXN0aW9uc0ZvcklucHV0RGVsZWdhdGUKIHsKICAgICAvLyBUZXh0IHN1Z2dlc3Rpb25zIHZl bmRlZCBmcm9tIGNsaWVudHMgdGFrZSBwcmVjZWRlbmNlIG92ZXIgdGV4dCBzdWdnZXN0aW9ucyBm cm9tIGEgZm9jdXNlZCBmb3JtIGNvbnRyb2wgd2l0aCBhIGRhdGFsaXN0Lgo= 359551 2019-01-18 16:04:20 -0800 2019-01-18 17:01:48 -0800 Patch bug-193596-20190118160419.patch text/plain 2835 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjOTYwYTVlODZmMjIxZjIy MzNkZjU0ZTc1ZWU5MmIwN2EwNjMyMWQuLjAzMmIyMmI0ZTRiNDNmOGZiNWQ0NjMyMjg3NDVlYmI1 NzMyYmE3MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDEtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwIHVuZG8g b3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmV0dXJuIHRvIGdldCBjb3JyZWN0IHVuZG8gYmVoYXZpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbToKKyAgICAgICAgCiAyMDE5LTAxLTE3ICBKb2huIFdpbGFuZGVyICA8d2ls YW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbmZyYXN0cnVjdHVyZSB0byBlbmFibGUv ZGlzYWJsZSBJVFAgRGVidWcgTW9kZSB0aHJvdWdoIFByZWZlcmVuY2VzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJLaXQv UGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDFmNjNhMzJhNTM5ZGQ2OWEwMTQ5M2Yy OWY0MDBlNDkzNmExNjg1NzguLmZmMjQ0NGEyZWZkZmY0NDg3OWNmMmQ2OTllNGI5ZWE2NjRmMTcw NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC0zMTcs NiArMzE3LDcgQEAgdHlwZWRlZiBlbnVtIHsKIEBlbmQKIAogQGludGVyZmFjZSBVSVJlc3BvbmRl ciAoKQorQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU0ludGVnZXIgdW5kb09wdGlv bjsKIC0gKHZvaWQpX2hhbmRsZUtleVVJRXZlbnQ6KFVJRXZlbnQgKilldmVudDsKIC0gKHZvaWQp X3doZWVsQ2hhbmdlZFdpdGhFdmVudDooVUlFdmVudCAqKWV2ZW50OwogQGVuZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5o IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5o CmluZGV4IGE3ZmZmZjc4ZjMwYTcwZjRmYzU5MGQ3MDVhMWQxOWUzYTM4ODFiZWYuLmJhYjRiYWY1 Y2U3Y2M1OTVlMGFhZWVkZWRiZTNkMDI1NDcyNjQ1ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKQEAgLTE1Nyw2 ICsxNTcsMTEgQEAgZW51bSBTdXBwcmVzc1NlbGVjdGlvbkFzc2lzdGFudFJlYXNvbiA6IHVpbnQ4 X3QgewogICAgIEZvY3VzZWRFbGVtZW50SXNUb29TbWFsbCA9IDEgPDwgMSwKICAgICBEcm9wQW5p bWF0aW9uSXNSdW5uaW5nID0gMSA8PCAyCiB9OworICAgIAorZW51bSBXS1VuZG9PcHRpb24gewor ICAgIFdLVW5kb1R5cGVEZWZhdWx0ID0gIDAsCisgICAgV0tVbmRvVHlwZVNtYWxsZXIgPSAxLAor fTsKIAogc3RydWN0IFdLU2VsZWN0aW9uRHJhd2luZ0luZm8gewogICAgIGVudW0gY2xhc3MgU2Vs ZWN0aW9uVHlwZSB7IE5vbmUsIFBsdWdpbiwgUmFuZ2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDNl NTI5MmE3OGMyYWNmNDYxYTY4MjkzYjNhYWM0MjJjOTBkN2IzYzUuLjY4MDQwYWE3MDc4OWJmYzQ0 MGUyYTdlMmM5ZTg5MGRjODVkZmUzNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNTEwNCw2ICs1MTA0 LDEzIEBAIC0gKHZvaWQpc2V0RGF0YUxpc3RUZXh0U3VnZ2VzdGlvbnM6KE5TQXJyYXk8VUlUZXh0 U3VnZ2VzdGlvbiAqPiAqKXRleHRTdWdnZXN0aW9uCiAKICNlbmRpZgogCistIChOU0ludGVnZXIp dW5kb09wdGlvbgoreworICAgIGlmIChfc3VwcHJlc3NTZWxlY3Rpb25Bc3Npc3RhbnRSZWFzb25z LmNvbnRhaW5zKFdlYktpdDo6Rm9jdXNlZEVsZW1lbnRJc1RyYW5zcGFyZW50T3JGdWxseUNsaXBw ZWQpKQorICAgICAgICByZXR1cm4gV2ViS2l0OjpXS1VuZG9UeXBlU21hbGxlcjsKKyAgICByZXR1 cm4gV2ViS2l0OjpXS1VuZG9UeXBlRGVmYXVsdDsKK30KKwogLSAodm9pZCl1cGRhdGVUZXh0U3Vn Z2VzdGlvbnNGb3JJbnB1dERlbGVnYXRlCiB7CiAgICAgLy8gVGV4dCBzdWdnZXN0aW9ucyB2ZW5k ZWQgZnJvbSBjbGllbnRzIHRha2UgcHJlY2VkZW5jZSBvdmVyIHRleHQgc3VnZ2VzdGlvbnMgZnJv bSBhIGZvY3VzZWQgZm9ybSBjb250cm9sIHdpdGggYSBkYXRhbGlzdC4K