193593 2019-01-18 14:59:50 -0800 Use scores everywhere in JetStream2's UI 2019-01-18 19:06:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin cdumez commit-queue ews-watchlist fpizlo ggaren gskachkov jond keith_miller mark.lam msaboff rmorisset rniwa ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1496046 0 saam 2019-01-18 14:59:50 -0800 ... 1496132 1 359568 saam 2019-01-18 18:19:14 -0800 Created attachment 359568 patch 1496133 2 359568 keith_miller 2019-01-18 18:20:07 -0800 Comment on attachment 359568 patch r=me. 1496136 3 359568 ysuzuki 2019-01-18 18:21:16 -0800 Comment on attachment 359568 patch r=me too. 1496151 4 359568 commit-queue 2019-01-18 19:05:15 -0800 Comment on attachment 359568 patch Clearing flags on attachment: 359568 Committed r240192: <https://trac.webkit.org/changeset/240192> 1496152 5 commit-queue 2019-01-18 19:05:17 -0800 All reviewed patches have been landed. Closing bug. 1496153 6 webkit-bug-importer 2019-01-18 19:06:28 -0800 <rdar://problem/47403962> 359568 2019-01-18 18:19:14 -0800 2019-01-18 19:05:15 -0800 patch a-backup.diff text/plain 4730 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDAxNzcpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAxLTE4ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBzY29yZXMgZXZl cnl3aGVyZSBpbiBKZXRTdHJlYW0yJ3MgVUkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MzU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogSmV0U3RyZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanM6CisgICAg ICAgIChEZWZhdWx0QmVuY2htYXJrLnByb3RvdHlwZS5wcm9jZXNzUmVzdWx0cyk6CisgICAgICAg IChEZWZhdWx0QmVuY2htYXJrLnByb3RvdHlwZS5nZXQgc2NvcmUpOgorICAgICAgICAoRGVmYXVs dEJlbmNobWFyay5zY29yZURlc2NyaXB0aW9uKToKKyAgICAgICAgKFdTTEJlbmNobWFyay5wcm90 b3R5cGUucHJvY2Vzc1Jlc3VsdHMpOgorICAgICAgICAoV1NMQmVuY2htYXJrLnByb3RvdHlwZS5n ZXQgc2NvcmUpOgorICAgICAgICAoV1NMQmVuY2htYXJrLnNjb3JlRGVzY3JpcHRpb24pOgorICAg ICAgICAoV2FzbUJlbmNobWFyay5wcm90b3R5cGUucHJvY2Vzc1Jlc3VsdHMpOgorICAgICAgICAo V2FzbUJlbmNobWFyay5wcm90b3R5cGUuZ2V0IHNjb3JlKToKKyAgICAgICAgKFdhc21CZW5jaG1h cmsuc2NvcmVEZXNjcmlwdGlvbik6CisgICAgICAgICogSmV0U3RyZWFtMi9pbmRleC5odG1sOgor CiAyMDE5LTAxLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFNES19WQVJJQU5UIGJ1aWxkIGRlc3RpbmF0aW9ucyBzaG91bGQgYmUgc2VwYXJhdGUgZnJvbSBu b24tU0RLX1ZBUklBTlQgYnVpbGRzCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIv SmV0U3RyZWFtRHJpdmVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvSmV0U3Ry ZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMJKHJldmlzaW9uIDI0MDE3NSkKKysrIFBlcmZvcm1hbmNl VGVzdHMvSmV0U3RyZWFtMi9KZXRTdHJlYW1Ecml2ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTU4 OCw3ICs1ODgsNyBAQCBjbGFzcyBEZWZhdWx0QmVuY2htYXJrIGV4dGVuZHMgQmVuY2htYXJrCiAg ICAgICAgIH0KICAgICAgICAgcmVzdWx0cyA9IGNvcHlBcnJheShyZXN1bHRzKTsKIAotICAgICAg ICB0aGlzLmZpcnN0SXRlcmF0aW9uID0gcmVzdWx0c1swXTsKKyAgICAgICAgdGhpcy5maXJzdEl0 ZXJhdGlvbiA9IHRvU2NvcmUocmVzdWx0c1swXSk7CiAKICAgICAgICAgcmVzdWx0cyA9IHJlc3Vs dHMuc2xpY2UoMSk7CiAgICAgICAgIHJlc3VsdHMuc29ydCgoYSwgYikgPT4gYSA8IGIgPyAxIDog LTEpOwpAQCAtNTk4LDEyICs1OTgsMTIgQEAgY2xhc3MgRGVmYXVsdEJlbmNobWFyayBleHRlbmRz IEJlbmNobWFyawogICAgICAgICBsZXQgd29yc3RDYXNlID0gW107CiAgICAgICAgIGZvciAobGV0 IGkgPSAwOyBpIDwgdGhpcy53b3JzdENhc2VDb3VudDsgKytpKQogICAgICAgICAgICAgd29yc3RD YXNlLnB1c2gocmVzdWx0c1tpXSk7Ci0gICAgICAgIHRoaXMud29yc3Q0ID0gbWVhbih3b3JzdENh c2UpOwotICAgICAgICB0aGlzLmF2ZXJhZ2UgPSBtZWFuKHJlc3VsdHMpOworICAgICAgICB0aGlz LndvcnN0NCA9IHRvU2NvcmUobWVhbih3b3JzdENhc2UpKTsKKyAgICAgICAgdGhpcy5hdmVyYWdl ID0gdG9TY29yZShtZWFuKHJlc3VsdHMpKTsKICAgICB9CiAKICAgICBnZXQgc2NvcmUoKSB7Ci0g ICAgICAgIHJldHVybiB0b1Njb3JlKGdlb21lYW4oW3RoaXMuZmlyc3RJdGVyYXRpb24sIHRoaXMu d29yc3Q0LCB0aGlzLmF2ZXJhZ2VdKSk7CisgICAgICAgIHJldHVybiBnZW9tZWFuKFt0aGlzLmZp cnN0SXRlcmF0aW9uLCB0aGlzLndvcnN0NCwgdGhpcy5hdmVyYWdlXSk7CiAgICAgfQogCiAgICAg c3ViVGltZXMoKSB7CkBAIC02MTUsNyArNjE1LDcgQEAgY2xhc3MgRGVmYXVsdEJlbmNobWFyayBl eHRlbmRzIEJlbmNobWFyawogICAgIH0KIAogICAgIHN0YXRpYyBzY29yZURlc2NyaXB0aW9uKCkg ewotICAgICAgICByZXR1cm4gWyJGaXJzdCAobXMpIiwgIldvcnN0IChtcykiLCAiQXZlcmFnZSAo bXMpIiwgIlNjb3JlIl07CisgICAgICAgIHJldHVybiBbIkZpcnN0IiwgIldvcnN0IiwgIkF2ZXJh Z2UiLCAiU2NvcmUiXTsKICAgICB9CiAKICAgICBzY29yZUlkZW50aWZpZXJzKCkgewpAQCAtNjc0 LDEyICs2NzQsMTIgQEAgY2xhc3MgV1NMQmVuY2htYXJrIGV4dGVuZHMgQmVuY2htYXJrIHsKICAg ICB9CiAKICAgICBwcm9jZXNzUmVzdWx0cyhyZXN1bHRzKSB7Ci0gICAgICAgIHRoaXMuc3RkbGli ID0gcmVzdWx0c1swXTsKLSAgICAgICAgdGhpcy5tYWluUnVuID0gcmVzdWx0c1sxXTsKKyAgICAg ICAgdGhpcy5zdGRsaWIgPSB0b1Njb3JlKHJlc3VsdHNbMF0pOworICAgICAgICB0aGlzLm1haW5S dW4gPSB0b1Njb3JlKHJlc3VsdHNbMV0pOwogICAgIH0KIAogICAgIGdldCBzY29yZSgpIHsKLSAg ICAgICAgcmV0dXJuIHRvU2NvcmUoZ2VvbWVhbihbdGhpcy5zdGRsaWIsIHRoaXMubWFpblJ1bl0p KTsKKyAgICAgICAgcmV0dXJuIGdlb21lYW4oW3RoaXMuc3RkbGliLCB0aGlzLm1haW5SdW5dKTsK ICAgICB9CiAKICAgICBnZXQgcnVubmVyQ29kZSgpIHsKQEAgLTcxMCw3ICs3MTAsNyBAQCBjbGFz cyBXU0xCZW5jaG1hcmsgZXh0ZW5kcyBCZW5jaG1hcmsgewogICAgIH0KIAogICAgIHN0YXRpYyBz Y29yZURlc2NyaXB0aW9uKCkgewotICAgICAgICByZXR1cm4gWyJTdGRsaWIgKG1zKSIsICJNYWlu UnVuIChtcykiLCAiU2NvcmUiXTsKKyAgICAgICAgcmV0dXJuIFsiU3RkbGliIiwgIk1haW5SdW4i LCAiU2NvcmUiXTsKICAgICB9CiAKICAgICBzY29yZUlkZW50aWZpZXJzKCkgewpAQCAtNzQ3LDEy ICs3NDcsMTIgQEAgY2xhc3MgV2FzbUJlbmNobWFyayBleHRlbmRzIEJlbmNobWFyayB7CiAgICAg fQogCiAgICAgcHJvY2Vzc1Jlc3VsdHMocmVzdWx0cykgewotICAgICAgICB0aGlzLnN0YXJ0dXBU aW1lID0gcmVzdWx0c1swXTsKLSAgICAgICAgdGhpcy5ydW5UaW1lID0gcmVzdWx0c1sxXTsKKyAg ICAgICAgdGhpcy5zdGFydHVwVGltZSA9IHRvU2NvcmUocmVzdWx0c1swXSk7CisgICAgICAgIHRo aXMucnVuVGltZSA9IHRvU2NvcmUocmVzdWx0c1sxXSk7CiAgICAgfQogCiAgICAgZ2V0IHNjb3Jl KCkgewotICAgICAgICByZXR1cm4gdG9TY29yZShnZW9tZWFuKFt0aGlzLnN0YXJ0dXBUaW1lLCB0 aGlzLnJ1blRpbWVdKSk7CisgICAgICAgIHJldHVybiBnZW9tZWFuKFt0aGlzLnN0YXJ0dXBUaW1l LCB0aGlzLnJ1blRpbWVdKTsKICAgICB9CiAKICAgICBnZXQgd2FzbVBhdGgoKSB7CkBAIC04NTcs NyArODU3LDcgQEAgY2xhc3MgV2FzbUJlbmNobWFyayBleHRlbmRzIEJlbmNobWFyayB7CiAgICAg fQogCiAgICAgc3RhdGljIHNjb3JlRGVzY3JpcHRpb24oKSB7Ci0gICAgICAgIHJldHVybiBbIlN0 YXJ0dXAgKG1zKSIsICJSdW50aW1lIChtcykiLCAiU2NvcmUiXTsKKyAgICAgICAgcmV0dXJuIFsi U3RhcnR1cCIsICJSdW50aW1lIiwgIlNjb3JlIl07CiAgICAgfQogCiAgICAgZ2V0IHN0YXJ0dXBJ RCgpIHsKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9pbmRleC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvSmV0U3RyZWFtMi9pbmRleC5odG1sCShyZXZpc2lv biAyNDAxNzUpCisrKyBQZXJmb3JtYW5jZVRlc3RzL0pldFN0cmVhbTIvaW5kZXguaHRtbAkod29y a2luZyBjb3B5KQpAQCAtNTIsNyArNTIsNyBAQAogPCEtLSA8YSBocmVmPSJpbmRleC5odG1sIj48 aW1nIGlkPSJsb2dvIiBzcmM9IkpldFN0cmVhbS1Mb2dvLnBuZyIgYWx0PSJKZXRTdHJlYW0iPjwv YT4gLS0+CiAKICAgICA8aDE+SmV0U3RyZWFtIDI8L2gxPgotICAgIDxwIGNsYXNzPSJzdW1tYXJ5 Ij5KZXRTdHJlYW0gaXMgYSBKYXZhU2NyaXB0IGJlbmNobWFyayBzdWl0ZSBmb2N1c2VkIG9uIHRo ZSBtb3N0IGFkdmFuY2VkIHdlYiBhcHBsaWNhdGlvbnMuIEZvciBtb3JlIGluZm9ybWF0aW9uLCBy ZWFkIHRoZSA8YSBocmVmPSJpbi1kZXB0aC5odG1sIj5pbi1kZXB0aCBhbmFseXNpczwvYT4uIEhp Z2hlciBzY29yZXMgYXJlIGJldHRlci48L3A+CisgICAgPHAgY2xhc3M9InN1bW1hcnkiPkpldFN0 cmVhbSAyIGlzIGEgSmF2YVNjcmlwdCBiZW5jaG1hcmsgc3VpdGUgZm9jdXNlZCBvbiB0aGUgbW9z dCBhZHZhbmNlZCB3ZWIgYXBwbGljYXRpb25zLiBGb3IgbW9yZSBpbmZvcm1hdGlvbiwgcmVhZCB0 aGUgPGEgaHJlZj0iaW4tZGVwdGguaHRtbCI+aW4tZGVwdGggYW5hbHlzaXM8L2E+LiBIaWdoZXIg c2NvcmVzIGFyZSBiZXR0ZXIuPC9wPgogICAgIDxwIGNsYXNzPSJzdW1tYXJ5IiBpZD0ibW9kZS1k ZXNjcmlwdGlvbiI+PC9wPgogCiAgICAgPGRpdiBpZD0icmVzdWx0LXN1bW1hcnkiPjwvZGl2Pgo=