193576 2019-01-18 08:06:49 -0800 [GTK][WPE] Make debug-test-runner work 2019-08-21 14:51:33 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen commit-queue cturner dbates don.olmstead ews-watchlist fujii lforschler mcatanzaro pnormand webkit-bug-importer oldest_to_newest 1495853 0 aperez 2019-01-18 08:06:49 -0800 Currently the “debug-test-runner” works only for the Mac port, and it would be quite handy to have it work with the WPE and GTK+ ports. 1495867 1 359495 aperez 2019-01-18 08:43:44 -0800 Created attachment 359495 Patch Note that I have almost never touched Perl code, so hopefully this patch is not too bad O:-) With the changes suggested in the patch it is possible to get WebKitTestRunner under GDB on GNU/Linux for many layout tests. Note that the intention is *not* to replicate all of possible modes of operation of run-webkit-tests, so for example tests which need a running HTTP server will not work. Most tests will, however, and having the script working is already being handy for me to investigate assertions. I think it would be valuable to have these changes landed upstream. Tu use, do something like: % build-webkit --debug --gtk % debug-test-runner --debug --gtk LayoutTests/fast/dom/location-hash.html Note that you will need a running X11 server or Wayland compositor accordingly. No attempt is made at running Xvfb or headless Weston. 1563668 2 376917 aperez 2019-08-21 13:56:34 -0700 Created attachment 376917 Patch for landing 1563699 3 376917 commit-queue 2019-08-21 14:49:06 -0700 Comment on attachment 376917 Patch for landing Clearing flags on attachment: 376917 Committed r248965: <https://trac.webkit.org/changeset/248965> 1563700 4 commit-queue 2019-08-21 14:49:07 -0700 All reviewed patches have been landed. Closing bug. 1563704 5 webkit-bug-importer 2019-08-21 14:51:33 -0700 <rdar://problem/54573003> 359495 2019-01-18 08:43:44 -0800 2019-08-21 13:56:30 -0700 Patch bug-193576-20190118184342.patch text/plain 3459 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzliZjgwY2YzYWNhZTg1YWU0NTFkYjkyZTNmNTY5ZGEy M2U1ZWU2YS4uZDZmNTFkMzJiZTNlYWFmMGRjN2FkZDM0YjJhYjNiMWI0NGQ0ZDA5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAxLTE4ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS11bV1BFXSBNYWtlIGRlYnVnLXRlc3QtcnVubmVyIHdvcmsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzU3NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRkaXJzLnBtOgorICAgICAgICAod3JhcHBlclByZWZpeElmTmVlZGVkKTogT25seSBhZGQg dGhlIHdyYXBwZXIgcHJlZml4IHdoZW4gbm90IHJ1bm5pbmcgaW5zaWRlIGEgRmxhdHBhayBzYW5k Ym94LgorICAgICAgICAoc2V0dXBVbml4V2ViS2l0RW52aXJvbm1lbnQpOiBBZGRlZCwgc2V0cyBU RVNUX1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVfRklMRU5BTUUgYW5kCisgICAgICAgIFRFU1RfUlVO TkVSX1RFU1RfUExVR0lOX1BBVEggaW4gdGhlIGVudmlyb25tZW50LgorICAgICAgICAoZXhlY1Vu aXhBcHBGb3JEZWJ1Z2dpbmcpOiBBZGRlZC4KKyAgICAgICAgKGRlYnVnV2ViS2l0VGVzdFJ1bm5l cik6IEFsdGVybmF0aXZlbHksIHVzZSBleGVjVW5peEFwcEZvckRlYnVnZ2luZygpIGZvciB0aGUg V1BFIGFuZCBHVEsrIHBvcnRzLgorCiAyMDE5LTAxLTE4ICBDaGFybGllIFR1cm5lciAgPGN0dXJu ZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtFTUVdW0NsZWFyS2V5XSBSZXF1 ZXN0IGtleXMgZnJvbSBDRE1JbnN0YW5jZSByYXRoZXIgdGhhbiBwYXNzaW5nIHZpYSBidXMgbWVz c2FnZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBkNmVlZDZlMWNiMGUyM2NkNmNmMWMxOWQ2YzFiM2Nh MDEyNDZhNDc5Li5hNWI2OWZkNWNhOTg1ZDkwZjVkYmUwMTAwNTk4NDRkMGNiYmU3MjBhIDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCkBAIC04OCw2ICs4OCw3IEBAIEJFR0lOIHsKICAgICAgICAmc2RrUGxhdGZv cm1EaXJlY3RvcnkKICAgICAgICAmc2V0Q29uZmlndXJhdGlvbgogICAgICAgICZzZXR1cE1hY1dl YktpdEVudmlyb25tZW50CisgICAgICAgJnNldHVwVW5peFdlYktpdEVudmlyb25tZW50CiAgICAg ICAgJnNoYXJlZENvbW1hbmRMaW5lT3B0aW9ucwogICAgICAgICZzaGFyZWRDb21tYW5kTGluZU9w dGlvbnNVc2FnZQogICAgICAgICZzaHV0RG93bklPU1NpbXVsYXRvckRldmljZQpAQCAtMjA2OCw3 ICsyMDY5LDcgQEAgc3ViIHdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpCiAgICAgaWYgKGlzQXBwbGVD b2NvYVdlYktpdCgpKSB7CiAgICAgICAgIHJldHVybiAoInhjcnVuIik7CiAgICAgfQotICAgIGlm ICgtZSBnZXRKaGJ1aWxkUGF0aCgpKSB7CisgICAgaWYgKHNob3VsZFVzZUpoYnVpbGQoKSBhbmQg ISBzaG91bGRVc2VGbGF0cGFrKCkpIHsKICAgICAgICAgbXkgQHByZWZpeCA9IChGaWxlOjpTcGVj LT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAiamhidWlsZCIsICJqaGJ1aWxkLXdyYXBw ZXIiKSk7CiAgICAgICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgICAgICBwdXNoKEBwcmVmaXgs ICItLWd0ayIpOwpAQCAtMjQ5MSw2ICsyNDkyLDE0IEBAIHN1YiBzZXR1cE1hY1dlYktpdEVudmly b25tZW50KCQpCiAgICAgc2V0VXBHdWFyZE1hbGxvY0lmTmVlZGVkKCk7CiB9CiAKK3N1YiBzZXR1 cFVuaXhXZWJLaXRFbnZpcm9ubWVudCgkKQoreworICAgIG15ICgkcHJvZHVjdERpcikgPSBAXzsK KworICAgICRFTlZ7VEVTVF9SVU5ORVJfSU5KRUNURURfQlVORExFX0ZJTEVOQU1FfSA9IEZpbGU6 OlNwZWMtPmNhdGZpbGUoJHByb2R1Y3REaXIsICJsaWIiLCAibGliVGVzdFJ1bm5lckluamVjdGVk QnVuZGxlLnNvIik7CisgICAgJEVOVntURVNUX1JVTk5FUl9URVNUX1BMVUdJTl9QQVRIfSA9IEZp bGU6OlNwZWMtPmNhdGRpcigkcHJvZHVjdERpciwgImxpYiIsICJwbHVnaW5zIik7Cit9CisKIHN1 YiBzZXR1cElPU1dlYktpdEVudmlyb25tZW50KCQpCiB7CiAgICAgbXkgKCRkeWxkRnJhbWV3b3Jr UGF0aCkgPSBAXzsKQEAgLTI4MjksNiArMjgzOCwyNCBAQCBzdWIgZXhlY01hY1dlYktpdEFwcEZv ckRlYnVnZ2luZygkKQogICAgIGV4ZWMgeyAkZGVidWdnZXJQYXRoIH0gJGRlYnVnZ2VyUGF0aCwg QGFyY2hpdGVjdHVyZUZsYWdzLCAkYXJndW1lbnRzU2VwYXJhdG9yLCAkYXBwUGF0aCwgYXJndW1l bnRzRm9yUnVuQW5kRGVidWdNYWNXZWJLaXRBcHAoKSBvciBkaWU7CiB9CiAKK3N1YiBleGVjVW5p eEFwcEZvckRlYnVnZ2luZygkKQoreworICAgIG15ICgkYXBwUGF0aCkgPSBAXzsKKworICAgIG15 ICRkZWJ1Z2dlclBhdGggPSBgd2hpY2ggZ2RiIHwgaGVhZCAtMWA7CisgICAgY2hvbXAgJGRlYnVn Z2VyUGF0aDsKKyAgICBkaWUgIkNhbid0IGZpbmQgdGhlIGdkYiBleGVjdXRhYmxlLlxuIiB1bmxl c3MgLXggJGRlYnVnZ2VyUGF0aDsKKworICAgIG15ICRwcm9kdWN0RGlyID0gcHJvZHVjdERpcigp OworICAgIHNldHVwVW5peFdlYktpdEVudmlyb25tZW50KCRwcm9kdWN0RGlyKTsKKworICAgIG15 IEBjbWRsaW5lID0gd3JhcHBlclByZWZpeElmTmVlZGVkKCk7CisgICAgcHVzaCBAY21kbGluZSwg JGRlYnVnZ2VyUGF0aCwgIi0tYXJncyIsICRhcHBQYXRoOworCisgICAgcHJpbnQgIlN0YXJ0aW5n IEB7W2Jhc2VuYW1lKCRhcHBQYXRoKV19IHVuZGVyIGdkYiB3aXRoIGJ1aWxkIFdlYktpdCBpbiAk cHJvZHVjdERpci5cbiI7CisgICAgZXhlYyBAY21kbGluZSwgQEFSR1Ygb3IgZGllOworfQorCiBz dWIgZGVidWdTYWZhcmkKIHsKICAgICBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CkBAIC0yODky LDYgKzI5MTksOCBAQCBzdWIgZGVidWdXZWJLaXRUZXN0UnVubmVyCiB7CiAgICAgaWYgKGlzQXBw bGVNYWNXZWJLaXQoKSkgewogICAgICAgICBleGVjTWFjV2ViS2l0QXBwRm9yRGVidWdnaW5nKEZp bGU6OlNwZWMtPmNhdGZpbGUocHJvZHVjdERpcigpLCAiV2ViS2l0VGVzdFJ1bm5lciIpKTsKKyAg ICB9IGVsc2lmIChpc0d0aygpIG9yIGlzV1BFKCkpIHsKKyAgICAgICAgZXhlY1VuaXhBcHBGb3JE ZWJ1Z2dpbmcoRmlsZTo6U3BlYy0+Y2F0ZmlsZShwcm9kdWN0RGlyKCksICJiaW4iLCAiV2ViS2l0 VGVzdFJ1bm5lciIpKTsKICAgICB9CiAKICAgICByZXR1cm4gMTsK 376917 2019-08-21 13:56:34 -0700 2019-08-21 14:49:06 -0700 Patch for landing bug-193576-20190821235633.patch text/plain 3431 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA1MjZhNDZlNzFiMzJkMmVkOTUzYjkzNjFhYjJmYzA3 ZGFkMmY0My4uZmE0MzFkMTA0MzAwMzYyYTkxNWQyMzM5OTc0YmUzZTliYWVjMDcyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTA4LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS11bV1BFXSBNYWtlIGRlYnVnLXRlc3QtcnVubmVyIHdvcmsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzU3NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJvLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAod3JhcHBlclByZWZpeElmTmVlZGVkKTogT25seSBh ZGQgdGhlIHdyYXBwZXIgcHJlZml4IHdoZW4gbm90IHJ1bm5pbmcgaW5zaWRlIGEgRmxhdHBhayBz YW5kYm94LgorICAgICAgICAoc2V0dXBVbml4V2ViS2l0RW52aXJvbm1lbnQpOiBBZGRlZCwgc2V0 cyBURVNUX1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVfRklMRU5BTUUgYW5kCisgICAgICAgIFRFU1Rf UlVOTkVSX1RFU1RfUExVR0lOX1BBVEggaW4gdGhlIGVudmlyb25tZW50LgorICAgICAgICAoZXhl Y1VuaXhBcHBGb3JEZWJ1Z2dpbmcpOiBBZGRlZC4KKyAgICAgICAgKGRlYnVnV2ViS2l0VGVzdFJ1 bm5lcik6IEFsdGVybmF0aXZlbHksIHVzZSBleGVjVW5peEFwcEZvckRlYnVnZ2luZygpIGZvciB0 aGUgV1BFIGFuZCBHVEsrIHBvcnRzLgorCiAyMDE5LTA4LTIwICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFB1dCBrZXlnZW4gZWxlbWVudCBiZWhpbmQgYSBydW50 aW1lIGZsYWcgYW5kIGRpc2FibGUgaXQgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGVh ZDMzOGVmYWQ2NmQzMTZhZjcwZWZkODc1Y2M4OTJlZjY1YjIzZWUuLjRmNDliZmRhMjE4MjBkZjA3 Zjg3ZTgzZGExZWRkZWZlZDMwZTVjNjYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTg4LDYgKzg4LDcg QEAgQkVHSU4gewogICAgICAgICZzZGtQbGF0Zm9ybURpcmVjdG9yeQogICAgICAgICZzZXRDb25m aWd1cmF0aW9uCiAgICAgICAgJnNldHVwTWFjV2ViS2l0RW52aXJvbm1lbnQKKyAgICAgICAmc2V0 dXBVbml4V2ViS2l0RW52aXJvbm1lbnQKICAgICAgICAmc2hhcmVkQ29tbWFuZExpbmVPcHRpb25z CiAgICAgICAgJnNoYXJlZENvbW1hbmRMaW5lT3B0aW9uc1VzYWdlCiAgICAgICAgJnNodXREb3du SU9TU2ltdWxhdG9yRGV2aWNlCkBAIC0yMDU0LDcgKzIwNTUsNyBAQCBzdWIgd3JhcHBlclByZWZp eElmTmVlZGVkKCkKICAgICBpZiAoaXNBcHBsZUNvY29hV2ViS2l0KCkpIHsKICAgICAgICAgcmV0 dXJuICgieGNydW4iKTsKICAgICB9Ci0gICAgaWYgKC1lIGdldEpoYnVpbGRQYXRoKCkpIHsKKyAg ICBpZiAoc2hvdWxkVXNlSmhidWlsZCgpIGFuZCAhIHNob3VsZFVzZUZsYXRwYWsoKSkgewogICAg ICAgICBteSBAcHJlZml4ID0gKEZpbGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJUb29s cyIsICJqaGJ1aWxkIiwgImpoYnVpbGQtd3JhcHBlciIpKTsKICAgICAgICAgaWYgKGlzR3RrKCkp IHsKICAgICAgICAgICAgIHB1c2goQHByZWZpeCwgIi0tZ3RrIik7CkBAIC0yNDk0LDYgKzI0OTUs MTQgQEAgc3ViIHNldHVwTWFjV2ViS2l0RW52aXJvbm1lbnQoJCkKICAgICBzZXRVcEd1YXJkTWFs bG9jSWZOZWVkZWQoKTsKIH0KIAorc3ViIHNldHVwVW5peFdlYktpdEVudmlyb25tZW50KCQpCit7 CisgICAgbXkgKCRwcm9kdWN0RGlyKSA9IEBfOworCisgICAgJEVOVntURVNUX1JVTk5FUl9JTkpF Q1RFRF9CVU5ETEVfRklMRU5BTUV9ID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkcHJvZHVjdERpciwg ImxpYiIsICJsaWJUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUuc28iKTsKKyAgICAkRU5We1RFU1Rf UlVOTkVSX1RFU1RfUExVR0lOX1BBVEh9ID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRwcm9kdWN0RGly LCAibGliIiwgInBsdWdpbnMiKTsKK30KKwogc3ViIHNldHVwSU9TV2ViS2l0RW52aXJvbm1lbnQo JCkKIHsKICAgICBteSAoJGR5bGRGcmFtZXdvcmtQYXRoKSA9IEBfOwpAQCAtMjgzNyw2ICsyODQ2 LDI0IEBAIHN1YiBleGVjTWFjV2ViS2l0QXBwRm9yRGVidWdnaW5nKCQpCiAgICAgZXhlYyB7ICRk ZWJ1Z2dlclBhdGggfSAkZGVidWdnZXJQYXRoLCBAYXJjaGl0ZWN0dXJlRmxhZ3MsICRhcmd1bWVu dHNTZXBhcmF0b3IsICRhcHBQYXRoLCBhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dlYktpdEFw cCgpIG9yIGRpZTsKIH0KIAorc3ViIGV4ZWNVbml4QXBwRm9yRGVidWdnaW5nKCQpCit7CisgICAg bXkgKCRhcHBQYXRoKSA9IEBfOworCisgICAgbXkgJGRlYnVnZ2VyUGF0aCA9IGB3aGljaCBnZGIg fCBoZWFkIC0xYDsKKyAgICBjaG9tcCAkZGVidWdnZXJQYXRoOworICAgIGRpZSAiQ2FuJ3QgZmlu ZCB0aGUgZ2RiIGV4ZWN1dGFibGUuXG4iIHVubGVzcyAteCAkZGVidWdnZXJQYXRoOworCisgICAg bXkgJHByb2R1Y3REaXIgPSBwcm9kdWN0RGlyKCk7CisgICAgc2V0dXBVbml4V2ViS2l0RW52aXJv bm1lbnQoJHByb2R1Y3REaXIpOworCisgICAgbXkgQGNtZGxpbmUgPSB3cmFwcGVyUHJlZml4SWZO ZWVkZWQoKTsKKyAgICBwdXNoIEBjbWRsaW5lLCAkZGVidWdnZXJQYXRoLCAiLS1hcmdzIiwgJGFw cFBhdGg7CisKKyAgICBwcmludCAiU3RhcnRpbmcgQHtbYmFzZW5hbWUoJGFwcFBhdGgpXX0gdW5k ZXIgZ2RiIHdpdGggYnVpbGQgV2ViS2l0IGluICRwcm9kdWN0RGlyLlxuIjsKKyAgICBleGVjIEBj bWRsaW5lLCBAQVJHViBvciBkaWU7Cit9CisKIHN1YiBkZWJ1Z1NhZmFyaQogewogICAgIGlmIChp c0FwcGxlTWFjV2ViS2l0KCkpIHsKQEAgLTI5MDAsNiArMjkyNyw4IEBAIHN1YiBkZWJ1Z1dlYktp dFRlc3RSdW5uZXIKIHsKICAgICBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgICAgIGV4 ZWNNYWNXZWJLaXRBcHBGb3JEZWJ1Z2dpbmcoRmlsZTo6U3BlYy0+Y2F0ZmlsZShwcm9kdWN0RGly KCksICJXZWJLaXRUZXN0UnVubmVyIikpOworICAgIH0gZWxzaWYgKGlzR3RrKCkgb3IgaXNXUEUo KSkgeworICAgICAgICBleGVjVW5peEFwcEZvckRlYnVnZ2luZyhGaWxlOjpTcGVjLT5jYXRmaWxl KHByb2R1Y3REaXIoKSwgImJpbiIsICJXZWJLaXRUZXN0UnVubmVyIikpOwogICAgIH0KIAogICAg IHJldHVybiAxOwo=