193570 2019-01-18 07:15:33 -0800 [Flatpak] Missing KeyboardInterrupt exception handler 2019-01-18 07:41:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1495826 0 pnormand 2019-01-18 07:15:33 -0800 Using org.webkit.WPE prefix in /home/phil/WebKit/WebKitBuild/WPE/FlatpakTreeRelease Starting MiniBrowser. ^CTraceback (most recent call last): File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module> sys.exit(WebkitFlatpak.load_from_args().run()) File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 792, in run return self.setup_dev_env() File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 865, in setup_dev_env return self.run_in_sandbox(*self.user_command) File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 766, in run_in_sandbox subprocess.check_call(flatpak_command, stdout=stdout) File "/usr/lib/python2.7/subprocess.py", line 185, in check_call retcode = call(*popenargs, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 172, in call return Popen(*popenargs, **kwargs).wait() File "/usr/lib/python2.7/subprocess.py", line 1099, in wait pid, sts = _eintr_retry_call(os.waitpid, self.pid, 0) File "/usr/lib/python2.7/subprocess.py", line 125, in _eintr_retry_call return func(*args) KeyboardInterrupt 1495832 1 359483 pnormand 2019-01-18 07:23:41 -0800 Created attachment 359483 patch 1495833 2 359483 mcatanzaro 2019-01-18 07:25:58 -0800 Comment on attachment 359483 patch View in context: https://bugs.webkit.org/attachment.cgi?id=359483&action=review > Tools/flatpak/flatpakutils.py:771 > + except KeyboardInterrupt: > + return 0 I wish python would just do something sane by default.... This would probably be desirable in the run_gdb() function as well. 1495839 3 pnormand 2019-01-18 07:37:50 -0800 run_gdb already chains to run_in_sandbox() 1495840 4 pnormand 2019-01-18 07:40:54 -0800 Committed r240147: <https://trac.webkit.org/changeset/240147> 1495841 5 webkit-bug-importer 2019-01-18 07:41:29 -0800 <rdar://problem/47384486> 359483 2019-01-18 07:23:41 -0800 2019-01-18 07:25:58 -0800 patch 0001-patch.patch text/plain 1375 pnormand RnJvbSA2MjkyZjgyOThkNDdiNjFlNWNmNGQ3M2IzZDBjNzViZTQ1ZmE5NThjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDE4IEphbiAyMDE5IDE1OjIxOjEwICswMDAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAxMCArKysrKysrKysr CiBUb29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weSB8ICAyICsrCiAyIGZpbGVzIGNoYW5nZWQs IDEyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggNTE0MjFjZTk4ODAuLjllZDk3YjY1M2M3IDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTkt MDEtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAg IFtGbGF0cGFrXSBNaXNzaW5nIEtleWJvYXJkSW50ZXJydXB0IGV4Y2VwdGlvbiBoYW5kbGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM1NzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZsYXRwYWsv ZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Via2l0RmxhdHBhay5ydW5faW5fc2FuZGJveCk6 IEJhc2ljIEtleWJvYXJkSW50ZXJydXB0IGhhbmRsaW5nLgorCiAyMDE5LTAxLTE4ICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5Db2xs YXBzaW5nXSBDb2xsYXBzaW5nIHRocm91Z2ggc2hvdWxkIG5vdCBpZ25vcmUgZmxvYXRzLgpkaWZm IC0tZ2l0IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkgYi9Ub29scy9mbGF0cGFrL2Zs YXRwYWt1dGlscy5weQppbmRleCAzNWQzNWQ0NGM5OC4uNTQ4NGI0OGM1NmUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBh a3V0aWxzLnB5CkBAIC03NjcsNiArNzY3LDggQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAg ICAgICAgIGV4Y2VwdCBzdWJwcm9jZXNzLkNhbGxlZFByb2Nlc3NFcnJvciBhcyBlOgogICAgICAg ICAgICAgICAgIHN5cy5zdGRlcnIud3JpdGUoc3RyKGUpICsgIlxuIikKICAgICAgICAgICAgICAg ICByZXR1cm4gZS5yZXR1cm5jb2RlCisgICAgICAgICAgICBleGNlcHQgS2V5Ym9hcmRJbnRlcnJ1 cHQ6CisgICAgICAgICAgICAgICAgcmV0dXJuIDAKIAogICAgICAgICByZXR1cm4gMAogCi0tIAoy LjIwLjEKCg==