193564 2019-01-17 22:14:34 -0800 [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats. 2019-01-18 11:11:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1495742 0 zalan 2019-01-17 22:14:34 -0800 ssia 1495743 1 359451 zalan 2019-01-17 22:17:25 -0800 Created attachment 359451 Patch 1495817 2 359451 koivisto 2019-01-18 06:28:31 -0800 Comment on attachment 359451 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359451&action=review > LayoutTests/fast/block/float/float-in-descendant-formatting-context-expected.txt:9 > +layer at (0,0) size 800x600 > + RenderView at (0,0) size 800x600 > +layer at (0,0) size 800x26 > + RenderBlock {HTML} at (0,0) size 800x26 > + RenderBody {BODY} at (8,8) size 784x10 > +layer at (8,8) size 784x10 > + RenderBlock {DIV} at (0,0) size 784x10 > + RenderInline {SPAN} at (0,0) size 0x0 > + RenderBlock (floating) {DIV} at (0,0) size 10x10 Could we do ref tests instead? Render tree dumps are bit weird for testing something that ultimately won't have render tree. 1495821 3 zalan 2019-01-18 06:42:52 -0800 Committed r240146: <https://trac.webkit.org/changeset/240146> 1495822 4 webkit-bug-importer 2019-01-18 06:43:27 -0800 <rdar://problem/47383635> 1495940 5 zalan 2019-01-18 11:11:46 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 359451 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359451&action=review > > > LayoutTests/fast/block/float/float-in-descendant-formatting-context-expected.txt:9 > > +layer at (0,0) size 800x600 > > + RenderView at (0,0) size 800x600 > > +layer at (0,0) size 800x26 > > + RenderBlock {HTML} at (0,0) size 800x26 > > + RenderBody {BODY} at (8,8) size 784x10 > > +layer at (8,8) size 784x10 > > + RenderBlock {DIV} at (0,0) size 784x10 > > + RenderInline {SPAN} at (0,0) size 0x0 > > + RenderBlock (floating) {DIV} at (0,0) size 10x10 > > Could we do ref tests instead? Render tree dumps are bit weird for testing > something that ultimately won't have render tree. In certain cases when testing against geometry it is actually more reliable to dump the box geometry and match against that (especially at this phase of the project and with this type of content). However I agree that the dumps in this format are not optimal/future-proof. That we should definitely change. 359451 2019-01-17 22:17:25 -0800 2019-01-18 06:22:31 -0800 Patch Patch.txt text/plain 5769 zalan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlODU2MjU0ZjZiNS4uY2MwYjJlNWMwMjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wMS0xNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtM RkNdW0JGQ11bTWFyZ2luQ29sbGFwc2luZ10gQ29sbGFwc2luZyB0aHJvdWdoIHNob3VsZCBub3Qg aWdub3JlIGZsb2F0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MzU2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1pbi1kZXNjZW5kYW50LWZvcm1hdHRpbmct Y29udGV4dC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYmxvY2svZmxvYXQv ZmxvYXQtaW4tZGVzY2VuZGFudC1mb3JtYXR0aW5nLWNvbnRleHQuaHRtbDogQWRkZWQuCisKIDIw MTktMDEtMTYgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgR1RLIGFuZCBXUEUgdGVzdCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LWluLWRlc2NlbmRhbnQtZm9ybWF0dGlu Zy1jb250ZXh0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxv YXQtaW4tZGVzY2VuZGFudC1mb3JtYXR0aW5nLWNvbnRleHQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5iYzljM2FlZjU2NgotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxvYXQtaW4tZGVzY2VuZGFudC1m b3JtYXR0aW5nLWNvbnRleHQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorbGF5ZXIgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCits YXllciBhdCAoMCwwKSBzaXplIDgwMHgyNgorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkg c2l6ZSA4MDB4MjYKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHgxMAor bGF5ZXIgYXQgKDgsOCkgc2l6ZSA3ODR4MTAKKyAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkg c2l6ZSA3ODR4MTAKKyAgICBSZW5kZXJJbmxpbmUge1NQQU59IGF0ICgwLDApIHNpemUgMHgwCisg ICAgUmVuZGVyQmxvY2sgKGZsb2F0aW5nKSB7RElWfSBhdCAoMCwwKSBzaXplIDEweDEwCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LWluLWRlc2NlbmRhbnQt Zm9ybWF0dGluZy1jb250ZXh0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zs b2F0LWluLWRlc2NlbmRhbnQtZm9ybWF0dGluZy1jb250ZXh0Lmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjUxZWZmNTAyMDlkCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1pbi1kZXNjZW5kYW50LWZvcm1hdHRp bmctY29udGV4dC5odG1sCkBAIC0wLDAgKzEsNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4K Kzxib2R5PgorPGRpdiBzdHlsZT0ib3ZlcmZsb3c6IGhpZGRlbiI+PHNwYW4+PC9zcGFuPjxkaXYg c3R5bGU9ImZsb2F0OiBsZWZ0OyB3aWR0aDogMTBweDsgaGVpZ2h0OiAxMHB4OyI+PC9kaXY+PC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGRhMzJkODgyMTMyLi40NjNhOTI1YmNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAxLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgW0xGQ11bQkZDXVtNYXJnaW5Db2xsYXBzaW5nXSBDb2xsYXBzaW5nIHRocm91Z2ggc2hvdWxk IG5vdCBpZ25vcmUgZmxvYXRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzNTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRmxvYXQgYm94ZXMgcHJldmVudCBjb2xsYXBzaW5nIHRocm91Z2guCisKKyAg ICAgICAgVGVzdDogZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1pbi1kZXNjZW5kYW50LWZvcm1hdHRp bmctY29udGV4dC5odG1sCisKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2Nr TWFyZ2luQ29sbGFwc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1h dHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2luc0NvbGxhcHNlVGhyb3VnaCk6CisK IDIwMTktMDEtMTcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXSBEbyBub3Qgc2tpcCBmbG9hdCBib3hlcyB0aGF0IGFyZSBub3QgcGFydCBvZiB0aGUgY3Vy cmVudCBmb3JtYXR0aW5nIGNvbnRleHQgd2hlbiBjb21wdXRpbmcgYm90dG9tLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxh cHNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJn aW5Db2xsYXBzZS5jcHAKaW5kZXggMDhkZTJhMGRmYTkuLjJlZjM0ZGY1YTRjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFw c2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tN YXJnaW5Db2xsYXBzZS5jcHAKQEAgLTQwOSwxNCArNDA5LDIzIEBAIGJvb2wgQmxvY2tGb3JtYXR0 aW5nQ29udGV4dDo6TWFyZ2luQ29sbGFwc2U6Om1hcmdpbnNDb2xsYXBzZVRocm91Z2goY29uc3Qg TGF5b3V0CiAgICAgICAgICAgICAvLyB3ZSBoYXZlbid0IHN0YXJ0ZWQgbGF5aW5nIGl0IG91dCB5 ZXQuCiAgICAgICAgICAgICBpZiAoIWxheW91dFN0YXRlLmhhc0Zvcm1hdHRpbmdTdGF0ZShsYXlv dXRCb3gpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIHJldHVy biBkb3duY2FzdDxJbmxpbmVGb3JtYXR0aW5nU3RhdGU+KGxheW91dFN0YXRlLmVzdGFibGlzaGVk Rm9ybWF0dGluZ1N0YXRlKGxheW91dEJveCkpLmlubGluZVJ1bnMoKS5pc0VtcHR5KCk7CisgICAg ICAgICAgICBhdXRvJiBmb3JtYXR0aW5nU3RhdGUgPSBkb3duY2FzdDxJbmxpbmVGb3JtYXR0aW5n U3RhdGU+KGxheW91dFN0YXRlLmVzdGFibGlzaGVkRm9ybWF0dGluZ1N0YXRlKGxheW91dEJveCkp OworICAgICAgICAgICAgaWYgKCFmb3JtYXR0aW5nU3RhdGUuaW5saW5lUnVucygpLmlzRW1wdHko KSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICAvLyBBbnkgZmxv YXQgYm94IGluIHRoaXMgZm9ybWF0dGluZyBjb250ZXh0IHByZXZlbnRzIGNvbGxhcHNpbmcgdGhy b3VnaC4KKyAgICAgICAgICAgIGF1dG8mIGZsb2F0cyA9IGZvcm1hdHRpbmdTdGF0ZS5mbG9hdGlu Z1N0YXRlKCkuZmxvYXRzKCk7CisgICAgICAgICAgICBmb3IgKGF1dG8mIGZsb2F0SXRlbSA6IGZs b2F0cykgeworICAgICAgICAgICAgICAgIGlmIChmbG9hdEl0ZW0uaXNEZXNjZW5kYW50T2ZGb3Jt YXR0aW5nUm9vdChkb3duY2FzdDxDb250YWluZXI+KGxheW91dEJveCkpKQorICAgICAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICB9CisgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChlc3RhYmxpc2hlc0Jsb2NrRm9ybWF0dGlu Z0NvbnRleHQobGF5b3V0Qm94KSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAK LSAgICBmb3IgKGF1dG8qIGluZmxvd0NoaWxkID0gZG93bmNhc3Q8Q29udGFpbmVyPihsYXlvdXRC b3gpLmZpcnN0SW5GbG93Q2hpbGQoKTsgaW5mbG93Q2hpbGQ7IGluZmxvd0NoaWxkID0gaW5mbG93 Q2hpbGQtPm5leHRJbkZsb3dTaWJsaW5nKCkpIHsKKyAgICBmb3IgKGF1dG8qIGluZmxvd0NoaWxk ID0gZG93bmNhc3Q8Q29udGFpbmVyPihsYXlvdXRCb3gpLmZpcnN0SW5GbG93T3JGbG9hdGluZ0No aWxkKCk7IGluZmxvd0NoaWxkOyBpbmZsb3dDaGlsZCA9IGluZmxvd0NoaWxkLT5uZXh0SW5GbG93 T3JGbG9hdGluZ1NpYmxpbmcoKSkgewogICAgICAgICBpZiAoZXN0YWJsaXNoZXNCbG9ja0Zvcm1h dHRpbmdDb250ZXh0KCppbmZsb3dDaGlsZCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgIGlmICghbWFyZ2luc0NvbGxhcHNlVGhyb3VnaChsYXlvdXRTdGF0ZSwgKmluZmxvd0No aWxkKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBhODI4ZWY1YWEwZC4uNjlkOWM4YTIzZGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOS0wMS0xNyAgWmFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtMRkNdW0JGQ11bTWFyZ2luQ29s bGFwc2luZ10gQ29sbGFwc2luZyB0aHJvdWdoIHNob3VsZCBub3QgaWdub3JlIGZsb2F0cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzU2NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTGF5b3V0UmVs b2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQ6CisKIDIwMTktMDEtMTcgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBEbyBub3Qgc2tpcCBmbG9h dCBib3hlcyB0aGF0IGFyZSBub3QgcGFydCBvZiB0aGUgY3VycmVudCBmb3JtYXR0aW5nIGNvbnRl eHQgd2hlbiBjb21wdXRpbmcgYm90dG9tLgpkaWZmIC0tZ2l0IGEvVG9vbHMvTGF5b3V0UmVsb2Fk ZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQgYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNj L0xGQy1wYXNzaW5nLXRlc3RzLnR4dAppbmRleCBkYzg5M2RiOTQ2ZS4uNTU5YmVkNDdlNTYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0 CisrKyBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CkBA IC0xMDUsNiArMTA1LDcgQEAgZmFzdC9ibG9jay9mbG9hdC8wMDguaHRtbAogZmFzdC9ibG9jay9m bG9hdC8wMDkuaHRtbAogZmFzdC9ibG9jay9mbG9hdC8wMTMuaHRtbAogZmFzdC9ibG9jay9mbG9h dC8wMTkuaHRtbAorZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1pbi1kZXNjZW5kYW50LWZvcm1hdHRp bmctY29udGV4dC5odG1sCiBmYXN0L2Jsb2NrL2Zsb2F0L25lZ2F0aXZlLW1hcmdpbi1jbGVhci5o dG1sCiBmYXN0L2Jsb2NrL2Zsb2F0L292ZXJoYW5naW5nLWFmdGVyLWhlaWdodC1kZWNyZWFzZS1v ZmZzZXRzLmh0bWwKIGZhc3QvYmxvY2svZmxvYXQvb3ZlcmhhbmdpbmctYWZ0ZXItaGVpZ2h0LWRl Y3JlYXNlLmh0bWwK