193555 2019-01-17 16:10:53 -0800 [LFC][BFC] Check for inflow children while computing height for block formatting context roots. 2019-01-18 06:26:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1495669 0 zalan 2019-01-17 16:10:53 -0800 The root might only have floating children. 1495671 1 359422 zalan 2019-01-17 16:15:46 -0800 Created attachment 359422 Patch 1495814 2 359422 commit-queue 2019-01-18 06:25:14 -0800 Comment on attachment 359422 Patch Clearing flags on attachment: 359422 Committed r240144: <https://trac.webkit.org/changeset/240144> 1495815 3 commit-queue 2019-01-18 06:25:16 -0800 All reviewed patches have been landed. Closing bug. 1495816 4 webkit-bug-importer 2019-01-18 06:26:30 -0800 <rdar://problem/47383429> 359422 2019-01-17 16:15:46 -0800 2019-01-18 06:25:14 -0800 Patch bug-193555-20190117161545.patch text/plain 4519 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDA4YjFiNDczZDM3NWU0 ZWI3YjIwMzc2ZTlmODRlMjEwNTk5MjZjYS4uNGFmMzdlZmMxNjRkNTQwY2VmNmJiMDlhNzNmODll OTM3MTQ1MTAyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBDaGVjayBm b3IgaW5mbG93IGNoaWxkcmVuIHdoaWxlIGNvbXB1dGluZyBoZWlnaHQgZm9yIGJsb2NrIGZvcm1h dHRpbmcgY29udGV4dCByb290cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MzU1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyBleHRlbmRzIGFyZUVzc2VudGlhbGx5RXF1YWwg dG8gMC4xMjVweCB0byBiZSBhYmxlIHRvIG1hdGNoIChlc3NlbnRpYWxseSBlcXVhbCkgaW5saW5l IHJ1bnMuIAorCisgICAgICAgICogbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0Ojpjb250ZW50SGVpZ2h0Rm9yRm9ybWF0dGluZ0Nv bnRleHRSb290KToKKyAgICAgICAgKiBsYXlvdXQvVmVyaWZpY2F0aW9uLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6YXJlRXNzZW50aWFsbHlFcXVhbCk6CisgICAgICAgICogcGFnZS9G cmFtZVZpZXdMYXlvdXRDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmxheW91dFVzaW5n Rm9ybWF0dGluZ0NvbnRleHQpOgorCiAyMDE5LTAxLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBBbiBlbGVtZW50IHdpdGggdHJhbnNmb3Jt IGlzIGEgY29udGFpbmluZyBibG9jayBmb3IgcG9zaXRpb25lZCBkZXNjZW5kYW50cy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcApp bmRleCA2YzMxMDJjZTg5YzlmMmNjNzcxZTIxYjRjNTk1YjkyZjViNzk4NTliLi45MzM5NmYwZDM1 YTUxY2NmMGM0MTE0NTUzMjIyZDEyYzM1NzlmODNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCkBAIC0xMTQsMTAgKzExNCwx MiBAQCBzdGF0aWMgTGF5b3V0VW5pdCBjb250ZW50SGVpZ2h0Rm9yRm9ybWF0dGluZ0NvbnRleHRS b290KGNvbnN0IExheW91dFN0YXRlJiBsYXlvdQogICAgICAgICAgICAgYm90dG9tID0gIGlubGlu ZVJ1bnMubGFzdCgpLmxvZ2ljYWxCb3R0b20oKTsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAo Zm9ybWF0dGluZ1Jvb3RDb250YWluZXIuZXN0YWJsaXNoZXNCbG9ja0Zvcm1hdHRpbmdDb250ZXh0 KCkgfHwgbGF5b3V0Qm94LmlzRG9jdW1lbnRCb3goKSkgewotICAgICAgICBhdXRvJiBmaXJzdERp c3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KCpmb3JtYXR0aW5n Um9vdENvbnRhaW5lci5maXJzdEluRmxvd0NoaWxkKCkpOwotICAgICAgICBhdXRvJiBsYXN0RGlz cGxheUJveCA9IGxheW91dFN0YXRlLmRpc3BsYXlCb3hGb3JMYXlvdXRCb3goKmZvcm1hdHRpbmdS b290Q29udGFpbmVyLmxhc3RJbkZsb3dDaGlsZCgpKTsKLSAgICAgICAgdG9wID0gZmlyc3REaXNw bGF5Qm94LnJlY3RXaXRoTWFyZ2luKCkudG9wKCk7Ci0gICAgICAgIGJvdHRvbSA9IGxhc3REaXNw bGF5Qm94LnJlY3RXaXRoTWFyZ2luKCkuYm90dG9tKCk7CisgICAgICAgIGlmIChmb3JtYXR0aW5n Um9vdENvbnRhaW5lci5oYXNJbkZsb3dDaGlsZCgpKSB7CisgICAgICAgICAgICBhdXRvJiBmaXJz dERpc3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KCpmb3JtYXR0 aW5nUm9vdENvbnRhaW5lci5maXJzdEluRmxvd0NoaWxkKCkpOworICAgICAgICAgICAgYXV0byYg bGFzdERpc3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KCpmb3Jt YXR0aW5nUm9vdENvbnRhaW5lci5sYXN0SW5GbG93Q2hpbGQoKSk7CisgICAgICAgICAgICB0b3Ag PSBmaXJzdERpc3BsYXlCb3gucmVjdFdpdGhNYXJnaW4oKS50b3AoKTsKKyAgICAgICAgICAgIGJv dHRvbSA9IGxhc3REaXNwbGF5Qm94LnJlY3RXaXRoTWFyZ2luKCkuYm90dG9tKCk7CisgICAgICAg IH0KICAgICB9CiAKICAgICBhdXRvKiBmb3JtYXR0aW5nQ29udGV4dFJvb3QgPSAmbGF5b3V0Qm94 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcAppbmRleCA0ZjI2YzRmN2VkM2M3 Y2M1M2ExYmEyNGU3ZGQ5N2I0MzE3NjAwNDIzLi4zNjFjNDc4NzU1YzlkZmMzNTUzYjMyYzY1ZDkz YTJiMzBkZTUzYzc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0 aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcApAQCAt NDYsNyArNDYsNyBAQCBzdGF0aWMgYm9vbCBhcmVFc3NlbnRpYWxseUVxdWFsKGZsb2F0IGEsIExh eW91dFVuaXQgYikKICAgICBpZiAoYSA9PSBiLnRvRmxvYXQoKSkKICAgICAgICAgcmV0dXJuIHRy dWU7CiAKLSAgICByZXR1cm4gZmFicyhhIC0gYi50b0Zsb2F0KCkpIDw9IDQgKiBMYXlvdXRVbml0 OjplcHNpbG9uKCk7CisgICAgcmV0dXJuIGZhYnMoYSAtIGIudG9GbG9hdCgpKSA8PSA4ICogTGF5 b3V0VW5pdDo6ZXBzaWxvbigpOwogfQogCiBzdGF0aWMgYm9vbCBvdXRwdXRNaXNtYXRjaGluZ1Np bXBsZUxpbmVJbmZvcm1hdGlvbklmTmVlZGVkKFRleHRTdHJlYW0mIHN0cmVhbSwgY29uc3QgTGF5 b3V0U3RhdGUmIGxheW91dFN0YXRlLCBjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIGJsb2NrRmxvdywg Y29uc3QgQ29udGFpbmVyJiBpbmxpbmVGb3JtYXR0aW5nUm9vdCkKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYmJlNGMxZGMxNDhjNjBiOTY3ZDE4 MmY4NGQzNmE3OTFhODhiZDkxLi5iZGEwNzQ0YTdkOTk5NjdmY2MxYmEyMGFlOWVjY2IxOGRkMjIx MzcyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMTcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbTEZDXVtCRkNdIENoZWNrIGZvciBpbmZsb3cgY2hpbGRyZW4gd2hpbGUg Y29tcHV0aW5nIGhlaWdodCBmb3IgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0IHJvb3RzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNTU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBMYXlvdXRSZWxv YWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dDoKKwogMjAxOS0wMS0xNyAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0JGQ10gQW4gZWxlbWVudCB3 aXRoIHRyYW5zZm9ybSBpcyBhIGNvbnRhaW5pbmcgYmxvY2sgZm9yIHBvc2l0aW9uZWQgZGVzY2Vu ZGFudHMuCmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5n LXRlc3RzLnR4dCBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMu dHh0CmluZGV4IGE4YjhlMDc1NWZmM2M3ZDUwM2QxYjllMTJkNzcwY2ZiMzg2ZWJlMzYuLjgxNGM5 MmY0NTRhYjg5ZGJjNGFlM2M0NjMwNjRiODRlMWJkZTY4MjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xh eW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CisrKyBiL1Rvb2xzL0xheW91 dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CkBAIC0xMDUsNiArMTA1LDcgQEAg ZmFzdC9ibG9jay9mbG9hdC8wMDguaHRtbAogZmFzdC9ibG9jay9mbG9hdC8wMDkuaHRtbAogZmFz dC9ibG9jay9mbG9hdC8wMTMuaHRtbAogZmFzdC9ibG9jay9mbG9hdC8wMTkuaHRtbAorZmFzdC9i bG9jay9mbG9hdC8wMzAuaHRtbAogZmFzdC9ibG9jay9mbG9hdC9uZWdhdGl2ZS1tYXJnaW4tY2xl YXIuaHRtbAogZmFzdC9ibG9jay9mbG9hdC9vdmVyaGFuZ2luZy1hZnRlci1oZWlnaHQtZGVjcmVh c2Utb2Zmc2V0cy5odG1sCiBmYXN0L2Jsb2NrL2Zsb2F0L292ZXJoYW5naW5nLWFmdGVyLWhlaWdo dC1kZWNyZWFzZS5odG1sCg==