193547 2019-01-17 12:11:33 -0800 [ews-build] validate-patch should handle the case when bug_id is None 2019-01-17 13:34:12 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard lforschler webkit-bug-importer oldest_to_newest 1495586 0 aakash_jain 2019-01-17 12:11:33 -0800 If bug_id is None for any reason (e.g.: EWS web-app did not passed bug_id to buildbot), it should be handled properly. Note that EWS doesn't need bug_id to process the patch, it is needed only to validate if the bug is still open or already closed. 1495589 1 359403 aakash_jain 2019-01-17 12:17:20 -0800 Created attachment 359403 Proposed patch 1495608 2 359403 lforschler 2019-01-17 12:57:32 -0800 Comment on attachment 359403 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review r=me with typo fix. > Tools/ChangeLog:10 > + (ValidatePatch.start): If bug_id is set as None in build propeties, fetch it from the patch. typo: properties 1495610 3 359403 jbedard 2019-01-17 13:03:17 -0800 Comment on attachment 359403 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359403&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:334 > + bug_id = self.getProperty('bug_id', '') or self.get_bug_id_from_patch(patch_id) Is self.get_bug_id_from_patch(patch_id) a network operation? That's the only reason I can think to change this. 1495616 4 aakash_jain 2019-01-17 13:13:13 -0800 > Is self.get_bug_id_from_patch(patch_id) a network operation? Yes, it is a network operation. It fetches the patch using bugzilla REST API and reads bug id from it. 1495633 5 aakash_jain 2019-01-17 13:28:48 -0800 Committed r240128: <https://trac.webkit.org/changeset/240128> 1495634 6 webkit-bug-importer 2019-01-17 13:29:28 -0800 <rdar://problem/47362136> 359403 2019-01-17 12:17:20 -0800 2019-01-17 13:34:12 -0800 Proposed patch ews-build-bugid-None.patch text/plain 1864 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDEyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB2YWxpZGF0ZS1wYXRjaCBzaG91bGQgaGFuZGxlIHRo ZSBjYXNlIHdoZW4gYnVnX2lkIGlzIE5vbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MzU0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5 OgorICAgICAgICAoVmFsaWRhdGVQYXRjaC5faXNfYnVnX2Nsb3NlZCk6IEdyYWNlZnVsbHkgaGFu ZGxlIHRoZSBjYXNlIHdoZW4gYnVnX2lkIGlzIE5vbmUuCisgICAgICAgIChWYWxpZGF0ZVBhdGNo LnN0YXJ0KTogSWYgYnVnX2lkIGlzIHNldCBhcyBOb25lIGluIGJ1aWxkIHByb3BldGllcywgZmV0 Y2ggaXQgZnJvbSB0aGUgcGF0Y2guCisKIDIwMTktMDEtMTcgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtCRkNdIEFuIGVsZW1lbnQgd2l0aCB0cmFuc2Zv cm0gaXMgYSBjb250YWluaW5nIGJsb2NrIGZvciBwb3NpdGlvbmVkIGRlc2NlbmRhbnRzLgpJbmRl eDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24g MjQwMTIyKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0zMDMsNiArMzAzLDEwIEBAIGNsYXNzIFZhbGlkYXRlUGF0Y2goYnVp bGRzdGVwLkJ1aWxkU3RlcCkKICAgICAgICAgcmV0dXJuIDAKIAogICAgIGRlZiBfaXNfYnVnX2Ns b3NlZChzZWxmLCBidWdfaWQpOgorICAgICAgICBpZiBub3QgYnVnX2lkOgorICAgICAgICAgICAg c2VsZi5fYWRkVG9Mb2coJ3N0ZGlvJywgJ1NraXBwaW5nIGJ1ZyBzdGF0dXMgdmFsaWRhdGlvbiBz aW5jZSBidWcgaWQgaXMgTm9uZS5cbicpCisgICAgICAgICAgICByZXR1cm4gLTEKKwogICAgICAg ICBidWdfanNvbiA9IHNlbGYuZ2V0X2J1Z19qc29uKGJ1Z19pZCkKICAgICAgICAgaWYgbm90IGJ1 Z19qc29uIG9yIG5vdCBidWdfanNvbi5nZXQoJ3N0YXR1cycpOgogICAgICAgICAgICAgc2VsZi5f YWRkVG9Mb2coJ3N0ZGlvJywgJ1VuYWJsZSB0byBmZXRjaCBidWcge30uXG4nLmZvcm1hdChidWdf aWQpKQpAQCAtMzI3LDcgKzMzMSw3IEBAIGNsYXNzIFZhbGlkYXRlUGF0Y2goYnVpbGRzdGVwLkJ1 aWxkU3RlcCkKICAgICAgICAgICAgIHNlbGYuZmluaXNoZWQoRkFJTFVSRSkKICAgICAgICAgICAg IHJldHVybiBOb25lCiAKLSAgICAgICAgYnVnX2lkID0gc2VsZi5nZXRQcm9wZXJ0eSgnYnVnX2lk Jywgc2VsZi5nZXRfYnVnX2lkX2Zyb21fcGF0Y2gocGF0Y2hfaWQpKQorICAgICAgICBidWdfaWQg PSBzZWxmLmdldFByb3BlcnR5KCdidWdfaWQnLCAnJykgb3Igc2VsZi5nZXRfYnVnX2lkX2Zyb21f cGF0Y2gocGF0Y2hfaWQpCiAKICAgICAgICAgYnVnX2Nsb3NlZCA9IHNlbGYuX2lzX2J1Z19jbG9z ZWQoYnVnX2lkKQogICAgICAgICBpZiBidWdfY2xvc2VkID09IDE6Cg==