193528 2019-01-16 22:08:44 -0800 [LFC][BFC][Quirk] Take body padding and border into account when stretching height. 2019-01-17 08:07:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1495397 0 zalan 2019-01-16 22:08:44 -0800 ssia 1495398 1 359351 zalan 2019-01-16 22:14:53 -0800 Created attachment 359351 Patch 1495465 2 359351 commit-queue 2019-01-17 08:01:07 -0800 Comment on attachment 359351 Patch Rejecting attachment 359351 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 359351, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=359351&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=193528&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 359351 from bug 193528. Fetching: https://bugs.webkit.org/attachment.cgi?id=359351 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp patching file Source/WebCore/layout/displaytree/DisplayBox.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp patching file Source/WebCore/layout/displaytree/DisplayBox.h patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit d2c08c56397..1aced4fa833 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 240107 = d2c08c563972982a9074a7334d0aa0da79da2551 r240108 = 1aced4fa8335c27b41a7417660ecbcc14b001d34 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/10784226 1495467 3 zalan 2019-01-17 08:06:30 -0800 Committed r240109: <https://trac.webkit.org/changeset/240109> 1495468 4 webkit-bug-importer 2019-01-17 08:07:28 -0800 <rdar://problem/47351324> 359351 2019-01-16 22:14:53 -0800 2019-01-17 08:01:07 -0800 Patch bug-193528-20190116221436.patch text/plain 6451 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIyMGQ0N2QwMjgxZjM0 NWNjODcyMDE3NTEzNTk5YjVmM2E3MDM3Ni4uOWYwNjYxMjM4ODNhMGU3ZWRhOGFiZmM2NmU4ZjA1 NjU5NDE2M2QxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAxLTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtRdWlya10g VGFrZSBib2R5IHBhZGRpbmcgYW5kIGJvcmRlciBpbnRvIGFjY291bnQgd2hlbiBzdHJldGNoaW5n IGhlaWdodC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MzUyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0UXVpcmtzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6UXVp cmtzOjpzdHJldGNoZWRJbkZsb3dIZWlnaHQpOgorICAgICAgICAqIGxheW91dC9kaXNwbGF5dHJl ZS9EaXNwbGF5Qm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6OnZlcnRpY2Fs Qm9yZGVyIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkJveDo6aG9yaXpvbnRh bEJvcmRlciBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6OnZlcnRpY2Fs UGFkZGluZyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6Omhvcml6b250 YWxQYWRkaW5nIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlld0xheW91dENvbnRleHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6bGF5b3V0VXNpbmdGb3JtYXR0aW5nQ29udGV4dCk6CisK IDIwMTktMDEtMTYgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBb TEZDXVtCRkNdIEluZmxvdyBub24tcmVwbGFjZWQgdXNlZCB3aWR0aCBzaG91bGQgbm90IGJlIG5l Z2F0aXZlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGlu Zy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0UXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dFF1aXJrcy5jcHAKaW5kZXgg NzFhMWE3OWRlNmZlMDUwNzlkNTBhM2FlOTkzMTk0NjI4MmZiZjA1MS4uY2ZmZTcyMmU5NDg1YjMw YjEyZjBiYWEzZTRjOGM3MDBiNWRlN2I5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0UXVpcmtzLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0Nv bnRleHRRdWlya3MuY3BwCkBAIC03MiwxMSArNzIsOSBAQCBIZWlnaHRBbmRNYXJnaW4gQmxvY2tG b3JtYXR0aW5nQ29udGV4dDo6UXVpcmtzOjpzdHJldGNoZWRJbkZsb3dIZWlnaHQoY29uc3QgTGF5 bwogCiAgICAgYXV0byYgZG9jdW1lbnRCb3ggPSBsYXlvdXRCb3guaXNEb2N1bWVudEJveCgpID8g bGF5b3V0Qm94IDogKmxheW91dEJveC5wYXJlbnQoKTsKICAgICBhdXRvJiBkb2N1bWVudEJveERp c3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGRvY3VtZW50Qm94 KTsKLSAgICBhdXRvIGRvY3VtZW50Qm94VmVydGljYWxCb3JkZXJzID0gZG9jdW1lbnRCb3hEaXNw bGF5Qm94LmJvcmRlclRvcCgpICsgZG9jdW1lbnRCb3hEaXNwbGF5Qm94LmJvcmRlckJvdHRvbSgp OwotICAgIGF1dG8gZG9jdW1lbnRCb3hWZXJ0aWNhbFBhZGRpbmdzID0gZG9jdW1lbnRCb3hEaXNw bGF5Qm94LnBhZGRpbmdUb3AoKS52YWx1ZU9yKDApICsgZG9jdW1lbnRCb3hEaXNwbGF5Qm94LnBh ZGRpbmdCb3R0b20oKS52YWx1ZU9yKDApOwogCiAgICAgYXV0byBzdHJlY2hlZEhlaWdodCA9IGxh eW91dFN0YXRlLmRpc3BsYXlCb3hGb3JMYXlvdXRCb3goaW5pdGlhbENvbnRhaW5pbmdCbG9jayhs YXlvdXRCb3gpKS5jb250ZW50Qm94SGVpZ2h0KCk7Ci0gICAgc3RyZWNoZWRIZWlnaHQgLT0gZG9j dW1lbnRCb3hWZXJ0aWNhbEJvcmRlcnMgKyBkb2N1bWVudEJveFZlcnRpY2FsUGFkZGluZ3M7Cisg ICAgc3RyZWNoZWRIZWlnaHQgLT0gZG9jdW1lbnRCb3hEaXNwbGF5Qm94LnZlcnRpY2FsQm9yZGVy KCkgKyBkb2N1bWVudEJveERpc3BsYXlCb3gudmVydGljYWxQYWRkaW5nKCkudmFsdWVPcigwKTsK IAogICAgIExheW91dFVuaXQgdG90YWxWZXJ0aWNhbE1hcmdpbjsKICAgICBpZiAobGF5b3V0Qm94 LmlzRG9jdW1lbnRCb3goKSkgewpAQCAtOTAsNiArODgsOSBAQCBIZWlnaHRBbmRNYXJnaW4gQmxv Y2tGb3JtYXR0aW5nQ29udGV4dDo6UXVpcmtzOjpzdHJldGNoZWRJbkZsb3dIZWlnaHQoY29uc3Qg TGF5bwogICAgICAgICBhdXRvIGRvY3VtZW50Qm94VmVydGljYWxNYXJnaW4gPSBHZW9tZXRyeTo6 Y29tcHV0ZWRWZXJ0aWNhbE1hcmdpbihsYXlvdXRTdGF0ZSwgZG9jdW1lbnRCb3gpOwogICAgICAg ICBzdHJlY2hlZEhlaWdodCAtPSAoZG9jdW1lbnRCb3hWZXJ0aWNhbE1hcmdpbi5iZWZvcmUudmFs dWVPcigwKSArIGRvY3VtZW50Qm94VmVydGljYWxNYXJnaW4uYWZ0ZXIudmFsdWVPcigwKSk7CiAK KyAgICAgICAgYXV0byYgYm9keUJveERpc3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94 Rm9yTGF5b3V0Qm94KGxheW91dEJveCk7CisgICAgICAgIHN0cmVjaGVkSGVpZ2h0IC09IGJvZHlC b3hEaXNwbGF5Qm94LnZlcnRpY2FsQm9yZGVyKCkgKyBib2R5Qm94RGlzcGxheUJveC52ZXJ0aWNh bFBhZGRpbmcoKS52YWx1ZU9yKDApOworCiAgICAgICAgIGF1dG8gbm9uQ29sbGFwc2VkTWFyZ2lu ID0gaGVpZ2h0QW5kTWFyZ2luLm5vbkNvbGxhcHNlZE1hcmdpbjsKICAgICAgICAgYXV0byBjb2xs YXBzZWRNYXJnaW4gPSBNYXJnaW5Db2xsYXBzZTo6Y29sbGFwc2VkVmVydGljYWxWYWx1ZXMobGF5 b3V0U3RhdGUsIGxheW91dEJveCwgbm9uQ29sbGFwc2VkTWFyZ2luKTsKICAgICAgICAgdG90YWxW ZXJ0aWNhbE1hcmdpbiA9IGNvbGxhcHNlZE1hcmdpbi5iZWZvcmUudmFsdWVPcihub25Db2xsYXBz ZWRNYXJnaW4uYmVmb3JlKSArIGNvbGxhcHNlZE1hcmdpbi5hZnRlci52YWx1ZU9yKG5vbkNvbGxh cHNlZE1hcmdpbi5hZnRlcik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlz cGxheXRyZWUvRGlzcGxheUJveC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVl L0Rpc3BsYXlCb3guaAppbmRleCAxZDQ1YWEzZGZiNjkwOWI4NGZkYjM5MDkxYWQ0ZjYyMWJmMTcx YzlhLi5iNzU0OWYxZmM0MGE2NjI4MDdlYmYwYjkwMDFjZjk5ZWVmOTA1NzlmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUvRGlzcGxheUJveC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5Qm94LmgKQEAgLTE1NCwxMSAr MTU0LDE1IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0IGJvcmRlckxlZnQoKSBjb25zdDsKICAg ICBMYXlvdXRVbml0IGJvcmRlckJvdHRvbSgpIGNvbnN0OwogICAgIExheW91dFVuaXQgYm9yZGVy UmlnaHQoKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IHZlcnRpY2FsQm9yZGVyKCkgY29uc3QgeyBy ZXR1cm4gYm9yZGVyVG9wKCkgKyBib3JkZXJCb3R0b20oKTsgfQorICAgIExheW91dFVuaXQgaG9y aXpvbnRhbEJvcmRlcigpIGNvbnN0IHsgcmV0dXJuIGJvcmRlckxlZnQoKSArIGJvcmRlclJpZ2h0 KCk7IH0KIAogICAgIE9wdGlvbmFsPExheW91dFVuaXQ+IHBhZGRpbmdUb3AoKSBjb25zdDsKICAg ICBPcHRpb25hbDxMYXlvdXRVbml0PiBwYWRkaW5nTGVmdCgpIGNvbnN0OwogICAgIE9wdGlvbmFs PExheW91dFVuaXQ+IHBhZGRpbmdCb3R0b20oKSBjb25zdDsKICAgICBPcHRpb25hbDxMYXlvdXRV bml0PiBwYWRkaW5nUmlnaHQoKSBjb25zdDsKKyAgICBPcHRpb25hbDxMYXlvdXRVbml0PiB2ZXJ0 aWNhbFBhZGRpbmcoKSBjb25zdDsKKyAgICBPcHRpb25hbDxMYXlvdXRVbml0PiBob3Jpem9udGFs UGFkZGluZygpIGNvbnN0OwogCiAgICAgTGF5b3V0VW5pdCBjb250ZW50Qm94VG9wKCkgY29uc3Qg eyByZXR1cm4gcGFkZGluZ0JveFRvcCgpICsgcGFkZGluZ1RvcCgpLnZhbHVlT3IoMCk7IH0KICAg ICBMYXlvdXRVbml0IGNvbnRlbnRCb3hMZWZ0KCkgY29uc3QgeyByZXR1cm4gcGFkZGluZ0JveExl ZnQoKSArIHBhZGRpbmdMZWZ0KCkudmFsdWVPcigwKTsgfQpAQCAtNjU1LDYgKzY1OSwyNCBAQCBp bmxpbmUgT3B0aW9uYWw8TGF5b3V0VW5pdD4gQm94OjpwYWRkaW5nUmlnaHQoKSBjb25zdAogICAg IHJldHVybiBtX3BhZGRpbmctPmhvcml6b250YWwucmlnaHQ7CiB9CiAKK2lubGluZSBPcHRpb25h bDxMYXlvdXRVbml0PiBCb3g6OnZlcnRpY2FsUGFkZGluZygpIGNvbnN0Cit7CisgICAgYXV0byBw YWRkaW5nVG9wID0gdGhpcy0+cGFkZGluZ1RvcCgpOworICAgIGF1dG8gcGFkZGluZ0JvdHRvbSA9 IHRoaXMtPnBhZGRpbmdCb3R0b20oKTsKKyAgICBpZiAoIXBhZGRpbmdUb3AgJiYgIXBhZGRpbmdC b3R0b20pCisgICAgICAgIHJldHVybiB7IH07CisgICAgcmV0dXJuIHBhZGRpbmdUb3AudmFsdWVP cigwKSArIHBhZGRpbmdCb3R0b20udmFsdWVPcigwKTsKK30KKworaW5saW5lIE9wdGlvbmFsPExh eW91dFVuaXQ+IEJveDo6aG9yaXpvbnRhbFBhZGRpbmcoKSBjb25zdAoreworICAgIGF1dG8gcGFk ZGluZ0xlZnQgPSB0aGlzLT5wYWRkaW5nTGVmdCgpOworICAgIGF1dG8gcGFkZGluZ1JpZ2h0ID0g dGhpcy0+cGFkZGluZ1JpZ2h0KCk7CisgICAgaWYgKCFwYWRkaW5nTGVmdCAmJiAhcGFkZGluZ1Jp Z2h0KQorICAgICAgICByZXR1cm4geyB9OworICAgIHJldHVybiBwYWRkaW5nTGVmdC52YWx1ZU9y KDApICsgcGFkZGluZ1JpZ2h0LnZhbHVlT3IoMCk7Cit9CisKIGlubGluZSBMYXlvdXRVbml0IEJv eDo6Ym9yZGVyVG9wKCkgY29uc3QKIHsKICAgICBBU1NFUlQobV9oYXNWYWxpZEJvcmRlcik7CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTA4NzVi MDg3Zjk3MjNlYWIzODMzZWVhZGU4YjdhYmY0ZDQ3NWY4YS4uOTJlMDA2NTkxMjJlMmQyMDNiYzU3 YWRjODZhMzlkOTlmYmY0MGYwOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTAxLTE2ICBaYWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtRdWlya10gVGFrZSBib2R5 IHBhZGRpbmcgYW5kIGJvcmRlciBpbnRvIGFjY291bnQgd2hlbiBzdHJldGNoaW5nIGhlaWdodC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzUyOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTGF5b3V0 UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQ6CisKIDIwMTktMDEtMTYgIFphbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtCRkNdIEluZmxvdyBu b24tcmVwbGFjZWQgdXNlZCB3aWR0aCBzaG91bGQgbm90IGJlIG5lZ2F0aXZlLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQgYi9Ub29s cy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dAppbmRleCA0Njk1ZjEx MmM5Y2RlNjkwMjIyYjhjNmIxYWQ1YjIwYThkNzJhMDg2Li5iYmU0YTlkYmFlZGU5NzI5ZmRhMzIz ZTBhMWQ5NWQxNmNjZGRlZGExIDEwMDY0NAotLS0gYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNj L0xGQy1wYXNzaW5nLXRlc3RzLnR4dAorKysgYi9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xG Qy1wYXNzaW5nLXRlc3RzLnR4dApAQCAtOTAsNiArOTAsNyBAQCBmYXN0L2Jsb2NrL2Jhc2ljLzAw Ny5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwOC5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwOS5o dG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAxMi5odG1sCitmYXN0L2Jsb2NrL2Jhc2ljL3F1aXJrLWhl aWdodC5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljL2NoaWxkLWJsb2NrLWxldmVsLWJveC13aXRoLWhl aWdodC1wZXJjZW50Lmh0bWwKIGZhc3QvYmxvY2svYmFzaWMvaGVpZ2h0LXBlcmNlbnRhZ2Utc2lt cGxlLmh0bWwKIGZhc3QvYmxvY2svYmFzaWMvaW5saW5lLWNvbnRlbnQtd2l0aC1mbG9hdGluZy1p bWFnZS5odG1sCg==