193526 2019-01-16 20:32:56 -0800 [JSC] Add generateHeapSnapshotForGCDebugging function to dump GCDebugging data 2019-01-17 09:33:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1495382 0 ysuzuki 2019-01-16 20:32:56 -0800 [JSC] Add a mode to generateHeapSnapshot function to dump GCDebugging data 1495384 1 359346 ysuzuki 2019-01-16 20:46:18 -0800 Created attachment 359346 Patch 1495401 2 359346 ysuzuki 2019-01-16 22:57:56 -0800 Comment on attachment 359346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359346&action=review > Source/JavaScriptCore/ChangeLog:13 > + multiple times for debugging. Currently, it only generates a large string, which is easily distinguishable in the heap inspector tool. This is why this patch adds a new generateHeapSnapshotForGCDebugging, while we already have functionGenerateHeapSnapshot. 1495481 3 359346 msaboff 2019-01-17 08:37:27 -0800 Comment on attachment 359346 Patch r=me 1495492 4 359346 ysuzuki 2019-01-17 09:07:21 -0800 Comment on attachment 359346 Patch Thanks! 1495502 5 359346 commit-queue 2019-01-17 09:32:44 -0800 Comment on attachment 359346 Patch Clearing flags on attachment: 359346 Committed r240113: <https://trac.webkit.org/changeset/240113> 1495503 6 commit-queue 2019-01-17 09:32:45 -0800 All reviewed patches have been landed. Closing bug. 1495504 7 webkit-bug-importer 2019-01-17 09:33:37 -0800 <rdar://problem/47353310> 359346 2019-01-16 20:46:18 -0800 2019-01-17 09:32:44 -0800 Patch bug-193526-20190116204617.patch text/plain 3937 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NDdmYTQ5YWEwMmE4MWI1NjkzMjgzNWU5OWMzZDk1MGQ4NDk0MzJiLi5mYTI0ZDYwNzIxZThkMDBh NjMzMzhmZjEzMDAxMDEwNTVjNTljNjg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOS0wMS0xNiAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIEFkZCBnZW5lcmF0ZUhlYXBTbmFwc2hvdEZvckdD RGVidWdnaW5nIGZ1bmN0aW9uIHRvIGR1bXAgR0NEZWJ1Z2dpbmcgZGF0YQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNTI2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGdlbmVy YXRlSGVhcFNuYXBzaG90Rm9yR0NEZWJ1Z2dpbmcgdG8gSlNDIHNoZWxsIHRvIGR1bXAgaGVhcCBz bmFwc2hvdCBKU09OIHN0cmluZyB3aXRoIEdDRGVidWdnaW5nIG9wdGlvbi4KKyAgICAgICAgR0NE ZWJ1Z2dpbmdTbmFwc2hvdCBtb2RlIGlzIHNsaWdodGx5IGRpZmZlcmVudCBmcm9tIEluc3BlY3Rv clNuYXBzaG90IGluIHRlcm1zIG9mIGJvdGggdGhlIG91dHB1dCBkYXRhIGFuZCB0aGUgYmVoYXZp b3IuCisgICAgICAgIEl0IGFsd2F5cyB0YWtlcyBmdWxsIHNuYXBzaG90LCBhbmQgaXQgcmVwb3J0 cyBpbnRlcm5hbCBkYXRhIHRvby4gVGhpcyBpcyB1c2VmdWwgdG8gdmlldyB0aGUgbGl2ZSBoZWFw IG9iamVjdHMgYWZ0ZXIgcnVubmluZworICAgICAgICB0aGUgY29kZS4gQWxzbywgZ2VuZXJhdGVI ZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2luZyByZXR1cm5zIFN0cmluZyBpbnN0ZWFkIG9mIHBhcnNp bmcgaXQgdG8gSlNPYmplY3QgaW50ZXJuYWxseSBieSBjYWxsaW5nCisgICAgICAgIEpTT04ucGFy c2UuIElmIHdlIGNvbnZlcnQgdGhlIFN0cmluZyB0byBidW5jaCBvZiBvYmplY3RzIGJ5IHVzaW5n IEpTT04ucGFyc2UsIGl0IGlzIGRpZmZpY3VsdCB0byBjYWxsIGdlbmVyYXRlSGVhcFNuYXBzaG90 Rm9yR0NEZWJ1Z2dpbmcKKyAgICAgICAgbXVsdGlwbGUgdGltZXMgZm9yIGRlYnVnZ2luZy4gQ3Vy cmVudGx5LCBpdCBvbmx5IGdlbmVyYXRlcyBhIGxhcmdlIHN0cmluZywgd2hpY2ggaXMgZWFzaWx5 IGRpc3Rpbmd1aXNoYWJsZSBpbiB0aGUgaGVhcCBpbnNwZWN0b3IgdG9vbC4KKworICAgICAgICAq IGpzYy5jcHA6CisgICAgICAgIChHbG9iYWxPYmplY3Q6OmZpbmlzaENyZWF0aW9uKToKKyAgICAg ICAgKGZ1bmN0aW9uR2VuZXJhdGVIZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2luZyk6CisKIDIwMTkt MDEtMTYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9y IG5ldyBieXRlY29kZSBzdHJ1Y3RzIHNvIHRoYXQgdGhlIGZpZWxkcyBhcmUgcHJlZml4ZWQgd2l0 aCAibV8iLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCBiNDY3MzA3ODVkYTE5OWMyZTIwZjVhMGRi YzVkZjYzMjQxMTIzNjBmLi5iNWQ0N2RkM2RiOWFkOGJhNmY4NDViYjMyMTE0ZmIwZGFmOGQ4ZjY1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcApAQCAtMzI4LDYgKzMyOCw3IEBAIHN0YXRpYyBFbmNvZGVk SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uSXMzMkJpdFBsYXRmb3JtKEV4ZWNTdGF0ZSop Owogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25DaGVja01vZHVs ZVN5bnRheChFeGVjU3RhdGUqKTsKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGZ1bmN0aW9uUGxhdGZvcm1TdXBwb3J0c1NhbXBsaW5nUHJvZmlsZXIoRXhlY1N0YXRlKik7CiBz dGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkdlbmVyYXRlSGVhcFNu YXBzaG90KEV4ZWNTdGF0ZSopOworc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg ZnVuY3Rpb25HZW5lcmF0ZUhlYXBTbmFwc2hvdEZvckdDRGVidWdnaW5nKEV4ZWNTdGF0ZSopOwog c3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25SZXNldFN1cGVyU2Ft cGxlclN0YXRlKEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NB TEwgZnVuY3Rpb25FbnN1cmVBcnJheVN0b3JhZ2UoRXhlY1N0YXRlKik7CiAjaWYgRU5BQkxFKFNB TVBMSU5HX1BST0ZJTEVSKQpAQCAtNTYyLDYgKzU2Myw3IEBAIGNsYXNzIEdsb2JhbE9iamVjdCA6 IHB1YmxpYyBKU0dsb2JhbE9iamVjdCB7CiAKICAgICAgICAgYWRkRnVuY3Rpb24odm0sICJwbGF0 Zm9ybVN1cHBvcnRzU2FtcGxpbmdQcm9maWxlciIsIGZ1bmN0aW9uUGxhdGZvcm1TdXBwb3J0c1Nh bXBsaW5nUHJvZmlsZXIsIDApOwogICAgICAgICBhZGRGdW5jdGlvbih2bSwgImdlbmVyYXRlSGVh cFNuYXBzaG90IiwgZnVuY3Rpb25HZW5lcmF0ZUhlYXBTbmFwc2hvdCwgMCk7CisgICAgICAgIGFk ZEZ1bmN0aW9uKHZtLCAiZ2VuZXJhdGVIZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2luZyIsIGZ1bmN0 aW9uR2VuZXJhdGVIZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2luZywgMCk7CiAgICAgICAgIGFkZEZ1 bmN0aW9uKHZtLCAicmVzZXRTdXBlclNhbXBsZXJTdGF0ZSIsIGZ1bmN0aW9uUmVzZXRTdXBlclNh bXBsZXJTdGF0ZSwgMCk7CiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAiZW5zdXJlQXJyYXlTdG9y YWdlIiwgZnVuY3Rpb25FbnN1cmVBcnJheVN0b3JhZ2UsIDApOwogI2lmIEVOQUJMRShTQU1QTElO R19QUk9GSUxFUikKQEAgLTIxMTksNiArMjEyMSwyNCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGZ1bmN0aW9uR2VuZXJhdGVIZWFwU25hcHNob3QoRXhlY1N0YXRlKiBleGVjKQogICAg IHJldHVybiByZXN1bHQ7CiB9CiAKK0VuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rp b25HZW5lcmF0ZUhlYXBTbmFwc2hvdEZvckdDRGVidWdnaW5nKEV4ZWNTdGF0ZSogZXhlYykKK3sK KyAgICBWTSYgdm0gPSBleGVjLT52bSgpOworICAgIEpTTG9ja0hvbGRlciBsb2NrKHZtKTsKKyAg ICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CisgICAgU3RyaW5nIGpzb25T dHJpbmc7CisgICAgeworICAgICAgICBEZWZlckdDRm9yQVdoaWxlIGRlZmVyR0Modm0uaGVhcCk7 IC8vIFByZXZlbnQgY29uY3VycmVudCBHQyBmcm9tIGludGVyZmVyaW5nIHdpdGggdGhlIGZ1bGwg R0MgdGhhdCB0aGUgc25hcHNob3QgZG9lcy4KKworICAgICAgICBIZWFwU25hcHNob3RCdWlsZGVy IHNuYXBzaG90QnVpbGRlcih2bS5lbnN1cmVIZWFwUHJvZmlsZXIoKSwgSGVhcFNuYXBzaG90QnVp bGRlcjo6U25hcHNob3RUeXBlOjpHQ0RlYnVnZ2luZ1NuYXBzaG90KTsKKyAgICAgICAgc25hcHNo b3RCdWlsZGVyLmJ1aWxkU25hcHNob3QoKTsKKworICAgICAgICBqc29uU3RyaW5nID0gc25hcHNo b3RCdWlsZGVyLmpzb24oKTsKKyAgICB9CisgICAgc2NvcGUucmVsZWFzZUFzc2VydE5vRXhjZXB0 aW9uKCk7CisgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmluZygmdm0sIGpzb25TdHJp bmcpKTsKK30KKwogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblJlc2V0U3Vw ZXJTYW1wbGVyU3RhdGUoRXhlY1N0YXRlKikKIHsKICAgICByZXNldFN1cGVyU2FtcGxlclN0YXRl KCk7Cg==