193520 2019-01-16 16:34:01 -0800 [LFC][BFC] For height computation, the bottom edge of the last line box value should not include top border/padding 2019-01-17 08:01:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan aakash_jain ap bfulgham commit-queue koivisto ryanhaddad simon.fraser tsavell webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1495324 0 zalan 2019-01-16 16:34:01 -0800 it needs to be in the coordinate system of the containing block's content box. 1495325 1 359334 zalan 2019-01-16 16:40:36 -0800 Created attachment 359334 Patch 1495435 2 aakash_jain 2019-01-17 04:55:20 -0800 This patch seems to break an API test: TestWebKitAPI.WKWebViewAutofillTests.UsernameAndPasswordFieldSeparatedByRadioButton Can you please have a look? Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 We are doing test-runs for upcoming 'EWS for API tests'. If this is a false positive, please let us know. 1495451 3 zalan 2019-01-17 06:44:22 -0800 (In reply to Aakash Jain from comment #2) > This patch seems to break an API test: > TestWebKitAPI.WKWebViewAutofillTests. > UsernameAndPasswordFieldSeparatedByRadioButton > > Can you please have a look? > > Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 > > We are doing test-runs for upcoming 'EWS for API tests'. If this is a false > positive, please let us know. Sure but this code is behind a run time flag and the flag is not enabled. 1495452 4 wenson_hsieh 2019-01-17 07:13:11 -0800 (In reply to Aakash Jain from comment #2) > This patch seems to break an API test: > TestWebKitAPI.WKWebViewAutofillTests. > UsernameAndPasswordFieldSeparatedByRadioButton > > Can you please have a look? > > Build: https://ews-build.webkit-uat.org/#/builders/20/builds/185 > > We are doing test-runs for upcoming 'EWS for API tests'. If this is a false > positive, please let us know. I believe this is a false positive (see: <https://bugs.webkit.org/show_bug.cgi?id=189165>). 1495463 5 359334 commit-queue 2019-01-17 08:00:20 -0800 Comment on attachment 359334 Patch Clearing flags on attachment: 359334 Committed r240108: <https://trac.webkit.org/changeset/240108> 1495464 6 commit-queue 2019-01-17 08:00:22 -0800 All reviewed patches have been landed. Closing bug. 1495466 7 webkit-bug-importer 2019-01-17 08:01:38 -0800 <rdar://problem/47351239> 359334 2019-01-16 16:40:36 -0800 2019-01-17 08:00:20 -0800 Patch bug-193520-20190116164020.patch text/plain 3539 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIyMGQ0N2QwMjgxZjM0 NWNjODcyMDE3NTEzNTk5YjVmM2E3MDM3Ni4uMTI5MzBlN2U1MzVhZGFhOWQ2NTlkN2RlY2JhZDMw YjUxYmRiNTBhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAxLTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBGb3IgaGVp Z2h0IGNvbXB1dGF0aW9uLCB0aGUgYm90dG9tIGVkZ2Ugb2YgdGhlIGxhc3QgbGluZSBib3ggdmFs dWUgc2hvdWxkIG5vdCBpbmNsdWRlIHRvcCBib3JkZXIvcGFkZGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNTIwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBzaW1pbGFyIHRvIHRoZSBv dGhlciAiMTAuNi4zIiBjYXNlcy4gVGhlIGJvdHRvbSBlZGdlIG9mIHRoZSBsYXN0IGlubGluZSBi b3ggaXMgaW4gdGhlIGNvb3JkaW5hdGUgc3lzdHllbQorICAgICAgICBvZiB0aGUgY29udGFpbmlu ZyBibG9jaydzIGJvcmRlciBib3ggKGFuZCBmb3IgY29udGVudCBoZWlnaHQgY29tcHV0YXRpb24g aXQgbmVlZHMgdG8gYmUgbWFwcGVkIHRvIHRoZSBjb250YWluaW5nIGJsb2NrJ3MgY29udGVudCBi b3ggaW5zdGVhZCkuCisKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9y bWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJs b2NrRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjppbkZsb3dOb25SZXBsYWNlZEhlaWdodEFu ZE1hcmdpbik6CisKIDIwMTktMDEtMTYgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBbTEZDXVtCRkNdIEluZmxvdyBub24tcmVwbGFjZWQgdXNlZCB3aWR0aCBzaG91 bGQgbm90IGJlIG5lZ2F0aXZlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Js b2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0R2Vv bWV0cnkuY3BwCmluZGV4IGY5Y2M3ZDM5YTdiNjkwMTRlODM5ODllMWM4ODUwMzUzYTNkYmQ5NmEu LmY2OGRkYTNjYmQzMTdlZDgwMTQxMDQxOGI4YWQ3Y2E0OTdiNWNkMTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4 dEdlb21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5n L0Jsb2NrRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKQEAgLTc3LDcgKzc3LDcgQEAgSGVp Z2h0QW5kTWFyZ2luIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjppbkZsb3dOb25S ZXBsYWNlZEhlaWdodEFuZE1hcmcKICAgICAgICAgICAgIC8vIFRoaXMgaXMgdGVtcCBhbmQgd2ls bCBiZSByZXBsYWNlZCBieSB0aGUgY29ycmVjdCBkaXNwbGF5IGJveCBvbmNlIGlubGluZSBydW5z IG1vdmUgb3ZlciB0byB0aGUgZGlzcGxheSB0cmVlLgogICAgICAgICAgICAgYXV0byYgaW5saW5l UnVucyA9IGRvd25jYXN0PElubGluZUZvcm1hdHRpbmdTdGF0ZT4obGF5b3V0U3RhdGUuZXN0YWJs aXNoZWRGb3JtYXR0aW5nU3RhdGUobGF5b3V0Qm94KSkuaW5saW5lUnVucygpOwogICAgICAgICAg ICAgYXV0byBib3R0b21FZGdlID0gaW5saW5lUnVucy5pc0VtcHR5KCkgPyBMYXlvdXRVbml0KCkg OiBpbmxpbmVSdW5zLmxhc3QoKS5sb2dpY2FsQm90dG9tKCk7Ci0gICAgICAgICAgICByZXR1cm4g eyBib3R0b21FZGdlLCBub25Db2xsYXBzZWRNYXJnaW4gfTsKKyAgICAgICAgICAgIHJldHVybiB7 IGJvdHRvbUVkZ2UgLSBib3JkZXJBbmRQYWRkaW5nVG9wLCBub25Db2xsYXBzZWRNYXJnaW4gfTsK ICAgICAgICAgfQogCiAgICAgICAgIC8vIDIuIHRoZSBib3R0b20gZWRnZSBvZiB0aGUgYm90dG9t IChwb3NzaWJseSBjb2xsYXBzZWQpIG1hcmdpbiBvZiBpdHMgbGFzdCBpbi1mbG93IGNoaWxkLCBp ZiB0aGUgY2hpbGQncyBib3R0b20gbWFyZ2luLi4uCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTA4NzViMDg3Zjk3MjNlYWIzODMzZWVhZGU4Yjdh YmY0ZDQ3NWY4YS4uYWM5OGM0YmJhNzQwMGMxOTM3MTQ0MDE3N2E3NGM3MTVhNzNhZmI3NiAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE5LTAxLTE2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgW0xGQ11bQkZDXSBGb3IgaGVpZ2h0IGNvbXB1dGF0aW9uLCB0aGUgYm90dG9tIGVkZ2Ug b2YgdGhlIGxhc3QgbGluZSBib3ggdmFsdWUgc2hvdWxkIGluY2x1ZGUgdG9wIGJvcmRlci9wYWRk aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM1 MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIExh eW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0OgorCiAyMDE5LTAxLTE2ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBJbmZs b3cgbm9uLXJlcGxhY2VkIHVzZWQgd2lkdGggc2hvdWxkIG5vdCBiZSBuZWdhdGl2ZS4KZGlmZiAt LWdpdCBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0IGIv VG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKaW5kZXggNDY5 NWYxMTJjOWNkZTY5MDIyMmI4YzZiMWFkNWIyMGE4ZDcyYTA4Ni4uYmZhMGVmZjFkMDI0ZmQ1YzFi N2NhOTc2MTA3NTc3Y2RiOWMyMjUxYiAxMDA2NDQKLS0tIGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQv bWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKKysrIGIvVG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlz Yy9MRkMtcGFzc2luZy10ZXN0cy50eHQKQEAgLTkwLDYgKzkwLDcgQEAgZmFzdC9ibG9jay9iYXNp Yy8wMDcuaHRtbAogZmFzdC9ibG9jay9iYXNpYy8wMDguaHRtbAogZmFzdC9ibG9jay9iYXNpYy8w MDkuaHRtbAogZmFzdC9ibG9jay9iYXNpYy8wMTIuaHRtbAorZmFzdC9ibG9jay9iYXNpYy8wMjEu aHRtbAogZmFzdC9ibG9jay9iYXNpYy9jaGlsZC1ibG9jay1sZXZlbC1ib3gtd2l0aC1oZWlnaHQt cGVyY2VudC5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljL2hlaWdodC1wZXJjZW50YWdlLXNpbXBsZS5o dG1sCiBmYXN0L2Jsb2NrL2Jhc2ljL2lubGluZS1jb250ZW50LXdpdGgtZmxvYXRpbmctaW1hZ2Uu aHRtbAo=