193501 2019-01-16 11:40:53 -0800 Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function 2019-01-16 14:04:42 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P1 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck nvasilyev webkit-bug-importer oldest_to_newest 1495139 0 mattbaker 2019-01-16 11:40:53 -0800 This bug was introduced in https://webkit.org/b/192917. Steps to Reproduce: 1. Inspect daringfireball.net 2. Open Elements tab 3. Reload the page TypeError:​ this._indexesForSubtree is not a function. (In 'this._indexesForSubtree(child)​', 'this._indexesForSubtree' is undefined)​ (at TreeOutline.js:​332:​53)​ removeChildAtIndex @ TreeOutline.js:​332:​53 _updateChildren @ DOMTreeElement.js:​494:​36 _updateChildren @ [native code]​ getChildNodes @ DOMNode.js:​490:​25 updateChildren @ DOMTreeElement.js:​420:​45 _updateModifiedNodes @ DOMTreeUpdater.js:​125:​49 performWork @ Utilities.js:​1501:​47 1495141 1 webkit-bug-importer 2019-01-16 11:41:29 -0800 <rdar://problem/47323967> 1495142 2 359285 mattbaker 2019-01-16 11:42:32 -0800 Created attachment 359285 Patch 1495193 3 359285 nvasilyev 2019-01-16 13:20:15 -0800 Comment on attachment 359285 Patch Looks good. I can't reproduce the exception anymore. 1495202 4 359285 joepeck 2019-01-16 13:39:11 -0800 Comment on attachment 359285 Patch r=me 1495222 5 359285 commit-queue 2019-01-16 14:04:41 -0800 Comment on attachment 359285 Patch Clearing flags on attachment: 359285 Committed r240051: <https://trac.webkit.org/changeset/240051> 1495223 6 commit-queue 2019-01-16 14:04:42 -0800 All reviewed patches have been landed. Closing bug. 359285 2019-01-16 11:42:32 -0800 2019-01-16 14:04:41 -0800 Patch bug-193501-20190116114231.patch text/plain 1817 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw Yzg0MzE3ODRiMDEzY2Q4M2FiMTJmNDgxOGUyNTQ1ZTkyZTZiZjJjLi41MmViMzIyOWFmZWUwZTVi ZTJlZGMwMzdiOTg1ZGFlYmU0OTYxMmY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wMS0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IFRyZWVPdXRsaW5lIFR5cGVFcnJvcjrigIsg dGhpcy5faW5kZXhlc0ZvclN1YnRyZWUgaXMgbm90IGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzUwMQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDczMjM5Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzOgorICAgICAg ICAoV0kuVHJlZU91dGxpbmUucHJvdG90eXBlLnJlbW92ZUNoaWxkQXRJbmRleCk6CisKIDIwMTkt MDEtMTUgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEF1ZGl0OiBjcmVhdGUgbmV3IElETCB0eXBlIGZvciBleHBvc2luZyBzcGVjaWFs IGZ1bmN0aW9uYWxpdHkgaW4gdGVzdCBjb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCmluZGV4IDlhMDE4 M2U3ZDZjYWUyZTAxNzE3MDAyMjdjMjdiZWM1NDRkZDg2OGQuLmE0N2U2MGI4OWFmNmUwZGVmNWI4 NjhhNjQ0NzkwNWY1YWIyOWVmOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC0zMjMsMTQgKzMyMywx NSBAQCBXSS5UcmVlT3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgICAgICAgICAgICAgcGFyZW50LnNlbGVjdCh0cnVlLCBmYWxzZSk7CiAgICAgICAgIH0K IAorICAgICAgICBsZXQgcmVtb3ZlZEluZGV4ZXMgPSBudWxsOworCiAgICAgICAgIGxldCB0cmVl T3V0bGluZSA9IGNoaWxkLnRyZWVPdXRsaW5lOwogICAgICAgICBpZiAodHJlZU91dGxpbmUpIHsK ICAgICAgICAgICAgIHRyZWVPdXRsaW5lLl9mb3JnZXRUcmVlRWxlbWVudChjaGlsZCk7CiAgICAg ICAgICAgICB0cmVlT3V0bGluZS5fZm9yZ2V0Q2hpbGRyZW5SZWN1cnNpdmUoY2hpbGQpOworICAg ICAgICAgICAgcmVtb3ZlZEluZGV4ZXMgPSB0cmVlT3V0bGluZS5faW5kZXhlc0ZvclN1YnRyZWUo Y2hpbGQpOwogICAgICAgICB9CiAKLSAgICAgICAgbGV0IHJlbW92ZWRJbmRleGVzID0gdGhpcy5f aW5kZXhlc0ZvclN1YnRyZWUoY2hpbGQpOwotCiAgICAgICAgIGlmIChjaGlsZC5wcmV2aW91c1Np YmxpbmcpCiAgICAgICAgICAgICBjaGlsZC5wcmV2aW91c1NpYmxpbmcubmV4dFNpYmxpbmcgPSBj aGlsZC5uZXh0U2libGluZzsKICAgICAgICAgaWYgKGNoaWxkLm5leHRTaWJsaW5nKQo=