193488 2019-01-16 05:40:12 -0800 Add more assertions to find root cause for release assert hit in StyleResolver 2019-02-06 01:11:36 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194333 InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue ggaren zalan oldest_to_newest 1495050 0 koivisto 2019-01-16 05:40:12 -0800 Improve asserts. 1495051 1 koivisto 2019-01-16 05:41:25 -0800 <rdar://problem/30983040> 1495053 2 359264 koivisto 2019-01-16 06:16:04 -0800 Created attachment 359264 patch 1495071 3 359264 commit-queue 2019-01-16 08:03:37 -0800 Comment on attachment 359264 patch Clearing flags on attachment: 359264 Committed r240037: <https://trac.webkit.org/changeset/240037> 1495072 4 commit-queue 2019-01-16 08:03:39 -0800 All reviewed patches have been landed. Closing bug. 359264 2019-01-16 06:16:04 -0800 2019-01-16 08:03:37 -0800 patch tree-style-resolve-assertion.patch text/plain 3843 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MDAzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE5LTAxLTE2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbW9yZSBhc3NlcnRpb25z IHRvIGZpbmQgcm9vdCBjYXVzZSBmb3IgcmVsZWFzZSBhc3NlcnQgaGl0IGluIFN0eWxlUmVzb2x2 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ4 OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzA5ODMwNDA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjp+U3R5bGVSZXNvbHZlcik6CisKKyAgICAg ICAgUmVsZWFzZSBhc3NlcnQgd2UgYXJlIG5vdCByZXNvbHZpbmcgdHJlZSBzdHlsZS4KKworICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0 SXNSZXNvbHZpbmdUcmVlU3R5bGUpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAg ICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmlzUmVzb2x2aW5nVHJlZVN0eWxlIGNvbnN0KToKKyAgICAg ICAgKiBzdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHls ZTo6VHJlZVJlc29sdmVyOjpTY29wZTo6U2NvcGUpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6 OlRyZWVSZXNvbHZlcjo6U2NvcGU6On5TY29wZSk6CisKKyAgICAgICAgU2V0IGlzUmVzb2x2aW5n VHJlZVN0eWxlIGJpdCB3aGVuIHdlIGhhdmUgYSB0cmVlIHJlc29sdmVyIHNjb3BlLgorCiAyMDE5 LTAxLTE2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBb RnJlZVR5cGVdIENhY2hlIHRoZSB6ZXJvLXdpZHRoIHNwYWNlIGdseXBoIGluIEdseXBoUGFnZTo6 ZmlsbCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCShyZXZpc2lvbiAy NDAwMzIpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI2Nyw2ICsyNjcsNyBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFkZEtleWZyYW1l U3R5bGUoUmVmCiAKIFN0eWxlUmVzb2x2ZXI6On5TdHlsZVJlc29sdmVyKCkKIHsKKyAgICBSRUxF QVNFX0FTU0VSVCghbV9kb2N1bWVudC5pc1Jlc29sdmluZ1RyZWVTdHlsZSgpKTsKICAgICBSRUxF QVNFX0FTU0VSVCghbV9pc0RlbGV0ZWQpOwogICAgIG1faXNEZWxldGVkID0gdHJ1ZTsKIApJbmRl eDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAyNDAwMzIpCisrKyBTb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzI2LDYgKzIzMjYsMTIg QEAgdm9pZCBEb2N1bWVudDo6ZGlkQ2xlYXJTdHlsZVJlc29sdmVyKCkKICAgICBtX3VzZXJBZ2Vu dFNoYWRvd1RyZWVTdHlsZVJlc29sdmVyID0gbnVsbHB0cjsKIH0KIAordm9pZCBEb2N1bWVudDo6 c2V0SXNSZXNvbHZpbmdUcmVlU3R5bGUoYm9vbCB2YWx1ZSkKK3sKKyAgICBSRUxFQVNFX0FTU0VS VCh2YWx1ZSAhPSBtX2lzUmVzb2x2aW5nVHJlZVN0eWxlKTsKKyAgICBtX2lzUmVzb2x2aW5nVHJl ZVN0eWxlID0gdmFsdWU7Cit9CisKIHZvaWQgRG9jdW1lbnQ6OmNyZWF0ZVJlbmRlclRyZWUoKQog ewogICAgIEFTU0VSVCghcmVuZGVyVmlldygpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCShy ZXZpc2lvbiAyNDAwMzIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTMzNCw2ICsxMzM0LDggQEAgcHVibGljOgogCiAgICAgYm9vbCBpblN0eWxl UmVjYWxjKCkgY29uc3QgeyByZXR1cm4gbV9pblN0eWxlUmVjYWxjOyB9CiAgICAgYm9vbCBpblJl bmRlclRyZWVVcGRhdGUoKSBjb25zdCB7IHJldHVybiBtX2luUmVuZGVyVHJlZVVwZGF0ZTsgfQor ICAgIGJvb2wgaXNSZXNvbHZpbmdUcmVlU3R5bGUoKSBjb25zdCB7IHJldHVybiBtX2lzUmVzb2x2 aW5nVHJlZVN0eWxlOyB9CisgICAgdm9pZCBzZXRJc1Jlc29sdmluZ1RyZWVTdHlsZShib29sKTsK IAogICAgIHZvaWQgdXBkYXRlVGV4dFJlbmRlcmVyKFRleHQmLCB1bnNpZ25lZCBvZmZzZXRPZlJl cGxhY2VkVGV4dCwgdW5zaWduZWQgbGVuZ3RoT2ZSZXBsYWNlZFRleHQpOwogCkBAIC0yMDE3LDYg KzIwMTksNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pblN0eWxlUmVjYWxjIHsgZmFsc2UgfTsK ICAgICBib29sIG1fY2xvc2VBZnRlclN0eWxlUmVjYWxjIHsgZmFsc2UgfTsKICAgICBib29sIG1f aW5SZW5kZXJUcmVlVXBkYXRlIHsgZmFsc2UgfTsKKyAgICBib29sIG1faXNSZXNvbHZpbmdUcmVl U3R5bGUgeyBmYWxzZSB9OwogCiAgICAgYm9vbCBtX2dvdG9BbmNob3JOZWVkZWRBZnRlclN0eWxl c2hlZXRzTG9hZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzRE5TUHJlZmV0Y2hFbmFibGVkIHsg ZmFsc2UgfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJlc29sdmVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5j cHAJKHJldmlzaW9uIDI0MDAzMikKKysrIFNvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJl c29sdmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjcsNiArNjcsNyBAQCBUcmVlUmVzb2x2ZXI6 OlNjb3BlOjpTY29wZShEb2N1bWVudCYgZG9jCiAgICAgOiBzdHlsZVJlc29sdmVyKGRvY3VtZW50 LnN0eWxlU2NvcGUoKS5yZXNvbHZlcigpKQogICAgICwgc2hhcmluZ1Jlc29sdmVyKGRvY3VtZW50 LCBzdHlsZVJlc29sdmVyLnJ1bGVTZXRzKCksIHNlbGVjdG9yRmlsdGVyKQogeworICAgIGRvY3Vt ZW50LnNldElzUmVzb2x2aW5nVHJlZVN0eWxlKHRydWUpOwogfQogCiBUcmVlUmVzb2x2ZXI6OlNj b3BlOjpTY29wZShTaGFkb3dSb290JiBzaGFkb3dSb290LCBTY29wZSYgZW5jbG9zaW5nU2NvcGUp CkBAIC04MCw2ICs4MSw5IEBAIFRyZWVSZXNvbHZlcjo6U2NvcGU6OlNjb3BlKFNoYWRvd1Jvb3Qm IHMKIAogVHJlZVJlc29sdmVyOjpTY29wZTo6flNjb3BlKCkKIHsKKyAgICBpZiAoIXNoYWRvd1Jv b3QpCisgICAgICAgIHN0eWxlUmVzb2x2ZXIuZG9jdW1lbnQoKS5zZXRJc1Jlc29sdmluZ1RyZWVT dHlsZShmYWxzZSk7CisKICAgICBzdHlsZVJlc29sdmVyLnNldE92ZXJyaWRlRG9jdW1lbnRFbGVt ZW50U3R5bGUobnVsbHB0cik7CiB9CiAK