193482 2019-01-15 19:21:23 -0800 [LFC] Adjust margin box verification. 2019-01-16 06:53:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1494980 0 zalan 2019-01-15 19:21:23 -0800 In certain cases, like out-of-flow boxes with margin auto, marginBoxRect() returns 0. It's clearly incorrect. 1494990 1 359248 zalan 2019-01-15 19:39:19 -0800 Created attachment 359248 Patch 1495059 2 359248 commit-queue 2019-01-16 06:53:01 -0800 Comment on attachment 359248 Patch Clearing flags on attachment: 359248 Committed r240035: <https://trac.webkit.org/changeset/240035> 1495060 3 commit-queue 2019-01-16 06:53:03 -0800 All reviewed patches have been landed. Closing bug. 359248 2019-01-15 19:39:19 -0800 2019-01-16 06:53:01 -0800 Patch bug-193482-20190115193903.patch text/plain 7045 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU0MjVjYWU1YzhhN2Iz NzZhNTM0YzcyM2YwMTJkMzdkMDM4MWRjMS4uYjNlZmRiMTkyMDkwYjk0ZGIxMzdmYjM2MGQ3Mjli YjYwM2Y3YWUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTE1ICBBbGFu IEtpbnNsZXkgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQWRqdXN0IG1hcmdp biBib3ggdmVyaWZpY2F0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzNDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gY2VydGFpbiBjYXNlcywgbGlrZSBvdXQtb2YtZmxvdyBib3hlcyB3aXRo IG1hcmdpbiBhdXRvLCBtYXJnaW5Cb3hSZWN0KCkgcmV0dXJucyAwLiBJdCdzIGNsZWFybHkgaW5j b3JyZWN0LAorICAgICAgICBzbyBsZXQncyBjaGVjayB0aGUgaW5kaXZpZHVhbCBtYXJnaW4gdmFs dWVzIGluc3RlYWQgKGFuZCBhdCB0aGlzIHBvaW50IHdlIGtub3cgdGhhdCBhbGwgb3RoZXIgYm94 ZXMgbWF0Y2gpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvYmxvY2svYmxvY2stb25seS9ub24tYXV0 by10b3AtYm90dG9tLWhlaWdodC13aXRoLWF1dG8tbWFyZ2lucy5odG1sCisKKyAgICAgICAgKiBs YXlvdXQvVmVyaWZpY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6b3V0cHV0 TWlzbWF0Y2hpbmdCbG9ja0JveEluZm9ybWF0aW9uSWZOZWVkZWQpOgorCiAyMDE5LTAxLTE1ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bT3V0LW9mLWZs b3ddIElnbm9yZSBib3R0b20gd2hlbiB0aGUgdmVydGljYWwgdmFsdWVzIGFyZSBvdmVyLWNvbnN0 cmFpbmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9WZXJpZmljYXRpb24uY3BwCmluZGV4IDY0ZjdhODRm MzQwNjY0NDY3Zjc0ZGE1YzAwNzA3NmQyNzJhNjQzYjkuLjRmMjZjNGY3ZWQzYzdjYzUzYTFiYTI0 ZTdkZDk3YjQzMTc2MDA0MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9WZXJp ZmljYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9WZXJpZmljYXRpb24uY3Bw CkBAIC0yNjUsMTEgKzI2NSw2IEBAIHN0YXRpYyBib29sIG91dHB1dE1pc21hdGNoaW5nQmxvY2tC b3hJbmZvcm1hdGlvbklmTmVlZGVkKFRleHRTdHJlYW0mIHN0cmVhbSwgY29uCiAgICAgICAgIHJl dHVybiB0cnVlOwogICAgIH0KIAotICAgIGlmIChyZW5kZXJlci5tYXJnaW5Cb3hSZWN0KCkgIT0g cmVuZGVyQm94TGlrZU1hcmdpbkJveChkaXNwbGF5Qm94KSkgewotICAgICAgICBvdXRwdXRSZWN0 KCJtYXJnaW5Cb3giLCByZW5kZXJlci5tYXJnaW5Cb3hSZWN0KCksIHJlbmRlckJveExpa2VNYXJn aW5Cb3goZGlzcGxheUJveCkpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0KICAgICBp ZiAocmVuZGVyZXIuYm9yZGVyQm94UmVjdCgpICE9IGRpc3BsYXlCb3guYm9yZGVyQm94KCkpIHsK ICAgICAgICAgb3V0cHV0UmVjdCgiYm9yZGVyQm94IiwgcmVuZGVyZXIuYm9yZGVyQm94UmVjdCgp LCBkaXNwbGF5Qm94LmJvcmRlckJveCgpKTsKICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0yODUs NiArMjgwLDIwIEBAIHN0YXRpYyBib29sIG91dHB1dE1pc21hdGNoaW5nQmxvY2tCb3hJbmZvcm1h dGlvbklmTmVlZGVkKFRleHRTdHJlYW0mIHN0cmVhbSwgY29uCiAgICAgICAgIHJldHVybiB0cnVl OwogICAgIH0KIAorICAgIGlmIChyZW5kZXJlci5tYXJnaW5Cb3hSZWN0KCkgIT0gcmVuZGVyQm94 TGlrZU1hcmdpbkJveChkaXNwbGF5Qm94KSkgeworICAgICAgICAvLyBJbiBjZXJ0YWluIGNhc2Vz LCBsaWtlIG91dC1vZi1mbG93IGJveGVzIHdpdGggbWFyZ2luIGF1dG8sIG1hcmdpbkJveFJlY3Qo KSByZXR1cm5zIDAuIEl0J3MgY2xlYXJseSBpbmNvcnJlY3QsCisgICAgICAgIC8vIHNvIGxldCdz IGNoZWNrIHRoZSBpbmRpdmlkdWFsIG1hcmdpbiB2YWx1ZXMgaW5zdGVhZCAoYW5kIGF0IHRoaXMg cG9pbnQgd2Uga25vdyB0aGF0IGFsbCBvdGhlciBib3hlcyBtYXRjaCkuCisgICAgICAgIGF1dG8g bWFyZ2luc01hdGNoID0gZGlzcGxheUJveC5tYXJnaW5CZWZvcmUoKSA9PSByZW5kZXJlci5tYXJn aW5CZWZvcmUoKQorICAgICAgICAgICAgJiYgZGlzcGxheUJveC5tYXJnaW5BZnRlcigpID09IHJl bmRlcmVyLm1hcmdpbkFmdGVyKCkKKyAgICAgICAgICAgICYmIGRpc3BsYXlCb3gubWFyZ2luU3Rh cnQoKSA9PSByZW5kZXJlci5tYXJnaW5TdGFydCgpCisgICAgICAgICAgICAmJiBkaXNwbGF5Qm94 Lm1hcmdpbkVuZCgpID09IHJlbmRlcmVyLm1hcmdpbkVuZCgpOworCisgICAgICAgIGlmICghbWFy Z2luc01hdGNoKSB7CisgICAgICAgICAgICBvdXRwdXRSZWN0KCJtYXJnaW5Cb3giLCByZW5kZXJl ci5tYXJnaW5Cb3hSZWN0KCksIHJlbmRlckJveExpa2VNYXJnaW5Cb3goZGlzcGxheUJveCkpOwor ICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKyAgICB9CisKICAgICByZXR1cm4g ZmFsc2U7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCAwNTBhZWU5OTJlOTIyZDkxOTBmNTY5ZWM4YTUwNzI0YWExYjE2MDQ2Li4yZjdlNzUz MWEyZTdlMWZkNTRjODQyZGUxZWZiOTg1M2FmMjYyZTYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMTUg IFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXSBBZGp1c3Qg bWFyZ2luIGJveCB2ZXJpZmljYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIExheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMu dHh0OgorCiAyMDE5LTAxLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bT3V0LW9mLWZsb3ddIElnbm9yZSBib3R0b20gd2hlbiB0aGUgdmVydGljYWwg dmFsdWVzIGFyZSBvdmVyLWNvbnN0cmFpbmVkCmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRSZWxv YWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3RzLnR4dCBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21p c2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CmluZGV4IDQyZDM2ZGY3OTVmODY5NTM4MzVkZTdiODA2 MTc2NjMyY2UzZGY4NjQuLjRkZTNlNDRhYjM5Yzc0NmIwZTk1NmY3ZTE1NDQxOTg5Zjc2NGZhODMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMu dHh0CisrKyBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0 CkBAIC03OSw2ICs3OSw3IEBAIGZhc3QvYmxvY2svYmxvY2stb25seS9yZWxhdGl2ZS1zaW1wbGUu aHRtbAogZmFzdC9ibG9jay9ibG9jay1vbmx5L2JveC1zaXppbmctaW5mbG93LW91dC1vZi1mbG93 LXNpbXBsZS5odG1sCiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvb3V0LW9mLWZsb3ctd2l0aC1jb250 YWluaW5nLWJsb2NrLWJvcmRlci1wYWRkaW5nLmh0bWwKIGZhc3QvYmxvY2svYmxvY2stb25seS9u b24tYXV0by10b3AtYm90dG9tLWxlZnQtcmlnaHQtd2lkaHQtaGVpZ2h0LW91dC1vZi1mbG93Lmh0 bWwKK2Zhc3QvYmxvY2svYmxvY2stb25seS9ub24tYXV0by10b3AtYm90dG9tLWhlaWdodC13aXRo LWF1dG8tbWFyZ2lucy5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwMi5odG1sCiBmYXN0L2Jsb2Nr L2Jhc2ljLzAwMy5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwNi5odG1sCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDExMDA0 YmE1ZGFlMWI3YzkzYjMzOTYyOGM0MTdjMWZiYjkwM2MyYS4uODJiMDk4YTUxNjc4MGM5M2VlOTU0 ZWVlZWY5OTcyYjYzNTczY2I4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTE1ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQWRqdXN0IG1h cmdpbiBib3ggdmVyaWZpY2F0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkzNDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRv bS1oZWlnaHQtd2l0aC1hdXRvLW1hcmdpbnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0aC1h dXRvLW1hcmdpbnMuaHRtbDogQWRkZWQuCisKIDIwMTktMDEtMTUgIFphbGFuIEJ1anRhcyAgPHph bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtPdXQtb2YtZmxvd10gSWdub3JlIGJvdHRv bSB3aGVuIHRoZSB2ZXJ0aWNhbCB2YWx1ZXMgYXJlIG92ZXItY29uc3RyYWluZWQKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxvY2stb25seS9ub24tYXV0by10b3AtYm90dG9t LWhlaWdodC13aXRoLWF1dG8tbWFyZ2lucy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0aC1hdXRvLW1h cmdpbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmRiZGE3MDIwOGIyOTkzZWMwZjkyNWQ0YmY5 OTIzMWI3ZGNiMzJkOTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2Nr L2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0aC1hdXRvLW1hcmdpbnMt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYw MAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAg ICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKK2xheWVyIGF0ICg4LDgp IHNpemUgMTEweDExMAorICBSZW5kZXJCbG9jayAocmVsYXRpdmUgcG9zaXRpb25lZCkge0RJVn0g YXQgKDAsMCkgc2l6ZSAxMTB4MTEwIFtib3JkZXI6ICg1cHggc29saWQgIzAwODAwMCldCitsYXll ciBhdCAoMTMsNTMpIHNpemUgNTB4NTAKKyAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQpIHtESVZ9 IGF0ICg1LDQ1KSBzaXplIDUweDUwIFtiZ2NvbG9yPSMwMDAwRkZdCitsYXllciBhdCAoOCwxMTgp IHNpemUgMTEweDExMAorICBSZW5kZXJCbG9jayAocmVsYXRpdmUgcG9zaXRpb25lZCkge0RJVn0g YXQgKDAsMTEwKSBzaXplIDExMHgxMTAgW2JvcmRlcjogKDVweCBzb2xpZCAjMDA4MDAwKV0KK2xh eWVyIGF0ICgxMywxMzMpIHNpemUgNTB4NTAKKyAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQpIHtE SVZ9IGF0ICg1LDE1KSBzaXplIDUweDUwIFtiZ2NvbG9yPSMwMDAwRkZdCitsYXllciBhdCAoOCwy MjgpIHNpemUgMTEweDExMAorICBSZW5kZXJCbG9jayAocmVsYXRpdmUgcG9zaXRpb25lZCkge0RJ Vn0gYXQgKDAsMjIwKSBzaXplIDExMHgxMTAgW2JvcmRlcjogKDVweCBzb2xpZCAjMDA4MDAwKV0K K2xheWVyIGF0ICgxMywyNTgpIHNpemUgNTB4NTAKKyAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQp IHtESVZ9IGF0ICg1LDMwKSBzaXplIDUweDUwIFtiZ2NvbG9yPSMwMDAwRkZdCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1o ZWlnaHQtd2l0aC1hdXRvLW1hcmdpbnMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxv Y2stb25seS9ub24tYXV0by10b3AtYm90dG9tLWhlaWdodC13aXRoLWF1dG8tbWFyZ2lucy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjYyNzJlODc1ZGViN2EwMGUwYWE3MzA4OGI1OWM4M2M2MzFiMGQ2MDgKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1 dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0aC1hdXRvLW1hcmdpbnMuaHRtbApAQCAtMCwwICsxLDIy IEBACis8c3R5bGU+CisuY29udGFpbmVyIHsKKwlib3JkZXI6IDVweCBzb2xpZCBncmVlbjsKKyAg ICBoZWlnaHQ6IDEwMHB4OworICAgIHdpZHRoOiAxMDBweDsKKyAgICBwb3NpdGlvbjogcmVsYXRp dmU7Cit9CisKK2RpdiBkaXYgeworCWJhY2tncm91bmQ6IGJsdWU7CisgICAgcG9zaXRpb246IGFi c29sdXRlOworCisgICAgaGVpZ2h0OiA1MHB4OworICAgIHdpZHRoOiA1MHB4OworCisgICAgdG9w OiAxMHB4OworICAgIGJvdHRvbTogMTBweDsKK30KKzwvc3R5bGU+Cis8ZGl2IGNsYXNzPWNvbnRh aW5lcj48ZGl2IHN0eWxlPSJtYXJnaW4tdG9wOiBhdXRvOyI+PC9kaXY+PC9kaXY+Cis8ZGl2IGNs YXNzPWNvbnRhaW5lcj48ZGl2IHN0eWxlPSJtYXJnaW4tYm90dG9tOiBhdXRvOyI+PC9kaXY+PC9k aXY+Cis8ZGl2IGNsYXNzPWNvbnRhaW5lcj48ZGl2IHN0eWxlPSJtYXJnaW4tdG9wOiBhdXRvOyBt YXJnaW4tYm90dG9tOiBhdXRvOyI+PC9kaXY+PC9kaXY+Cg==