193473 2019-01-15 17:09:26 -0800 [WebGPU] Update vertex-buffer-triangle-strip.html to actually use vertex buffer 2019-01-16 17:35:09 -0800 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_fan justin_fan commit-queue darin dino ews-watchlist graouts kondapallykalyan mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1494916 0 justin_fan 2019-01-15 17:09:26 -0800 [WebGPU] Update vertex-buffer-triangle-strip.html to actually use vertex buffer 1494925 1 359231 justin_fan 2019-01-15 17:16:43 -0800 Created attachment 359231 Patch 1494929 2 359231 darin 2019-01-15 17:20:31 -0800 Comment on attachment 359231 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359231&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:138 > + // FIXME: Setting bufferIndex to an index that DNE causes a SIGABRT when calling [MTLDevice newRenderPipelineStateWithDescriptor] > + // that is not caught by BLOCK_OBJC_EXCEPTIONS. I don’t think "DNE" is standard terminology. Writing out "does not exist" or "is out of bounds" would be clearer. But this FIXME comment is not very clear. What does the comment mean? It seems to be an interesting bit of trivia; what should we be fixing? It’s like a comment saying "// FIXME: Dereferencing a null pointer causes a SIGABRT that is not caught by BLOCK_OBJC_EXCEPTIONS." True, but how exactly is this relevant to the next line of code? Is it possible that inputSlot is an index that does not exist? If so, what can we do about it? 1494946 3 359231 simon.fraser 2019-01-15 18:02:40 -0800 Comment on attachment 359231 Patch This patch has too many FIXMEs. 1495135 4 justin_fan 2019-01-16 11:28:17 -0800 Thanks for the comments! Instead of writing in fixmes I'll create a new bug to address the issues I raised for myself. 1495174 5 webkit-bug-importer 2019-01-16 12:42:28 -0800 <rdar://problem/47326063> 1495198 6 359297 justin_fan 2019-01-16 13:33:01 -0800 Created attachment 359297 Patch 1495318 7 359297 dino 2019-01-16 16:28:55 -0800 Comment on attachment 359297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359297&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:137 > - mtlAttributeDesc.bufferIndex = attributes[i].shaderLocation; > + mtlAttributeDesc.bufferIndex = attributes[i].inputSlot; You don't mention why you made this change. The bug title only mentions the HTML. What was wrong about it? > LayoutTests/webgpu/vertex-buffer-triangle-strip.html:17 > + float4 position [[attribute(0)]]; Can you label with both attribute(0) and position to avoid having two identical structs? 1495320 8 359297 mmaxfield 2019-01-16 16:31:39 -0800 Comment on attachment 359297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359297&action=review > LayoutTests/webgpu/vertex-buffer-triangle-strip.html:32 > +fragment float4 fragment_main(VertexOut v [[stage_in]]) Does this need to take any arguments at all? 1495334 9 359336 justin_fan 2019-01-16 16:56:09 -0800 Created attachment 359336 Patch for landing 1495353 10 359336 commit-queue 2019-01-16 17:35:08 -0800 Comment on attachment 359336 Patch for landing Clearing flags on attachment: 359336 Committed r240101: <https://trac.webkit.org/changeset/240101> 1495354 11 commit-queue 2019-01-16 17:35:09 -0800 All reviewed patches have been landed. Closing bug. 359231 2019-01-15 17:16:43 -0800 2019-01-16 13:33:00 -0800 Patch bug-193473-20190115171638.patch text/plain 4316 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTAwZDMxNDVjNzA3ODk3 YjY5MmY1ODBiZTMyNjlhYjZkMTg5ZWQ0OC4uM2JiMTQwNWU3ZWJjZmFiZWI4ZGRiZmNjNzkxMDI1 NjhlZjk5NTUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQVV0gVXBkYXRl IHZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbCB0byBhY3R1YWxseSB1c2UgdmVydGV4 IGJ1ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVzdDogQ292ZXJlZCBieSB2ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0bWwuIE5vIGNo YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2Nv YS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1tOgorICAgICAgICAoV2ViQ29yZTo6c2V0SW5wdXRT dGF0ZUZvclBpcGVsaW5lRGVzY3JpcHRvcik6IFVzZSB0aGUgaW5wdXRTbG90IGluc3RlYWQgb2Yg c2hhZGVyTG9jYXRpb24gYXMgYnVmZmVySW5kZXguCisKIDIwMTktMDEtMTUgIE15bGVzIEMuIE1h eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIEltcGxlbWVu dCB0aGUgbG9vcCBjaGVja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvY29jb2EvR1BVUmVuZGVyUGlwZWxpbmVNZXRhbC5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1t CmluZGV4IDc5YWU5MjY5MTRhN2Q1ZTc0NzIwOWEwNjhiMDVjYWQ5MWE0ZTc1OTkuLmNkNzA5Zjdm ZjI0MWIxMjU0YzcxNGM0ZjU5MmE3NmEwMjYyN2FjNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5k ZXJQaXBlbGluZU1ldGFsLm1tCkBAIC0xMzQsOCArMTM0LDExIEBAIHN0YXRpYyBib29sIHNldElu cHV0U3RhdGVGb3JQaXBlbGluZURlc2NyaXB0b3IoY29uc3QgY2hhciogY29uc3QgZnVuY3Rpb25O YW1lLCBNCiAgICAgICAgIE1UTFZlcnRleEF0dHJpYnV0ZURlc2NyaXB0b3IgKm10bEF0dHJpYnV0 ZURlc2MgPSBbYXR0cmlidXRlQXJyYXkgb2JqZWN0QXRJbmRleGVkU3Vic2NyaXB0OmldOwogICAg ICAgICBtdGxBdHRyaWJ1dGVEZXNjLmZvcm1hdCA9ICptdGxGb3JtYXQ7CiAgICAgICAgIG10bEF0 dHJpYnV0ZURlc2Mub2Zmc2V0ID0gYXR0cmlidXRlc1tpXS5vZmZzZXQ7Ci0gICAgICAgIG10bEF0 dHJpYnV0ZURlc2MuYnVmZmVySW5kZXggPSBhdHRyaWJ1dGVzW2ldLnNoYWRlckxvY2F0aW9uOwor ICAgICAgICAvLyBGSVhNRTogU2V0dGluZyBidWZmZXJJbmRleCB0byBhbiBpbmRleCB0aGF0IERO RSBjYXVzZXMgYSBTSUdBQlJUIHdoZW4gY2FsbGluZyBbTVRMRGV2aWNlIG5ld1JlbmRlclBpcGVs aW5lU3RhdGVXaXRoRGVzY3JpcHRvcl0KKyAgICAgICAgLy8gdGhhdCBpcyBub3QgY2F1Z2h0IGJ5 IEJMT0NLX09CSkNfRVhDRVBUSU9OUy4KKyAgICAgICAgbXRsQXR0cmlidXRlRGVzYy5idWZmZXJJ bmRleCA9IGF0dHJpYnV0ZXNbaV0uaW5wdXRTbG90OwogICAgICAgICBbbXRsVmVydGV4RGVzY3Jp cHRvci5nZXQoKS5hdHRyaWJ1dGVzIHNldE9iamVjdDptdGxBdHRyaWJ1dGVEZXNjIGF0SW5kZXhl ZFN1YnNjcmlwdDppXTsKKyAgICAgICAgLy8gRklYTUU6IFdoYXQgaXMgR1BVVmVydGV4QXR0cmli dXRlRGVzY3JpcHRvci5zaGFkZXJMb2NhdGlvbiB1c2VkIGZvcj8KICAgICB9CiAKICAgICAvLyBQ b3B1bGF0ZSB2ZXJ0ZXggYnVmZmVyIGxheW91dHMsIGlmIGFueS4KQEAgLTE1NCw2ICsxNTcsNyBA QCBzdGF0aWMgYm9vbCBzZXRJbnB1dFN0YXRlRm9yUGlwZWxpbmVEZXNjcmlwdG9yKGNvbnN0IGNo YXIqIGNvbnN0IGZ1bmN0aW9uTmFtZSwgTQogICAgICAgICBtdGxMYXlvdXREZXNjLnN0ZXBGdW5j dGlvbiA9ICptdGxTdGVwRnVuY3Rpb247CiAgICAgICAgIG10bExheW91dERlc2Muc3RyaWRlID0g aW5wdXRzW2pdLnN0cmlkZTsKICAgICAgICAgW210bFZlcnRleERlc2NyaXB0b3IuZ2V0KCkubGF5 b3V0cyBzZXRPYmplY3Q6bXRsTGF5b3V0RGVzYyBhdEluZGV4ZWRTdWJzY3JpcHQ6al07CisgICAg ICAgIC8vIEZJWE1FOiBXaGF0IGlzIEdQVVZlcnRleElucHV0RGVzY3JpcHRvci5pbnB1dFNsb3Qg dXNlZCBmb3I/CiAgICAgfQogCiAgICAgbXRsRGVzY3JpcHRvci52ZXJ0ZXhEZXNjcmlwdG9yID0g bXRsVmVydGV4RGVzY3JpcHRvci5nZXQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYjU0ZTA2ZWY2NzIyYjBjMDYzZTBi ZWYzYmJlY2EwOTkxMjRlMDVhLi5kOWJlMmVkNjlhZTFiNjBkZmZiNmY2ODg3OGE2ODZlYWNmNTcx MGYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDEtMTUgIEp1c3RpbiBGYW4gIDxqdXN0 aW5fZmFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR1BVXSBVcGRhdGUgdmVydGV4LWJ1ZmZl ci10cmlhbmdsZS1zdHJpcC5odG1sIHRvIGFjdHVhbGx5IHVzZSB2ZXJ0ZXggYnVmZmVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM0NzMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZhY3RvciB0aGUg dmVydGV4IHNoYWRlciB0byB1c2UgdGhlIHZlcnRleCBzdGFnZSBpbnB1dCwgcmF0aGVyIHRoYW4g YnVmZmVyIHJlc291cmNlcy4gCisKKyAgICAgICAgKiB3ZWJncHUvdmVydGV4LWJ1ZmZlci10cmlh bmdsZS1zdHJpcC5odG1sOgorCiAyMDE5LTAxLTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzOTk5MywgcjIzOTk5 NSwgcjIzOTk5NywgYW5kCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJncHUvdmVydGV4LWJ1 ZmZlci10cmlhbmdsZS1zdHJpcC5odG1sIGIvTGF5b3V0VGVzdHMvd2ViZ3B1L3ZlcnRleC1idWZm ZXItdHJpYW5nbGUtc3RyaXAuaHRtbAppbmRleCBhZTk3Mzc5ZjhmN2U5MzI1YmRiMmE0YTE4MDBi MmY0YWIzOTc3NjVjLi43Yzc3MDUxNmJkZjE5ZDg3ODgxZGUyNTA4NDM1YjUxYThlYmU2ZWYzIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJncHUvdmVydGV4LWJ1ZmZlci10cmlhbmdsZS1zdHJp cC5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYmdwdS92ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0 cmlwLmh0bWwKQEAgLTEyLDE3ICsxMiwyNCBAQCBjb25zdCBzaGFkZXJDb2RlID0gYAogICAgIAog dXNpbmcgbmFtZXNwYWNlIG1ldGFsOwogCi1zdHJ1Y3QgVmVydGV4CitzdHJ1Y3QgVmVydGV4SW4K K3sKKyAgICBmbG9hdDQgcG9zaXRpb24gW1thdHRyaWJ1dGUoMCldXTsKK307CisKK3N0cnVjdCBW ZXJ0ZXhPdXQKIHsKICAgICBmbG9hdDQgcG9zaXRpb24gW1twb3NpdGlvbl1dOwogfTsKIAotdmVy dGV4IFZlcnRleCB2ZXJ0ZXhfbWFpbihjb25zdCBkZXZpY2UgVmVydGV4KiB2ZXJ0ZXhfYXJyYXkg W1tidWZmZXIoMCldXSwgdWludCB2aWQgW1t2ZXJ0ZXhfaWRdXSkKK3ZlcnRleCBWZXJ0ZXhPdXQg dmVydGV4X21haW4oVmVydGV4SW4gdmVydGV4SW4gW1tzdGFnZV9pbl1dKQogewotICAgIHJldHVy biB2ZXJ0ZXhfYXJyYXlbdmlkXTsKKyAgICBWZXJ0ZXhPdXQgdk91dDsKKyAgICB2T3V0LnBvc2l0 aW9uID0gdmVydGV4SW4ucG9zaXRpb247CisgICAgcmV0dXJuIHZPdXQ7CiB9CiAKLWZyYWdtZW50 IGZsb2F0NCBmcmFnbWVudF9tYWluKFZlcnRleCB2ZXJ0ZXhJbiBbW3N0YWdlX2luXV0pCitmcmFn bWVudCBmbG9hdDQgZnJhZ21lbnRfbWFpbihWZXJ0ZXhPdXQgdiBbW3N0YWdlX2luXV0pCiB7CiAg ICAgcmV0dXJuIGZsb2F0NCgwLjAsIDEuMCwgMC4wLCAxLjApOwogfQo= 359297 2019-01-16 13:33:01 -0800 2019-01-16 16:56:06 -0800 Patch bug-193473-20190116133259.patch text/plain 3546 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTAwZDMxNDVjNzA3ODk3 YjY5MmY1ODBiZTMyNjlhYjZkMTg5ZWQ0OC4uM2JiMTQwNWU3ZWJjZmFiZWI4ZGRiZmNjNzkxMDI1 NjhlZjk5NTUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQVV0gVXBkYXRl IHZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbCB0byBhY3R1YWxseSB1c2UgdmVydGV4 IGJ1ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGVzdDogQ292ZXJlZCBieSB2ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0bWwuIE5vIGNo YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2Nv YS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1tOgorICAgICAgICAoV2ViQ29yZTo6c2V0SW5wdXRT dGF0ZUZvclBpcGVsaW5lRGVzY3JpcHRvcik6IFVzZSB0aGUgaW5wdXRTbG90IGluc3RlYWQgb2Yg c2hhZGVyTG9jYXRpb24gYXMgYnVmZmVySW5kZXguCisKIDIwMTktMDEtMTUgIE15bGVzIEMuIE1h eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIEltcGxlbWVu dCB0aGUgbG9vcCBjaGVja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvY29jb2EvR1BVUmVuZGVyUGlwZWxpbmVNZXRhbC5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1t CmluZGV4IDc5YWU5MjY5MTRhN2Q1ZTc0NzIwOWEwNjhiMDVjYWQ5MWE0ZTc1OTkuLjgyMzJiOTY3 Zjc1M2U4MjY0M2Y1ZGJiZWQ4OTQ2NTIyOWY4OGUzZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVSZW5k ZXJQaXBlbGluZU1ldGFsLm1tCkBAIC0xMzQsNyArMTM0LDcgQEAgc3RhdGljIGJvb2wgc2V0SW5w dXRTdGF0ZUZvclBpcGVsaW5lRGVzY3JpcHRvcihjb25zdCBjaGFyKiBjb25zdCBmdW5jdGlvbk5h bWUsIE0KICAgICAgICAgTVRMVmVydGV4QXR0cmlidXRlRGVzY3JpcHRvciAqbXRsQXR0cmlidXRl RGVzYyA9IFthdHRyaWJ1dGVBcnJheSBvYmplY3RBdEluZGV4ZWRTdWJzY3JpcHQ6aV07CiAgICAg ICAgIG10bEF0dHJpYnV0ZURlc2MuZm9ybWF0ID0gKm10bEZvcm1hdDsKICAgICAgICAgbXRsQXR0 cmlidXRlRGVzYy5vZmZzZXQgPSBhdHRyaWJ1dGVzW2ldLm9mZnNldDsKLSAgICAgICAgbXRsQXR0 cmlidXRlRGVzYy5idWZmZXJJbmRleCA9IGF0dHJpYnV0ZXNbaV0uc2hhZGVyTG9jYXRpb247Cisg ICAgICAgIG10bEF0dHJpYnV0ZURlc2MuYnVmZmVySW5kZXggPSBhdHRyaWJ1dGVzW2ldLmlucHV0 U2xvdDsKICAgICAgICAgW210bFZlcnRleERlc2NyaXB0b3IuZ2V0KCkuYXR0cmlidXRlcyBzZXRP YmplY3Q6bXRsQXR0cmlidXRlRGVzYyBhdEluZGV4ZWRTdWJzY3JpcHQ6aV07CiAgICAgfQogCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggZmI1NGUwNmVmNjcyMmIwYzA2M2UwYmVmM2JiZWNhMDk5MTI0ZTA1YS4uZDliZTJlZDY5 YWUxYjYwZGZmYjZmNjg4NzhhNjg2ZWFjZjU3MTBmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDE5LTAxLTE1ICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAg W1dlYkdQVV0gVXBkYXRlIHZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbCB0byBhY3R1 YWxseSB1c2UgdmVydGV4IGJ1ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVmYWN0b3IgdGhlIHZlcnRleCBzaGFkZXIgdG8gdXNlIHRoZSB2ZXJ0 ZXggc3RhZ2UgaW5wdXQsIHJhdGhlciB0aGFuIGJ1ZmZlciByZXNvdXJjZXMuIAorCisgICAgICAg ICogd2ViZ3B1L3ZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbDoKKwogMjAxOS0wMS0x NSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIyMzk5OTMsIHIyMzk5OTUsIHIyMzk5OTcsIGFuZApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvd2ViZ3B1L3ZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbCBiL0xh eW91dFRlc3RzL3dlYmdwdS92ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0bWwKaW5kZXgg YWU5NzM3OWY4ZjdlOTMyNWJkYjJhNGExODAwYjJmNGFiMzk3NzY1Yy4uN2M3NzA1MTZiZGYxOWQ4 Nzg4MWRlMjUwODQzNWI1MWE4ZWJlNmVmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViZ3B1 L3ZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJn cHUvdmVydGV4LWJ1ZmZlci10cmlhbmdsZS1zdHJpcC5odG1sCkBAIC0xMiwxNyArMTIsMjQgQEAg Y29uc3Qgc2hhZGVyQ29kZSA9IGAKICAgICAKIHVzaW5nIG5hbWVzcGFjZSBtZXRhbDsKIAotc3Ry dWN0IFZlcnRleAorc3RydWN0IFZlcnRleEluCit7CisgICAgZmxvYXQ0IHBvc2l0aW9uIFtbYXR0 cmlidXRlKDApXV07Cit9OworCitzdHJ1Y3QgVmVydGV4T3V0CiB7CiAgICAgZmxvYXQ0IHBvc2l0 aW9uIFtbcG9zaXRpb25dXTsKIH07CiAKLXZlcnRleCBWZXJ0ZXggdmVydGV4X21haW4oY29uc3Qg ZGV2aWNlIFZlcnRleCogdmVydGV4X2FycmF5IFtbYnVmZmVyKDApXV0sIHVpbnQgdmlkIFtbdmVy dGV4X2lkXV0pCit2ZXJ0ZXggVmVydGV4T3V0IHZlcnRleF9tYWluKFZlcnRleEluIHZlcnRleElu IFtbc3RhZ2VfaW5dXSkKIHsKLSAgICByZXR1cm4gdmVydGV4X2FycmF5W3ZpZF07CisgICAgVmVy dGV4T3V0IHZPdXQ7CisgICAgdk91dC5wb3NpdGlvbiA9IHZlcnRleEluLnBvc2l0aW9uOworICAg IHJldHVybiB2T3V0OwogfQogCi1mcmFnbWVudCBmbG9hdDQgZnJhZ21lbnRfbWFpbihWZXJ0ZXgg dmVydGV4SW4gW1tzdGFnZV9pbl1dKQorZnJhZ21lbnQgZmxvYXQ0IGZyYWdtZW50X21haW4oVmVy dGV4T3V0IHYgW1tzdGFnZV9pbl1dKQogewogICAgIHJldHVybiBmbG9hdDQoMC4wLCAxLjAsIDAu MCwgMS4wKTsKIH0K 359336 2019-01-16 16:56:09 -0800 2019-01-16 17:35:08 -0800 Patch for landing bug-193473-20190116165608.patch text/plain 3757 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTAwZDMxNDVjNzA3ODk3 YjY5MmY1ODBiZTMyNjlhYjZkMTg5ZWQ0OC4uNDU1MjVhYzg2MGE3NTllYzI5MmM4OTJkZDBmYmM1 ZGUyZTIxY2VmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQVV0gVXBkYXRl IHZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbCB0byBhY3R1YWxseSB1c2UgdmVydGV4 IGJ1ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTkzNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGVhbiBKYWNrc29uIGFuZCBNeWxlcyBNYXhm aWVsZC4KKworICAgICAgICBBbHNvLCBzd2l0Y2ggdG8gdXNpbmcgdGhlIGlucHV0U2xvdCBpbnN0 ZWFkIG9mIHRoZSBzaGFkZXJMb2NhdGlvbiBmaWVsZCwgYXMgdGhpcyBzZWVtcyBtb3JlIGNvcnJl Y3QuIAorICAgICAgICBBcyBvZiBub3cgSSBjYW5ub3QgZGV0ZXJtaW5lIGFuIGFuYWxvZyBmb3Ig V2ViR1BVJ3Mgc2hhZGVyTG9jYXRpb24gaW4gTWV0YWwuIAorCisgICAgICAgIFRlc3Q6IENvdmVy ZWQgYnkgdmVydGV4LWJ1ZmZlci10cmlhbmdsZS1zdHJpcC5odG1sLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BVUmVuZGVy UGlwZWxpbmVNZXRhbC5tbToKKyAgICAgICAgKFdlYkNvcmU6OnNldElucHV0U3RhdGVGb3JQaXBl bGluZURlc2NyaXB0b3IpOiBVc2UgdGhlIGlucHV0U2xvdCBpbnN0ZWFkIG9mIHNoYWRlckxvY2F0 aW9uIGFzIGJ1ZmZlckluZGV4LiAKKwogMjAxOS0wMS0xNSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxt bWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSExTTF0gSW1wbGVtZW50IHRoZSBsb29w IGNoZWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dw dS9jb2NvYS9HUFVSZW5kZXJQaXBlbGluZU1ldGFsLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3B1L2NvY29hL0dQVVJlbmRlclBpcGVsaW5lTWV0YWwubW0KaW5kZXggNzlh ZTkyNjkxNGE3ZDVlNzQ3MjA5YTA2OGIwNWNhZDkxYTRlNzU5OS4uODIzMmI5NjdmNzUzZTgyNjQz ZjVkYmJlZDg5NDY1MjI5Zjg4ZTNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3B1L2NvY29hL0dQVVJlbmRlclBpcGVsaW5lTWV0YWwubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L2NvY29hL0dQVVJlbmRlclBpcGVsaW5l TWV0YWwubW0KQEAgLTEzNCw3ICsxMzQsNyBAQCBzdGF0aWMgYm9vbCBzZXRJbnB1dFN0YXRlRm9y UGlwZWxpbmVEZXNjcmlwdG9yKGNvbnN0IGNoYXIqIGNvbnN0IGZ1bmN0aW9uTmFtZSwgTQogICAg ICAgICBNVExWZXJ0ZXhBdHRyaWJ1dGVEZXNjcmlwdG9yICptdGxBdHRyaWJ1dGVEZXNjID0gW2F0 dHJpYnV0ZUFycmF5IG9iamVjdEF0SW5kZXhlZFN1YnNjcmlwdDppXTsKICAgICAgICAgbXRsQXR0 cmlidXRlRGVzYy5mb3JtYXQgPSAqbXRsRm9ybWF0OwogICAgICAgICBtdGxBdHRyaWJ1dGVEZXNj Lm9mZnNldCA9IGF0dHJpYnV0ZXNbaV0ub2Zmc2V0OwotICAgICAgICBtdGxBdHRyaWJ1dGVEZXNj LmJ1ZmZlckluZGV4ID0gYXR0cmlidXRlc1tpXS5zaGFkZXJMb2NhdGlvbjsKKyAgICAgICAgbXRs QXR0cmlidXRlRGVzYy5idWZmZXJJbmRleCA9IGF0dHJpYnV0ZXNbaV0uaW5wdXRTbG90OwogICAg ICAgICBbbXRsVmVydGV4RGVzY3JpcHRvci5nZXQoKS5hdHRyaWJ1dGVzIHNldE9iamVjdDptdGxB dHRyaWJ1dGVEZXNjIGF0SW5kZXhlZFN1YnNjcmlwdDppXTsKICAgICB9CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYjU0 ZTA2ZWY2NzIyYjBjMDYzZTBiZWYzYmJlY2EwOTkxMjRlMDVhLi5iZDQ3YzYxZDBiMjI0ZDdhODA3 MjczMGI1MTM4NjM3MDM0ZjExZDhlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDEtMTUg IEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR1BVXSBV cGRhdGUgdmVydGV4LWJ1ZmZlci10cmlhbmdsZS1zdHJpcC5odG1sIHRvIGFjdHVhbGx5IHVzZSB2 ZXJ0ZXggYnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTM0NzMKKworICAgICAgICBSZXZpZXdlZCBieSBEZWFuIEphY2tzb24gYW5kIE15bGVz IE1heGZpZWxkLgorCisgICAgICAgIFJlZmFjdG9yIHRoZSB2ZXJ0ZXggc2hhZGVyIHRvIHVzZSB0 aGUgdmVydGV4IHN0YWdlIGlucHV0LCByYXRoZXIgdGhhbiBidWZmZXIgcmVzb3VyY2VzLiAKKwor ICAgICAgICAqIHdlYmdwdS92ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0bWw6CisKIDIw MTktMDEtMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjM5OTkzLCByMjM5OTk1LCByMjM5OTk3LCBhbmQKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3dlYmdwdS92ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0 bWwgYi9MYXlvdXRUZXN0cy93ZWJncHUvdmVydGV4LWJ1ZmZlci10cmlhbmdsZS1zdHJpcC5odG1s CmluZGV4IGFlOTczNzlmOGY3ZTkzMjViZGIyYTRhMTgwMGIyZjRhYjM5Nzc2NWMuLjYxMWZlZTRh MjE1NDIyYmQ4NzFmYmQwMTlkNzg1NjRmZmEzYjY4NzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3dlYmdwdS92ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlwLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvd2ViZ3B1L3ZlcnRleC1idWZmZXItdHJpYW5nbGUtc3RyaXAuaHRtbApAQCAtMTIsMTcgKzEy LDI0IEBAIGNvbnN0IHNoYWRlckNvZGUgPSBgCiAgICAgCiB1c2luZyBuYW1lc3BhY2UgbWV0YWw7 CiAKLXN0cnVjdCBWZXJ0ZXgKK3N0cnVjdCBWZXJ0ZXhJbgoreworICAgIGZsb2F0NCBwb3NpdGlv biBbW2F0dHJpYnV0ZSgwKV1dOworfTsKKworc3RydWN0IFZlcnRleE91dAogewogICAgIGZsb2F0 NCBwb3NpdGlvbiBbW3Bvc2l0aW9uXV07CiB9OwogCi12ZXJ0ZXggVmVydGV4IHZlcnRleF9tYWlu KGNvbnN0IGRldmljZSBWZXJ0ZXgqIHZlcnRleF9hcnJheSBbW2J1ZmZlcigwKV1dLCB1aW50IHZp ZCBbW3ZlcnRleF9pZF1dKQordmVydGV4IFZlcnRleE91dCB2ZXJ0ZXhfbWFpbihWZXJ0ZXhJbiB2 ZXJ0ZXhJbiBbW3N0YWdlX2luXV0pCiB7Ci0gICAgcmV0dXJuIHZlcnRleF9hcnJheVt2aWRdOwor ICAgIFZlcnRleE91dCB2T3V0OworICAgIHZPdXQucG9zaXRpb24gPSB2ZXJ0ZXhJbi5wb3NpdGlv bjsKKyAgICByZXR1cm4gdk91dDsKIH0KIAotZnJhZ21lbnQgZmxvYXQ0IGZyYWdtZW50X21haW4o VmVydGV4IHZlcnRleEluIFtbc3RhZ2VfaW5dXSkKK2ZyYWdtZW50IGZsb2F0NCBmcmFnbWVudF9t YWluKCkKIHsKICAgICByZXR1cm4gZmxvYXQ0KDAuMCwgMS4wLCAwLjAsIDEuMCk7CiB9Cg==