193470 2019-01-15 16:05:05 -0800 [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto. 2019-01-16 07:24:42 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1494876 0 zalan 2019-01-15 16:05:05 -0800 Missed the case when both computed values are non-auto. 1494881 1 359217 zalan 2019-01-15 16:15:36 -0800 Created attachment 359217 Patch 1495066 2 359217 commit-queue 2019-01-16 07:03:19 -0800 Comment on attachment 359217 Patch Rejecting attachment 359217 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 359217, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=359217&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=193470&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 359217 from bug 193470. Fetching: https://bugs.webkit.org/attachment.cgi?id=359217 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 7 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/layout/FormattingContextGeometry.cpp patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/LayoutReloaded/misc/LFC-passing-tests.txt Hunk #1 FAILED at 79. 1 out of 1 hunk FAILED -- saving rejects to file Tools/LayoutReloaded/misc/LFC-passing-tests.txt.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/block/block-only/non-auto-top-bottom-height-with-margins-expected.txt patching file LayoutTests/fast/block/block-only/non-auto-top-bottom-height-with-margins.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10771932 1495068 3 zalan 2019-01-16 07:23:33 -0800 Committed r240036: <https://trac.webkit.org/changeset/240036> 1495069 4 webkit-bug-importer 2019-01-16 07:24:42 -0800 <rdar://problem/47316008> 359217 2019-01-15 16:15:36 -0800 2019-01-16 07:03:19 -0800 Patch bug-193470-20190115161521.patch text/plain 6446 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU0MjVjYWU1YzhhN2Iz NzZhNTM0YzcyM2YwMTJkMzdkMDM4MWRjMS4uYjIwOTBhMDAxYzZhNDI2ZjFiNmY2OTE5MGVmZGM0 OGZlYTRjZmY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bT3V0LW9mLWZsb3dd IFNldCB1c2VkIHZlcnRpY2FsIG1hcmdpbiB2YWx1ZXMgd2hlbiB0b3AvaGVpZ2h0L2JvdHRvbSBh cmUgbm9uLWF1dG8uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTM0NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOb24tYXV0byB2ZXJ0aWNhbCBtYXJnaW4gdmFsdWVzICh3aGljaCBpcyBtb3N0bHkgdGhl IGNhc2UpIHNob3VsZCBiZSBzZXQgYXMgdXNlZCB2YWx1ZXMuCisKKyAgICAgICAgVGVzdDogZmFz dC9ibG9jay9ibG9jay1vbmx5L25vbi1hdXRvLXRvcC1ib3R0b20taGVpZ2h0LXdpdGgtbWFyZ2lu cy5odG1sCisKKyAgICAgICAgKiBsYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6 b3V0T2ZGbG93Tm9uUmVwbGFjZWRWZXJ0aWNhbEdlb21ldHJ5KToKKwogMjAxOS0wMS0xNSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW091dC1vZi1mbG93 XSBJZ25vcmUgYm90dG9tIHdoZW4gdGhlIHZlcnRpY2FsIHZhbHVlcyBhcmUgb3Zlci1jb25zdHJh aW5lZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0 R2VvbWV0cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2Vv bWV0cnkuY3BwCmluZGV4IGY1ZmVjMDQ0YjJmMzQwYjJkYTExMDQ4ZDNhNzg1ZTU5YTUyMDFiYTYu LjZjMzEwMmNlODljOWYyY2M3NzFlMjFiNGM1OTViOTJmNWI3OTg1OWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKQEAgLTMw NCw3ICszMDQsOCBAQCBWZXJ0aWNhbEdlb21ldHJ5IEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRy eTo6b3V0T2ZGbG93Tm9uUmVwbGFjZWRWZXJ0aWNhbEdlb21ldAogICAgICAgICB9IGVsc2UgaWYg KCFjb21wdXRlZFZlcnRpY2FsTWFyZ2luLmFmdGVyKSB7CiAgICAgICAgICAgICB1c2VkVmVydGlj YWxNYXJnaW4uYmVmb3JlID0gKmNvbXB1dGVkVmVydGljYWxNYXJnaW4uYmVmb3JlOwogICAgICAg ICAgICAgdXNlZFZlcnRpY2FsTWFyZ2luLmFmdGVyID0gY29udGFpbmluZ0Jsb2NrSGVpZ2h0IC0g KCp0b3AgKyB1c2VkVmVydGljYWxNYXJnaW4uYmVmb3JlICsgYm9yZGVyVG9wICsgcGFkZGluZ1Rv cCArIGNvbnRlbnRIZWlnaHQoKSArIHBhZGRpbmdCb3R0b20gKyBib3JkZXJCb3R0b20gKyAqYm90 dG9tKTsKLSAgICAgICAgfQorICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHVzZWRWZXJ0aWNh bE1hcmdpbiA9IHsgKmNvbXB1dGVkVmVydGljYWxNYXJnaW4uYmVmb3JlLCAqY29tcHV0ZWRWZXJ0 aWNhbE1hcmdpbi5hZnRlciB9OwogICAgICAgICAvLyBPdmVyLWNvbnN0cmFpbmVkPwogICAgICAg ICBhdXRvIGJveEhlaWdodCA9ICp0b3AgKyB1c2VkVmVydGljYWxNYXJnaW4uYmVmb3JlICsgYm9y ZGVyVG9wICsgcGFkZGluZ1RvcCArIGNvbnRlbnRIZWlnaHQoKSArIHBhZGRpbmdCb3R0b20gKyBi b3JkZXJCb3R0b20gKyB1c2VkVmVydGljYWxNYXJnaW4uYWZ0ZXIgKyAqYm90dG9tOwogICAgICAg ICBpZiAoYm94SGVpZ2h0ICE9IGNvbnRhaW5pbmdCbG9ja0hlaWdodCkKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNTBhZWU5OTJlOTIyZDkxOTBm NTY5ZWM4YTUwNzI0YWExYjE2MDQ2Li4wY2EwMDlkODIxNzFjZWFjMmQ2ZWUxNTVkMWU3OTY1ODYw NGNhNDI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KKworICAgICAgICBbTEZDXVtPdXQtb2YtZmxvd10gU2V0IHVzZWQgdmVydGljYWwgbWFy Z2luIHZhbHVlcyB3aGVuIHRvcC9oZWlnaHQvYm90dG9tIGFyZSBub24tYXV0by4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ3MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTGF5b3V0UmVsb2FkZWQv bWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQ6CisKIDIwMTktMDEtMTUgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtPdXQtb2YtZmxvd10gSWdub3JlIGJv dHRvbSB3aGVuIHRoZSB2ZXJ0aWNhbCB2YWx1ZXMgYXJlIG92ZXItY29uc3RyYWluZWQKZGlmZiAt LWdpdCBhL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0IGIv VG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKaW5kZXggNDJk MzZkZjc5NWY4Njk1MzgzNWRlN2I4MDYxNzY2MzJjZTNkZjg2NC4uMmUxNzQ2MGYwMjQwNjBjMTll NjUyMzFiOGUyZWRiYzIxYmZhYmMyZiAxMDA2NDQKLS0tIGEvVG9vbHMvTGF5b3V0UmVsb2FkZWQv bWlzYy9MRkMtcGFzc2luZy10ZXN0cy50eHQKKysrIGIvVG9vbHMvTGF5b3V0UmVsb2FkZWQvbWlz Yy9MRkMtcGFzc2luZy10ZXN0cy50eHQKQEAgLTc5LDYgKzc5LDcgQEAgZmFzdC9ibG9jay9ibG9j ay1vbmx5L3JlbGF0aXZlLXNpbXBsZS5odG1sCiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvYm94LXNp emluZy1pbmZsb3ctb3V0LW9mLWZsb3ctc2ltcGxlLmh0bWwKIGZhc3QvYmxvY2svYmxvY2stb25s eS9vdXQtb2YtZmxvdy13aXRoLWNvbnRhaW5pbmctYmxvY2stYm9yZGVyLXBhZGRpbmcuaHRtbAog ZmFzdC9ibG9jay9ibG9jay1vbmx5L25vbi1hdXRvLXRvcC1ib3R0b20tbGVmdC1yaWdodC13aWRo dC1oZWlnaHQtb3V0LW9mLWZsb3cuaHRtbAorZmFzdC9ibG9jay9ibG9jay1vbmx5L25vbi1hdXRv LXRvcC1ib3R0b20taGVpZ2h0LXdpdGgtbWFyZ2lucy5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAw Mi5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwMy5odG1sCiBmYXN0L2Jsb2NrL2Jhc2ljLzAwNi5o dG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggNDExMDA0YmE1ZGFlMWI3YzkzYjMzOTYyOGM0MTdjMWZiYjkwM2MyYS4uMmVh NGRiZjFhNDAwNDFlYmNhNjUzNjE4OGRmNmYwMDI1ZGRkMDRjMSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTAxLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgW0xGQ11bT3V0LW9mLWZsb3ddIFNldCB1c2VkIHZlcnRpY2FsIG1hcmdpbiB2YWx1ZXMgd2hl biB0b3AvaGVpZ2h0L2JvdHRvbSBhcmUgbm9uLWF1dG8uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM0NzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvYmxvY2svYmxvY2stb25seS9ub24tYXV0 by10b3AtYm90dG9tLWhlaWdodC13aXRoLW1hcmdpbnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQt d2l0aC1tYXJnaW5zLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAxLTE1ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bT3V0LW9mLWZsb3ddIElnbm9yZSBib3R0 b20gd2hlbiB0aGUgdmVydGljYWwgdmFsdWVzIGFyZSBvdmVyLWNvbnN0cmFpbmVkCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRv bS1oZWlnaHQtd2l0aC1tYXJnaW5zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmxv Y2svYmxvY2stb25seS9ub24tYXV0by10b3AtYm90dG9tLWhlaWdodC13aXRoLW1hcmdpbnMtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjliNzQ3Mjg0NTQ0ZThjY2E5ZDVlMDg4ODY1Yjg2MTU3ZTNm ZGFkMDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9u bHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0aC1tYXJnaW5zLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDE3IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmll dyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBS ZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7 Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTg0CitsYXllciBhdCAoOCw4KSBzaXplIDExMHgxMTAK KyAgUmVuZGVyQmxvY2sgKHJlbGF0aXZlIHBvc2l0aW9uZWQpIHtESVZ9IGF0ICgwLDApIHNpemUg MTEweDExMCBbYm9yZGVyOiAoNXB4IHNvbGlkICMwMDgwMDApXQorbGF5ZXIgYXQgKDEzLDMzKSBz aXplIDUweDUwCisgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoNSwyNSkgc2l6 ZSA1MHg1MCBbYmdjb2xvcj0jMDAwMEZGXQorbGF5ZXIgYXQgKDgsMTE4KSBzaXplIDExMHgxMTAK KyAgUmVuZGVyQmxvY2sgKHJlbGF0aXZlIHBvc2l0aW9uZWQpIHtESVZ9IGF0ICgwLDExMCkgc2l6 ZSAxMTB4MTEwIFtib3JkZXI6ICg1cHggc29saWQgIzAwODAwMCldCitsYXllciBhdCAoMTMsMTMz KSBzaXplIDUweDUwCisgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoNSwxNSkg c2l6ZSA1MHg1MCBbYmdjb2xvcj0jMDAwMEZGXQorbGF5ZXIgYXQgKDgsMjI4KSBzaXplIDExMHgx MTAKKyAgUmVuZGVyQmxvY2sgKHJlbGF0aXZlIHBvc2l0aW9uZWQpIHtESVZ9IGF0ICgwLDIyMCkg c2l6ZSAxMTB4MTEwIFtib3JkZXI6ICg1cHggc29saWQgIzAwODAwMCldCitsYXllciBhdCAoMTMs MjUzKSBzaXplIDUweDUwCisgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoNSwy NSkgc2l6ZSA1MHg1MCBbYmdjb2xvcj0jMDAwMEZGXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ibG9jay9ibG9jay1vbmx5L25vbi1hdXRvLXRvcC1ib3R0b20taGVpZ2h0LXdpdGgtbWFy Z2lucy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9ibG9jay1vbmx5L25vbi1hdXRvLXRv cC1ib3R0b20taGVpZ2h0LXdpdGgtbWFyZ2lucy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFmMjVhYjI1YzQ3 ZmVhZWNiYjQzNmI0ZGJkNTBiZWExNjE4MzJhODkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvbm9uLWF1dG8tdG9wLWJvdHRvbS1oZWlnaHQtd2l0 aC1tYXJnaW5zLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPHN0eWxlPgorLmNvbnRhaW5lciB7CisJ Ym9yZGVyOiA1cHggc29saWQgZ3JlZW47CisgICAgaGVpZ2h0OiAxMDBweDsKKyAgICB3aWR0aDog MTAwcHg7CisgICAgcG9zaXRpb246IHJlbGF0aXZlOworfQorCitkaXYgZGl2IHsKKwliYWNrZ3Jv dW5kOiBibHVlOworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKworICAgIGhlaWdodDogNTBweDsK KyAgICB3aWR0aDogNTBweDsKKworICAgIHRvcDogMTBweDsKKyAgICBib3R0b206IDEwcHg7Cit9 Cis8L3N0eWxlPgorPGRpdiBjbGFzcz1jb250YWluZXI+PGRpdiBzdHlsZT0ibWFyZ2luLXRvcDog MTBweDsiPjwvZGl2PjwvZGl2PgorPGRpdiBjbGFzcz1jb250YWluZXI+PGRpdiBzdHlsZT0ibWFy Z2luLWJvdHRvbTogMTBweDsiPjwvZGl2PjwvZGl2PgorPGRpdiBjbGFzcz1jb250YWluZXI+PGRp diBzdHlsZT0ibWFyZ2luLXRvcDogMTBweDsgbWFyZ2luLWJvdHRvbTogMTBweDsiPjwvZGl2Pjwv ZGl2Pgo=