193468 2019-01-15 15:12:11 -0800 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() 2019-01-16 12:35:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin commit-queue webkit-bug-importer zalan oldest_to_newest 1494844 0 thorton 2019-01-15 15:12:11 -0800 Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() 1494848 1 359211 thorton 2019-01-15 15:15:18 -0800 Created attachment 359211 Patch 1494849 2 thorton 2019-01-15 15:15:21 -0800 <rdar://problem/38645869> 1494870 3 359211 commit-queue 2019-01-15 15:55:43 -0800 Comment on attachment 359211 Patch Clearing flags on attachment: 359211 Committed r240016: <https://trac.webkit.org/changeset/240016> 1494871 4 commit-queue 2019-01-15 15:55:44 -0800 All reviewed patches have been landed. Closing bug. 1495132 5 thorton 2019-01-16 11:27:48 -0800 Reopening to attach new patch. 1495133 6 359284 thorton 2019-01-16 11:27:49 -0800 Created attachment 359284 Patch 1495140 7 359284 zalan 2019-01-16 11:41:27 -0800 Comment on attachment 359284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359284&action=review > Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:375 > + IntSize documentSize = renderView->unscaledDocumentRect().size(); It's probably not the case but this second layoutIfNeeded() could potentially nuke the frame as well. 1495144 8 359286 thorton 2019-01-16 11:53:50 -0800 Created attachment 359286 Patch 1495165 9 359286 commit-queue 2019-01-16 12:35:16 -0800 Comment on attachment 359286 Patch Clearing flags on attachment: 359286 Committed r240045: <https://trac.webkit.org/changeset/240045> 1495166 10 commit-queue 2019-01-16 12:35:18 -0800 All reviewed patches have been landed. Closing bug. 359211 2019-01-15 15:15:18 -0800 2019-01-16 11:27:47 -0800 Patch bug-193468-20190115151518.patch text/plain 1788 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkNDY4NjEzODc1Zjk3ZDMz MWM0MDc1OWU2NzQ3NWY5YzgwMWNjM2QuLjAwYjVkZDc5OGM3Y2E1MDM5NzY1NjA1NDVmYjg4MGJh OTUwZjdjMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMTUgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRnJlcXVlbnQgbnVsbC1k ZXJlZiB1bmRlciBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXRE b2N1bWVudElmTmVlZGVkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MzQ2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzg2NDU4Njk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAo V2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXREb2N1 bWVudElmTmVlZGVkKToKKyAgICAgICAgSSdtIG5vdCBzdXJlIHdoeSB0aGlzIGdvdCAqd29yc2Uq LCBidXQgd2Ugc2hvdWxkIG51bGwtY2hlY2sgUmVuZGVyVmlldy4KKyAgICAgICAgSXQncyBPSyB0 byBiYWlsIGZyb20gc2NhbGVWaWV3VG9GaXREb2N1bWVudElmTmVlZGVkLCB3ZSdsbCByZS1kbyBp dAorICAgICAgICB0aGUgbmV4dCB0aW1lIHdlIHBhaW50ICh3aGljaCB3aWxsIHN1cmVseSBoYXBw ZW4gaWYgd2UgZ2FpbiBhIFJlbmRlclZpZXcpLgorCiAyMDE5LTAxLTE1ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGlPUyBidWlsZCBh ZnRlciByMjM5OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0gYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KaW5k ZXggODNiNjU5OTI3MGI1MWM3YmIxOGVmZTczN2E1OTJlMDI1NzFhMjgwNi4uMDgzZTk2Y2M4OTBi ZmYwMjcwM2VmNTEwOGY5ZjBiODcyNmJjOTVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRp b25EcmF3aW5nQXJlYS5tbQpAQCAtMzEyLDYgKzMxMiw5IEBAIHZvaWQgVGlsZWRDb3JlQW5pbWF0 aW9uRHJhd2luZ0FyZWE6OnNjYWxlVmlld1RvRml0RG9jdW1lbnRJZk5lZWRlZCgpCiAgICAgaWYg KCFtX3Nob3VsZFNjYWxlVmlld1RvRml0RG9jdW1lbnQpCiAgICAgICAgIHJldHVybjsKIAorICAg IGlmICghbV93ZWJQYWdlLm1haW5GcmFtZVZpZXcoKS0+cmVuZGVyVmlldygpKQorICAgICAgICBy ZXR1cm47CisKICAgICBMT0coUmVzaXplLCAiVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEg JXAgc2NhbGVWaWV3VG9GaXREb2N1bWVudElmTmVlZGVkIiwgdGhpcyk7CiAgICAgbV93ZWJQYWdl LmxheW91dElmTmVlZGVkKCk7CiAK 359284 2019-01-16 11:27:49 -0800 2019-01-16 11:53:49 -0800 Patch bug-193468-20190116112748.patch text/plain 2631 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjMjE2NDc2ZTZhMDY0Zjg2 MGQ4N2U1MGRjOGNlZTc0NTQ4NDY0MTMuLjYzM2M1ZDQ4ZWI0MmE2YjhjMDQyMTkxODQ1YTQ2MDM0 YzAxOGU2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMTUgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRnJlcXVlbnQgbnVsbC1k ZXJlZiB1bmRlciBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXRE b2N1bWVudElmTmVlZGVkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MzQ2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzg2NDU4Njk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAo V2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXREb2N1 bWVudElmTmVlZGVkKToKKyAgICAgICAgQWRqdXN0IHRoZSBudWxsLWNoZWNrIGEgYml0OyBaYWxh biBwb2ludGVkIG91dCB0aGF0IHRoZSBsYXlvdXQgY291bGQKKyAgICAgICAgYmUgcmVzcG9uc2li bGUgZm9yIHRoZSBGcmFtZS9SZW5kZXJWaWV3IGdvaW5nIGF3YXksIHNvIHdlIHNob3VsZCBiYWls CisgICAgICAgICphZnRlciogbGF5b3V0LCBub3QgYmVmb3JlLgorCiAyMDE5LTAxLTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgV2luQ2Fpcm8gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdB cmVhLm1tCmluZGV4IDVlZTFmODI2MzU3OWZjZTI2YjMxMmNjZTVjMmNmYjc4YzEyYzY3OTAuLjVh NWMwMzI1MDkzNjk5MjFmZmQxZjY1N2YwNWI0MTNiOThhNDM5NjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5n QXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRD b3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KQEAgLTMxOCw4ICszMTgsMTYgQEAgdm9pZCBUaWxl ZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXREb2N1bWVudElmTmVlZGVk KCkKICAgICBMT0coUmVzaXplLCAiVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEgJXAgc2Nh bGVWaWV3VG9GaXREb2N1bWVudElmTmVlZGVkIiwgdGhpcyk7CiAgICAgbV93ZWJQYWdlLmxheW91 dElmTmVlZGVkKCk7CiAKKyAgICBhdXRvIG1haW5GcmFtZVZpZXcgPSBtX3dlYlBhZ2UubWFpbkZy YW1lVmlldygpOworICAgIGlmICghbWFpbkZyYW1lVmlldykKKyAgICAgICAgcmV0dXJuOworCisg ICAgYXV0byByZW5kZXJWaWV3ID0gbWFpbkZyYW1lVmlldy0+cmVuZGVyVmlldygpOworICAgIGlm ICghcmVuZGVyVmlldykKKyAgICAgICAgcmV0dXJuOworCiAgICAgaW50IHZpZXdXaWR0aCA9IG1f d2ViUGFnZS5zaXplKCkud2lkdGgoKTsKLSAgICBpbnQgZG9jdW1lbnRXaWR0aCA9IG1fd2ViUGFn ZS5tYWluRnJhbWVWaWV3KCktPnJlbmRlclZpZXcoKS0+dW5zY2FsZWREb2N1bWVudFJlY3QoKS53 aWR0aCgpOworICAgIGludCBkb2N1bWVudFdpZHRoID0gcmVuZGVyVmlldy0+dW5zY2FsZWREb2N1 bWVudFJlY3QoKS53aWR0aCgpOwogCiAgICAgYm9vbCBkb2N1bWVudFdpZHRoQ2hhbmdlZCA9IG1f bGFzdERvY3VtZW50U2l6ZUZvclNjYWxlVG9GaXQud2lkdGgoKSAhPSBkb2N1bWVudFdpZHRoOwog ICAgIGJvb2wgdmlld1dpZHRoQ2hhbmdlZCA9IG1fbGFzdFZpZXdTaXplRm9yU2NhbGVUb0ZpdC53 aWR0aCgpICE9IHZpZXdXaWR0aDsKQEAgLTM2NCw3ICszNzIsNyBAQCB2b2lkIFRpbGVkQ29yZUFu aW1hdGlvbkRyYXdpbmdBcmVhOjpzY2FsZVZpZXdUb0ZpdERvY3VtZW50SWZOZWVkZWQoKQogICAg IG1fd2ViUGFnZS5zZXRVc2VGaXhlZExheW91dChmYWxzZSk7CiAgICAgbV93ZWJQYWdlLmxheW91 dElmTmVlZGVkKCk7CiAKLSAgICBJbnRTaXplIGRvY3VtZW50U2l6ZSA9IG1fd2ViUGFnZS5tYWlu RnJhbWVWaWV3KCktPnJlbmRlclZpZXcoKS0+dW5zY2FsZWREb2N1bWVudFJlY3QoKS5zaXplKCk7 CisgICAgSW50U2l6ZSBkb2N1bWVudFNpemUgPSByZW5kZXJWaWV3LT51bnNjYWxlZERvY3VtZW50 UmVjdCgpLnNpemUoKTsKICAgICBtX2xhc3RWaWV3U2l6ZUZvclNjYWxlVG9GaXQgPSBtX3dlYlBh Z2Uuc2l6ZSgpOwogICAgIG1fbGFzdERvY3VtZW50U2l6ZUZvclNjYWxlVG9GaXQgPSBkb2N1bWVu dFNpemU7CiAK 359286 2019-01-16 11:53:50 -0800 2019-01-16 12:35:16 -0800 Patch bug-193468-20190116115349.patch text/plain 2461 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjMjE2NDc2ZTZhMDY0Zjg2 MGQ4N2U1MGRjOGNlZTc0NTQ4NDY0MTMuLjYzM2M1ZDQ4ZWI0MmE2YjhjMDQyMTkxODQ1YTQ2MDM0 YzAxOGU2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMTUgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRnJlcXVlbnQgbnVsbC1k ZXJlZiB1bmRlciBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXRE b2N1bWVudElmTmVlZGVkKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MzQ2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzg2NDU4Njk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAo V2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVWaWV3VG9GaXREb2N1 bWVudElmTmVlZGVkKToKKyAgICAgICAgQWRqdXN0IHRoZSBudWxsLWNoZWNrIGEgYml0OyBaYWxh biBwb2ludGVkIG91dCB0aGF0IHRoZSBsYXlvdXQgY291bGQKKyAgICAgICAgYmUgcmVzcG9uc2li bGUgZm9yIHRoZSBGcmFtZS9SZW5kZXJWaWV3IGdvaW5nIGF3YXksIHNvIHdlIHNob3VsZCBiYWls CisgICAgICAgICphZnRlciogbGF5b3V0LCBub3QgYmVmb3JlLgorCiAyMDE5LTAxLTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgV2luQ2Fpcm8gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdB cmVhLm1tCmluZGV4IDVlZTFmODI2MzU3OWZjZTI2YjMxMmNjZTVjMmNmYjc4YzEyYzY3OTAuLmZi ODQ4ZGE1NzA5OTM1MWEyOTU2YjA1YmM1ZWRiZDZiM2M1OWJmYzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5n QXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRD b3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KQEAgLTMxMiwxMiArMzEyLDEyIEBAIHZvaWQgVGls ZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNjYWxlVmlld1RvRml0RG9jdW1lbnRJZk5lZWRl ZCgpCiAgICAgaWYgKCFtX3Nob3VsZFNjYWxlVmlld1RvRml0RG9jdW1lbnQpCiAgICAgICAgIHJl dHVybjsKIAotICAgIGlmICghbV93ZWJQYWdlLm1haW5GcmFtZVZpZXcoKS0+cmVuZGVyVmlldygp KQotICAgICAgICByZXR1cm47Ci0KICAgICBMT0coUmVzaXplLCAiVGlsZWRDb3JlQW5pbWF0aW9u RHJhd2luZ0FyZWEgJXAgc2NhbGVWaWV3VG9GaXREb2N1bWVudElmTmVlZGVkIiwgdGhpcyk7CiAg ICAgbV93ZWJQYWdlLmxheW91dElmTmVlZGVkKCk7CiAKKyAgICBpZiAoIW1fd2ViUGFnZS5tYWlu RnJhbWVWaWV3KCkgfHwgIW1fd2ViUGFnZS5tYWluRnJhbWVWaWV3KCktPnJlbmRlclZpZXcoKSkK KyAgICAgICAgcmV0dXJuOworCiAgICAgaW50IHZpZXdXaWR0aCA9IG1fd2ViUGFnZS5zaXplKCku d2lkdGgoKTsKICAgICBpbnQgZG9jdW1lbnRXaWR0aCA9IG1fd2ViUGFnZS5tYWluRnJhbWVWaWV3 KCktPnJlbmRlclZpZXcoKS0+dW5zY2FsZWREb2N1bWVudFJlY3QoKS53aWR0aCgpOwogCkBAIC0z NjQsNiArMzY0LDkgQEAgdm9pZCBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6c2NhbGVW aWV3VG9GaXREb2N1bWVudElmTmVlZGVkKCkKICAgICBtX3dlYlBhZ2Uuc2V0VXNlRml4ZWRMYXlv dXQoZmFsc2UpOwogICAgIG1fd2ViUGFnZS5sYXlvdXRJZk5lZWRlZCgpOwogCisgICAgaWYgKCFt X3dlYlBhZ2UubWFpbkZyYW1lVmlldygpIHx8ICFtX3dlYlBhZ2UubWFpbkZyYW1lVmlldygpLT5y ZW5kZXJWaWV3KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIEludFNpemUgZG9jdW1lbnRTaXpl ID0gbV93ZWJQYWdlLm1haW5GcmFtZVZpZXcoKS0+cmVuZGVyVmlldygpLT51bnNjYWxlZERvY3Vt ZW50UmVjdCgpLnNpemUoKTsKICAgICBtX2xhc3RWaWV3U2l6ZUZvclNjYWxlVG9GaXQgPSBtX3dl YlBhZ2Uuc2l6ZSgpOwogICAgIG1fbGFzdERvY3VtZW50U2l6ZUZvclNjYWxlVG9GaXQgPSBkb2N1 bWVudFNpemU7Cg==