193466 2019-01-15 15:01:48 -0800 Fix incorrect ASSERT added in r239840 2019-01-15 16:09:00 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1494837 0 eric.carlson 2019-01-15 15:01:48 -0800 UserMediaCaptureManager::Source::Source asserts when creating an Audio stream. 1494838 1 eric.carlson 2019-01-15 15:04:30 -0800 <rdar://problem/47095142> 1494841 2 359209 eric.carlson 2019-01-15 15:08:01 -0800 Created attachment 359209 Patch 1494851 3 359209 youennf 2019-01-15 15:15:43 -0800 Comment on attachment 359209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65 > + ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone); Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)? 1494853 4 359209 eric.carlson 2019-01-15 15:28:16 -0800 Comment on attachment 359209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review >> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65 >> + ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType == CaptureDevice::DeviceType::Screen || deviceType == CaptureDevice::DeviceType::Window || deviceType == CaptureDevice::DeviceType::Microphone); > > Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)? Good idea, thanks. 1494854 5 359213 eric.carlson 2019-01-15 15:29:32 -0800 Created attachment 359213 Patch for landing 1494878 6 359213 commit-queue 2019-01-15 16:08:58 -0800 Comment on attachment 359213 Patch for landing Clearing flags on attachment: 359213 Committed r240017: <https://trac.webkit.org/changeset/240017> 1494879 7 commit-queue 2019-01-15 16:09:00 -0800 All reviewed patches have been landed. Closing bug. 359209 2019-01-15 15:08:01 -0800 2019-01-15 15:29:31 -0800 Patch bug-193466-20190115150800.patch text/plain 1723 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ3NjhhYzk3NzQ4ZjRkZmM2 MWEwMTcxZmZhNTU2NjQ5NGNjNWY5N2EuLjBlY2Y1MDgwMzUxMDQ1MThjM2QwNjYwMDdjOGE2M2Ix N2U1YTFhNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDEtMTUgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGluY29ycmVjdCBB U1NFUlQgYWRkZWQgaW4gcjIzOTg0MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkzNDY2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzA5NTE0Mj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6U291cmNlOjpTb3VyY2UpOgorCiAyMDE5LTAxLTEw ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1Nd IEFkZCBuYW1lIG9mIElPUmVnaXN0cnkga2V5IGluIHNhbmRib3guCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLmNw cAppbmRleCBlMmI1MTljZTM0YTQzZTBjNWFkODc1NDY4ZDU4Y2MzNWUxZjVhMDM2Li5kZjBmOWFk NDY2ODBmMGU0Mzc1N2JhZjZkYTQxM2VjNTAxNDM0NWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHAK QEAgLTYyLDcgKzYyLDcgQEAgcHVibGljOgogICAgICAgICAsIG1fbWFuYWdlcihtYW5hZ2VyKQog ICAgICAgICAsIG1fZGV2aWNlVHlwZShkZXZpY2VUeXBlKQogICAgIHsKLSAgICAgICAgQVNTRVJU KGRldmljZVR5cGUgPT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6Q2FtZXJhIHx8IGRldmlj ZVR5cGUgPT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6U2NyZWVuIHx8IGRldmljZVR5cGUg PT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6V2luZG93KTsKKyAgICAgICAgQVNTRVJUKGRl dmljZVR5cGUgPT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6Q2FtZXJhIHx8IGRldmljZVR5 cGUgPT0gQ2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6U2NyZWVuIHx8IGRldmljZVR5cGUgPT0g Q2FwdHVyZURldmljZTo6RGV2aWNlVHlwZTo6V2luZG93IHx8IGRldmljZVR5cGUgPT0gQ2FwdHVy ZURldmljZTo6RGV2aWNlVHlwZTo6TWljcm9waG9uZSk7CiAgICAgICAgIGlmICh0eXBlID09IFR5 cGU6OkF1ZGlvKQogICAgICAgICAgICAgbV9yaW5nQnVmZmVyID0gc3RkOjptYWtlX3VuaXF1ZTxD QVJpbmdCdWZmZXI+KG1ha2VVbmlxdWVSZWY8U2hhcmVkUmluZ0J1ZmZlclN0b3JhZ2U+KG51bGxw dHIpKTsKICAgICB9Cg== 359213 2019-01-15 15:29:32 -0800 2019-01-15 16:08:58 -0800 Patch for landing bug-193466-20190115152931.patch text/plain 1566 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ3NjhhYzk3NzQ4ZjRkZmM2 MWEwMTcxZmZhNTU2NjQ5NGNjNWY5N2EuLjMxNzQyMjE5NTcwMDQyYmJhZGU0Y2RjNGUzNGM3Zjc5 MjI0MmNlNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDEtMTUgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGluY29ycmVjdCBB U1NFUlQgYWRkZWQgaW4gcjIzOTg0MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkzNDY2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzA5NTE0Mj4K KworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpTb3VyY2U6OlNvdXJjZSk6CisKIDIwMTktMDEtMTAg IFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10g QWRkIG5hbWUgb2YgSU9SZWdpc3RyeSBrZXkgaW4gc2FuZGJveC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHAgYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3Bw CmluZGV4IGUyYjUxOWNlMzRhNDNlMGM1YWQ4NzU0NjhkNThjYzM1ZTFmNWEwMzYuLjQ1YjkwMWU4 YWM0ZDkwOGRjYWZiZGEwMTZlNTNhZGNmZjhiN2VhZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLmNwcApA QCAtNjIsNyArNjIsNyBAQCBwdWJsaWM6CiAgICAgICAgICwgbV9tYW5hZ2VyKG1hbmFnZXIpCiAg ICAgICAgICwgbV9kZXZpY2VUeXBlKGRldmljZVR5cGUpCiAgICAgewotICAgICAgICBBU1NFUlQo ZGV2aWNlVHlwZSA9PSBDYXB0dXJlRGV2aWNlOjpEZXZpY2VUeXBlOjpDYW1lcmEgfHwgZGV2aWNl VHlwZSA9PSBDYXB0dXJlRGV2aWNlOjpEZXZpY2VUeXBlOjpTY3JlZW4gfHwgZGV2aWNlVHlwZSA9 PSBDYXB0dXJlRGV2aWNlOjpEZXZpY2VUeXBlOjpXaW5kb3cpOworICAgICAgICBBU1NFUlQoZGV2 aWNlVHlwZSAhPSBDYXB0dXJlRGV2aWNlOjpEZXZpY2VUeXBlOjpVbmtub3duKTsKICAgICAgICAg aWYgKHR5cGUgPT0gVHlwZTo6QXVkaW8pCiAgICAgICAgICAgICBtX3JpbmdCdWZmZXIgPSBzdGQ6 Om1ha2VfdW5pcXVlPENBUmluZ0J1ZmZlcj4obWFrZVVuaXF1ZVJlZjxTaGFyZWRSaW5nQnVmZmVy U3RvcmFnZT4obnVsbHB0cikpOwogICAgIH0K